[metrics-bugs] #30216 [Metrics/Library]: Add bandwidth file parser to metrics-lib

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Apr 25 08:34:25 UTC 2019


#30216: Add bandwidth file parser to metrics-lib
-------------------------------------------------+-------------------------
 Reporter:  irl                                  |          Owner:  karsten
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Metrics/Library                      |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth,tor-dirauth,metrics-      |  Actual Points:
  roadmap-2019-q2                                |
Parent ID:  #21378                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:8 karsten]:
 > How about we ask the bandwidth-file-spec authors to clarify whether this
 is planned in the future? If there are no such plans, that is, header
 lines with 1.x versions can never have spaces, and this is stated
 explicitly in the spec, I'd like to keep this simple and efficient parser
 implementation. Otherwise we can add a check like you suggested, which
 certainly makes the parser more complex, but which would address this
 case.

 Or here's another suggestion: We make the change you suggested, ask the
 spec authors to clarify, and then hopefully simplify the parser again.
 I'll work on a patch later today.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30216#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list