[metrics-bugs] #28136 [Metrics/Website]: OnionPerf graph handles missing data on 2018-10-01 in a weird way

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 31 09:14:29 UTC 2018


#28136: OnionPerf graph handles missing data on 2018-10-01 in a weird way
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  defect           |         Status:  needs_review
 Priority:  High             |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 Replying to [comment:6 karsten]:
 > Replying to [comment:5 irl]:
 > > There is another function to sanitize the data from the database,
 `emptyNull`, which perhaps could do with either a better name or some
 JavaDoc. I can see what it does looking at the code but was confused
 looking at the code above that called it.
 >
 > Agreed, there's room for improvement here. I'll think more about it and
 post a patch here tomorrow.

 Please review [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/commit/?h=task-28136-3&id=cdab81bdd17f8de3f22c28dd6392e697f823b846
 commit cdab81b in my task-28136-3 branch].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28136#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list