[metrics-bugs] #28136 [Metrics/Website]: OnionPerf graph handles missing data on 2018-10-01 in a weird way

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 30 08:11:25 UTC 2018


#28136: OnionPerf graph handles missing data on 2018-10-01 in a weird way
-----------------------------+-----------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  defect           |         Status:  merge_ready
 Priority:  High             |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Ok. This change looks good.

 There is another function to sanitize the data from the database,
 `emptyNull`, which perhaps could do with either a better name or some
 JavaDoc. I can see what it does looking at the code but was confused
 looking at the code above that called it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28136#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list