[metrics-bugs] #28114 [Metrics/Library]: Improve getter names for boolean fields in metrics-lib

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Oct 18 23:54:44 UTC 2018

#28114: Improve getter names for boolean fields in metrics-lib
 Reporter:  efgyirfe784  |          Owner:  metrics-team
     Type:  enhancement  |         Status:  new
 Priority:  Medium       |      Component:  Metrics/Library
  Version:               |       Severity:  Normal
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
 This ticket is created from #24419. #24419 notes that not all Onionoo
 methods could be changed to the isXY() pattern for boolean getter methods
 due to interfaces such as org.torproject.descriptor.NetworkStatusEntry.
 This ticket is to update metrics-libs accordingly. From #24419:

 >1. I did not change
 "getUnmeasured()" to "isUnmeasured()" because the interface
 org.torproject.descriptor.NetworkStatusEntry requires it, and I figured
 org.torproject.descriptor is outside the scope of this ticket.

 >>Agreed. We'd first have to change metrics-lib interfaces, put out a new
 major metrics-lib release, and then update the tests in Onionoo. Worth
 doing, though we would ideally combine this with other changes that
 require a major metrics-lib version bump.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28114>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the metrics-bugs mailing list