[metrics-bugs] #28116 [Metrics/Statistics]: Split up legacy module into more maintainable parts

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Nov 14 19:28:16 UTC 2018


#28116: Split up legacy module into more maintainable parts
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  karsten
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 Replying to [comment:3 karsten]:
 > My plan is to:
 >  1. merge/deploy these changes,

 Already done.

 For the remaining steps I started a new
 [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/log/?h=task-28116-3 branch task-28116-3] with six commits so far:

  - 88535e1 fixes unit tests;

 >  2. remove then unused code from the legacy module,

  - 6765b8e stops generating the now unused servers.csv in the legacy
 module;
  - 09cfdfd stops including advertised bandwidth data in bandwidth.csv,
 which is also produced by the legacy module, and instead switches to data
 from the ipv6servers module;
  - ca5fa45 removes quite a bit of now unused code from the legacy module;

 >  3. rename the legacy module to bandwidth, because it's only remaining
 purpose will be to produce our bandwidth history statistics, and

  - f8fa108 modernizes a bit more of the legacy module and renames it to
 bwhist;

 >  4. rename the ipv6servers module to servers.

  - c95125a finally renames the ipv6servers module to just servers.

 All commits are tested locally, though I suspect that deployment will be
 another challenge, just like deployment of the first step was not exactly
 trivial. Still very much worth making this change!

 Please take a look. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28116#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list