[metrics-bugs] #23854 [Metrics/Website]: Add an RSS feed for https://metrics.torproject.org/news.html

[Tor Bug Tracker & Wiki]

#23854: Add an RSS feed for https://metrics.torproject.org/news.html
-----------------------------+------------------------------
 Reporter:  cypherpunks      |          Owner:  irl
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by irl):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:14 karsten]:
 >  - You should read about "Java diamond operator". In several places
 you're undoing changes that we made quite recently when switching to Java
 7. For example, we prefer `List<String> aList = new ArrayList<>();` over
 `List<String> aList = new ArrayList<String>();'.

 Fixed.

 That's going to be a hard habit to break. Is there something we can add to
 checkstyle to catch this?

 >  - Please add a space after the closing bracket in `return (String[])
 this.protocols.toArray()` and related places.

 Fixed.

 >  - I think your code prints a news entry with `start == end` as "start
 to end", whereas the current code would print it as just "start". Can you
 change that back?

 Fixed.

 >  - You picked non-standard Java variable names like `short_desc` and
 fixed them in a later commit. Can you rather make such fixes to your own
 commits as "fixup" or "squash" commits and either squash them yourself or
 let me do that as part of the merge process?

 Fixed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23854#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online