[metrics-bugs] #25241 [Metrics/Onionoo]: effective_family sometimes contains the relay's own fingerprint

[Tor Bug Tracker & Wiki]

#25241: effective_family sometimes contains the relay's own fingerprint
-----------------------------+-----------------------------------
 Reporter:  irl              |          Owner:  karsten
     Type:  defect           |         Status:  needs_information
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+-----------------------------------
Changes (by iwakeh):

 * status:  needs_review => needs_information


Comment:

 Wondering, if his shouldn't go in a different direction.  I would expect
 the family to contain the listing relay (the 'self').  Isn't it a use case
 to compare families of relays?  Then I would need to somewhat artificially
 add the 'self's.  And, the field's name also yields that the entire family
 is listed incl. 'self'.  So, Onionoo should rather add 'self' always (,
 which is also a slightly simpler patch).
 I couldn't find any reasons for removing the 'self' in the other tickets
 referenced here.
 Thoughts?

 (On first glance I couldn't find any related tests.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25241#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online