[metrics-bugs] #24153 [Metrics/Library]: Make DescriptorCollector resume previously aborted downloads

[Tor Bug Tracker & Wiki]

#24153: Make DescriptorCollector resume previously aborted downloads
-----------------------------+--------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  defect           |         Status:  accepted
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  assigned => accepted


Comment:

 I wrote a tiny patch in [https://gitweb.torproject.org/user/karsten
 /metrics-
 lib.git/commit/?h=task-24153&id=31c9250d8e31d572cf9c5e88f45edc1fcdc0f6a0
 commit 31c9250 of my task-24153 branch]. That patch only fixes the bug
 that we skipped a remote file that we did not finish downloading before.
 Please review. Thanks!

 What this patch does not do is clean up temporary files that we for
 whatever reason do not reattempt to download in a later run. That seems
 more like a (useful) enhancement than a defect, though. Using
 `Files.createTempFiles` seems like a good way to implement that, though
 I'm not entirely sure how to turn a temporary file into a permanent one
 using that approach. I'd say, let's create a new ticket for that and just
 fix this bug now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24153#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online