[metrics-bugs] #25085 [Metrics/Onionoo]: Make order of sorted results deterministic

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Feb 16 09:16:13 UTC 2018

#25085: Make order of sorted results deterministic
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #25002           |         Points:
 Reviewer:  karsten          |        Sponsor:

Comment (by karsten):

 Replying to [comment:7 iwakeh]:
 > I thought about that, too, but am kind of vary to introduce the change.
 After all, it's been that way all along.

 It's true that it has been like this all the time. It just feels like an
 improvement to make all responses deterministic, not just some.

 > On the other hand, I cannot think of a client side use case for the non-
 deterministic order.

 No, it's nothing that clients can rely on.

 > Maybe, introduce another parameter for fingerprint sorting?  But, that's
 more work.

 That's some more work, yes. But what would be the goal? Have a default
 value for the `order` parameter? But what if clients ask for results
 ordered by `"consensus_weight"` without passing `"fingerprint"` as second
 field to order by? Then we'd be in the same situation as we're in now. I
 think fingerprint is really a special case here. It's like the primary key
 in a database sense.

 > Unless, you raise any other concern here, I'll prepare the changed

 No other concerns from me.

 > Where there any other reasons for setting to needs_revision?

 Just this.


Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25085#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the metrics-bugs mailing list