[metrics-bugs] #25241 [Metrics/Onionoo]: effective_family sometimes contains the relay's own fingerprint

[Tor Bug Tracker & Wiki]

#25241: effective_family sometimes contains the relay's own fingerprint
-----------------------------+--------------------------
 Reporter:  irl              |          Owner:  karsten
     Type:  defect           |         Status:  accepted
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  new => accepted


Comment:

 Hmm, yes, I think it makes more sense to exclude the relay itself from its
 `"effective_family"`.

 It looks like the reason is that some relays include their own fingerprint
 in the family line of their server descriptor. For example,
 `03603092cf69a41857aed9131aba531cf4e71f27`:

 {{{
 @type server-descriptor 1.0
 router sipuliDE01 94.130.181.81 6381 0 0
 identity-ed25519
 -----BEGIN ED25519 CERT-----
 AQQABnCOAQpGlUrHIKxdR7v7BHwzvtyu5vjWJb3q52EWHg6F8npMAQAgBAA1+uBN
 NBr4hTuW+Kbo0w4AdV1ZzBWqbP5pzKa1/WtPGBWiu91zkxM0APYsY17lf9/eu0dI
 SnmejAv3CB65kb20XbhG8fJzvbbAvKUApYaOVCO6FmJEwRlNBSVA6my6Ugo=
 -----END ED25519 CERT-----
 master-key-ed25519 NfrgTTQa+IU7lvim6NMOAHVdWcwVqmz+acymtf1rTxg
 or-address [2a01:4f8:1c0c:414b::1]:8573
 platform Tor 0.2.9.14 on Linux
 proto Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1-2 Link=1-4
 LinkAuth=1 Microdesc=1-2 Relay=1-2
 published 2018-02-05 09:04:34
 fingerprint 4357 0F86 2FE7 CAF7 B486 6B9B D95D B276 6221 8BBD
 uptime 3515
 bandwidth 1073741824 2147483647 57535
 extra-info-digest C3F79852F13BD8F15EB221F6D0A298D416242EE0
 xbEm5P5s0wcubfLRIYV4ms6cFBz0764X24OpNpa0SGI
 onion-key
 -----BEGIN RSA PUBLIC KEY-----
 MIGJAoGBALkbUUVGfsDVS9Vi8BRc0CLeS0PbRKoAh3CICoychg00B6nQmxGTJX0o
 okKUGikA+AmTDcii7VQd3M1INVT7XPIjy7PMAiiiBZqogREMMW1r70+AZEK/whJu
 2CjesaY70rP0yUZYsT8QNZgOUNR14jQyB5z2ofYSMZWAacQRdYjJAgMBAAE=
 -----END RSA PUBLIC KEY-----
 signing-key
 -----BEGIN RSA PUBLIC KEY-----
 MIGJAoGBAOGWq/4J9CsBA06Re32X8U522p97sQeRY1jXNgS+6cQ14rjfGyU7ydq6
 jab34lHe2lLdyENhYroOeUSJWFRKX276IrZBJ1CS+UMPVHcIQvdDMSImg4zEESAX
 PNHk2tdnESTVlaUIAStVnQU9Nu3wH7VzQDhupEEYpOJY7siVAJObAgMBAAE=
 -----END RSA PUBLIC KEY-----
 onion-key-crosscert
 -----BEGIN CROSSCERT-----
 TKINsu+xKXjn+/4IP8pT7VD7BKKBGF7Pywoo3X+YLzcoESIUgZ9oyUdwt1tPQ4Qr
 Yar+hxh1dcJZ9ge7uVp+v/m6zXwFfUTka5MUAgaaUPMqryIp+wV+A7W6rv/7cSBB
 Six6IsOJPIVkUKuzYDlMspdRjR6/DcBvlhif40v62SQ=
 -----END CROSSCERT-----
 ntor-onion-key-crosscert 1
 -----BEGIN ED25519 CERT-----
 AQoABm+aATX64E00GviFO5b4pujTDgB1XVnMFaps/mnMprX9a08YANimuVWhML71
 rmBaLJlfawceE7k5P69VKqXZGis3cnSovIsvFK3p4+vELEwdZEsVu66W5Znumyc8
 a3Rg5jQrRQk=
 -----END ED25519 CERT-----
 family $43570F862FE7CAF7B4866B9BD95DB27662218BBD
 $AEB76F909EE1730926195E92F0D6BBDDD0AC60ED
 $AFC637373810BE6EC4411F58D575CE5D137326CF
 $C552FF01540030F675DCF4793F1C32828ACD3FF1
 hidden-service-dir
 contact O_O <tor at lin dot fi>
 ntor-onion-key IWbsv6SwQv06fSdlybpnF3RuXG4q1tA11FbXB+/ELV8=
 accept 8.8.8.8:53
 accept 8.8.4.4:53
 reject *:*
 router-sig-ed25519
 TbKPy+MSIG9Cv2GyOGtCykcDJRD04bCESaFDHGqoxjLxQrcV12m3HDzKNBqgYWNXuX054kVDqmNQkbkaFfSfDw
 router-signature
 -----BEGIN SIGNATURE-----
 GuoAa7adXOktLBp7V0hvK4r9TT2tfGkLcxWQlfDf2dtv1NNwQ+DvLXAE+tnWaw8B
 8foFO7UAMTPNdePk7uMVOkwRlodEoAw1cwuE0U9rnrcM4jUA/xAnMiqs3bVqTh42
 L9JD2IfRQGmINm9pKeY/T1rPNF41Vwtdh0Csx0IPbqU=
 -----END SIGNATURE-----
 }}}

 Onionoo returns the following details document for this relay:

 {{{
 {
   "version": "5.0",
   "build_revision": "a66bfd1",
   "relays_published": "2018-02-14 10:00:00",
   "relays": [
     {
       "nickname": "sipuliDE01",
       "fingerprint": "43570F862FE7CAF7B4866B9BD95DB27662218BBD",
       "or_addresses": [
         "94.130.181.81:6381",
         "[2a01:4f8:1c0c:414b::1]:8573"
       ],
       "last_seen": "2018-02-12 05:00:00",
       "last_changed_address_or_port": "2018-01-24 22:00:00",
       "first_seen": "2018-01-23 14:00:00",
       "running": false,
       "flags": [
         "Fast",
         "Running",
         "Stable",
         "Valid"
       ],
       "country": "de",
       "country_name": "Germany",
       "latitude": 51.2993,
       "longitude": 9.491,
       "as_number": "AS24940",
       "as_name": "Hetzner Online GmbH",
       "consensus_weight": 66900,
       "host_name": "static.81.181.130.94.clients.your-server.de",
       "last_restarted": "2018-02-11 18:31:40",
       "bandwidth_rate": 1073741824,
       "bandwidth_burst": 2147483647,
       "observed_bandwidth": 0,
       "advertised_bandwidth": 0,
       "exit_policy": [
         "accept 8.8.8.8:53",
         "accept 8.8.4.4:53",
         "reject *:*"
       ],
       "exit_policy_summary": {
         "reject": [
           "1-65535"
         ]
       },
       "contact": "O_O <tor at lin dot fi>",
       "platform": "Tor 0.2.9.14 on Linux",
       "version": "0.2.9.14",
       "effective_family": [
         "43570F862FE7CAF7B4866B9BD95DB27662218BBD",
         "AEB76F909EE1730926195E92F0D6BBDDD0AC60ED",
         "AFC637373810BE6EC4411F58D575CE5D137326CF",
         "C552FF01540030F675DCF4793F1C32828ACD3FF1"
       ],
       "recommended_version": true,
       "hibernating": true,
       "measured": true
     }
   ],
   "bridges_published": "2018-02-14 10:04:06",
   "bridges": []
 }
 }}}

 I wrote a quick fix that I'm currently testing. Grabbing this ticket and
 posting a branch as soon as it's tested.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25241#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online