[metrics-bugs] #27039 [Metrics/Onionoo]: Timestamps in graph history documents are incorrectly formatted

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Aug 7 12:31:12 UTC 2018


#27039: Timestamps in graph history documents are incorrectly formatted
-----------------------------+--------------------------
 Reporter:  starlight        |          Owner:  irl
     Type:  defect           |         Status:  accepted
 Priority:  High             |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------

Comment (by karsten):

 Yes, I think that's the issue. Looks like we did not include the
 `GraphHistory` class when we added Jackson-related annotations in 52494a7.

 The fix is probably as simple as copying those annotations from `Document`
 to `GraphHistory`.

 But how do we fix existing files in `out/` directories?
  - We could wait until new files are being written and accept that old
 files might be broken. Not very nice.
  - We could change the servlet to read all history files and rewrite them
 before including them in a response. Not very efficient.
  - We could write a small tool to run on an existing `out/` directory that
 reads in history files and overwrites them, if they are broken. Might be
 okay.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27039#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list