[metrics-bugs] #25712 [Metrics/Library]: Replace ServerDescriptor#getHiddenServiceDirVersions with ServerDescriptor#isHiddenServiceDir

[Tor Bug Tracker & Wiki]

#25712: Replace ServerDescriptor#getHiddenServiceDirVersions with
ServerDescriptor#isHiddenServiceDir
-----------------------------+--------------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Low              |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Hi Karsten,

 I think that testHiddenServiceDirVersions2And3() should not throw a parse
 error. Extra arguments are allowed at the end of directory lines, unless
 specifically prohibited in the spec:
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n261

 The spec change in #25284 documents that tor has always ignored version
 arguments on this line. It does not make trailing arguments invalid, and
 some non-tor implementations may use them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25712#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online