[metrics-bugs] #21414 [Metrics]: Include currently running software versions in responses (collector.tp.o, onionoo.tp.o) and on the website (metrics.tp.o)

[Tor Bug Tracker & Wiki]

#21414: Include currently running software versions in responses (collector.tp.o,
onionoo.tp.o) and on the website (metrics.tp.o)
--------------------------+---------------------------------
 Reporter:  iwakeh        |          Owner:  metrics-team
     Type:  enhancement   |         Status:  needs_review
 Priority:  Low           |      Milestone:  CollecTor 1.4.0
Component:  Metrics       |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  metrics-2017  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+---------------------------------

Comment (by iwakeh):

 I don't see my fixup commits in your branch (which is a little confusing)
 and some of the changes you made were in there.
 But, the changes look ok; except that I prefer to explicitly set the
 fallback value 'null' instead of relying on the default in `getProperty`,
 because this states that the decision was made consciously and not by
 accident -- some way to document in code.

 Regarding the changelog of metrics-lib:  This needs to be clearer, like
 "the Git revision supplied by the calling software" or similar.  It should
 make clear that this is a revision of the software __using__ the API and
 that metrics-lib doesn't interfere with it.  metrics-lib creates the
 files, but the git-revision supplied is not metrics-lib.

 The same for CollecTor, maybe:
 //Git revision of the CollecTor instance's software used to create this
 file, which will be omitted if unknown.//

 (Wondering if the metrics-lib revision should be appended to the one given
 by CollecTor as it does have some influence on the files, i.e.,
 `"build_revision":"abcdfe7-zyxabc5"`? It would be easy, but of course we
 would have to discuss and explain what happens when there is only one of
 these available)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21414#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online