[metrics-bugs] #21414 [Metrics]: Include currently running software versions in responses (collector.tp.o, onionoo.tp.o) and on the website (metrics.tp.o)

[Tor Bug Tracker & Wiki]

#21414: Include currently running software versions in responses (collector.tp.o,
onionoo.tp.o) and on the website (metrics.tp.o)
--------------------------+---------------------------------
 Reporter:  iwakeh        |          Owner:  metrics-team
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Low           |      Milestone:  CollecTor 1.4.0
Component:  Metrics       |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  metrics-2017  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+---------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Thanks for starting this!

 The metrics-base patch looks good, merged.

 However, I'd want us to make one change: we should just leave out the
 "build_revision" field from index.json if no revision is available. The
 "not-available" string only makes the protocol a bit more complex, because
 we need to explain what it means, but it doesn't add any information. And
 we need to check for null anyway, because that field does not exist until
 now. I'm happy to make that change.

 But there's another issue that I don't know how to fix: when I apply the
 patches for 2 and 3 and start a test CollecTor instance, it includes the
 revision of ''metrics-lib'' rather than its own revision. Not sure why,
 possibly because there are two `build.properties` files now, one from
 metrics-lib and one from CollecTor. Hmm, do you have a fix for that?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21414#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online