[metrics-bugs] #22112 [Metrics/Metrics website]: Replace torperf.csv with onionperf.csv

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 9 10:27:29 UTC 2017


#22112: Replace torperf.csv with onionperf.csv
-------------------------------------+--------------------------------
 Reporter:  karsten                  |          Owner:  metrics-team
     Type:  enhancement              |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:
Component:  Metrics/Metrics website  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+--------------------------------
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 Committed to master means 'productive', but the current onionperf.csv
 links on metrics.tp.o lead to 404; is that intended?

 init-onionperf.sql:  The last "group by" on the second to the last line
 contains a `3`, which seems to refer to `source`, but `source` in this
 select is set to `''`.  What is intended here?

 Why are there columns in the measurements table that are not used later on
 (mostly the unrecognized key lines))?  Shouldn't these be omitted?
 Here it seems as if only 'endpointremote' is used to determine the content
 of column 'server'.  If just that is needed it ought to be filled by the
 java code initially.  But, I might have overlooked something?

 In some other module we used constants for column-names in Java.  As the
 db redesign will be future work, is this intentionally left to be improved
 then?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22112#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list