[metrics-bugs] #20596 [Metrics]: add jdk version to manifest files

[Tor Bug Tracker & Wiki]

#20596: add jdk version to manifest files
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  metrics-team
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------

Comment (by iwakeh):

 That looks fine!

 The attribute is only necessary for the class file jar, but I didn't write
 that.

 Do you mind adding two more attributes?

 In total these lines:

 {{{
 <attribute name="JDK-Version" value="${java.runtime.version}"/>
 <attribute name="JVM-Name" value="${java.vm.name}"/>
 <attribute name="JVM-Vendor" value="${java.vm.vendor}"/>
 }}}

 i.e.
 {{{
 #!diff
           <attribute name="Implementation-Title" value="DescripTor"/>
           <attribute name="Implementation-Version"
                      value="${release.version}-${git.revision}"/>
  +        <attribute name="JDK-Version" value="${java.runtime.version}"/>
  +        <attribute name="JVM-Name" value="${java.vm.name}"/>
  +        <attribute name="JVM-Vendor" value="${java.vm.vendor}"/>
         </manifest>
       </jar>
       <jar destfile="${jarsourcesfile}">
 }}}

 jvm vendor and name might be useful, too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online