On 2020-06-23 15:41:43, Antoine Beaupré wrote:
On 2020-06-23 19:31:06, George Kadianakis wrote:
George Kadianakis desnacked@riseup.net writes:
Hello,
me and David assigned reviews today and here is the procedure we came up with. Unfortunately, because we dont use merge requests in gitlab yet, we cannot use the natural procedure of gitlab when it comes to code reviews, so we had to hack something up with labels for now.
Hello,
I also made a wiki page about this process here: https://gitlab.torproject.org/tpo/core/tor/-/wikis/NetworkTeam/GitlabReviews and I linked to it from: https://gitlab.torproject.org/tpo/core/tor/-/wikis/home#processes-and-polici...
That's because David made an improvement to the review queries and by putting it on the wiki it allows us to incrementally improve the queries and process.
I'll link this from the TPA docs, thanks for maintaining this outside of the mailing list! :)
that is currently:
https://help.torproject.org/tsa/howto/gitlab/#How_to_contribute_code.3F
... in case anyone was wondering. :)
a.