GitLab

at 2026-07-22T15:13:09+02:00

fixup! BB 40925: Implemented the Security Level component

BB 45131: Avoid the unsafe getBoolPref in the security level.

In the security level we use getBoolPref without a default value.
Therefore it might throw during the initialization of the security
level.

This case should not happen normally for us, but it might happen if
upstream removes a preference default, and in that case the security
level initialization will fail at startup.
It seems better to handle the case (but add a console warning, so that
we notice it and investigate it).

@@ -336,14 +336,22 @@ var read_setting_from_prefs = function (prefNames) {
      // For the given settingIndex, check if all current pref values
      // match the setting.
      for (const prefName of prefNames) {
 -      const wanted = kSecuritySettings[prefName][settingIndex];
 -      const actual = Services.prefs.getBoolPref(prefName);
 -      if (wanted !== actual) {
 -        possibleSetting = false;
 -        logger.debug(
 -          `${prefName} does not match level ${settingIndex}: ${actual}, should be ${wanted}!`
 -        );
 -        break;
 +      try {
 +        const wanted = kSecuritySettings[prefName][settingIndex];
 +        const actual = Services.prefs.getBoolPref(prefName);
 +        if (wanted !== actual) {
 +          possibleSetting = false;
 +          logger.debug(
 +            `${prefName} does not match level ${settingIndex}: ${actual}, should be ${wanted}!`
 +          );
 +          break;
 +        }
 +      } catch (e) {
 +        // All the relevant prefs must have a defined default.
 +        // If we get here, a preference might have been dropped upstream,
 +        // therefore it makes sense to ignore it to determine the security
 +        // level, but warn so that we have a look at what went wrong.
 +        logger.warn(`Cannot get the value for ${prefName}`, e);
+       }
+     }
      if (possibleSetting) {

Pier Angelo Vendrame pushed to branch tor-browser-153.0esr-16.0-1 at The Tor Project / Applications / Tor Browser

Commits:

1 changed file:

Changes: