Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser

Commits:

• 98b8bdd4
  by Pier Angelo Vendrame at 2024-08-08T19:12:40+02:00

  fixup! Bug 40309: Avoid using regional OS locales
  
  Bug 42349: Change the RFPTarget in the region spoofing.
  
  One of our patches makes sure that when spoof English is not in use, we
  report the same locale as the app language, instead of reporting the OS
  locale (which is Firefox's default behavior when the app and OS
  languages are the same).
  
  When rebasing onto 128, we broke this patch because we had to specify
  an RFPTarget, and I chose RFPTarget::JSLocale.
  This is the only target that can be disabled even when running RFP
  instead of FFP, because it is controlled by privacy.spoof_english.
  

• 402c32c1
  by Pier Angelo Vendrame at 2024-08-08T19:12:56+02:00

  fixup! Firefox preference overrides.
  
  Add some notes about live-reload, discovered while investigating some
  localization issues.
  

2 changed files:

• browser/app/profile/001-base-profile.js
• intl/locale/LocaleService.cpp

Changes:

 // tor-browser#41417: do not allow live reload until we switch to Fluent and

 // stop using .textContent.

+// Even after that, it might be a good idea to keep it off, as it is not handled

+// very well, and it might give a window during which websites could fingerprint

+// the change (see tor-browser#42349 and tor-browser#42771).

 pref("intl.multilingual.liveReload", false);

 // Enable URL query stripping to protect against cross-site tracking (tor-browser#41092)

 NS_IMETHODIMP

 LocaleService::GetRegionalPrefsLocales(nsTArray<nsCString>& aRetVal) {

+  // tor-browser#42349, #42771: We cannot use JSLocale because it is spoof

+  // English. So, we use another target for now.

   if (nsContentUtils::ShouldResistFingerprinting(

           "This is probably a patch that should be refined. But to get the "

           "build going, we just keep applying this generic check.",

-          RFPTarget::JSLocale)) {

+          RFPTarget::JSDateTimeUTC)) {

     GetAppLocalesAsBCP47(aRetVal);

     return NS_OK;

   }