Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
-
44820468
by Henry Wilkes at 2024-08-29T16:42:37+02:00
-
d44ef5f7
by Henry Wilkes at 2024-08-29T16:42:41+02:00
2 changed files:
Changes:
... | ... | @@ -757,8 +757,8 @@ nsBrowserContentHandler.prototype = { |
757 | 757 | additionalPage = Services.urlFormatter.formatURLPref(
|
758 | 758 | "startup.homepage_welcome_url.additional"
|
759 | 759 | );
|
760 | - // Disable 'later run' pages for new profiles (tor-browser#41568)
|
|
761 | - lazy.LaterRun.selfDestruct();
|
|
760 | + // Turn on 'later run' pages for new profiles.
|
|
761 | + lazy.LaterRun.enable(lazy.LaterRun.ENABLE_REASON_NEW_PROFILE);
|
|
762 | 762 | break;
|
763 | 763 | case OVERRIDE_NEW_MSTONE: {
|
764 | 764 | // Check whether we will restore a session. If we will, we assume
|
... | ... | @@ -61,6 +61,20 @@ export let LaterRun = { |
61 | 61 | },
|
62 | 62 | |
63 | 63 | init(reason) {
|
64 | + // Keep disabled in Base Browser. See tor-browser#41568.
|
|
65 | + // NOTE: This means that users cannot benefit from feature prompts gated
|
|
66 | + // behind LaterRun.
|
|
67 | + // In mozilla ESR 128 it is only used in one place, and is gated behind a
|
|
68 | + // feature recommendation preference that we switch off in Base Browser
|
|
69 | + // anyway. See tor-browser#42630.
|
|
70 | + // But this decision should be reviewed. See tor-browser#43093.
|
|
71 | + Services.prefs.setBoolPref(kEnabledPref, false);
|
|
72 | + // Clear any preferences that may have been set before LaterRun was
|
|
73 | + // disabled.
|
|
74 | + Services.prefs.clearUserPref(kSessionCountPref);
|
|
75 | + Services.prefs.clearUserPref(kProfileCreationTime);
|
|
76 | + Services.prefs.clearUserPref(kUpdateAppliedTime);
|
|
77 | + |
|
64 | 78 | if (!this.enabled) {
|
65 | 79 | return;
|
66 | 80 | }
|
... | ... | @@ -99,11 +113,8 @@ export let LaterRun = { |
99 | 113 | return Services.prefs.getBoolPref(kEnabledPref, false);
|
100 | 114 | },
|
101 | 115 | |
102 | - enable(reason) {
|
|
103 | - if (!this.enabled) {
|
|
104 | - Services.prefs.setBoolPref(kEnabledPref, true);
|
|
105 | - this.init(reason);
|
|
106 | - }
|
|
116 | + enable(_reason) {
|
|
117 | + // Keep disabled in Base Browser. See tor-browser#41568.
|
|
107 | 118 | },
|
108 | 119 | |
109 | 120 | get hoursSinceInstall() {
|