GitLab

at 2025-05-14T10:15:38+02:00

Bug 1963354 - Refine the GTK version checked before declaring various GDK_WINDOW_STATE... constants. r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D247104

Bug 1965035 - Remove an unused WebRTC import from DohSettingsStore. r=sekim,android-reviewers,pollymce

Differential Revision: https://phabricator.services.mozilla.com/D248279

BB 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

BB 43072: Add aria label and description to moz-message-bar.

Ensures that moz-message-bar, including notifications, are announced on
Orca.

This addresses upstream bugzilla bug 1895857 and should likely be
replaced when it is fixed.

BB 42739: Use the brand name for profile error messages.

Some messages in profileSelection.properties use gAppData->name as
variable inputs. However, gAppData->name is still "Firefox" for our
base-browser builds, rather than the user-facing browser name. We swap
these instances with the displayed brand name instead.

BB 41483: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla bug 1790187

BB 41459: WebRTC fails to build under mingw (Part 1)

- properly define NOMINMAX for just MSVC builds

BB 41459: WebRTC fails to build under mingw (Part 2)

- fixes required to build third_party/libwebrtc

BB 41459: WebRTC fails to build under mingw (Part 3)

- fixes required to build third_party/sipcc

BB 41459: WebRTC fails to build under mingw (Part 4)

- fixes requried to build netwerk/sctp

BB 41459: WebRTC fails to build under mingw (Part 5)

- fixes required to build dom/media/webrtc

BB 41459: WebRTC fails to build under mingw (Part 6)

- fixes required to build dom/media/systemservices

BB 42758: Fix WebRTC build errors.

fixup! BB 42758: Fix WebRTC build errors.

MB 436: Link to pthread on mingw.

BB 41854: Allow overriding download spam protection.

BB 42832: Download spam prevention exemption for browser extensions.

BB 42220: Allow for more file types to be forced-inline.

Firefox allows to open some files in the browser without any
confirmation, but this will result in a disk leak, because the file will
be downloaded to the temporary directory first (and not deleted, in some
cases).
A preference allows PDFs to be opened without being downloaded to disk.
So, we introduce a similar one to do the same for all the files that are
set to be opened automatically in the browser.

BB 42835: Create an actor to filter file data transfers

BB 42728: Modify ./mach lint to skip unused linters

Adding issue and merge request templates

fixup! Adding issue and merge request templates

revert

BB 43615: Add Gitlab Issue and Merge Request templates

fixup! BB 43615: Add Gitlab Issue and Merge Request templates

add new and modify existing shared Tor/Mullvad browser templates

BB 42683: Create script to generate issue triage csv file from bugzilla query and git logs

BB 42305: Add script to combine translation files across versions.

BB 43535: Enable tests

Add CI for Base Browser

fixup! Add CI for Base Browser

Timeout `git fetch` if takes longer than 3min.

Long fetched are very expensive and due to the amount of
parallel jobs our CI can execute at a time too many long
fetches can cause significant slowness on our Gitlab instance.

fixup! Add CI for Base Browser

Base Browser's .mozconfigs.

Bug 17858: Cannot create incremental MARs for hardened builds.
Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff
(which is part of mar-tools and is not distributed to end-users) with
ASan.

Bug 21849: Don't allow SSL key logging.

Bug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value.
Also see bug 27472 where we made a similar fix for Android.

Bug 29859: Disable HLS support for now

Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug 33734: Set MOZ_NORMANDY to False

Bug 33851: Omit Parental Controls.

Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

Bug 41584: Move some configuration options to base-browser level

fixup! Base Browser's .mozconfigs.

BB 43772: Do not use official branding for BB/TB/MB.

We already pass --with-branding in our builds, no need to also pass
this option.
However, we should further audit what this option does, and try to
recall why we added it at a certain point.

Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment
disabled.
Mozilla does not use a similar configuration, but either runs a Firefox
build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a
better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with
./mach package-multi-locale to create multi-locale packages.
The required command isn't exposed through any other mach command.
So, we patch package-multi-locale both to prevent it from failing when
doing official builds and to detect any future changes on it.

BB 29320: Replace the gnu target with gnullvm for Rust.

BB 42616: Remove VideoCaptureTest.kt.

This is a workaround to fix the GeckoView build with WebRTC disabled.
We should replace this workaround with a proper solution, that
excludes this test when MOZ_WEBRTC is undefined/False.

BB 41108: Remove privileged macOS installation from 102

BB 41149: Re-enable DLL injection protection in all builds not just nightlies

BB 43092: Disable wayland by default in Base Browser.

BB 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
manifest, so we can't use the ifdef preprocessor guards around the
permissions we do not want. Commenting the permissions is the
next-best-thing.

BB 28125: Prevent non-Necko network connections

BB 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421,
https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

BB 40717: Hide Windows SSO in settings

BB 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying
--disable-eme. But that changed and it is even bundled nowadays (see:
Mozilla's bug 1300654). We don't want to ship it right now as the use
case for it is not really visible while the code had security
vulnerabilities in the past.

BB 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

BB 42831: Remove the shopping components.

fixup! BB 42831: Remove the shopping components.

BB 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

BB 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

Bug 41662: Disable about:sync-logs

Even though we disable sync by default with
`identity.fxaccounts.enabled`, this about: page is still avilable.
We could throw an exception on the constructor of the related
component, but it would result only in an error in the console, without
a visible "this address does not look right" error page.
If we fix the issues with MOZ_SERVICES_SYNC, we can restore the
component.

BB 42716: Disable unwanted about: pages

BB 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when
the user entered an https or http URL in the URL bar, or
typed a search term.

BB 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and
url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for
'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For
the ones in the 'main' bucket, this prevents them from being synced
unnecessarily (the code in remote-settings does so for collections
in the main bucket for which a dump or local data exists). For the
collections in the other buckets, we just save some size by not
shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

BB 41092: Add a RemoteSettings JSON dump for query-stripping

BB 42730: Patch RemoteSettings to use only local dumps as a data source

BB 41635: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

BB 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

BB 28369: Stop shipping pingsender executable

BB 42630: Disable LaterRun module.

BB 41599: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes
and act consequently (e.g., to improve WebSocket UX).
However, there are a few ways to get this internal network ID, so we
patch them out, to be sure any new code will not be able to use them and
possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to
prevent any accidental leak in the future.
Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

BB 43386: Use Firefox in the UA in RFP-exempt request.

XHR requests initiated by extensions are exempt from RFP.
Therefore, they report the actual app name, instead of Firefox, and the
actual Firefox minor version.

This happens whenever the app name has been customized and does not
match a hardcoded "Firefox".

BB 41327: Disable UrlbarProviderInterventions

BB 42037: Disable about:firefoxview page

Firefox preference overrides.

fixup! Firefox preference overrides.

BB 43322: Switch from font whitelist to font visibility.

fixup! Firefox preference overrides.

This reverts commit ce4889c9f51d60761ffcbd416eac50ed6490fed9.

BB 43140: Tighten up fonts on Linux.

We ship a fontconfig configuration to esnure all Linux users have the
same defaults and reduce the chances of fingerprinting.
We used to add this file in tor-browser-build, but some users might
skip it by using the browser executable without the wrapper script.
Therefore, we decided to activate the file with the FontConfig API
instead of the environment variables.

Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our
fontconfig configuration. As a result, the final criterion to choose
the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use
it also for the UI. FontConfig will fall back to some other font for
scripts Arimo does not cover as expected (we tested with Japanese).

Bug 43141: Hardcode system-ui to Arimo.

BB 41901: Hardcode normalized FontSubstitutes.

Windows has a system to set font aliases through the registry.
This allows some customization that could be used as a fingerprinting
vector.
Moreover, this mechanism is used by Windows itself, and different SKUs
might have different default FontSubstitutes.

BB 43322: Customize the font visibility lists.

Customize the lists of fonts to assign base visibility to in
base browser and derivatives.

Also, rename the files with the upstream lists, to make sure we do not
use them by mistake.

BB 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is
called from Fenix side and sets `intl.accept_languages`
accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

BB 42562: Normalized the Accepted Languages on Android.

The OS language might be outside the list of actually supported
languages and it might leak the user's region.
Therefore, we force the locale reported in Accept-Language to match one
we support with translations, even when it means using a not exact
region tag.

BB 40171: Make WebRequest and GeckoWebExecutor First-Party aware

BB 26345: Hide tracking protection UI

BB 43109: Hide Firefox Relay from settings.

This should remain disabled, see tor-browser#42814.

BB 42777: Hide Website Privacy Preferences.

We hide the Website Privacy Preferences section, which controls the
"global privacy control" (GPC) and "do not track" (DNT) settings.

BB 42070: Hide "Use smooth scrolling" from settings

BB 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

BB 41739: Remove "Website appearance" from about:preferences.

It is ignored because of RFP and it is confusing for users.

BB 43117: Hide "Always underline links" from settings.

BB 42774: Always hide the third-pary certs UI.

BB 43118: Hide feature recommendation (CFR) settings.

BB 9173: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a
directory relative to the binary path.
The directory can be specified through the --with-relative-data-dir.
This is relative to the same directory as the firefox main binary for
Linux and Windows.

On macOS, we remove Contents/MacOS from it.
Or, in other words, the directory is relative to the application
bundle.

This behavior can be overriden at runtime, by placing a file called
system-install adjacent to the firefox main binary (also on macOS).

BB 42773: Replace ~ with the original home.

In Bug 93141, Mozilla started sending users to their home when they type
~ in the URL bar.
On Linux, we change $HOME for various reason, therefore you would be
redirected to the spoofed home directory when typing ~.
So, we check if the original home directory is known, and use that,
instead.

BB 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

BB 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line
tools, and not the browser, but I decided to patch them anyway because there
literally is a maze of network function pointers being passed around, and it's
very hard to tell if some random code might not pass in the proper proxied
versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

BB 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref
`intl.regional_prefs.use_os_locales` is false but RFP is enabled.

BB 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

BB 29745: Limit remote access to content accessible resources

BB 33955: When copying an image only copy the image contents to the clipboard

BB 41791: Omit the source URL when copying page contents to the clipboard

BB 42288: Allow language spoofing in status messages.

BB 43196: Remove the vendor name from media notifications on Linux.

Firefox shows "vendor remoteName" as a title of the "... is playing
media" notification on Linux.
However, for our browser the remote name is enough, and prepending the
vendor to it creates a string users usually never see.

Base Browser strings

This commit adds all the strings needed by following Base Browser
patches.

fixup! Base Browser strings

BB 41919: Letterboxing, add temporarily visible web content-size indicator on window resizing.

fixup! Base Browser strings

TB 43624: Tweak the string letterboxing-size-status.

NOTE: The string has not yet reached translators, so we do not need to
change the ID.

BB 42583: Modify moz-support-link for Base Browser.

BB 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than
name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the
Japanese language tag could be confusing for users, and moreover the
language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system
language, but some users might want to change it.
So, we tell them that it is possible, but only once.

BB 40283: Workaround for the file upload bug

BB 42019: Empty browser's clipboard on browser shutdown

BB 42084: Ensure English spoofing works even if preferences are set out of order.

BB 41930: Remove the UI to customize accept_languages.

BB 32308: Use direct browser sizing for letterboxing.

Bug 30556: align letterboxing with 200x100 new win width stepping

BB 41631: Prevent weird initial window dimensions caused by subpixel computations

BB 41918: Option to reuse last window size when letterboxing is enabled.

BB 41916: Letterboxing preferences UI

fixup! BB 41916: Letterboxing preferences UI

BB 41695: Warn on window maximization without letterboxing in RFPHelper module

BB 42443: Shrink window to match letterboxing size when the emtpy area is clicked.

BB 41919: Letterboxing, add temporarily visible web content-size indicator on window resizing.

fixup! BB 41919: Letterboxing, add temporarily visible web content-size indicator on window resizing.

BB 43632: Letterboxing, always show the correct size for the active tab on resizing.
BB 43642: New tab shows letterboxing size indicator.

BB 42528: Don't leak system scrollbar size on windows.

BB 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order
to avoid several network requests that we do not need.

Bug 41624: Disable about:pocket-* pages.

Bug 40144: Redirect about:privatebrowsing to the user's home

BB 4234: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201).
Windows: avoid writing to the registry (16236).
Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
  16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser
version changed (even if the Firefox version and build ID did
not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions
that windows will be restored after an update is applied, and replace the
"Restart and Restore" button label with an existing
"Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the
hamburger (app) menu while the update service is downloading a MAR
file. Before this change, the browser did not indicate to the user
that an update was in progress, which is especially confusing in
Tor Browser because downloads often take some time. If the user
clicks on the new menu item, the about dialog is opened to allow
the user to see download progress.

As part of this fix, the update service was changed to always show
update-related messages in the hamburger menu, even if the update
was started in the foreground via the about dialog or via the
"Check for Tor Browser Update" toolbar menu item. This change is
consistent with the Tor Browser goal of making sure users are
informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

BB 42061: Create an alpha update channel.

BB 41682: Add base-browser nightly mar signing key

BB 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and
MOZ_SOURCE_CHANGESET.
But the code takes for granted that it refers to a Hg instance, so it
combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`.
With this commit, we change this logic to combine them to create a URL
that is valid for GitLab.
$MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag.
If that is needed, we could use /-/tree/, instead of /-/commit/.

BB 42438: Tweaks to the migration wizard.

Remove the items not compatible with our features (such as history) from
the migration wizard.

On Linux, allow to specify an alternative home directory, since we
usually change $HOME in our startup script.

BB 40069: Add helpers for message passing with extensions

BB 41598: Prevent NoScript from being removed/disabled.

Bug 40253: Explicitly allow NoScript in Private Browsing mode.

BB 41581: Hide NoScript extension's toolbar button by default.

This hides it from both the toolbar and the unified extensions panel.

We also hide the unified-extension-button if the panel would be empty:
not including the NoScript button when it is hidden. As a result, this
will be hidden by default until a user installs another extension (or
shows the NoScript button and unpins it).

BB 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons

BB 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually
indicates the current global security level via icon (as defined by the
extensions.torbutton.security_slider pref), a drop-down hanger with a
short description of the current security level, and a new section in
the about:preferences#privacy page where users can change their current
security level. In addition, the hanger and the preferences page will
show a visual warning when the user has modified prefs associated with
the security level and provide a one-click 'Restore Defaults' button to
get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

BB 40926: Implemented the New Identity feature

fixup! BB 40926: Implemented the New Identity feature

Fixed oncommands

BB 41736: Customize toolbar for base-browser.

BB 42027: Base Browser migration procedures.

This commit implmenents the the Base Browser's version of _migrateUI.

Pier Angelo Vendrame pushed to branch mullvad-browser-139.0a1-15.0-1 at The Tor Project / Applications / Mullvad Browser

Commits:

355 changed files:

The diff was not included because it is too large.