I am so thankful to you for helping me out. But there is one thing that I would like to point out. I cloned both the esr8.5-1 and esr9.0-1 branches and tried building them. Both of them failed with the latest rust version (which now is 1.35) (got similar macro errors of which I had sent you a screenshot before). I needed to fall back to rust v1.29.1 to build them without any errors.

I am really really grateful to you for helping me out. I can now start working on my project. Thank you so much!

Warm Regards,
Rishabh Raj

On Wed, May 29, 2019 at 4:14 AM Georg Koppen <gk@torproject.org> wrote:
Rishabh Raj:
> Hello Georg,
>
> I was finally able to build it, but here is what I had to do. |./mach
> configure| will not run unless I do not patch the
> "build/moz.configure/init.configure" file using this website
> <https://hg.mozilla.org/integration/autoland/rev/36f4ba2fb6f5>. After this,
> I figured out that |./mach build| was giving me errors because my rust
> version was 1.34. I downgraded it to 1.29 and it worked (I have no clue as
> to why this is required).

I wonder what branch you are actually using for building because that
the patch for bug 1479540, which you need, got backported to esr60
months ago and is available on all recent tor-browser branches. That
might be the underlying problem for your rust issues as well.

Please check out `tor-browser-60.7.0esr-9.0-1` which is the current
development branch (but `tor-browser-60.7.0esr-8.5-1` should work as well.

> But now that it has built, I did |./mach stage-package| and then copied the
> contents of the folder "obj-*/dist/firefox/" to the "Browser/" folder of
> tor-browser-linux64-8.5_en-US which I downloaded from Tor Browser's
> website. But now, when I run |./start-tor-browser.desktop|, it launches
> Firefox browser with my current profile. I thought that it would launch Tor
> Browser, but it didn't. Is this how it's supposed to work? I feel that I am
> close and I might be missing something here. I would be really grateful if
> you could tell me what I am missing here.

I think you are not checking out the proper tor-browser branch (see
above), which explains why you need to provide an own .mozconfig file
etc. even though that file with the Tor Browser settings is already there.

Georg

> For the record, I would be modifying Firefox's webgl code (as in the code
> which handles the various animation programs which using webgl)
>
> Warm Regards,
> Rishabh Raj
>
> On Tue, May 28, 2019 at 7:39 AM Georg Koppen <gk@torproject.org> wrote:
>
>> Rishabh Raj:
>>> Hello,
>>> I had previously sent a similar mail on tbb-community-team. But Georg
>>> advised me to send it on tbb-dev. So here I am.
>>>
>>> I am actually working on modifying some parts of Tor Browser for my
>> project
>>> and for that I will need to build Tor Browser's source code. I was
>>> following this website
>>> <https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking>
>>> (Georg has updated it now) and after cloning tor-browser-build repo, I
>> did
>>> a |make nightly-linux-x86_64|, which took almost half a day to complete
>> on
>>> my Ubuntu 18.04 system. But, since I would be making some changes to the
>>> browser (mostly Firefox code), I need to alter code and build again and
>>> again.
>>>
>>> In the above website, there is an option for '*Building Just Firefox*'
>> and
>>> I am trying that. Coming to the updated wiki, I think there might still
>> be
>>> some issues there. Allow me to make myself clearer:
>>>
>>> (1)
>>> Installation of packages. Some of them may be deprecated. For example I
>> get
>>> this after running the command :
>>> |||
>>> Reading package lists... Done
>>> Building dependency tree
>>> Reading state information... Done
>>> Package hardening-wrapper is not available, but is referred to by another
>>> package.
>>> This may mean that the package is missing, has been obsoleted, or
>>> is only available from another source
>>>
>>> E: Package 'hardening-wrapper' has no installation candidate
>>> E: Unable to locate package libgstreamer-plugins-base0.10-dev
>>> E: Couldn't find any package by glob 'libgstreamer-plugins-base0.10-dev'
>>> E: Couldn't find any package by regex 'libgstreamer-plugins-base0.10-dev'
>>> |||
>>>
>>> (2)
>>> Assuming this is not the issue, I proceeded and made the new file
>>> |.mozconfig| and copied the given two lines into it, cloned and moved the
>>> tor-launcher as well and ran the |./mach configure --with-tor-...|
>> command,
>>> which gives:
>>
>> What happens if you try my last advice:
>>
>> """
>> No need for a new .mozconfig. If you check out the latest tor-browser
>> branch (tor-browser-60.7.0esr-9.0-1) there is already a .mozconfig file
>> that works for Linux.
>>
>> Then just using the mach commands on the wiki should work (I tested that
>> at least the configure command worked on my system) provided you have
>> the right packages installed.
>> """
>> ?
>>
>> Georg
>>
>> _______________________________________________
>> tbb-dev mailing list
>> tbb-dev@lists.torproject.org
>> https://lists.torproject.org/cgi-bin/mailman/listinfo/tbb-dev
>>
>
>
> _______________________________________________
> tbb-dev mailing list
> tbb-dev@lists.torproject.org
> https://lists.torproject.org/cgi-bin/mailman/listinfo/tbb-dev
>


_______________________________________________
tbb-dev mailing list
tbb-dev@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tbb-dev