On 2019-12-02 17:01, Jeremy Rand wrote:
Nicolas Vigier:
On Fri, 15 Nov 2019, Thomas Klausner wrote:
I wanted to build firefox-tor-browser-68.2.0esr-9.0-1-build2 (torbrowser 9.0.1) on NetBSD from the source tarball, but I stumbled over a couple problems.
The first one, .mozconfig contains --disable-eme but configure doesn't like it:
mozbuild.configure.options.InvalidOptionError: --disable-eme is not available in this configuration
Is this a NetBSD-specific issue or more general?
In our linux, windows, macOS .mozconfigs we have the line:
ac_add_options --disable-eme
But I don't remember seeing this error, so it looks NetBSD-specific.
I'm pretty sure I've seen it in my WIP port of Tor Browser to Linux on ARM. Firefox ESR68 has a regression compared to ESR60, where it throws an error if you pass --disable-eme on a platform that doesn't support EME. Presumably NetBSD doesn't support EME just like Linux on ARM doesn't, so you hit that bug just like I did.
I'm not sure I would consider this a regression. In the configuration file you are explicitly saying you want to disable EME, but the platform does not support EME - so how do you disable something that can not possibly be enabled? I completely agree the error message can be more helpful and clearer about why it is "not available".
We explored this error on Android, as well. The ticket has more details: https://trac.torproject.org/projects/tor/ticket/31880