morgan pushed to branch mullvad-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser

Commits:

16 changed files:

Changes:

  • .gitlab/issue_templates/000 Bug Report.md
    1
    +# 🐞 Bug Report
    
    2
    +<!--
    
    3
    +Use this template to report problems with the browser which are unrelated to
    
    4
    +website functionality (please use the Web Compatibility template for such issues).
    
    5
    +The issue's title MUST provide a succinct description of the problem.
    
    6
    +
    
    7
    +Some good (hypothetical) titles:
    
    8
    +- Browser crashes when visiting example.com in Safer mode
    
    9
    +- Letterboxing appears even when disabled when using tiling window-manager
    
    10
    +- All fonts in browser-chrome have serifs
    
    11
    +
    
    12
    +Please DO NOT include information about platform in the title, it is redundant
    
    13
    +with our labeling system!
    
    14
    +-->
    
    15
    +
    
    16
    +## Reproduction steps
    
    17
    +<!--
    
    18
    +Provide specific steps developers can follow to reproduce your issue.
    
    19
    +-->
    
    20
    +
    
    21
    +## Expected behaviour
    
    22
    +<!--
    
    23
    +Provide a description of the browser feature or scenario which does not appear
    
    24
    +to be working.
    
    25
    +-->
    
    26
    +
    
    27
    +## Actual behaviour
    
    28
    +<!--
    
    29
    +Provide a description of what actually occurs.
    
    30
    +-->
    
    31
    +
    
    32
    +## Bookkeeping
    
    33
    +<!--
    
    34
    +Please provide the following information:
    
    35
    +-->
    
    36
    +
    
    37
    +- Browser version:
    
    38
    +- Browser channel:
    
    39
    +  - [ ] Release
    
    40
    +  - [ ] Alpha
    
    41
    +  - [ ] Nightly
    
    42
    +- Distribution method:
    
    43
    +  - [ ] Installer/archive from mullvad.net
    
    44
    +  - [ ] homebrew
    
    45
    +  - [ ] other (please specify):
    
    46
    +- Operating System:
    
    47
    +  - [ ] Windows
    
    48
    +  - [ ] macOS
    
    49
    +  - [ ] Linux
    
    50
    +  - [ ] Other (please specify):
    
    51
    +- Operating System Version:
    
    52
    +
    
    53
    +### Browser UI language
    
    54
    +<!--
    
    55
    +Found in `about:preferences#general`.
    
    56
    +Feel free to omit this if you like, but sometimes bugs can be language specific so having
    
    57
    +this info may make it easier for developers to reproduce your problem.
    
    58
    +-->
    
    59
    +
    
    60
    +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones?
    
    61
    +<!--
    
    62
    +If you changed any preference in about:config that aren't exposed in a UI,
    
    63
    +could you try to see if you can reproduce without them? Generally speaking, such
    
    64
    +changes are unsupported and bugs might be closed as invalid.
    
    65
    +-->
    
    66
    +
    
    67
    +### Do you have any extra extensions installed?
    
    68
    +<!-- e.g. Firefox Multi-Account Containers, uBlock Origin, etc -->
    
    69
    +
    
    70
    +## Troubleshooting
    
    71
    +<!--
    
    72
    +This is optional, but it will help to resolve your problem.
    
    73
    +-->
    
    74
    +
    
    75
    +### Does this bug occur in a fresh installation?
    
    76
    +
    
    77
    +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear?
    
    78
    +<!--
    
    79
    +Archived packages for past versions can be found here:
    
    80
    +- https://archive.torproject.org/tor-package-archive
    
    81
    +-->
    
    82
    +
    
    83
    +### Does this bug occur in the Alpha release channel?
    
    84
    +<!--
    
    85
    +Sometimes bugs are fixed in the Alpha (development) channel but not in the Stable channel.
    
    86
    +⚠️ However, the Alpha release channel is the development version and as such may be contain
    
    87
    +critical bugs not present in the Stable release channel.
    
    88
    +
    
    89
    +The latest Alpha can be found here:
    
    90
    +- https://github.com/mullvad/mullvad-browser/releases?q=prerelease%3Atrue
    
    91
    +-->
    
    92
    +
    
    93
    +### Does this bug occur in Firefox ESR (Desktop only)?
    
    94
    +<!--
    
    95
    +Tor Browser is based on Firefox ESR, so any bugs present in this upstream project will likely
    
    96
    +also be present in Tor Browser.
    
    97
    +Firefox ESR is available for download here:
    
    98
    +- https://www.mozilla.org/en-US/firefox/all/desktop-esr/
    
    99
    +-->
    
    100
    +
    
    101
    +### Does this bug occur in Firefox Rapid Release?
    
    102
    +<!--
    
    103
    +If the issue occurs in Firefox ESR, but does not occur in Firefox Rapid Release, we may be able
    
    104
    +to identify and backport the patch which fixes it.
    
    105
    +
    
    106
    +Firefox Rapid Release is available for download here:
    
    107
    +- https://www.mozilla.org/en-US/firefox/new/
    
    108
    +
    
    109
    +If the issue has been fixed in Firefox, do you know the Bugzilla issue number associated with the fix?
    
    110
    +-->
    
    111
    +
    
    112
    +<!-- Do not edit beneath this line <3 -->
    
    113
    +
    
    114
    +---
    
    115
    +
    
    116
    +/label ~"Apps::Product::MullvadBrowser"
    
    117
    +/label ~"Apps::Type::Bug"

  • .gitlab/issue_templates/010 Proposal.md
    1
    +# 💡 Proposal
    
    2
    +<!--
    
    3
    +Use this template to request a feature or propose some change in the browser.
    
    4
    +The issue will likely be edited many times over its life to flesh out the various
    
    5
    +questions, so if you don't know the answers to something, jut leave it blank!
    
    6
    +
    
    7
    +The issue's title MUST provide a succinct description of proposal.
    
    8
    +
    
    9
    +Some good (hypothetical) titles:
    
    10
    +- Remove 'Safer' option from Security Level
    
    11
    +- Bundle uBlock Origin by default
    
    12
    +- Replace NoScript with faith-based JavaScript sand-boxing
    
    13
    +-->
    
    14
    +
    
    15
    +## User Story
    
    16
    +<!--
    
    17
    +Provide a high-level summary of the proposed feature, the problem it solves, and
    
    18
    +what it would allow users to do if implemented. -->
    
    19
    +
    
    20
    +## Security and Privacy Implications
    
    21
    +<!--
    
    22
    +How would this proposal interact with our the browser's threat model?
    
    23
    +Would this feature negatively affect the browser's security or privacy
    
    24
    +guarantees?
    
    25
    +-->
    
    26
    +
    
    27
    +### Security
    
    28
    +<!--
    
    29
    +TODO: Mullvad Browser's threat model is somehow less restrictive than Tor Browser's, but currently undefined
    
    30
    +Outline any security implications this feature would introduce. The browser's
    
    31
    +security requirements can be found in our threat model document here:
    
    32
    +- https://gitlab.torproject.org/tpo/applications/wiki/-/wikis/Design-Documents/Tor-Browser-Design-Doc#21-security-requirements
    
    33
    +-->
    
    34
    +
    
    35
    +### Privacy
    
    36
    +<!--
    
    37
    +TODO: Mullvad Browser's threat model is somehow less restrictive than Tor Browser's, but currently undefined
    
    38
    +Outline any privacy implications this feature would introduce. The browser's
    
    39
    +privacy requirements can be found in our threat model document here:
    
    40
    +- https://gitlab.torproject.org/tpo/applications/wiki/-/wikis/Design-Documents/Tor-Browser-Design-Doc#22-privacy-requirements
    
    41
    +-->
    
    42
    +
    
    43
    +## Accessibility Implications
    
    44
    +<!--
    
    45
    +Would this proposal affect or interact with the browser's usability for users
    
    46
    +with accessibility needs (e.g. vision or mobility issues). What problems would need
    
    47
    +to be solved to ensure these users are not left behind?
    
    48
    +-->
    
    49
    +
    
    50
    +## Other Trade-Offs
    
    51
    +<!--
    
    52
    +Beyond the security, privacy and accessibility implications, what other implications
    
    53
    +are there for users?
    
    54
    +-->
    
    55
    +
    
    56
    +## Prior Art
    
    57
    +
    
    58
    +### Does this feature exist in other browsers?
    
    59
    +- [ ] Yes
    
    60
    +    - [ ] Firefox
    
    61
    +    - [ ] Firefox ESR
    
    62
    +    - [ ] Other (please specify)
    
    63
    +- [ ] No
    
    64
    +
    
    65
    +### Does this feature exist as an extension? If yes, which one provides this functionality?
    
    66
    +
    
    67
    +<!-- Do not edit beneath this line <3 -->
    
    68
    +
    
    69
    +---
    
    70
    +
    
    71
    +/label ~"Apps::Product::MullvadBrowser"
    
    72
    +/label ~"Apps::Type::Proposal"

  • .gitlab/issue_templates/020 Web Compatibility.md
    1
    +# 🌍 Web Compatibility
    
    2
    +<!--
    
    3
    +Use this template to report websites which do not work properly in the browser.
    
    4
    +The issue's title MUST provide a succinct description of the problem.
    
    5
    +
    
    6
    +Some good (hypothetical) titles:
    
    7
    +- Road signs do not render correctly on maps.foo.com
    
    8
    +- Infinite CAPTCHA prompts on bar.nat
    
    9
    +- Cannot login to baz.org
    
    10
    +-->
    
    11
    +
    
    12
    +## URL
    
    13
    +<!-- Provide a link to the website -->
    
    14
    +
    
    15
    +## Expected behaviour
    
    16
    +<!--
    
    17
    +Provide a description of the how the website is supposed to work
    
    18
    +-->
    
    19
    +
    
    20
    +## Actual behaviour
    
    21
    +<!--
    
    22
    +Provide a description of what actually occurs
    
    23
    +-->
    
    24
    +
    
    25
    +## Reproduction steps
    
    26
    +<!--
    
    27
    +Provide specific steps developers can follow to reproduce your issue
    
    28
    +-->
    
    29
    +
    
    30
    +## Bookkeeping
    
    31
    +<!--
    
    32
    +Please provide the following information:
    
    33
    +-->
    
    34
    +
    
    35
    +- Browser version:
    
    36
    +- Browser channel:
    
    37
    +  - [ ] Release
    
    38
    +  - [ ] Alpha
    
    39
    +  - [ ] Nightly
    
    40
    +- Distribution method:
    
    41
    +  - [ ] Installer/archive from mullvad.net
    
    42
    +  - [ ] homebrew
    
    43
    +  - [ ] other (please specify):
    
    44
    +- Operating System:
    
    45
    +  - [ ] Windows
    
    46
    +  - [ ] macOS
    
    47
    +  - [ ] Linux
    
    48
    +  - [ ] Other (please specify):
    
    49
    +- Operating System Version:
    
    50
    +
    
    51
    +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones?
    
    52
    +<!--
    
    53
    +If you changed any preference in about:config that aren't exposed in a UI,
    
    54
    +could you try to see if you can reproduce without them? Generally speaking, such
    
    55
    +changes are unsupported and bugs might be closed as invalid.
    
    56
    +-->
    
    57
    +
    
    58
    +### Do you have any extra extensions installed?
    
    59
    +<!-- e.g. Firefox Multi-Account Containers, uBlock Origin, etc -->
    
    60
    +
    
    61
    +## Troubleshooting
    
    62
    +<!--
    
    63
    +This is optional, but it will help to resolve your problem.
    
    64
    +-->
    
    65
    +
    
    66
    +### Does this bug occur in a fresh installation?
    
    67
    +
    
    68
    +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear?
    
    69
    +<!--
    
    70
    +Archived packages for past versions can be found here:
    
    71
    +- https://archive.torproject.org/tor-package-archive
    
    72
    +-->
    
    73
    +
    
    74
    +### Does this bug occur in the Alpha release channel?
    
    75
    +<!--
    
    76
    +Sometimes bugs are fixed in the Alpha (development) channel but not in the Stable channel.
    
    77
    +⚠️ However, the Alpha release channel is the development version and as such may be contain
    
    78
    +critical bugs not present in the Stable release channel.
    
    79
    +
    
    80
    +The latest Alpha can be found here:
    
    81
    +- https://github.com/mullvad/mullvad-browser/releases?q=prerelease%3Atrue
    
    82
    +-->
    
    83
    +
    
    84
    +### Does this bug occur in Firefox ESR (Desktop only)?
    
    85
    +<!--
    
    86
    +Tor Browser is based on Firefox ESR, so any bugs present in this upstream project will likely
    
    87
    +also be present in Tor Browser.
    
    88
    +Firefox ESR is available for download here:
    
    89
    +- https://www.mozilla.org/en-US/firefox/all/desktop-esr/
    
    90
    +-->
    
    91
    +
    
    92
    +### Does this bug occur in Firefox Rapid Release?
    
    93
    +<!--
    
    94
    +If the issue occurs in Firefox ESR, but does not occur in Firefox Rapid Release, we may be able
    
    95
    +to identify and backport the patch which fixes it.
    
    96
    +
    
    97
    +Firefox Rapid Release is available for download here:
    
    98
    +- https://www.mozilla.org/en-US/firefox/new/
    
    99
    +
    
    100
    +If the issue has been fixed in Firefox, do you know the Bugzilla issue number associated with the fix?
    
    101
    +-->
    
    102
    +
    
    103
    +<!-- Do not edit beneath this line <3 -->
    
    104
    +
    
    105
    +---
    
    106
    +
    
    107
    +/label ~"Apps::Product::MullvadBrowser"
    
    108
    +/label ~"Apps::Type::WebCompatibility"

  • .gitlab/issue_templates/030 Test.md
    1
    +# 💣 Test
    
    2
    +<!--
    
    3
    +Use this template to track testing of some feature. Please
    
    4
    +try to make the title a good one-liner for the changelogs!
    
    5
    +
    
    6
    +Some good (hypothetical) titles:
    
    7
    +- Add test exercising new circuit button
    
    8
    +- Add tests for verifying built-in bridge connectivity
    
    9
    +- Develop a mock Lox authority for automated testing
    
    10
    +-->
    
    11
    +
    
    12
    +## Description
    
    13
    +<!--
    
    14
    +Provide an overview of the technical/implementation aspects of this
    
    15
    +test work a developer would need to know
    
    16
    +-->
    
    17
    +
    
    18
    +## Scenarios
    
    19
    +<!--
    
    20
    +Provide a list of high-level classes of desired test-cases
    
    21
    +and the expected behaviour of each
    
    22
    +-->
    
    23
    +
    
    24
    +<!-- Do not edit beneath this line <3 -->
    
    25
    +
    
    26
    +---
    
    27
    +
    
    28
    +/label ~"Apps::Product::MullvadBrowser"
    
    29
    +/label ~"Apps::Type::Test"

  • .gitlab/issue_templates/040 Feature.md
    1
    +# ✨ Feature
    
    2
    +<!--
    
    3
    +Use this template to track implementation of some feature. Please
    
    4
    +try to make the title a good one-liner for the changelogs!
    
    5
    +
    
    6
    +Some good (hypothetical) titles:
    
    7
    +- Bundle AwesomeFont Sans Font
    
    8
    +- Implement new user on-boarding UX
    
    9
    +- Publish Linux aarch64 alpha builds
    
    10
    +-->
    
    11
    +
    
    12
    +## Description
    
    13
    +<!--
    
    14
    +Provide an overview of the technical/implementation aspects of this feature
    
    15
    +-->
    
    16
    +
    
    17
    +## Bookkeeping
    
    18
    +
    
    19
    +### Proposal
    
    20
    +<!-- Add links to associated proposal issues (or delete block) -->
    
    21
    +- mullvad-browser#123
    
    22
    +
    
    23
    +### Design
    
    24
    +<!-- Add links to associated design issues (or delete block) -->
    
    25
    +- tpo/UX/Design#123
    
    26
    +
    
    27
    +<!-- Do not edit beneath this line <3 -->
    
    28
    +
    
    29
    +---
    
    30
    +
    
    31
    +/label ~"Apps::Product::MullvadBrowser"
    
    32
    +/label ~"Apps::Type::Feature"

  • .gitlab/issue_templates/Backport.md.gitlab/issue_templates/050 Backport.md
    1
    +# ⬅️ Backport Patchset
    
    1 2
     <!--
    
    2
    -Title:
    
    3
    -    Backport mullvad-browser#123: Title of Issue
    
    4
    -    Backport Bugzilla 1234567: Title of Issue
    
    3
    +This is an issue for tracking back-porting a patch-set (e.g. from Alpha to Stable or from
    
    4
    +Mozilla Rapid-Release to Alpha).
    
    5 5
     
    
    6
    -This is an issue for tracking back-porting a patch-set (e.g. from Alpha to Stable or from Mozilla Rapid-Release to Alpha)
    
    7
    --->
    
    6
    +please ensure the title has the following format:
    
    7
    +
    
    8
    +- Backport tor-browser#12345: Title of original issue
    
    9
    +- Backport Bugzilla 1234567: Title of original issue
    
    8 10
     
    
    9
    -## Backport Patchset
    
    11
    +-->
    
    10 12
     
    
    11
    -### Book-keeping
    
    13
    +## Bookkeeping
    
    12 14
     
    
    13
    -#### Gitlab Issue(s)
    
    15
    +### Issue(s)
    
    14 16
     - tor-browser#12345
    
    15 17
     - mullvad-browser#123
    
    16 18
     - https://bugzilla.mozilla.org/show_bug.cgi?id=1234567
    
    17 19
     
    
    18
    -#### Merge Request(s)
    
    19
    -- mullvad-browser!123
    
    20
    +### Merge Request(s)
    
    21
    +- tor-browser!123
    
    20 22
     
    
    21
    -#### Target Channels
    
    23
    +### Target Channels
    
    22 24
     
    
    23 25
     - [ ] Alpha
    
    24 26
     - [ ] Stable
    
    27
    +- [ ] Legacy
    
    25 28
     
    
    26
    -### Notes
    
    29
    +## Notes
    
    27 30
     
    
    28 31
     <!-- whatever additional info, context, etc that would be helpful for backporting -->
    
    29 32
     
    
    33
    +
    
    34
    +<!-- Do not edit beneath this line <3 -->
    
    35
    +
    
    36
    +---
    
    37
    +
    
    38
    +/label ~"Apps::Product::TorBrowser"
    
    30 39
     /label ~"Apps::Type::Backport"

  • .gitlab/issue_templates/Rebase Browser - Alpha.md.gitlab/issue_templates/060 Rebase - Alpha.md
    1
    +# ⤵️ Rebase Alpha
    
    2
    +
    
    1 3
     **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr
    
    2 4
     
    
    3 5
     <details>
    
    ... ... @@ -85,4 +87,10 @@
    85 87
         ```
    
    86 88
       - [ ] Push tag to `upstream`
    
    87 89
     
    
    90
    +<!-- Do not edit beneath this line <3 -->
    
    91
    +
    
    92
    +---
    
    93
    +
    
    94
    +/label ~"Apps::Product::MullvadBrowser"
    
    88 95
     /label ~"Apps::Type::Rebase"
    
    96
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Rebase Browser - Stable.md.gitlab/issue_templates/061 Rebase - Stable.md
    1
    +# ⤵️ Rebase Stable
    
    1 2
     **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr
    
    2 3
     
    
    3 4
     <details>
    
    ... ... @@ -86,4 +87,10 @@
    86 87
         ```
    
    87 88
       - [ ] Push tag to `upstream`
    
    88 89
     
    
    90
    +<!-- Do not edit beneath this line <3 -->
    
    91
    +
    
    92
    +---
    
    93
    +
    
    94
    +/label ~"Apps::Product::MullvadBrowser"
    
    89 95
     /label ~"Apps::Type::Rebase"
    
    96
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Rebase Browser - Rapid.md.gitlab/issue_templates/063 Rebase - Rapid.md
    1
    +# ⤵️ Rebase Rapid
    
    2
    +
    
    1 3
     **NOTE**: All examples in this template reference the rebase from Firefox 129.0a1 to 130.0a1, see the tor-browser `Rebase Browser - Rapid.md` template for further info
    
    2 4
     
    
    3 5
     <details>
    
    ... ... @@ -82,4 +84,10 @@
    82 84
         ```
    
    83 85
       - [ ] Push tag to `upstream`
    
    84 86
     
    
    87
    +<!-- Do not edit beneath this line <3 -->
    
    88
    +
    
    89
    +---
    
    90
    +
    
    91
    +/label ~"Apps::Product::MullvadBrowser"
    
    85 92
     /label ~"Apps::Type::Rebase"
    
    93
    +/label ~"Apps::Priority::High"

  • .gitlab/issue_templates/Emergency Security Issue.md.gitlab/issue_templates/090 Emergency Security Issue.md
    1
    +# 🚨 Emergency Security Issue
    
    2
    +
    
    1 3
     **NOTE** This is an issue template to standardise our process for responding to and fixing critical security and privacy vulnerabilities, exploits, etc.
    
    2 4
     
    
    3 5
     ## Information
    
    4 6
     
    
    5 7
     ### Related Issue
    
    6
    -- tor-browser#AAAAA
    
    7 8
     - mullvad-browser#BBBBB
    
    8 9
     - tor-browser-build#CCCCC
    
    9 10
     
    
    10 11
     #### Affected Platforms
    
    11 12
     
    
    12
    -- [ ] Android
    
    13 13
     - [ ] Desktop
    
    14 14
       - [ ] Windows
    
    15 15
       - [ ] macOS
    
    ... ... @@ -18,7 +18,9 @@
    18 18
     ### Type of Issue: What are we dealing with?
    
    19 19
     
    
    20 20
     - [ ] Security (sandbox escape, remote code execution, etc)
    
    21
    -- [ ] Cross-Site Linkability (correlating sessions across websites)
    
    21
    +- [ ] Proxy Bypass (traffic contents becoming MITM'able)
    
    22
    +- [ ] De-Anonymization (otherwise identifying which website a user is visiting)
    
    23
    +- [ ] Cross-Site Linkability (correlating sessions across circuits and websites)
    
    22 24
     - [ ] Disk Leak (persisting session information to disk)
    
    23 25
     - [ ] Other (please explain)
    
    24 26
     
    
    ... ... @@ -29,16 +31,17 @@
    29 31
       - [ ] **clairehurst** : Android, macOS
    
    30 32
       - [ ] **dan** : Android, macOS
    
    31 33
       - [ ] **henry** : accessibility, frontend, localisation
    
    34
    +  - [ ] **jwilde** : windows, firefox internals
    
    32 35
       - [ ] **ma1** : firefox internals
    
    33 36
       - [ ] **pierov** : updater, fonts, localisation, general
    
    34
    -  - [ ] **richard** : signing, release
    
    37
    +  - [ ] **morgan** : signing, release
    
    35 38
       - [ ] **thorin** : fingerprinting
    
    36 39
     - [ ] Other Engineering Teams
    
    37 40
       - [ ] UX (**donuts**)
    
    38 41
       - [ ] TPA (**anarcat**, **lavamind**)
    
    39 42
     - [ ] External Tor Partners
    
    40
    -  - [ ] Mozilla (**tjr**)
    
    41
    -  - [ ] Mullvad (**ruihildt**)
    
    43
    +  - [ ] Mozilla
    
    44
    +  - [ ] Mullvad
    
    42 45
       - [ ] Other (please list)
    
    43 46
     
    
    44 47
     ### Urgency: When do we need to act?
    
    ... ... @@ -65,7 +68,6 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad
    65 68
     
    
    66 69
     - [ ] Start an initial email thread with the following people:
    
    67 70
       - [ ] **bella**
    
    68
    -  - [ ] **ruihildt**, **support@mullvadvpn.net**
    
    69 71
       - [ ] Relevant Applications Developers
    
    70 72
       - [ ] **(Optional)** **micah**
    
    71 73
         - if there are considerations or asks outside the Applications Team
    
    ... ... @@ -74,12 +76,20 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad
    74 76
       - [ ] **(Optional)** **gazebook**
    
    75 77
         - if there are consequences to the organisation or partners beyond a browser update, then a communication plan may be needed
    
    76 78
     
    
    79
    +Godspeed! :pray:
    
    80
    +
    
    81
    +<!-- Do not edit beneath this line <3 -->
    
    82
    +
    
    83
    +---
    
    84
    +
    
    77 85
     /cc @bella
    
    78 86
     /cc @ma1
    
    79 87
     /cc @micah
    
    80
    -/cc @richard
    
    88
    +/cc @morgan
    
    81 89
     /cc @ruihildt
    
    82 90
     
    
    83 91
     /confidential
    
    84 92
     
    
    85
    -Godspeed! :pray:
    93
    +/label ~"Apps::Product::MullvadBrowser"
    
    94
    +/label ~"Apps::Type::Bug"
    
    95
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Default.md
    1
    +# Open a new Issue
    
    2
    +
    
    3
    +Please select the appropriate issue template from the **Description** drop-down.
    
    4
    +
    
    5
    +---
    
    6
    +
    
    7
    +- 🐞 **Bug Report** - report a problem with the browser
    
    8
    +- 💡 **Proposal** - suggest a new feature
    
    9
    +- 🌐 **Web Compatibility** - report a broken website
    
    10
    +
    
    11
    +*NOTE*: the following issue types are intended for internal use
    
    12
    +
    
    13
    +- 💣 **Test** - develop a test or update testing infrastructure
    
    14
    +-**Feature** - implement new features
    
    15
    +- ⬅️ **Backport** - cherry-pick change to other release channels
    
    16
    +- ⤵️ **Rebase - Alpha** - rebase alpha to latest Firefox ESR version
    
    17
    +- ⤵️ **Rebase - Stable** - rebase stable to latest Firefox ESR version
    
    18
    +- ⤵️ **Rebase - Rapid** - rebase rapid to latest Firefox Nightly version
    
    19
    +- 🚨 **Emergency Security Issue** - manage fixing and publishing a critical security fix

  • .gitlab/issue_templates/QA - Android.md deleted
    1
    -Manual QA test check-list for major android releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist!
    
    2
    -<details>
    
    3
    -    <summary>Tor Browser Android QA Checklist</summary>
    
    4
    -```markdown
    
    5
    -# System Information
    
    6
    -
    
    7
    -- Version: Tor Browser XXX
    
    8
    -- OS: Android YYY
    
    9
    -- Device + CPU Architecture: ZZZ
    
    10
    -
    
    11
    -# Features
    
    12
    -
    
    13
    -## Base functionality
    
    14
    -- [ ] Tor Browser launches successfully
    
    15
    -- [ ] Connects to the Tor network
    
    16
    -- [ ] Localisation (Browser chrome)
    
    17
    -  - [ ] Check especially the recently added strings
    
    18
    -- [ ] Toolbars and menus work
    
    19
    -- [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html
    
    20
    -- [ ] Security level (Standard, Safer, Safest)
    
    21
    -    - **TODO**: test pages verifying correct behaviour
    
    22
    -
    
    23
    -## Proxy safety
    
    24
    -- [ ] Tor exit test: https://check.torproject.org
    
    25
    -- [ ] Circuit isolation
    
    26
    -    - Following websites should all report different IP addresses
    
    27
    -    - https://ifconfig.io
    
    28
    -    - https://myip.wtf
    
    29
    -    - https://wtfismyip.com
    
    30
    -- [ ] DNS leaks: https://dnsleaktest.com
    
    31
    -
    
    32
    -## Connectivity + Anti-Censorship
    
    33
    -- [ ] Bridges:
    
    34
    -    - Bootstrap
    
    35
    -    - Browse: https://check.torproject.org
    
    36
    -    - [ ] Default bridges:
    
    37
    -        - [ ] obfs4
    
    38
    -        - [ ] meek
    
    39
    -        - [ ] snowflake
    
    40
    -    - [ ] User provided bridges:
    
    41
    -        - [ ] obfs4 from https://bridges.torproject.org
    
    42
    -        - [ ] webtunnel from https://bridges.torproject.org
    
    43
    -        - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/conjure/-/blob/main/client/torrc?ref_type=heads#L6)
    
    44
    -
    
    45
    -## Web Browsing
    
    46
    -- [ ] HTTPS-Only: http://http.badssl.com
    
    47
    -- [ ] .onion:
    
    48
    -    - [ ] torproject.org onion: http://2gzyxa5ihm7nsggfxnu52rck2vv4rvmdlkiu3zzui5du4xyclen53wid.onion/
    
    49
    -    - [ ] Onion service errors
    
    50
    -        - [ ] invalid onion: http://invalid.onion
    
    51
    -        - [ ] onion offline: http://wfdn32ds656ycma5gvrh7duvdvxbg2ygzr3no3ijsya25qm6nnko4iqd.onion/
    
    52
    -        - [ ] onion baddssl: https://gitlab.torproject.org/tpo/applications/team/-/wikis/Development-Information/BadSSL-But-Onion
    
    53
    -        - **TODO** all the identity block states
    
    54
    -        - **TODO** client auth
    
    55
    -- [ ] **TODO**: .securedrop.tor.onion
    
    56
    -- [ ] **TODO**: onion-service alt-svc
    
    57
    -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page
    
    58
    -    - [ ] MPEG4
    
    59
    -    - [ ] WebM
    
    60
    -    - [ ] Ogg
    
    61
    -- [ ] WebSocket Test: https://websocketking.com/
    
    62
    -
    
    63
    -## External Components
    
    64
    -- [ ] NoScript
    
    65
    -  - [ ] Latest Version: https://addons.mozilla.org/en-US/firefox/addon/noscript/
    
    66
    -  - [ ] Not removable from about:addons
    
    67
    -  - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/
    
    68
    -    - **TODO**: fix test pages
    
    69
    -```
    
    70
    -
    
    71
    -</details>

  • .gitlab/issue_templates/QA - Desktop.md deleted
    1
    -Manual QA test check-list for major desktop releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist!
    
    2
    -
    
    3
    -<details>
    
    4
    -    <summary>Tor Browser Desktop QA Checklist</summary>
    
    5
    -
    
    6
    -```markdown
    
    7
    -# System Information
    
    8
    -
    
    9
    -- Version: Tor Browser XXX
    
    10
    -- OS: Windows|macOS|Linux YYY
    
    11
    -- CPU Architecture:
    
    12
    -- Profile: New|Old
    
    13
    -
    
    14
    -# Features
    
    15
    -
    
    16
    -## Base functionality
    
    17
    -- [ ] Tor Browser launches successfully
    
    18
    -- [ ] Connects to the Tor network
    
    19
    -    - [ ] Homepage loads:
    
    20
    -        - [ ] about:tor
    
    21
    -        - [ ] about:blank
    
    22
    -        - [ ] custom
    
    23
    -- [ ] Tor Browser loads URLs passed by command-line after bootstrapped
    
    24
    -- [ ] Localisation (Browser chrome)
    
    25
    -  - [ ] Language notification/message bar
    
    26
    -  - [ ] Spoof English
    
    27
    -  - [ ] Check especially the recently added strings
    
    28
    -- [ ] UI Customisations:
    
    29
    -    - [ ] New Identity
    
    30
    -        - [ ] Toolbar icon
    
    31
    -        - [ ] Hamburger menu
    
    32
    -        - [ ] File menu
    
    33
    -    - [ ] New circuit for this site
    
    34
    -        - [ ] Circuit display
    
    35
    -        - [ ] Hamburger menu
    
    36
    -        - [ ] File menu
    
    37
    -    - [ ] No Firefox extras (Sync, Pocket, Report broken site, Tracking protection, etc)
    
    38
    -    - [ ] No unified extensions button (puzzle piece)
    
    39
    -    - [ ] NoScript button hidden
    
    40
    -    - [ ] Context Menu Populated
    
    41
    -- [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html
    
    42
    -- [ ] Security level (Standard, Safer, Safest)
    
    43
    -    - Displays in:
    
    44
    -        - toolbar icon
    
    45
    -        - toolbar panel
    
    46
    -        - about:preferences#privacy
    
    47
    -    - [ ] On switch, each UI element is updated
    
    48
    -    - [ ] On custom config (toggle `svg.disabled`)
    
    49
    -        - [ ] each UI element displays warning
    
    50
    -        - [ ] `Restore defaults` reverts custom prefs
    
    51
    -    - **TODO**: test pages verifying correct behaviour
    
    52
    -- [ ] New identity
    
    53
    -- [ ] Betterboxing
    
    54
    -    - [ ] Reuse last window size
    
    55
    -    - [ ] Content alignment
    
    56
    -    - [ ] No letterboxing:
    
    57
    -        - [ ]empty tabs or privileged pages (eg: about:blank, about:about)
    
    58
    -        - [ ] full-screen video
    
    59
    -        - [ ] pdf viewer
    
    60
    -        - [ ] reader-mode
    
    61
    -- [ ] Downloads Warning
    
    62
    -    - [ ] Downloads toolbar panel
    
    63
    -    - [ ] about:downloads
    
    64
    -    - [ ] Library window (<kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>o</kbd>)
    
    65
    -- [ ] Drag and Drop protections:
    
    66
    -    - [ ] Dragging a link from a tab to another tab in the same window works
    
    67
    -    - [ ] Dragging a link from a tab to another tab in a separate window works
    
    68
    -    - [ ] Dragging a link into the library creates a bookmark
    
    69
    -    - [ ] Dragging a link from Tor Browser to Firefox doesn't work
    
    70
    -    - [ ] Dragging a link from Firefox to Tor Browser works
    
    71
    -    - [ ] Dragging a link from Tor Browser to another app (e.g., text editor) doesn't work
    
    72
    -    - [ ] Repeat with page favicon
    
    73
    -
    
    74
    -## Proxy safety
    
    75
    -- [ ] Tor exit test: https://check.torproject.org
    
    76
    -- [ ] Circuit isolation
    
    77
    -    - Following websites should all report different IP addresses
    
    78
    -    - https://ifconfig.io
    
    79
    -    - https://myip.wtf
    
    80
    -    - https://wtfismyip.com
    
    81
    -- [ ] DNS leaks: https://dnsleaktest.com
    
    82
    -- [ ] Circuit Display
    
    83
    -    - [ ] Website => circuit
    
    84
    -    - [ ] Remote PDF => circuit
    
    85
    -    - [ ] Remote image => circuit
    
    86
    -    - [ ] .onion Website => circuit with onion-service relays
    
    87
    -    - [ ] .tor.onion Website => circuit with onion-service relays, link to true onion address
    
    88
    -        - http://ft.securedrop.tor.onion
    
    89
    -    - [ ] Website in reader mode => circuit (same as w/o reader mode)
    
    90
    -    - [ ] Local image => no circuit
    
    91
    -    - [ ] Local SVG with remote content => catch-all circuit, but not shown
    
    92
    -    - [ ] Local PDF => no circuit
    
    93
    -    - [ ] Local HTML `file://` with local resources  => no circuit
    
    94
    -    - [ ] Local HTML `file://` with remote resources => catch-all circuit, but not shown
    
    95
    -
    
    96
    -## Connectivity + Anti-Censorship
    
    97
    -- [ ] Tor daemon config by environment variables
    
    98
    -    - https://gitlab.torproject.org/tpo/applications/team/-/wikis/Environment-variables-and-related-preferences
    
    99
    -- [ ] Internet Test ( about:preferences#connection )
    
    100
    -  - [ ] Fails when offline
    
    101
    -  - [ ] Succeeds when online
    
    102
    -- [ ] Bridges:
    
    103
    -    - Bootstrap
    
    104
    -    - Browse: https://check.torproject.org
    
    105
    -    - Bridge node in circuit-display
    
    106
    -    - Bridge cards
    
    107
    -    - Disable
    
    108
    -    - Remove
    
    109
    -    - [ ] Default bridges:
    
    110
    -        - [ ] Removable as a group, not editable
    
    111
    -        - [ ] obfs4
    
    112
    -        - [ ] meek
    
    113
    -        - [ ] snowflake
    
    114
    -    - [ ] User provided bridges:
    
    115
    -        - [ ] Removable and editable individually
    
    116
    -        - [ ] obfs4 from https://bridges.torproject.org
    
    117
    -        - [ ] webtunnel from https://bridges.torproject.org
    
    118
    -        - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/conjure/-/blob/main/client/torrc?ref_type=heads#L6)
    
    119
    -    - [ ] Request bridges...
    
    120
    -        - [ ] Removable as a group, but not editable
    
    121
    -        - [ ] Succeeds when bootstrapped
    
    122
    -        - [ ] Succeeds when not bootstrapped
    
    123
    -    - **TODO**: Lox
    
    124
    -- [ ] Connect Assist
    
    125
    -    - Useful pref: `torbrowser.debug.censorship_level`
    
    126
    -    - [ ] Auto-bootstrap updates Tor connection settings on success
    
    127
    -    - [ ] Auto-bootstrap restore previous Tor connection settings on failure
    
    128
    -
    
    129
    -## Web Browsing
    
    130
    -- [ ] HTTPS-Only: http://http.badssl.com
    
    131
    -- [ ] Crypto-currency warning on http website
    
    132
    -    - **TODO**: we should provide an example page
    
    133
    -- [ ] .onion:
    
    134
    -    - [ ] torproject.org onion: http://2gzyxa5ihm7nsggfxnu52rck2vv4rvmdlkiu3zzui5du4xyclen53wid.onion/
    
    135
    -    - [ ] Onion-Location pill
    
    136
    -    - [ ] Client authentication
    
    137
    -        - You can create an ephemeral client-auth onion-service using [onion share](https://onionshare.org)
    
    138
    -        - [ ] Remember key option saves the key between sessions.
    
    139
    -        - [ ] Saved keys are viewable in preferences (privacy).
    
    140
    -          - [ ] Can remove individual keys.
    
    141
    -          - [ ] Can remove all keys at once.
    
    142
    -    - [ ] Onion service errors
    
    143
    -        - [ ] invalid onion: http://invalid.onion
    
    144
    -        - [ ] onion offline: http://wfdn32ds656ycma5gvrh7duvdvxbg2ygzr3no3ijsya25qm6nnko4iqd.onion/
    
    145
    -        - [ ] onion baddssl: https://gitlab.torproject.org/tpo/applications/team/-/wikis/Development-Information/BadSSL-But-Onion
    
    146
    -        - **TODO** all the identity block states
    
    147
    -        - **TODO** client auth
    
    148
    -- [ ] **TODO**: .securedrop.tor.onion
    
    149
    -- [ ] **TODO**: onion-service alt-svc
    
    150
    -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page
    
    151
    -    - [ ] MPEG4
    
    152
    -    - [ ] WebM
    
    153
    -    - [ ] Ogg
    
    154
    -- [ ] WebSocket Test: https://websocketking.com/
    
    155
    -
    
    156
    -## External Components
    
    157
    -- [ ] NoScript
    
    158
    -  - [ ] Latest Version: https://addons.mozilla.org/en-US/firefox/addon/noscript/
    
    159
    -  - [ ] Not removable from about:addons
    
    160
    -  - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/
    
    161
    -    - **TODO**: fix test pages
    
    162
    -```
    
    163
    -
    
    164
    -</details>

  • .gitlab/issue_templates/Uplift.md deleted
    1
    -<!--
    
    2
    -Title:
    
    3
    -    Uplift tor-browser#12345: Title of Issue
    
    4
    -
    
    5
    -This is an issue for tracking uplift of a patch-set to Firefox
    
    6
    --->
    
    7
    -
    
    8
    -## Uplift Patchset
    
    9
    -
    
    10
    -### Book-keeping
    
    11
    -
    
    12
    -#### Gitlab Issue(s)
    
    13
    -- tor-browser#12345
    
    14
    -- mullvad-browser#123
    
    15
    -
    
    16
    -#### Merge Request(s)
    
    17
    -- tor-browser!123
    
    18
    -
    
    19
    -#### Upstream Mozilla Issue(s):
    
    20
    -- https://bugzilla.mozilla.org/show_bug.cgi?id=12345
    
    21
    -
    
    22
    -### Notes
    
    23
    -
    
    24
    -<!-- whatever additional info, context, etc that would be helpful for uplifting -->
    
    25
    -
    
    26
    -/label ~"Apps::Type::Uplift"

  • .gitlab/issue_templates/bug.md deleted
    1
    -<!--
    
    2
    -* Use this issue template for reporting a new bug.
    
    3
    --->
    
    4
    -
    
    5
    -### Summary
    
    6
    -**Summarize the bug encountered concisely.**
    
    7
    -
    
    8
    -
    
    9
    -### Steps to reproduce:
    
    10
    -**How one can reproduce the issue - this is very important.**
    
    11
    -
    
    12
    -1. Step 1
    
    13
    -2. Step 2
    
    14
    -3. ...
    
    15
    -
    
    16
    -### What is the current bug behavior?
    
    17
    -**What actually happens.**
    
    18
    -
    
    19
    -
    
    20
    -### What is the expected behavior?
    
    21
    -**What you want to see instead**
    
    22
    -
    
    23
    -
    
    24
    -
    
    25
    -### Environment
    
    26
    -**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.**
    
    27
    -**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.**
    
    28
    -
    
    29
    -### Relevant logs and/or screenshots
    
    30
    -
    
    31
    -
    
    32
    -/label ~"Apps::Type::Bug"

  • .gitlab/merge_request_templates/default.md.gitlab/merge_request_templates/Default.md
    ... ... @@ -64,6 +64,7 @@
    64 64
       - **accessibility** : henry
    
    65 65
       - **android** : clairehurst, dan
    
    66 66
       - **build system** : boklm
    
    67
    +  - **ci/cd**: brizental, henry
    
    67 68
       - **extensions** : ma1
    
    68 69
       - **firefox internals (XUL/JS/XPCOM)** : jwilde, ma1
    
    69 70
       - **fonts** : pierov
    
    ... ... @@ -72,7 +73,7 @@
    72 73
       - **localization** : henry, pierov
    
    73 74
       - **macOS** : clairehurst, dan
    
    74 75
       - **nightly builds** : boklm
    
    75
    -  - **rebases/release-prep** : dan, ma1, pierov, morgan
    
    76
    +  - **rebases/release-prep** : brizental, clairehurst, dan, ma1, pierov, morgan
    
    76 77
       - **security** : jwilde, ma1
    
    77 78
       - **signing** : boklm, morgan
    
    78 79
       - **updater** : pierov