morgan pushed to branch tor-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser

Commits:

22 changed files:

Changes:

  • .gitlab/issue_templates/000 Bug Report.md
    1 
    +# 🐞 Bug Report
    2 
    +<!--
    3 
    +Use this template to report problems with the browser which are unrelated to
    4 
    +website functionality (please use the Web Compatibility template for such issues).
    5 
    +The issue's title MUST provide a succinct description of the problem.
    6 
    +
    7 
    +Some good (hypothetical) titles:
    8 
    +- Browser crashes when visiting example.com in Safer mode
    9 
    +- Letterboxing appears even when disabled when using tiling window-manager
    10 
    +- All fonts in browser-chrome have serifs
    11 
    +
    12 
    +Please DO NOT include information about platform in the title, it is redundant
    13 
    +with our labeling system!
    14 
    +-->
    15 
    +
    16 
    +## Reproduction steps
    17 
    +<!--
    18 
    +Provide specific steps developers can follow to reproduce your issue.
    19 
    +-->
    20 
    +
    21 
    +## Expected behaviour
    22 
    +<!--
    23 
    +Provide a description of the browser feature or scenario which does not appear
    24 
    +to be working.
    25 
    +-->
    26 
    +
    27 
    +## Actual behaviour
    28 
    +<!--
    29 
    +Provide a description of what actually occurs.
    30 
    +-->
    31 
    +
    32 
    +## Bookkeeping
    33 
    +<!--
    34 
    +Please provide the following information:
    35 
    +-->
    36 
    +
    37 
    +- Browser version:
    38 
    +- Browser channel:
    39 
    +  - [ ] Release
    40 
    +  - [ ] Alpha
    41 
    +  - [ ] Nightly
    42 
    +- Distribution method:
    43 
    +  - [ ] Installer/archive from torproject.org
    44 
    +  - [ ] tor-browser-launcher
    45 
    +  - [ ] homebrew
    46 
    +  - [ ] other (please specify):
    47 
    +- Operating System:
    48 
    +  - [ ] Windows
    49 
    +  - [ ] macOS
    50 
    +  - [ ] Linux
    51 
    +  - [ ] Android
    52 
    +  - [ ] Tails
    53 
    +  - [ ] Other (please specify):
    54 
    +- Operating System Version:
    55 
    +
    56 
    +### Browser UI language
    57 
    +<!--
    58 
    +Found in `about:preferences#general`.
    59 
    +Feel free to omit this if you like, but sometimes bugs can be language specific so having
    60 
    +this info may make it easier for developers to reproduce your problem.
    61 
    +-->
    62 
    +
    63 
    +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones?
    64 
    +<!--
    65 
    +If you changed any preference in about:config that aren't exposed in a UI,
    66 
    +could you try to see if you can reproduce without them? Generally speaking, such
    67 
    +changes are unsupported and bugs might be closed as invalid.
    68 
    +-->
    69 
    +
    70 
    +### Do you have any extra extensions installed?
    71 
    +<!-- e.g. Firefox Multi-Account Containers, uBlock Origin, etc -->
    72 
    +
    73 
    +## Troubleshooting
    74 
    +<!--
    75 
    +This is optional, but it will help to resolve your problem.
    76 
    +-->
    77 
    +
    78 
    +### Does this bug occur in a fresh installation?
    79 
    +
    80 
    +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear?
    81 
    +<!--
    82 
    +Archived packages for past versions can be found here:
    83 
    +- https://archive.torproject.org/tor-package-archive
    84 
    +-->
    85 
    +
    86 
    +### Does this bug occur in the Alpha release channel?
    87 
    +<!--
    88 
    +Sometimes bugs are fixed in the Alpha (development) channel but not in the Stable channel.
    89 
    +⚠️ However, the Alpha release channel is the development version and as such may be contain
    90 
    +critical bugs not present in the Stable release channel. Do not test in Alpha if you are an
    91 
    +at risk user unless you really, actually, truly know what you are doing!
    92 
    +
    93 
    +The latest Alpha can be found here:
    94 
    +- https://www.torproject.org/download/alpha/
    95 
    +-->
    96 
    +
    97 
    +### Does this bug occur in Firefox ESR (Desktop only)?
    98 
    +<!--
    99 
    +Tor Browser is based on Firefox ESR, so any bugs present in this upstream project will likely
    100 
    +also be present in Tor Browser.
    101 
    +Firefox ESR is available for download here:
    102 
    +- https://www.mozilla.org/en-US/firefox/all/desktop-esr/
    103 
    +-->
    104 
    +
    105 
    +### Does this bug occur in Firefox Rapid Release?
    106 
    +<!--
    107 
    +If the issue occurs in Firefox ESR, but does not occur in Firefox Rapid Release, we may be able
    108 
    +to identify and backport the patch which fixes it.
    109 
    +
    110 
    +Firefox Rapid Release is available for download here:
    111 
    +- https://www.mozilla.org/en-US/firefox/new/
    112 
    +
    113 
    +If the issue has been fixed in Firefox, do you know the Bugzilla issue number associated with the fix?
    114 
    +-->
    115 
    +
    116 
    +<!-- Do not edit beneath this line <3 -->
    117 
    +
    118 
    +---
    119 
    +
    120 
    +/label ~"Apps::Product::TorBrowser"
    121 
    +/label ~"Apps::Type::Bug"

  • .gitlab/issue_templates/010 Proposal.md
    1 
    +# 💡 Proposal
    2 
    +<!--
    3 
    +Use this template to request a feature or propose some change in the browser.
    4 
    +The issue will likely be edited many times over its life to flesh out the various
    5 
    +questions, so if you don't know the answers to something, jut leave it blank!
    6 
    +
    7 
    +The issue's title MUST provide a succinct description of proposal.
    8 
    +
    9 
    +Some good (hypothetical) titles:
    10 
    +- Remove 'Safer' option from Security Level
    11 
    +- Bundle uBlock Origin by default
    12 
    +- Replace NoScript with faith-based JavaScript sand-boxing
    13 
    +-->
    14 
    +
    15 
    +## User Story
    16 
    +<!--
    17 
    +Provide a high-level summary of the proposed feature, the problem it solves, and
    18 
    +what it would allow users to do if implemented. -->
    19 
    +
    20 
    +## Security and Privacy Implications
    21 
    +<!--
    22 
    +How would this proposal interact with our the browser's threat model?
    23 
    +Would this feature negatively affect the browser's security or privacy
    24 
    +guarantees?
    25 
    +-->
    26 
    +
    27 
    +### Security
    28 
    +<!--
    29 
    +Outline any security implications this feature would introduce. The browser's
    30 
    +security requirements can be found in our threat model document here:
    31 
    +- https://gitlab.torproject.org/tpo/applications/wiki/-/wikis/Design-Documents/Tor-Browser-Design-Doc#21-security-requirements
    32 
    +-->
    33 
    +
    34 
    +### Privacy
    35 
    +<!--
    36 
    +Outline any privacy implications this feature would introduce. The browser's
    37 
    +privacy requirements can be found in our threat model document here:
    38 
    +- https://gitlab.torproject.org/tpo/applications/wiki/-/wikis/Design-Documents/Tor-Browser-Design-Doc#22-privacy-requirements
    39 
    +-->
    40 
    +
    41 
    +## Accessibility Implications
    42 
    +<!--
    43 
    +Would this proposal affect or interact with the browser's usability for users
    44 
    +with accessibility needs (e.g. vision or mobility issues). What problems would need
    45 
    +to be solved to ensure these users are not left behind?
    46 
    +-->
    47 
    +
    48 
    +## Other Trade-Offs
    49 
    +<!--
    50 
    +Beyond the security, privacy and accessibility implications, what other implications
    51 
    +are there for users?
    52 
    +-->
    53 
    +
    54 
    +## Prior Art
    55 
    +
    56 
    +### Does this feature exist in other browsers?
    57 
    +- [ ] Yes
    58 
    +    - [ ] Firefox
    59 
    +    - [ ] Firefox ESR
    60 
    +    - [ ] Other (please specify)
    61 
    +- [ ] No
    62 
    +
    63 
    +### Does this feature exist as an extension? If yes, which one provides this functionality?
    64 
    +
    65 
    +<!-- Do not edit beneath this line <3 -->
    66 
    +
    67 
    +---
    68 
    +
    69 
    +/label ~"Apps::Product::TorBrowser"
    70 
    +/label ~"Apps::Type::Proposal"

  • .gitlab/issue_templates/020 Web Compatibility.md
    1 
    +# 🌍 Web Compatibility
    2 
    +<!--
    3 
    +Use this template to report websites which do not work properly in the browser.
    4 
    +The issue's title MUST provide a succinct description of the problem.
    5 
    +
    6 
    +Some good (hypothetical) titles:
    7 
    +- Road signs do not render correctly on maps.foo.com
    8 
    +- Infinite CAPTCHA prompts on bar.nat
    9 
    +- Cannot login to baz.org
    10 
    +-->
    11 
    +
    12 
    +## URL
    13 
    +<!-- Provide a link to the website -->
    14 
    +
    15 
    +## Expected behaviour
    16 
    +<!--
    17 
    +Provide a description of the how the website is supposed to work
    18 
    +-->
    19 
    +
    20 
    +## Actual behaviour
    21 
    +<!--
    22 
    +Provide a description of what actually occurs
    23 
    +-->
    24 
    +
    25 
    +## Reproduction steps
    26 
    +<!--
    27 
    +Provide specific steps developers can follow to reproduce your issue
    28 
    +-->
    29 
    +
    30 
    +## Bookkeeping
    31 
    +<!--
    32 
    +Please provide the following information:
    33 
    +-->
    34 
    +
    35 
    +- Browser version:
    36 
    +- Browser channel:
    37 
    +  - [ ] Release
    38 
    +  - [ ] Alpha
    39 
    +  - [ ] Nightly
    40 
    +- Distribution method:
    41 
    +  - [ ] Installer/archive from torproject.org
    42 
    +  - [ ] tor-browser-launcher
    43 
    +  - [ ] homebrew
    44 
    +  - [ ] other (please specify):
    45 
    +- Operating System:
    46 
    +  - [ ] Windows
    47 
    +  - [ ] macOS
    48 
    +  - [ ] Linux
    49 
    +  - [ ] Android
    50 
    +  - [ ] Tails
    51 
    +  - [ ] Other (please specify):
    52 
    +- Operating System Version:
    53 
    +
    54 
    +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones?
    55 
    +<!--
    56 
    +If you changed any preference in about:config that aren't exposed in a UI,
    57 
    +could you try to see if you can reproduce without them? Generally speaking, such
    58 
    +changes are unsupported and bugs might be closed as invalid.
    59 
    +-->
    60 
    +
    61 
    +### Do you have any extra extensions installed?
    62 
    +<!-- e.g. Firefox Multi-Account Containers, uBlock Origin, etc -->
    63 
    +
    64 
    +## Troubleshooting
    65 
    +<!--
    66 
    +This is optional, but it will help to resolve your problem.
    67 
    +-->
    68 
    +
    69 
    +### Does this bug occur in a fresh installation?
    70 
    +
    71 
    +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear?
    72 
    +<!--
    73 
    +Archived packages for past versions can be found here:
    74 
    +- https://archive.torproject.org/tor-package-archive
    75 
    +-->
    76 
    +
    77 
    +### Does this bug occur in the Alpha release channel?
    78 
    +<!--
    79 
    +Sometimes bugs are fixed in the Alpha (development) channel but not in the Stable channel.
    80 
    +⚠️ However, the Alpha release channel is the development version and as such may be contain
    81 
    +critical bugs not present in the Stable release channel. Do not test in Alpha if you are an
    82 
    +at risk user unless you really, actually, truly know what you are doing!
    83 
    +
    84 
    +The latest Alpha can be found here:
    85 
    +- https://www.torproject.org/download/alpha/
    86 
    +-->
    87 
    +
    88 
    +### Does this bug occur in Firefox ESR (Desktop only)?
    89 
    +<!--
    90 
    +Tor Browser is based on Firefox ESR, so any bugs present in this upstream project will likely
    91 
    +also be present in Tor Browser.
    92 
    +Firefox ESR is available for download here:
    93 
    +- https://www.mozilla.org/en-US/firefox/all/desktop-esr/
    94 
    +-->
    95 
    +
    96 
    +### Does this bug occur in Firefox Rapid Release?
    97 
    +<!--
    98 
    +If the issue occurs in Firefox ESR, but does not occur in Firefox Rapid Release, we may be able
    99 
    +to identify and backport the patch which fixes it.
    100 
    +
    101 
    +Firefox Rapid Release is available for download here:
    102 
    +- https://www.mozilla.org/en-US/firefox/new/
    103 
    +
    104 
    +If the issue has been fixed in Firefox, do you know the Bugzilla issue number associated with the fix?
    105 
    +-->
    106 
    +
    107 
    +<!-- Do not edit beneath this line <3 -->
    108 
    +
    109 
    +---
    110 
    +
    111 
    +/label ~"Apps::Product::TorBrowser"
    112 
    +/label ~"Apps::Type::WebCompatibility"

  • .gitlab/issue_templates/030 Test.md
    1 
    +# 💣 Test
    2 
    +<!--
    3 
    +Use this template to track testing of some feature. Please
    4 
    +try to make the title a good one-liner for the changelogs!
    5 
    +
    6 
    +Some good (hypothetical) titles:
    7 
    +- Add test exercising new circuit button
    8 
    +- Add tests for verifying built-in bridge connectivity
    9 
    +- Develop a mock Lox authority for automated testing
    10 
    +-->
    11 
    +
    12 
    +## Description
    13 
    +<!--
    14 
    +Provide an overview of the technical/implementation aspects of this
    15 
    +test work a developer would need to know
    16 
    +-->
    17 
    +
    18 
    +## Scenarios
    19 
    +<!--
    20 
    +Provide a list of high-level classes of desired test-cases
    21 
    +and the expected behaviour of each
    22 
    +-->
    23 
    +
    24 
    +<!-- Do not edit beneath this line <3 -->
    25 
    +
    26 
    +---
    27 
    +
    28 
    +/label ~"Apps::Product::TorBrowser"
    29 
    +/label ~"Apps::Type::Test"

  • .gitlab/issue_templates/040 Feature.md
    1 
    +# ✨ Feature
    2 
    +<!--
    3 
    +Use this template to track implementation of some feature. Please
    4 
    +try to make the title a good one-liner for the changelogs!
    5 
    +
    6 
    +Some good (hypothetical) titles:
    7 
    +- Bundle AwesomeFont Sans Font
    8 
    +- Implement new user on-boarding UX
    9 
    +- Publish Linux aarch64 alpha builds
    10 
    +-->
    11 
    +
    12 
    +## Description
    13 
    +<!--
    14 
    +Provide an overview of the technical/implementation aspects of this feature
    15 
    +-->
    16 
    +
    17 
    +## Bookkeeping
    18 
    +
    19 
    +### Proposal
    20 
    +<!-- Add links to associated proposal issues (or delete block) -->
    21 
    +- tor-browser#12345
    22 
    +
    23 
    +### Design
    24 
    +<!-- Add links to associated design issues (or delete block) -->
    25 
    +- tpo/UX/Design#123
    26 
    +
    27 
    +<!-- Do not edit beneath this line <3 -->
    28 
    +
    29 
    +---
    30 
    +
    31 
    +/label ~"Apps::Product::TorBrowser"
    32 
    +/label ~"Apps::Type::Feature"

  • .gitlab/issue_templates/Backport.md → .gitlab/issue_templates/050 Backport.md
    1 
    +# ⬅️ Backport Patchset
    1 2 
     <!--
    2 
    -Title:
    3 
    -    Backport tor-browser#12345: Title of Issue
    4 
    -    Backport Bugzilla 1234567: Title of Issue
    3 
    +This is an issue for tracking back-porting a patch-set (e.g. from Alpha to Stable or from
    4 
    +Mozilla Rapid-Release to Alpha).
    5 5
    6 
    -This is an issue for tracking back-porting a patch-set (e.g. from Alpha to Stable or from Mozilla Rapid-Release to Alpha)
    7 
    --->
    6 
    +please ensure the title has the following format:
    7 
    +
    8 
    +- Backport tor-browser#12345: Title of original issue
    9 
    +- Backport Bugzilla 1234567: Title of original issue
    8 10
    9 
    -## Backport Patchset
    11 
    +-->
    10 12
    11 
    -### Book-keeping
    13 
    +## Bookkeeping
    12 14
    13 
    -#### Issue(s)
    15 
    +### Issue(s)
    14 16 
     - tor-browser#12345
    15 17 
     - mullvad-browser#123
    16 18 
     - https://bugzilla.mozilla.org/show_bug.cgi?id=1234567
    17 19
    18 
    -#### Merge Request(s)
    20 
    +### Merge Request(s)
    19 21 
     - tor-browser!123
    20 22
    21 
    -#### Target Channels
    23 
    +### Target Channels
    22 24
    23 25 
     - [ ] Alpha
    24 26 
     - [ ] Stable
    25 27 
     - [ ] Legacy
    26 28
    27 
    -### Notes
    29 
    +## Notes
    28 30
    29 31 
     <!-- whatever additional info, context, etc that would be helpful for backporting -->
    30 32
    33 
    +
    34 
    +<!-- Do not edit beneath this line <3 -->
    35 
    +
    36 
    +---
    37 
    +
    38 
    +/label ~"Apps::Product::TorBrowser"
    31 39 
     /label ~"Apps::Type::Backport"

  • .gitlab/issue_templates/Rebase Browser - Alpha.md → .gitlab/issue_templates/060 Rebase - Alpha.md
    1 
    +# ⤵️ Rebase Alpha
    2 
    +
    1 3 
     **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr
    2 4
    3 5 
     <details>
    ... ... @@ -152,4 +154,10 @@
    152 154 
         - [ ] Update `firefox_platform_version`
    153 155 
         - [ ] Set `browser_build` to 1 (to prevent failures in alpha testbuilds)
    154 156
    157 
    +<!-- Do not edit beneath this line <3 -->
    158 
    +
    159 
    +---
    160 
    +
    161 
    +/label ~"Apps::Product::TorBrowser"
    155 162 
     /label ~"Apps::Type::Rebase"
    163 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Rebase Browser - Stable.md → .gitlab/issue_templates/061 Rebase - Stable.md
    1 
    +# ⤵️ Rebase Stable
    2 
    +
    1 3 
     **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr
    2 4
    3 5 
     <details>
    ... ... @@ -114,4 +116,10 @@
    114 116 
         ```
    115 117 
       - [ ] Push tag to `upstream`
    116 118
    119 
    +<!-- Do not edit beneath this line <3 -->
    120 
    +
    121 
    +---
    122 
    +
    123 
    +/label ~"Apps::Product::TorBrowser"
    117 124 
     /label ~"Apps::Type::Rebase"
    125 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Rebase Browser - Legacy.md → .gitlab/issue_templates/062 Rebase - Legacy.md
    1 
    +# ⤵️ Rebase Legacy
    2 
    +
    1 3 
     **NOTE:** All examples in this template reference the rebase from 115.17.0esr to 115.18.0esr
    2 4
    3 5 
     <details>
    ... ... @@ -110,4 +112,10 @@
    110 112 
         ```
    111 113 
       - [ ] Push tag to `upstream`
    112 114
    115 
    +<!-- Do not edit beneath this line <3 -->
    116 
    +
    117 
    +---
    118 
    +
    119 
    +/label ~"Apps::Product::TorBrowser"
    113 120 
     /label ~"Apps::Type::Rebase"
    121 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Rebase Browser - Rapid.md → .gitlab/issue_templates/063 Rebase - Rapid.md
    1 
    +# ⤵️ Rebase Rapid
    2 
    +
    1 3 
     - **NOTE**: All examples in this template reference the rebase from Firefox 129.0a1 to 130.0a1
    2 4 
     - **TODO**:
    3 5 
       - Documentation step for any difficulties or noteworthy things for each rapid rebase
    ... ... @@ -289,4 +291,10 @@ gitGraph:
    289 291 
         ```
    290 292 
       - [ ] Push tag to `upstream`
    291 293
    294 
    +<!-- Do not edit beneath this line <3 -->
    295 
    +
    296 
    +---
    297 
    +
    298 
    +/label ~"Apps::Product::TorBrowser"
    292 299 
     /label ~"Apps::Type::Rebase"
    300 
    +/label ~"Apps::Priority::High"

  • .gitlab/issue_templates/Uplift.md → .gitlab/issue_templates/070 Uplift.md
    1 
    +# ⬆️ **Uplift**
    1 2 
     <!--
    2 3 
     Title:
    3 4 
         Uplift tor-browser#12345: Title of Issue
    ... ... @@ -5,22 +6,25 @@ Title:
    5 6 
     This is an issue for tracking uplift of a patch-set to Firefox
    6 7 
     -->
    7 8
    8 
    -## Uplift Patchset
    9 
    +## Book-keeping
    9 10
    10 
    -### Book-keeping
    11 
    -
    12 
    -#### Gitlab Issue(s)
    11 
    +### Gitlab Issue(s)
    13 12 
     - tor-browser#12345
    14 13 
     - mullvad-browser#123
    15 14
    16 
    -#### Merge Request(s)
    15 
    +### Merge Request(s)
    17 16 
     - tor-browser!123
    18 17
    19 
    -#### Upstream Mozilla Issue(s):
    18 
    +### Upstream Mozilla Issue(s):
    20 19 
     - https://bugzilla.mozilla.org/show_bug.cgi?id=12345
    21 20
    22 
    -### Notes
    21 
    +## Notes
    22 
    +<!--
    23 
    +Whatever additional info, context, etc that would be helpful for uplifting -->
    24 
    +
    25 
    +<!-- Do not edit beneath this line <3 -->
    23 26
    24 
    -<!-- whatever additional info, context, etc that would be helpful for uplifting -->
    27 
    +---
    25 28
    29 
    +/label ~"Apps::Product::TorBrowser"
    26 30 
     /label ~"Apps::Type::Uplift"

  • .gitlab/issue_templates/Backport Android Security Fixes.md → .gitlab/issue_templates/080 Security Backports.md
    1 
    +# 🛡️ **Security Backports**
    2 
    +
    1 3 
     <details>
    2 4 
       <summary>Explanation of Variables</summary>
    3 5
    ... ... @@ -16,20 +18,14 @@
    16 18
    17 19 
     **NOTE:** It is assumed the `tor-browser` rebases (stable and alpha) have already happened and there exists a `build1` build tags for both `base-browser` and `tor-browser` (stable and alpha)
    18 20
    19 
    -### **Bookkeeping**
    21 
    +## **Bookkeeping**
    20 22
    21 
    -- [ ] Link this issue to the appropriate [Release Prep](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Apps%3A%3AType%3A%3AReleasePreparation) issues (stable and alpha).
    23 
    +- [ ] Link this issue to the appropriate [Release Prep](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Apps%3A%3AType%3A%3AReleasePreparation) issues (alpha, stable, and legacy).
    22 24
    23 
    -### **Security Vulnerabilities Report**: https://www.mozilla.org/en-US/security/advisories/
    25 
    +## **Security Vulnerabilities Report**: https://www.mozilla.org/en-US/security/advisories/
    24 26
    25 27 
     - Potentially Affected Components:
    26 28 
       - `firefox`/`geckoview`: https://github.com/mozilla/gecko-dev
    27 
    -  - `application-services`: https://github.com/mozilla/application-services
    28 
    -  - `android-components` (ESR 102 only): https://github.com/mozilla-mobile/firefox-android
    29 
    -  - `fenix` (ESR 102 only): https://github.com/mozilla-mobile/firefox-android
    30 
    -  - `firefox-android`: https://github.com/mozilla-mobile/firefox-android
    31 
    -
    32 
    -**NOTE:** `android-components` and `fenix` used to have their own repos, but since November 2022 they have converged to a single `firefox-android` repo. Any backports will require manually porting patches over to our legacy repos until we have transitioned to ESR 115.
    33 29
    34 30 
     - [ ] Go through the `Security Vulnerabilities fixed in Firefox $(RR_VERSION)` report and create a candidate list of CVEs which potentially need to be backported in this issue:
    35 31 
       - CVEs which are explicitly labeled as 'Android' only
    ... ... @@ -43,100 +39,49 @@
    43 39 
         - To find the `gecko-dev` version of a `mozilla-central`, search for a unique string in the relevant `mozilla-central` commit message in the `gecko-dev/release` branch log.
    44 40 
         - **NOTE:** This process is unfortunately somewhat poorly defined/ad-hoc given the general variation in how Bugzilla issues are labeled and resolved. In general this is going to involve a bit of hunting to identify needed commits or determining whether or not the fix is relevant.
    45 41
    46 
    -### CVEs
    42 
    +## CVEs
    47 43
    48 44 
     <!-- CVE Resolution Template, foreach CVE to investigate add an entry in the form:
    49 45 
     - [ ] https://www.mozilla.org/en-US/security/advisories/mfsaYYYY-NN/#CVE-YYYY-XXXXX // CVE description
    50 46 
       - https://bugzilla.mozilla.org/show_bug.cgi?id=NNNNNN // Bugzilla issue
    51 47 
       - **Note**: Any relevant info about this fix, justification for why it is not necessary, etc
    52 48 
       - **Patches**
    53 
    -    - firefox-android: https://link.to/relevant/patch
    54 49 
         - firefox: https://link.to/relevant/patch
    55 50 
      -->
    56 51
    57 
    -### **tor-browser**: https://gitlab.torproject.org/tpo/applications/tor-browser.git
    52 
    +## **tor-browser**: https://gitlab.torproject.org/tpo/applications/tor-browser.git
    58 53 
     - [ ] Backport any Android-specific security fixes from Firefox rapid-release
    59 54 
       - [ ] Backport patches to `tor-browser` stable branch
    60 55 
       - [ ] Open MR
    61 56 
       - [ ] Merge
    62 
    -  - [ ] Rebase patches onto:
    57 
    +  - [ ] cherry-pick patches onto:
    63 58 
         - [ ] `base-browser` stable
    59 
    +    - [ ] `mullvad-browser` stable
    64 60 
         - [ ] `tor-browser` alpha
    65 61 
         - [ ] `base-browser` alpha
    62 
    +    - [ ] `mullvad-browser` alpha
    66 63 
       - [ ] Sign/Tag commits:
    67 
    -    - **Tag**: `$(PROJECT_NAME)-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)`
    68 
    -    - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)`
    64 
    +    - In **tor-browser-build.git**, run signing script:
    65 
    +      ```bash
    66 
    +      ./tools/browser/sign-tag.${PROJECT_NAME} ${CHANNEL} ${BUILD_N}
    67 
    +      ```
    69 68 
         - [ ] `base-browser` stable
    70 69 
         - [ ] `tor-browser` stable
    70 
    +    - [ ] `mullvad-browser` stable
    71 71 
         - [ ] `base-browser` alpha
    72 72 
         - [ ] `tor-browser` alpha
    73 
    -  - [ ] Push tags to `upstream`
    74 
    -- **OR**
    75 
    -- [ ] No backports
    73 
    +    - [ ] `mullvad-browser` alpha
    76 74
    77 
    -### **application-services**: https://gitlab.torproject.org/tpo/applications/application-services
    78 
    -- **NOTE**: we will need to setup a gitlab copy of this repo and update `tor-browser-build` before we can apply security backports here
    79 
    -- [ ] Backport any Android-specific security fixes from Firefox rapid-release
    80 
    -  - [ ] Backport patches to `application-services` stable branch
    81 
    -  - [ ] Open MR
    82 
    -  - [ ] Merge
    83 
    -  - [ ] Rebase patches onto `application-services` alpha
    84 
    -  - [ ] Sign/Tag commits:
    85 
    -    - **Tag**: `application-services-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)`
    86 
    -    - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha`
    87 
    -    - [ ] `application-services` stable
    88 
    -    - [ ] `application-services` alpha
    89 75 
       - [ ] Push tags to `upstream`
    90 76 
     - **OR**
    91 77 
     - [ ] No backports
    92 78
    79 
    +<!-- Do not edit beneath this line <3 -->
    93 80
    94 
    -### **android-components (Optional, ESR 102)**: https://gitlab.torproject.org/tpo/applications/android-components.git
    95 
    -- [ ] Backport any Android-specific security fixes from Firefox rapid-release
    96 
    -  - **NOTE**: Since November 2022, this repo has been merged with `fenix` into a singular `firefox-android` repo: https://github.com/mozilla-mobile/firefox-android. Any backport will require a patch rewrite to apply to our legacy `android-components` project.
    97 
    -  - [ ] Backport patches to `android-components` stable branch
    98 
    -  - [ ] Open MR
    99 
    -  - [ ] Merge
    100 
    -  - [ ] Rebase patches onto `android-components` alpha
    101 
    -  - [ ] Sign/Tag commits:
    102 
    -    - **Tag**: `android-components-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)`
    103 
    -    - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)`
    104 
    -    - [ ] `android-components` stable
    105 
    -    - [ ] `android-components` alpha
    106 
    -  - [ ] Push tags to `upstream`
    107 
    -- **OR**
    108 
    -- [ ] No backports
    109 
    -
    110 
    -
    111 
    -### **fenix (Optional, ESR 102)**: https://gitlab.torproject.org/tpo/applications/fenix.git
    112 
    -- [ ] Backport any Android-specific security fixes from Firefox rapid-release
    113 
    -  - **NOTE**: Since February 2023, this repo has been merged with `android-components` into a singular `firefox-android` repo: https://github.com/mozilla-mobile/firefox-android. Any backport will require a patch rewrite to apply to our legacy `fenix` project.
    114 
    -  - [ ] Backport patches to `fenix` stable branch
    115 
    -  - [ ] Open MR
    116 
    -  - [ ] Merge
    117 
    -  - [ ] Rebase patches onto `fenix` alpha
    118 
    -  - [ ] Sign/Tag commits:
    119 
    -    - **Tag**: `tor-browser-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)`
    120 
    -    - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)`
    121 
    -    - [ ] `fenix` stable
    122 
    -    - [ ] `fenix` alpha
    123 
    -  - [ ] Push tags to `upstream`
    124 
    -- **OR**
    125 
    -- [ ] No backports
    126 
    -
    127 
    -### **firefox-android**: https://gitlab.torproject.org/tpo/applications/firefox-android
    128 
    -- [ ] Backport any Android-specific security fixes from Firefox rapid-release
    129 
    -  - [ ] Backport patches to `firefox-android` stable branch
    130 
    -  - [ ] Open MR
    131 
    -  - [ ] Merge
    132 
    -  - [ ] Rebase patches onto `fenix` alpha
    133 
    -  - [ ] Sign/Tag commits:
    134 
    -    - **Tag**: `firefox-android-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)`
    135 
    -    - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)`
    136 
    -    - [ ] `firefox-android` stable
    137 
    -    - [ ] `firefox-android` alpha
    138 
    -  - [ ] Push tags to `upstream`
    139 
    -- **OR**
    140 
    -- [ ] No backports
    81 
    +---
    141 82
    142 83 
     /confidential
    84 
    +/label ~"Apps::Product::TorBrowser"
    85 
    +/label ~"Apps::Product::MullvadBrowser"
    86 
    +/label ~"Apps::Type::Backport"
    87 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Emergency Security Issue.md → .gitlab/issue_templates/090 Emergency Security Issue.md
    1 
    +# 🚨 Emergency Security Issue
    2 
    +
    1 3 
     **NOTE** This is an issue template to standardise our process for responding to and fixing critical security and privacy vulnerabilities, exploits, etc.
    2 4
    3 5 
     ## Information
    ... ... @@ -31,9 +33,10 @@
    31 33 
       - [ ] **clairehurst** : Android, macOS
    32 34 
       - [ ] **dan** : Android, macOS
    33 35 
       - [ ] **henry** : accessibility, frontend, localisation
    36 
    +  - [ ] **jwilde** : windows, firefox internals
    34 37 
       - [ ] **ma1** : firefox internals
    35 38 
       - [ ] **pierov** : updater, fonts, localisation, general
    36 
    -  - [ ] **richard** : signing, release
    39 
    +  - [ ] **morgan** : signing, release
    37 40 
       - [ ] **thorin** : fingerprinting
    38 41 
     - [ ] Other Engineering Teams
    39 42 
       - [ ] Networking (**ahf**, **dgoulet**)
    ... ... @@ -80,11 +83,20 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad
    80 83 
       - [ ] **(Optional)** **gazebook**
    81 84 
         - if there are consequences to the organisation or partners beyond a browser update, then a communication plan may be needed
    82 85
    86 
    +Godspeed! :pray:
    87 
    +
    88 
    +<!-- Do not edit beneath this line <3 -->
    89 
    +
    90 
    +---
    91 
    +
    83 92 
     /cc @bella
    84 93 
     /cc @ma1
    85 94 
     /cc @micah
    86 
    -/cc @richard
    95 
    +/cc @morgan
    87 96
    88 97 
     /confidential
    89 98
    90 
    -Godspeed! :pray:
    99 
    +/label ~"Apps::Product::TorBrowser"
    100 
    +/label ~"Apps::Product::MullvadBrowser"
    101 
    +/label ~"Apps::Type::Bug"
    102 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/QA - Desktop.md → .gitlab/issue_templates/100 Release QA - Desktop.md
    1 
    +# ✅ Release QA - Desktop
    2 
    +
    1 3 
     Manual QA test check-list for major desktop releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist!
    2 4
    3 5 
     <details>
    4 6 
         <summary>Tor Browser Desktop QA Checklist</summary>
    5 7
    6 
    -```markdown
    8 
    +```
    7 9 
     # System Information
    8 10
    9 11 
     - Version: Tor Browser XXX
    ... ... @@ -25,6 +27,8 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int
    25 27 
       - [ ] Language notification/message bar
    26 28 
       - [ ] Spoof English
    27 29 
       - [ ] Check especially the recently added strings
    30 
    +  - [ ] New Locales
    31 
    +    - [ ] Bulgarian, Belarusian, Portuguese (PT)
    28 32 
     - [ ] UI Customisations:
    29 33 
         - [ ] New Identity
    30 34 
             - [ ] Toolbar icon
    ... ... @@ -53,8 +57,9 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int
    53 57 
     - [ ] Betterboxing
    54 58 
         - [ ] Reuse last window size
    55 59 
         - [ ] Content alignment
    60 
    +    - [ ] Window size indicator on window resize
    56 61 
         - [ ] No letterboxing:
    57 
    -        - [ ]empty tabs or privileged pages (eg: about:blank, about:about)
    62 
    +        - [ ] empty tabs or privileged pages (eg: about:blank, about:about)
    58 63 
             - [ ] full-screen video
    59 64 
             - [ ] pdf viewer
    60 65 
             - [ ] reader-mode
    ... ... @@ -96,8 +101,9 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int
    96 101 
     ## Connectivity + Anti-Censorship
    97 102 
     - [ ] Tor daemon config by environment variables
    98 103 
         - https://gitlab.torproject.org/tpo/applications/team/-/wikis/Environment-variables-and-related-preferences
    99 
    -- [ ] Internet Test ( about:preferences#connection )
    100 
    -  - [ ] Fails when offline
    104 
    +- [ ] Internet Test ( bootstrap, also visible in about:preferences#connection )
    105 
    +  - [ ] Fails when offline (Goes to offline about:neterror)
    106 
    +    - **NOTE**: platform dependent, expected that Linux will just try to bootstrap forever
    101 107 
       - [ ] Succeeds when online
    102 108 
     - [ ] Bridges:
    103 109 
         - Bootstrap
    ... ... @@ -122,7 +128,8 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int
    122 128 
             - [ ] Succeeds when not bootstrapped
    123 129 
         - **TODO**: Lox
    124 130 
     - [ ] Connect Assist
    125 
    -    - Useful pref: `torbrowser.debug.censorship_level`
    131 
    +    - Useful pref: `torbrowser.debug.censorship_level` (0-5; least to most censored)
    132 
    +    - [ ] Connect Automatically checkbox triggers bootstrapping after one successful bootstrap attempt
    126 133 
         - [ ] Auto-bootstrap updates Tor connection settings on success
    127 134 
         - [ ] Auto-bootstrap restore previous Tor connection settings on failure
    128 135
    ... ... @@ -147,10 +154,14 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int
    147 154 
             - **TODO** client auth
    148 155 
     - [ ] **TODO**: .securedrop.tor.onion
    149 156 
     - [ ] **TODO**: onion-service alt-svc
    150 
    -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page
    151 
    -    - [ ] MPEG4
    152 
    -    - [ ] WebM
    153 
    -    - [ ] Ogg
    157 
    +- [ ] HTML5 Video: https://onion-tests.pierov.org/video.html
    158 
    +    - [ ] H264
    159 
    +    - [ ] VP9
    160 
    +    - [ ] VP8
    161 
    +    - [ ] AV1
    162 
    +    - [ ] Theora
    163 
    +    - [ ] MPEG4 + mp3: only audio should work
    164 
    +    - [ ] HEVC + AAC: should not work
    154 165 
     - [ ] WebSocket Test: https://websocketking.com/
    155 166
    156 167 
     ## External Components
    ... ... @@ -159,6 +170,43 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int
    159 170 
       - [ ] Not removable from about:addons
    160 171 
       - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/
    161 172 
         - **TODO**: fix test pages
    173 
    +
    174 
    +## Tor Settings (about:preferences#connection)
    175 
    +- [ ] Proxy
    176 
    +  - [ ] Bad Proxy Address Reports Error; e.g. any bad bad proxy address/port/etc
    177 
    +   - [ ] On initial failure gives error modal
    178 
    +   - [ ] On browser restart, will also give an error if provided a bad setting
    179 
    +  - [ ] Good Proxy Works
    180 
    +    - [ ] SOCKS5
    181 
    +- [ ] Bridge
    182 
    +  - [ ] Bad Bridge Fails with error modal; eg: `0:0`
    183 
    +  - [ ] Modifying Bridges *during* bootstrap should cancel bootstrap
    184 
    +- [ ] Firewall
    185 
    +  - [ ] UI shouldn't accept bad ports (e.g. invalid port numbers, non-numbers, etc)
    186 
    +- [ ] Each individual setting type has it's own validation (i.e. not all or nothing anymore)
    187 
    +
    162 188 
     ```
    163 189
    164 190 
     </details>
    191 
    +
    192 
    +Please lay claim to a platform in the comments:
    193 
    +
    194 
    +- Windows
    195 
    +  - Windows 10, Windows 11
    196 
    +  - x86
    197 
    +  - x86_64
    198 
    +- macOS
    199 
    +  - 10.15, 15.x
    200 
    +  - x86_64
    201 
    +  - aarch64
    202 
    +- Linux
    203 
    +  - x86
    204 
    +  - x86_64
    205 
    +
    206 
    +<!-- Do not edit beneath this line <3 -->
    207 
    +
    208 
    +---
    209 
    +
    210 
    +/label ~"Apps::Product::TorBrowser"
    211 
    +/label ~"Apps::Type::Test"
    212 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/QA - Android.md → .gitlab/issue_templates/101 Release QA - Android.md
    1 
    +# ✅ Release QA - Android
    2 
    +
    1 3 
     Manual QA test check-list for major android releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist!
    4 
    +
    2 5 
     <details>
    3 6 
         <summary>Tor Browser Android QA Checklist</summary>
    4 
    -```markdown
    7 
    +
    8 
    +```
    5 9 
     # System Information
    6 10
    7 11 
     - Version: Tor Browser XXX
    ... ... @@ -19,6 +23,11 @@ Manual QA test check-list for major android releases. Please copy/paste form int
    19 23 
     - [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html
    20 24 
     - [ ] Security level (Standard, Safer, Safest)
    21 25 
         - **TODO**: test pages verifying correct behaviour
    26 
    +- [ ] Bookmarks: for now ensure adding/removing/etc work as expected and doesn't busy-spin
    27 
    +
    28 
    +### Localisation
    29 
    +- [ ] New Locales
    30 
    +  - [ ] Bulgarian, Belarusian, Portuguese (PT)
    22 31
    23 32 
     ## Proxy safety
    24 33 
     - [ ] Tor exit test: https://check.torproject.org
    ... ... @@ -30,6 +39,8 @@ Manual QA test check-list for major android releases. Please copy/paste form int
    30 39 
     - [ ] DNS leaks: https://dnsleaktest.com
    31 40
    32 41 
     ## Connectivity + Anti-Censorship
    42 
    +- [ ] Internet Test (try connect assist while actually offline)
    43 
    +  - [ ] We expect this to fail but we should see what it actually does
    33 44 
     - [ ] Bridges:
    34 45 
         - Bootstrap
    35 46 
         - Browse: https://check.torproject.org
    ... ... @@ -41,6 +52,11 @@ Manual QA test check-list for major android releases. Please copy/paste form int
    41 52 
             - [ ] obfs4 from https://bridges.torproject.org
    42 53 
             - [ ] webtunnel from https://bridges.torproject.org
    43 54 
             - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/conjure/-/blob/main/client/torrc?ref_type=heads#L6)
    55 
    +- [ ] Connect Assist
    56 
    +    - Useful pref: `torbrowser.debug.censorship_level` (0-5; least to most censored)
    57 
    +    - [ ] Connect Automatically checkbox triggers bootstrapping after one successful bootstrap attempt
    58 
    +    - [ ] Auto-bootstrap updates Tor connection settings on success
    59 
    +    - [ ] Auto-bootstrap restore previous Tor connection settings on failure
    44 60
    45 61 
     ## Web Browsing
    46 62 
     - [ ] HTTPS-Only: http://http.badssl.com
    ... ... @@ -54,10 +70,14 @@ Manual QA test check-list for major android releases. Please copy/paste form int
    54 70 
             - **TODO** client auth
    55 71 
     - [ ] **TODO**: .securedrop.tor.onion
    56 72 
     - [ ] **TODO**: onion-service alt-svc
    57 
    -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page
    58 
    -    - [ ] MPEG4
    59 
    -    - [ ] WebM
    60 
    -    - [ ] Ogg
    73 
    +- [ ] HTML5 Video: https://onion-tests.pierov.org/video.html
    74 
    +    - [ ] H264
    75 
    +    - [ ] VP9
    76 
    +    - [ ] VP8
    77 
    +    - [ ] AV1
    78 
    +    - [ ] Theora
    79 
    +    - [ ] MPEG4 + mp3: only audio should work
    80 
    +    - [ ] HEVC + AAC: should not work
    61 81 
     - [ ] WebSocket Test: https://websocketking.com/
    62 82
    63 83 
     ## External Components
    ... ... @@ -69,3 +89,19 @@ Manual QA test check-list for major android releases. Please copy/paste form int
    69 89 
     ```
    70 90
    71 91 
     </details>
    92 
    +
    93 
    +Please lay claim to an architecture in the comments:
    94 
    +
    95 
    +Architectures:
    96 
    +- x86
    97 
    +- x86_64
    98 
    +- arm32
    99 
    +- aarch64
    100 
    +
    101 
    +<!-- Do not edit beneath this line <3 -->
    102 
    +
    103 
    +---
    104 
    +
    105 
    +/label ~"Apps::Product::TorBrowser"
    106 
    +/label ~"Apps::Type::Test"
    107 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/110 Bugzilla Triage.md
    1 
    +# 📋 Bugzilla Triage
    2 
    +
    3 
    +**NOTE** This issue presumes the branches and tags for the next Firefox release have already been created in tor-browser.git
    4 
    +
    5 
    +- [ ] Generate Bugzilla triage CSV
    6 
    +  - Run (from `tor-browser-build` root):
    7 
    +  ```bash
    8 
    +    ./tools/browser/generate-bugzilla-triage-csv ${FIREFOX_VERSION} ${PREVIOUS_NIGHTLY_TAG} ${NEXT_NIGHLTY_TAG} ${TRIAGE_ISSUE_NUMBER} ${REVIEWERS} > out.csv
    9 
    +  ```
    10 
    +  - `${FIREFOX_VERSION}`: the major Firefox version of the nightly to review
    11 
    +    - **Example**: 129
    12 
    +  - `${PREVIOUS_NIGHTLY_TAG}`: the nightly 'end' tag of the previous major Firefox version
    13 
    +    - **Example**: `FIREFOX_NIGHTLY_128_END`
    14 
    +  - `${NEXT_NIGHLTY_TAG}`: the nightly 'end' tag of the next major Firefox version we are reviewing
    15 
    +    - **Example**: `FIREFOX_NIGHTLY_129_END`
    16 
    +  - `${TRIAGE_ISSUE_NUMBER}`: this `tor-browser` issue
    17 
    +    - **Example**: `43303`
    18 
    +  - `${REVIEWERS}`: `morgan` and two additional devs to triage this Firefox version
    19 
    +    - `boklm`
    20 
    +    - `brizental`
    21 
    +    - `clairehurst`
    22 
    +    - `dan`
    23 
    +    - `henry`
    24 
    +    - `jwilde`
    25 
    +    - `ma1`
    26 
    +    - `pierov`
    27 
    +  - **Example**:
    28 
    +    ```bash
    29 
    +    ./tools/browser/generate-bugzilla-triage-csv 129 FIREFOX_NIGHTLY_128_END FIREFOX_NIGHTLY_129_END 43303 morgan pierov henry > 129.csv
    30 
    +    ```
    31 
    +- [ ] Attach the generated CSV file to the triage isssue
    32 
    +- [ ] Import to Google Sheets ( https://sheets.google.com )
    33 
    +  - [ ] Create blank spreadsheet
    34 
    +  - [ ] **Title**: `Bugzilla Triage ${VERSION}`
    35 
    +  - [ ] Import CSV: File > Import > Upload
    36 
    +    - **Import location**: "Replace spreadsheet"
    37 
    +    - **Separator type**: "Comma"
    38 
    +    - **Convert text to numbers, dates, and fomulas**: "✅"
    39 
    +  - [ ] Convert 'Review' column's issue cells to check-boxes:
    40 
    +    - Select relevant cells (i.e.: `A2:A1554` for in the 129 triage)
    41 
    +    - Insert > Checkbox
    42 
    +  - [ ] Convert 'Triaged by' cells to check-boxes
    43 
    +  - [ ] Share Spreadsheet
    44 
    +    - 🔒 Share > General access
    45 
    +      - Change `Restricted` to `Anyone with the link`
    46 
    +    - Post link in an internal note on this issue
    47 
    +- [ ] Page requested reviewers to this issue
    48 
    +- [ ] Triage Completed by:
    49 
    +  - [ ] morgan
    50 
    +  - [ ] reviewer 1 <!-- replace with reviewer name :) -->
    51 
    +  - [ ] reviewer 2 <!-- replace with reviewer name :) -->
    52 
    +
    53 
    +/label ~"esr-140"
    54 
    +/label ~"Apps::Product::TorBrowser"
    55 
    +/label ~"Apps::Type::Audit"
    56 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Bugzilla Audit.md → .gitlab/issue_templates/120 Bugzilla Audit.md
    1 
    +# 🔍 Bugzilla Audit
    1 2 
     <!--
    2 3 
     Title:
    3 4 
         Review Mozilla <bugzilla-num>: <bugzilla-description>
    ... ... @@ -5,10 +6,16 @@ Title:
    5 6
    6 7 
     **Bugzilla**: https://bugzilla.mozilla.org/show_bug.cgi?id=
    7 8
    8 
    -<!-- briefly describe why this issue needs further review -->
    9 
    +## Description
    9 10
    11 
    +<!-- Briefly describe why this issue needs further review -->
    12 
    +
    13 
    +<!-- Do not edit beneath this line <3 -->
    14 
    +
    15 
    +---
    10 16
    11 17 
     <!-- Make sure the "esr-" label is the correct version: -->
    12 18 
     /label ~"esr-140"
    13 
    -
    14 
    -/label ~"Bugzilla Review" ~"Apps::Type::Audit"
    19 
    +/label ~"Apps::Product::TorBrowser"
    20 
    +/label ~"Apps::Type::Audit"
    21 
    +/label ~"Apps::Priority::Blocker"

  • .gitlab/issue_templates/Bugzilla Triage.md deleted
    1 
    -  # Bugzilla Triage
    2 
    -
    3 
    -  **NOTE** This issue presumes the branches and tags for the next Firefox release have already been created in tor-browser.git
    4 
    -
    5 
    -  - [ ] Generate Bugzilla triage CSV
    6 
    -    - Run (from `tor-browser-build` root):
    7 
    -    ```bash
    8 
    -      ./tools/browser/generate-bugzilla-triage-csv ${FIREFOX_VERSION} ${PREVIOUS_NIGHTLY_TAG} ${NEXT_NIGHLTY_TAG} ${TRIAGE_ISSUE_NUMBER} ${REVIEWERS} > out.csv
    9 
    -    ```
    10 
    -    - `${FIREFOX_VERSION}`: the major Firefox version of the nightly to review
    11 
    -      - **Example**: 129
    12 
    -    - `${PREVIOUS_NIGHTLY_TAG}`: the nightly 'end' tag of the previous major Firefox version
    13 
    -      - **Example**: `FIREFOX_NIGHTLY_128_END`
    14 
    -    - `${NEXT_NIGHLTY_TAG}`: the nightly 'end' tag of the next major Firefox version we are reviewing
    15 
    -      - **Example**: `FIREFOX_NIGHTLY_129_END`
    16 
    -    - `${TRIAGE_ISSUE_NUMBER}`: this `tor-browser` issue
    17 
    -      - **Example**: `43303`
    18 
    -    - `${REVIEWERS}`: `morgan` and two additional devs to triage this Firefox version
    19 
    -      - `boklm`
    20 
    -      - `brizental`
    21 
    -      - `clairehurst`
    22 
    -      - `dan`
    23 
    -      - `henry`
    24 
    -      - `jwilde`
    25 
    -      - `ma1`
    26 
    -      - `pierov`
    27 
    -    - **Example**:
    28 
    -      ```bash
    29 
    -      ./tools/browser/generate-bugzilla-triage-csv 129 FIREFOX_NIGHTLY_128_END FIREFOX_NIGHTLY_129_END 43303 morgan pierov henry > 129.csv
    30 
    -      ```
    31 
    -  - [ ] Attach the generated CSV file to the triage isssue
    32 
    -  - [ ] Import to Google Sheets ( https://sheets.google.com )
    33 
    -    - [ ] Create blank spreadsheet
    34 
    -    - [ ] **Title**: `Bugzilla Triage ${VERSION}`
    35 
    -    - [ ] Import CSV: File > Import > Upload
    36 
    -      - **Import location**: "Replace spreadsheet"
    37 
    -      - **Separator type**: "Comma"
    38 
    -      - **Convert text to numbers, dates, and fomulas**: "✅"
    39 
    -    - [ ] Convert 'Review' column's issue cells to check-boxes:
    40 
    -      - Select relevant cells (i.e.: `A2:A1554` for in the 129 triage)
    41 
    -      - Insert > Checkbox
    42 
    -    - [ ] Convert 'Triaged by' cells to check-boxes
    43 
    -    - [ ] Share Spreadsheet
    44 
    -      - 🔒 Share > General access
    45 
    -        - Change `Restricted` to `Anyone with the link`
    46 
    -      - Post link in an internal note on this issue
    47 
    -  - [ ] Page requested reviewers to this issue
    48 
    -  - [ ] Triage Completed by:
    49 
    -    - [ ] morgan
    50 
    -    - [ ] reviewer 1 <!-- replace with reviewer name :) -->
    51 
    -    - [ ] reviewer 2 <!-- replace with reviewer name :) -->

  • .gitlab/issue_templates/Default.md
    1 
    +# Open a new Issue
    2 
    +
    3 
    +Please select the appropriate issue template from the **Description** drop-down.
    4 
    +
    5 
    +---
    6 
    +
    7 
    +- 🐞 **Bug Report** - report a problem with the browser
    8 
    +- 💡 **Proposal** - suggest a new feature
    9 
    +- 🌐 **Web Compatibility** - report a broken website
    10 
    +
    11 
    +*NOTE*: the following issue types are intended for internal use
    12 
    +
    13 
    +- 💣 **Test** - develop a test or update testing infrastructure
    14 
    +- ✨ **Feature** - implement new features
    15 
    +- ⬅️ **Backport** - cherry-pick change to other release channels
    16 
    +- ⤵️ **Rebase - Alpha** - rebase alpha to latest Firefox ESR version
    17 
    +- ⤵️ **Rebase - Stable** - rebase stable to latest Firefox ESR version
    18 
    +- ⤵️ **Rebase - Legacy** - rebase legacy to latest Firefox ESR 115 version
    19 
    +- ⤵️ **Rebase - Rapid** - rebase rapid to latest Firefox Nightly version
    20 
    +- ⬆️ **Uplift** - uplift change to upstream project
    21 
    +- 🛡️ **Security Backports** - cherry-pick security fixes from Firefox
    22 
    +- 🚨 **Emergency Security Issue** - manage fixing and publishing a critical security fix
    23 
    +- ✅ **Release QA - Desktop** - test and verify functionality of our Desktop release
    24 
    +- ✅ **Release QA - Android** - test and verify functionality of our Android release
    25 
    +- 📋 **Bugzilla Triage** - identify upstream Firefox issues which need to be audited
    26 
    +- 🔍 **Bugzilla Audit** - determine if/how an upstream change affects the browser

  • .gitlab/issue_templates/bug.md deleted
    1 
    -<!--
    2 
    -* Use this issue template for reporting a new bug.
    3 
    --->
    4 
    -
    5 
    -### Summary
    6 
    -**Summarize the bug encountered concisely.**
    7 
    -
    8 
    -
    9 
    -### Steps to reproduce:
    10 
    -**How one can reproduce the issue - this is very important.**
    11 
    -
    12 
    -1. Step 1
    13 
    -2. Step 2
    14 
    -3. ...
    15 
    -
    16 
    -### What is the current bug behavior?
    17 
    -**What actually happens.**
    18 
    -
    19 
    -
    20 
    -### What is the expected behavior?
    21 
    -**What you want to see instead**
    22 
    -
    23 
    -
    24 
    -
    25 
    -### Environment
    26 
    -**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.**
    27 
    -**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.**
    28 
    -
    29 
    -### Relevant logs and/or screenshots
    30 
    -
    31 
    -
    32 
    -/label ~"Apps::Type::Bug"

  • .gitlab/merge_request_templates/default.md → .gitlab/merge_request_templates/Default.md
    ... ... @@ -66,6 +66,7 @@
    66 66 
       - **accessibility** : henry
    67 67 
       - **android** : clairehurst, dan
    68 68 
       - **build system** : boklm
    69 
    +  - **ci/cd**: brizental, henry
    69 70 
       - **extensions** : ma1
    70 71 
       - **firefox internals (XUL/JS/XPCOM)** : jwilde, ma1
    71 72 
       - **fonts** : pierov
    ... ... @@ -74,7 +75,7 @@
    74 75 
       - **localization** : henry, pierov
    75 76 
       - **macOS** : clairehurst, dan
    76 77 
       - **nightly builds** : boklm
    77 
    -  - **rebases/release-prep** : dan, ma1, pierov, morgan
    78 
    +  - **rebases/release-prep** : brizental, clairehurst, dan, ma1, pierov, morgan
    78 79 
       - **security** : jwilde, ma1
    79 80 
       - **signing** : boklm, morgan
    80 81 
       - **updater** : pierov

  • .gitlab/merge_request_templates/Rebase.md deleted
    1 
    -## Merge Info
    2 
    -
    3 
    -<!-- Bookkeeping information for release management -->
    4 
    -
    5 
    -### Rebase Issue
    6 
    -- tor-browser#xxxxx
    7 
    -- mullvad-browser#xxxxx
    8 
    -
    9 
    -### Release Prep Issue
    10 
    -- tor-browser-build#xxxxx
    11 
    -
    12 
    -### Issue Tracking
    13 
    -- [ ] Link rebase issue with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Apps%3A%3AType%3A%3AReleasePreparation&first_page_size=20) for changelog generation
    14 
    -
    15 
    -### Review
    16 
    -
    17 
    -#### Request Reviewer
    18 
    -
    19 
    -- [ ] Request review from a release engineer: boklm, dan, ma1, morgan, pierov
    20 
    -
    21 
    -#### Change Description
    22 
    -
    23 
    -<!-- Any interesting notes about the rebase and an overview of what the reviewer should expect from the diff of diffs and range-diff -->

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help