richard pushed to branch main at The Tor Project / Applications / tor-browser-spec

Commits:

1 changed file:

Changes:

  • audits/FF112_AUDIT
    1
    +# General
    
    2
    +
    
    3
    +The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
    
    4
    +
    
    5
    +The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
    
    6
    +
    
    7
    +`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
    
    8
    +
    
    9
    +## Firefox: https://github.com/mozilla/gecko-dev.git
    
    10
    +
    
    11
    +- Start: `431cede9cc9472bb648f5dfe24c54d0067c290e4` ( `FIREFOX_111_0_1_RELEASE` )
    
    12
    +- End:   `8307d3d3e4bfbca09aaa17e444f106e1e1d91b65`  ( `FIREFOX_112_0_2_RELEASE` )
    
    13
    +
    
    14
    +### Languages:
    
    15
    +- [x] java
    
    16
    +- [x] cpp
    
    17
    +- [x] js
    
    18
    +- [x] rust
    
    19
    +
    
    20
    +Nothing of interest (using `code_audit.sh`)
    
    21
    +
    
    22
    +---
    
    23
    +
    
    24
    +## Application Services: https://github.com/mozilla/application-services.git
    
    25
    +
    
    26
    +- Start: `9657aebb7450c5b58e8b9a88bec12bd5e9e0f700`  ( `v97.2.0` )
    
    27
    +- End:   `48916bbaf585f89fdff3404d181b260ed981a2d6`  ( `v97.5.0` )
    
    28
    +
    
    29
    +### Languages:
    
    30
    +- [x] java
    
    31
    +- [x] cpp
    
    32
    +- [x] js
    
    33
    +- [x] rust
    
    34
    +
    
    35
    +Nothing of interest (using `code_audit.sh`)
    
    36
    +
    
    37
    +## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
    
    38
    +
    
    39
    +- Start: `6b0f9fdb3f603974914de82185cd184065b2ebee`
    
    40
    +- End:   `32bb398127bacccb268a272091d2e62b8d72d6b9`
    
    41
    +
    
    42
    +### Languages:
    
    43
    +- [x] java
    
    44
    +- [x] cpp
    
    45
    +- [x] js
    
    46
    +- [x] rust
    
    47
    +
    
    48
    +#### Problematic Commits
    
    49
    +
    
    50
    +- Bug 1809305 - Allow user to copy an image to the clipboard (#948)
    
    51
    + `fce0a9aa4f2ac60254dde989ee115252116fe1d7`
    
    52
    +  - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42002
    
    53
    +  - **RESOLUTION** nothing to do here, no linkability concern
    
    54
    +- Bug 1819431 - Reimplement default browser notification with Nimbus Messaging equivalent (#1031) - `5989841d341f3ca867cdb2581dd06b6ce4d86156`
    
    55
    +  - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42003
    
    56
    +  - **RESOLUTION** nothing to do here, nimbus isn't initialised
    
    57
    +- Bug 1818015 - Use custom tab to show privacy notice during onboarding `8661a63a378da6c76fede176824e8c8655d9d560`
    
    58
    +  - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42004
    
    59
    +  - **RESOLUTION**
    
    60
    +- Bug 1816932 - Add Maps to app links common sub domains
    
    61
    + `84227af1a8d6df8fa28f1f0c44966bf376b94337`
    
    62
    +  - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42005
    
    63
    +  - **RESOLUTION** nothing to do here, does not affect us as we don't use firefox's builtin onboarding
    
    64
    +- Bug 1817726 - Add Recents url sharing - `c2586cba5091402723e4b4aaab7ac357a5e0b707`
    
    65
    +  - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42006
    
    66
    +  - **RESOLUTION** Disabled this feature in Tor Browser
    
    67
    +
    
    68
    +## Ticket Review ##
    
    69
    +
    
    70
    +Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=112%20Branch&order=priority%2Cbug_severity&limit=0`
    
    71
    +
    
    72
    +Nothing of interest (manual inspection)
    
    73
    +
    
    74
    +### Problematic Tickets
    
    75
    +
    
    76
    +- **Give user a choice on how open in app works** https://bugzilla.mozilla.org/show_bug.cgi?id=1818085
    
    77
    +
    
    78
    +## Export
    
    79
    +- [x] Export Report and save to `tor-browser-spec/audits`
    \ No newline at end of file