GitLab

at 2024-02-29T14:09:03+01:00

fixup! MB 38: Mullvad Browser configuration

s/privacy-browser/mullvad-browser/

fixup! MB 112: Updater customization for Mullvad Browser

s/privacy-browser/mullvad-browser/

MB 234: Disable OS spoofing in HTTP User-Agent.

This commits makes it possible to disable OS spoofing in the HTTP
User-Agent header, to see if matching header and JS property improve
usability.

 // a result.

 pref("browser.toolbars.bookmarks.visibility", "never");

-// privacy-browser#19: Enable Mullvad's DOH

+// mullvad-browser#19: Enable Mullvad's DOH

 pref("network.trr.uri", "https://dns.mullvad.net/dns-query");

 pref("network.trr.default_provider_uri", "https://dns.mullvad.net/dns-query");

 pref("network.trr.mode", 3);

 pref("doh-rollout.provider-list", "[{\"UIName\":\"Mullvad\",\"autoDefault\":true,\"canonicalName\":\"\",\"id\":\"mullvad\",\"last_modified\":0,\"schema\":0,\"uri\":\"https://dns.mullvad.net/dns-query\"},{\"UIName\":\"Mullvad (Ad-blocking)\",\"autoDefault\":false,\"canonicalName\":\"\",\"id\":\"mullvad\",\"last_modified\":0,\"schema\":0,\"uri\":\"https://adblock.dns.mullvad.net/dns-query\"}]");

-// privacy-browser#122: Audit DoH heuristics

+// mullvad-browser#122: Audit DoH heuristics

 pref("doh-rollout.disable-heuristics", true);

-// privacy-browser#37: Customization for the about dialog

+// mullvad-browser#37: Customization for the about dialog

 pref("app.releaseNotesURL.aboutDialog", "about:blank");

-// privacy-browser#94: Disable legacy global microphone/webcam indicator

+// mullvad-browser#94: Disable legacy global microphone/webcam indicator

 // Disable the legacy Firefox Quantum-styled global webcam/microphone indicator in favor of each

 // platform's native indicator

 pref("privacy.webrtc.legacyGlobalIndicator", false);

-// privacy-browser#87: Windows and Linux need additional work to make the

+// mullvad-browser#87: Windows and Linux need additional work to make the

 // default browser choice working.

 // We are shipping only the portable versions for the initial release anyway, so

 // we leave this popup enabled only on macOS.

 // mullvad-browser#228: default to spoof en-US and skip showing the dialog

 pref("privacy.spoof_english", 2);

-// privacy-browser#131: Review a few updater preferences

+// mullvad-browser#131: Review a few updater preferences

 pref("app.update.notifyDuringDownload", true);

 pref("app.update.url.manual", "https://mullvad.net/download/browser");

 pref("app.update.url.details", "https://mullvad.net/download/browser");

 pref("app.releaseNotesURL.aboutDialog", "about:blank");

 // point to our feedback url rather than Mozilla's

 pref("app.feedback.baseURL", "https://mullvad.net/help/tag/browser/");

+

+// mullvad-browser#234: Do not spoof the OS in the User-Agent header

+pref("privacy.resistFingerprinting.spoofOsInUserAgentHeader", false);
     // obsService->AddObserver(this, "net:failed-to-process-uri-content", true);

   }

+  Preferences::AddWeakObserver(

+      this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns);

+

   MakeNewRequestTokenBucket();

   mWifiTickler = new Tickler();

   if (NS_FAILED(mWifiTickler->Init())) mWifiTickler = nullptr;

     // Inform nsIOService that network is tearing down.

     gIOService->SetHttpHandlerAlreadyShutingDown();

+    Preferences::RemoveObserver(

+        this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns);

+

     ShutdownConnectionManager();

     // need to reset the session start time since cache validation may

     ShutdownConnectionManager();

     mConnMgr = nullptr;

     Unused << InitConnectionMgr();

+  } else if (!strcmp(topic, "nsPref:changed") &&

+             !NS_strcmp(

+                 data,

+                 u"privacy.resistFingerprinting.spoofOsInUserAgentHeader")) {

+    nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true);

   }

   return NS_OK;

   // https://developer.mozilla.org/en-US/docs/Web/API/NavigatorID/userAgent

   // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent

+  const bool spoofOs =

+      isForHTTPHeader &&

+      Preferences::GetBool(

+          "privacy.resistFingerprinting.spoofOsInUserAgentHeader", true);

+

   // These magic numbers are the lengths of the UA string literals below.

   // Assume three-digit Firefox version numbers so we have room to grow.

   size_t preallocatedLength =

       13 +

-      (isForHTTPHeader ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS)

-                       : mozilla::ArrayLength(SPOOFED_UA_OS)) -

+      (spoofOs ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS)

+               : mozilla::ArrayLength(SPOOFED_UA_OS)) -

       1 + 5 + 3 + 10 + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 +

       2;

   userAgent.SetCapacity(preallocatedLength);

   // "Mozilla/5.0 (%s; rv:%d.0) Gecko/%d Firefox/%d.0"

   userAgent.AssignLiteral("Mozilla/5.0 (");

-  if (isForHTTPHeader) {

+  if (spoofOs) {

     userAgent.AppendLiteral(SPOOFED_HTTP_UA_OS);

   } else {

     userAgent.AppendLiteral(SPOOFED_UA_OS);

Pier Angelo Vendrame pushed to branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser

Commits:

3 changed files:

Changes: