GitLab

at 2026-02-05T19:38:10+01:00

Bug 2013390: Test file extension before testing zip and tarfiles.r=ahal

The tarfile check specifically has been returning false positives on DMG
files.

Differential Revision: https://phabricator.services.mozilla.com/D281070

@@ -25,6 +25,7 @@ setup(
          "Programming Language :: Python :: 3.10",
          "Programming Language :: Python :: 3.11",
          "Programming Language :: Python :: 3.12",
 +        "Programming Language :: Python :: 3.13",
      ],
      # Get strings from http://pypi.python.org/pypi?%3Aaction=list_classifiers
      keywords="mozilla manifests",
@@ -39,5 +40,5 @@ setup(
        [console_scripts]
        manifestparser = manifestparser.cli:main
        """,
 -    python_requires=">=3.8, <3.13",
 +    python_requires=">=3.8",
+ )

@@ -121,12 +121,12 @@ def install(src, dest):
          if src.lower().endswith(".msix"):
              # MSIX packages _are_ ZIP files, so we need to look for them first.
              install_dir = _install_msix(src)
 -        elif zipfile.is_zipfile(src) or tarfile.is_tarfile(src):
 -            install_dir = mozfile.extract(src, dest)[0]
          elif src.lower().endswith(".dmg"):
              install_dir = _install_dmg(src, dest)
          elif src.lower().endswith(".exe"):
              install_dir = _install_exe(src, dest)
 +        elif zipfile.is_zipfile(src) or tarfile.is_tarfile(src):
 +            install_dir = mozfile.extract(src, dest)[0]
          else:
              raise InvalidSource(f"{src} is not a valid installer file")