|
1
|
+# General
|
|
2
|
+
|
|
3
|
+The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
|
|
4
|
+
|
|
5
|
+The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
|
|
6
|
+
|
|
7
|
+`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
|
|
8
|
+
|
|
9
|
+## Firefox: https://github.com/mozilla/gecko-dev.git
|
|
10
|
+
|
|
11
|
+- Start: `250178df19caa1fb25bfa0e35728426cfbde95f8` ( `FIREFOX_110_0_1_RELEASE` )
|
|
12
|
+- End: `431cede9cc9472bb648f5dfe24c54d0067c290e4` ( `FIREFOX_111_0_1_RELEASE` )
|
|
13
|
+
|
|
14
|
+### Languages:
|
|
15
|
+- [x] java
|
|
16
|
+- [x] cpp
|
|
17
|
+- [x] js
|
|
18
|
+- [x] rust
|
|
19
|
+
|
|
20
|
+Nothing of interest (using `code_audit.sh`)
|
|
21
|
+
|
|
22
|
+---
|
|
23
|
+
|
|
24
|
+## Application Services: https://github.com/mozilla/application-services.git
|
|
25
|
+
|
|
26
|
+- Start: `5755d9ce30ef10248eb55c4b39a522a118ce7d95` ( `v97.1.0` )
|
|
27
|
+- End: `9657aebb7450c5b58e8b9a88bec12bd5e9e0f700` ( `v97.2.0` )
|
|
28
|
+
|
|
29
|
+### Languages:
|
|
30
|
+- [x] java
|
|
31
|
+- [x] cpp
|
|
32
|
+- [x] js
|
|
33
|
+- [x] rust
|
|
34
|
+
|
|
35
|
+Nothing of interest (using `code_audit.sh`)
|
|
36
|
+
|
|
37
|
+## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
|
|
38
|
+
|
|
39
|
+- Start: `bc529747751ab545dba0a90a339f11382d742c97`
|
|
40
|
+- End: `6b0f9fdb3f603974914de82185cd184065b2ebee`
|
|
41
|
+
|
|
42
|
+### Languages:
|
|
43
|
+- [x] java
|
|
44
|
+- [x] cpp
|
|
45
|
+- [x] js
|
|
46
|
+- [x] rust
|
|
47
|
+
|
|
48
|
+#### Problematic Commits
|
|
49
|
+
|
|
50
|
+- Bug 1811531 - Add 'site' query parameter to Pocket sponsored stories request
|
|
51
|
+ `2dfe183ed96720b843f872fdf51fe206ed9a311c`
|
|
52
|
+ - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41990
|
|
53
|
+ - **RESOLUTION** pocket not available in PBM which we lock+enforce
|
|
54
|
+- Bug 1812518 - Allow a custom View for 3rd party downloads `174237dcbb6d8c631f5834ecbc7875d670bb6d8d`
|
|
55
|
+ - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41991
|
|
56
|
+ - **RESOLUTION** feature disabled
|
|
57
|
+
|
|
58
|
+## Fenix: https://github.com/mozilla-mobile/fenix.git
|
|
59
|
+
|
|
60
|
+- Start: `69e08e3ffbf4b9f5a2ffec99b238fa0c5da1d315`
|
|
61
|
+- End: `8571b648efc860bd2511183540b792e10c6cc0f4`
|
|
62
|
+
|
|
63
|
+### Languages:
|
|
64
|
+- [x] java
|
|
65
|
+- [x] cpp
|
|
66
|
+- [x] js
|
|
67
|
+- [x] rust
|
|
68
|
+
|
|
69
|
+#### Problematic Commits
|
|
70
|
+
|
|
71
|
+- Bug 1815623 - Add telemetry for sharing to an app from the share sheet
|
|
72
|
+ `4e5d9b323b465a73d24f8ee91a8b55df10545c36`
|
|
73
|
+
|
|
74
|
+## Ticket Review ##
|
|
75
|
+
|
|
76
|
+Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=111%20Branch&order=priority%2Cbug_severity&limit=0`
|
|
77
|
+
|
|
78
|
+#### Problematic Tickets
|
|
79
|
+
|
|
80
|
+- **Add API for saving a PDF** https://bugzilla.mozilla.org/show_bug.cgi?id=1810761
|
|
81
|
+ - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41993
|
|
82
|
+ - **RESOLUTION** just enabling download byte-per-byte and viewing of PDF in browser, no extra meta data or conversion happens
|
|
83
|
+
|
|
84
|
+## Export
|
|
85
|
+- [x] Export Report and save to `tor-browser-spec/audits` |
|
|
\ No newline at end of file |