GitLab

at 2025-07-17T14:06:34+01:00

fixup! BB 40926: Implemented the New Identity feature

TB 43638: Add the cmd_newIdentity command element and use it.

       <toolbarbutton id="appMenu-new-identity"

                      class="subviewbutton"

                      data-l10n-id="appmenuitem-new-identity"

-                     key="new-identity-key"/>

+                     key="new-identity-key"

+                     command="cmd_newIdentity"/>

       <toolbarseparator/>

       <toolbarbutton id="appMenu-bookmarks-button"

                      class="subviewbutton subviewbutton-nav"

     // Init the SecurityLevelButton

     SecurityLevelButton.init();

-    // Init the NewIdentityButton

-    NewIdentityButton.init();

-

     // Certain kinds of automigration rely on this notification to complete

     // their tasks BEFORE the browser window is shown. SessionStore uses it to

     // restore tabs into windows AFTER important parts like gMultiProcessBrowser

     SecurityLevelButton.uninit();

-    NewIdentityButton.uninit();

-

     if (gToolbarKeyNavEnabled) {

       ToolbarKeyboardNavigator.uninit();

     }

                           key="key_privatebrowsing" data-l10n-id="menu-file-new-private-window"/>

                 <menuseparator/>

                 <menuitem id="menu_newIdentity"

-                          key="new-identity-key" data-l10n-id="menu-new-identity"/>

+                          command="cmd_newIdentity"

+                          key="new-identity-key"

+                          data-l10n-id="menu-new-identity"/>

                 <menuseparator/>

                 <menuitem id="menu_openLocation"

                           hidden="true"

 #ifdef XP_MACOSX

     <command id="zoomWindow" data-l10n-id="window-zoom-command" />

 #endif

+

+    <command id="cmd_newIdentity" />

   </commandset>

 #include ../../components/places/content/placesCommands.inc.xhtml

                    command="cmd_newNavigator"

                    tooltip="dynamic-shortcut-tooltip"/>

-    <toolbarbutton id="new-identity-button" class="toolbarbutton-1 chromeclass-toolbar-additional"

+    <toolbarbutton id="new-identity-button"

+                   command="cmd_newIdentity"

+                   class="toolbarbutton-1 chromeclass-toolbar-additional"

                    data-l10n-id="toolbar-new-identity"/>

     <toolbarbutton id="fullscreen-button" class="toolbarbutton-1 chromeclass-toolbar-additional"

     "Browser:NewUserContextTab",

     "Tools:PrivateBrowsing",

     "zoomWindow",

+    "cmd_newIdentity",

   ]);

   /**

   let newIdentityInProgress = false;

   return {

-    topics,

-

-    init() {

-      // We first search in the DOM for the identity button. If it does not

-      // exist it may be in the toolbox palette. In the latter case we still

-      // need to initialize the button in case it is added back later through

-      // customization.

-      const button =

-        document.getElementById("new-identity-button") ||

-        window.gNavToolbox.palette.querySelector("#new-identity-button");

-      button?.addEventListener("command", () => {

-        this.onCommand();

-      });

-      document

-        .getElementById("appMenu-viewCache")

-        .content.querySelector("#appMenu-new-identity")

-        ?.addEventListener("command", () => {

-          this.onCommand();

-        });

-      document

-        .getElementById("menu_newIdentity")

-        ?.addEventListener("command", () => {

-          this.onCommand();

-        });

-    },

-

-    uninit() {},

-

     async onCommand() {

       try {

         // Ignore if there's a New Identity in progress to avoid race

henry pushed to branch base-browser-140.0esr-15.0-1 at The Tor Project / Applications / Tor Browser

Commits:

7 changed files:

Changes: