- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.14.0esr-12.5-1-build1
by ma1 (＠ma1) 26 Jul '23

26 Jul '23

ma1 pushed new tag tor-browser-102.14.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-102.14.0esr-12.5-1] 97 commits: Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
by ma1 (＠ma1) 26 Jul '23

26 Jul '23

ma1 pushed to branch base-browser-102.14.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 66650a2e by Pier Angelo Vendrame at 2023-07-25T23:31:49+02:00 Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms. Differential Revision: https://phabricator.services.mozilla.com/D150400 - - - - - 891ce49f by Pier Angelo Vendrame at 2023-07-25T23:31:56+02:00 Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS). Differential Revision: https://phabricator.services.mozilla.com/D146300 - - - - - 0167b97a by Jamie Nicol at 2023-07-25T23:31:57+02:00 Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D154897 - - - - - b1829371 by Pier Angelo Vendrame at 2023-07-25T23:31:58+02:00 Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D157843 - - - - - 1125e718 by Neill Miller at 2023-07-25T23:31:59+02:00 Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with Bug 1123480. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition. Differential Revision: https://phabricator.services.mozilla.com/D157800 - - - - - e3afc014 by Gabriele Svelto at 2023-07-25T23:32:00+02:00 Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium macOS unfair locks enforce that a lock can only be released by the thread which locked it. On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing. Differential Revision: https://phabricator.services.mozilla.com/D148287 - - - - - f4cf7ede by Gabriele Svelto at 2023-07-25T23:32:01+02:00 Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium Depends on D148287 Differential Revision: https://phabricator.services.mozilla.com/D99280 - - - - - 3d94ece4 by Kershaw Chang at 2023-07-25T23:32:02+02:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - 24236471 by Kathy Brade at 2023-07-25T23:32:02+02:00 Bug 1769028: Disable DNS lookup in nsProfileLock when the proxy bypass protection is enabled r=mossop Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1 when the proxy bypass protection is enabled. Differential Revision: https://phabricator.services.mozilla.com/D161264 - - - - - c3235edc by Gabriele Svelto at 2023-07-25T23:32:03+02:00 Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone Differential Revision: https://phabricator.services.mozilla.com/D149599 - - - - - b22ed534 by Gabriele Svelto at 2023-07-25T23:32:04+02:00 Bug 1784018 - Remove deprecated OSSpinLocks r=glandium On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core. Differential Revision: https://phabricator.services.mozilla.com/D154205 - - - - - e5e87caa by Hubert Boma Manilla at 2023-07-25T23:32:05+02:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers - Block redirects on sourceMappingUrl - Add debugger test Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 9d39b9d6 by Hubert Boma Manilla at 2023-07-25T23:32:06+02:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739 - - - - - c02ec6c6 by Jonathan Kew at 2023-07-25T23:32:07+02:00 Bug 1792157 - Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families. r=gfx-reviewers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D175350 - - - - - a72fbee6 by Rob Wu at 2023-07-25T23:32:08+02:00 Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin Depends on D164656 Differential Revision: https://phabricator.services.mozilla.com/D166108 - - - - - a424f1cf by Kash Shampur at 2023-07-25T23:32:09+02:00 Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so. Differential Revision: https://phabricator.services.mozilla.com/D167167 - - - - - de73c560 by Pier Angelo Vendrame at 2023-07-25T23:32:09+02:00 Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden Now it displays app display name, instead of having Firefox hardcoded. Differential Revision: https://phabricator.services.mozilla.com/D168562 - - - - - b74c0791 by Jon Coppeard at 2023-07-25T23:32:10+02:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely. This fixes the crash produced by the testcase. Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - d6c35ccf by Jon Coppeard at 2023-07-25T23:32:11+02:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC. Depends on D169701 Differential Revision: https://phabricator.services.mozilla.com/D169702 - - - - - 4651288e by Pier Angelo Vendrame at 2023-07-25T23:32:12+02:00 Bug 1817756 - Add a seed to the network ID. r=valentin,necko-reviewers This helps to prevent linkability of users in the same network. Differential Revision: https://phabricator.services.mozilla.com/D170373 - - - - - 72140b84 by John Lin at 2023-07-25T23:42:26+02:00 Bug 1832832 - protect encoder accesses in Java callbacks. r=media-playback-reviewers,alwu a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D178564 - - - - - cffad159 by Arsen Arsenović at 2023-07-25T23:42:27+02:00 Bug 1811714 - Add a few missing <cstdint> includes r=gfx-reviewers,nical GCC 13s libstdc++ reduced its dependency on some headers like <cstdint>, so it's no longer transitively included through various headers. Include it explicitly. See also: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes 11:16.32 .../components/telemetry/pingsender/pingsender.cpp:30:7: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kConnectionTimeoutMs = 30 * 1000; 11:16.33 ^ 11:16.33 ... /components/telemetry/pingsender/pingsender.cpp:76:9: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kBufferSize = 4 * 1024 - 1; 11:16.34 ^ 11:16.44 2 errors generated. (et al) Differential Revision: https://phabricator.services.mozilla.com/D167491 - - - - - 2f4a54a3 by James Teh at 2023-07-26T21:52:19+02:00 Bug 1772170: Ensure cached Accessibles and offsets are valid before returning them in DocAccessibleParent::SelectionRanges. r=eeejay Differential Revision: https://phabricator.services.mozilla.com/D148745 - - - - - e460aee8 by James Teh at 2023-07-26T21:52:20+02:00 Bug 1781169: Ensure that the cached start/end containers contain characters before returning them in DocAccessibleParent::SelectionRanges. r=eeejay In bug 1772170, I added code to ensure that the cached offsets are valid. However, this didn't account for the possibility that one of the containers contained 0 characters. In that case, offset 0 is itself invalid. If there were also no children, this might in GetChildAtOffset being called and returning null, causing a crash when retrieving selection. Differential Revision: https://phabricator.services.mozilla.com/D154964 - - - - - 7f4de3a3 by Georg Koppen at 2023-07-26T21:52:21+02:00 Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM" This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f. This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed. - - - - - 5388480a by Henry Wilkes at 2023-07-26T21:52:22+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 113974c0 by Henry Wilkes at 2023-07-26T21:52:23+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - bab3b502 by Pier Angelo Vendrame at 2023-07-26T21:52:24+02:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 7bf81d37 by Marco Simonelli at 2023-07-26T21:52:25+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 28aeacd5 by Marco Simonelli at 2023-07-26T21:52:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 17fd7119 by Marco Simonelli at 2023-07-26T21:52:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 49244d4b by Marco Simonelli at 2023-07-26T21:52:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 516a096f by Marco Simonelli at 2023-07-26T21:52:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - e08f2fc3 by Marco Simonelli at 2023-07-26T21:52:29+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 447b1ded by Gaba at 2023-07-26T21:52:30+02:00 Adding issue and merge request templates - - - - - 91460f85 by Pier Angelo Vendrame at 2023-07-26T21:52:31+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 8fcbe886 by Pier Angelo Vendrame at 2023-07-26T21:52:32+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 5b2779a5 by Dan Ballard at 2023-07-26T21:52:32+02:00 Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac - - - - - 5a3057bf by Pier Angelo Vendrame at 2023-07-26T21:52:33+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - c78741f2 by Dan Ballard at 2023-07-26T21:52:34+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - b4a4bec8 by Matthew Finkel at 2023-07-26T21:52:35+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 81122dd6 by Matthew Finkel at 2023-07-26T21:52:36+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 617b19d0 by Mike Perry at 2023-07-26T21:52:37+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 5107f970 by Alex Catarineu at 2023-07-26T21:52:38+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 5ccd2869 by Georg Koppen at 2023-07-26T21:52:39+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 972b550c by Kathy Brade at 2023-07-26T21:52:39+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 9cfa53dc by Kathy Brade at 2023-07-26T21:52:40+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 4afff71e by Alex Catarineu at 2023-07-26T21:52:41+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - f3231564 by Kathy Brade at 2023-07-26T21:52:42+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 42f24da1 by Arthur Edelstein at 2023-07-26T21:52:43+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 727a1d8b by Alex Catarineu at 2023-07-26T21:52:44+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - e5bc5b12 by Pier Angelo Vendrame at 2023-07-26T21:52:45+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - dfc706b5 by Georg Koppen at 2023-07-26T21:52:46+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - fae932dd by Alex Catarineu at 2023-07-26T21:52:46+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 5d5d652e by cypherpunks1 at 2023-07-26T21:52:47+02:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING - - - - - 35cb57e6 by cypherpunks1 at 2023-07-26T21:52:48+02:00 Bug 41568: Disable LaterRun - - - - - 75bb1ef6 by cypherpunks1 at 2023-07-26T21:52:49+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 683e266e by Pier Angelo Vendrame at 2023-07-26T21:52:50+02:00 Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled. The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled. Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature. - - - - - c10ca88e by Pier Angelo Vendrame at 2023-07-26T21:52:51+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 08d32d39 by Mike Perry at 2023-07-26T21:52:52+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - b469f0bf by Richard Pospesel at 2023-07-26T21:52:53+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 92e56693 by Pier Angelo Vendrame at 2023-07-26T21:52:53+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - e4faff8e by Alex Catarineu at 2023-07-26T21:52:54+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 62ae3e48 by Alex Catarineu at 2023-07-26T21:52:55+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - d8a6dad5 by Alex Catarineu at 2023-07-26T21:52:56+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 5e7fdf93 by Alex Catarineu at 2023-07-26T21:52:57+02:00 Bug 26345: Hide tracking protection UI - - - - - bf0600b5 by Pier Angelo Vendrame at 2023-07-26T21:52:58+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - f86be196 by Alex Catarineu at 2023-07-26T21:52:59+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 54a51fd9 by Mike Perry at 2023-07-26T21:53:00+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - d1149500 by Igor Oliveira at 2023-07-26T21:53:00+02:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome. - - - - - b294d2f2 by Pier Angelo Vendrame at 2023-07-26T21:53:01+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 2de3c3e1 by Matthew Finkel at 2023-07-26T21:53:02+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - ae956fde by Pier Angelo Vendrame at 2023-07-26T21:53:03+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 7dc8381d by hackademix at 2023-07-26T21:53:04+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - b69832f6 by hackademix at 2023-07-26T21:53:05+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 29d68b60 by hackademix at 2023-07-26T21:53:06+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 83e0ee54 by hackademix at 2023-07-26T21:53:06+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 0b245d7d by hackademix at 2023-07-26T21:53:07+02:00 Bug 32308: use direct browser sizing for letterboxing. - - - - - b9381cc9 by hackademix at 2023-07-26T21:53:08+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 31d7df07 by Pier Angelo Vendrame at 2023-07-26T21:53:09+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 60deb682 by Henry Wilkes at 2023-07-26T21:53:10+02:00 Bug 41371: Temporary hack to fix language selector popup position - - - - - 43be7b06 by p13dz at 2023-07-26T21:53:11+02:00 Bug 40283: Workaround for the file upload bug - - - - - 0a7e7744 by Arthur Edelstein at 2023-07-26T21:53:12+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - f799f6d8 by Pier Angelo Vendrame at 2023-07-26T21:53:13+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - 83594880 by Henry Wilkes at 2023-07-26T21:53:14+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages and about:firefoxview. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 88b637f7 by Pier Angelo Vendrame at 2023-07-26T21:53:14+02:00 Bug 41542: Disable the creation of a default profile Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories. We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174. - - - - - 71e39eb0 by Kathy Brade at 2023-07-26T21:53:15+02:00 Bug 13379: Allow using NSS to sign and verify MAR signatures Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary. - - - - - 7315ed21 by Kathy Brade at 2023-07-26T21:53:16+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - c6cf8afc by Nicolas Vigier at 2023-07-26T21:53:17+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 698ee78e by hackademix at 2023-07-26T21:53:18+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 835a208b by hackademix at 2023-07-26T21:53:19+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 7a250899 by Pier Angelo Vendrame at 2023-07-26T21:53:20+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - c963884b by Alex Catarineu at 2023-07-26T21:53:21+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - d164facc by Matthew Finkel at 2023-07-26T21:53:21+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - c4322c27 by Pier Angelo Vendrame at 2023-07-26T21:53:22+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - f23ceeeb by Pier Angelo Vendrame at 2023-07-26T21:53:23+02:00 Bug 40926: Implemented the New Identity feature - - - - - fadc5932 by Henry Wilkes at 2023-07-26T21:53:24+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 30 changed files: - .eslintignore - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/ipc/DocAccessibleParent.cpp - − browser/actors/RFPHelperChild.jsm - − browser/actors/RFPHelperParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.css - browser/base/content/browser.js - browser/base/content/browser.xhtml - + browser/base/content/languageNotification.js - browser/base/content/main-popupset.inc.xhtml - browser/base/content/navigator-toolbox.inc.xhtml - browser/base/jar.mn - browser/base/moz.build - browser/components/BrowserContentHandler.jsm - browser/components/BrowserGlue.jsm The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4ce612… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4ce612… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.14.0esr-12.5-1] 138 commits: Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
by ma1 (＠ma1) 26 Jul '23

26 Jul '23

ma1 pushed to branch tor-browser-102.14.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 66650a2e by Pier Angelo Vendrame at 2023-07-25T23:31:49+02:00 Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms. Differential Revision: https://phabricator.services.mozilla.com/D150400 - - - - - 891ce49f by Pier Angelo Vendrame at 2023-07-25T23:31:56+02:00 Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS). Differential Revision: https://phabricator.services.mozilla.com/D146300 - - - - - 0167b97a by Jamie Nicol at 2023-07-25T23:31:57+02:00 Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D154897 - - - - - b1829371 by Pier Angelo Vendrame at 2023-07-25T23:31:58+02:00 Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D157843 - - - - - 1125e718 by Neill Miller at 2023-07-25T23:31:59+02:00 Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with Bug 1123480. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition. Differential Revision: https://phabricator.services.mozilla.com/D157800 - - - - - e3afc014 by Gabriele Svelto at 2023-07-25T23:32:00+02:00 Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium macOS unfair locks enforce that a lock can only be released by the thread which locked it. On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing. Differential Revision: https://phabricator.services.mozilla.com/D148287 - - - - - f4cf7ede by Gabriele Svelto at 2023-07-25T23:32:01+02:00 Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium Depends on D148287 Differential Revision: https://phabricator.services.mozilla.com/D99280 - - - - - 3d94ece4 by Kershaw Chang at 2023-07-25T23:32:02+02:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - 24236471 by Kathy Brade at 2023-07-25T23:32:02+02:00 Bug 1769028: Disable DNS lookup in nsProfileLock when the proxy bypass protection is enabled r=mossop Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1 when the proxy bypass protection is enabled. Differential Revision: https://phabricator.services.mozilla.com/D161264 - - - - - c3235edc by Gabriele Svelto at 2023-07-25T23:32:03+02:00 Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone Differential Revision: https://phabricator.services.mozilla.com/D149599 - - - - - b22ed534 by Gabriele Svelto at 2023-07-25T23:32:04+02:00 Bug 1784018 - Remove deprecated OSSpinLocks r=glandium On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core. Differential Revision: https://phabricator.services.mozilla.com/D154205 - - - - - e5e87caa by Hubert Boma Manilla at 2023-07-25T23:32:05+02:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers - Block redirects on sourceMappingUrl - Add debugger test Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 9d39b9d6 by Hubert Boma Manilla at 2023-07-25T23:32:06+02:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739 - - - - - c02ec6c6 by Jonathan Kew at 2023-07-25T23:32:07+02:00 Bug 1792157 - Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families. r=gfx-reviewers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D175350 - - - - - a72fbee6 by Rob Wu at 2023-07-25T23:32:08+02:00 Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin Depends on D164656 Differential Revision: https://phabricator.services.mozilla.com/D166108 - - - - - a424f1cf by Kash Shampur at 2023-07-25T23:32:09+02:00 Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so. Differential Revision: https://phabricator.services.mozilla.com/D167167 - - - - - de73c560 by Pier Angelo Vendrame at 2023-07-25T23:32:09+02:00 Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden Now it displays app display name, instead of having Firefox hardcoded. Differential Revision: https://phabricator.services.mozilla.com/D168562 - - - - - b74c0791 by Jon Coppeard at 2023-07-25T23:32:10+02:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely. This fixes the crash produced by the testcase. Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - d6c35ccf by Jon Coppeard at 2023-07-25T23:32:11+02:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC. Depends on D169701 Differential Revision: https://phabricator.services.mozilla.com/D169702 - - - - - 4651288e by Pier Angelo Vendrame at 2023-07-25T23:32:12+02:00 Bug 1817756 - Add a seed to the network ID. r=valentin,necko-reviewers This helps to prevent linkability of users in the same network. Differential Revision: https://phabricator.services.mozilla.com/D170373 - - - - - 72140b84 by John Lin at 2023-07-25T23:42:26+02:00 Bug 1832832 - protect encoder accesses in Java callbacks. r=media-playback-reviewers,alwu a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D178564 - - - - - cffad159 by Arsen Arsenović at 2023-07-25T23:42:27+02:00 Bug 1811714 - Add a few missing <cstdint> includes r=gfx-reviewers,nical GCC 13s libstdc++ reduced its dependency on some headers like <cstdint>, so it's no longer transitively included through various headers. Include it explicitly. See also: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes 11:16.32 .../components/telemetry/pingsender/pingsender.cpp:30:7: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kConnectionTimeoutMs = 30 * 1000; 11:16.33 ^ 11:16.33 ... /components/telemetry/pingsender/pingsender.cpp:76:9: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kBufferSize = 4 * 1024 - 1; 11:16.34 ^ 11:16.44 2 errors generated. (et al) Differential Revision: https://phabricator.services.mozilla.com/D167491 - - - - - 2f4a54a3 by James Teh at 2023-07-26T21:52:19+02:00 Bug 1772170: Ensure cached Accessibles and offsets are valid before returning them in DocAccessibleParent::SelectionRanges. r=eeejay Differential Revision: https://phabricator.services.mozilla.com/D148745 - - - - - e460aee8 by James Teh at 2023-07-26T21:52:20+02:00 Bug 1781169: Ensure that the cached start/end containers contain characters before returning them in DocAccessibleParent::SelectionRanges. r=eeejay In bug 1772170, I added code to ensure that the cached offsets are valid. However, this didn't account for the possibility that one of the containers contained 0 characters. In that case, offset 0 is itself invalid. If there were also no children, this might in GetChildAtOffset being called and returning null, causing a crash when retrieving selection. Differential Revision: https://phabricator.services.mozilla.com/D154964 - - - - - 7f4de3a3 by Georg Koppen at 2023-07-26T21:52:21+02:00 Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM" This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f. This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed. - - - - - 5388480a by Henry Wilkes at 2023-07-26T21:52:22+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 113974c0 by Henry Wilkes at 2023-07-26T21:52:23+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - bab3b502 by Pier Angelo Vendrame at 2023-07-26T21:52:24+02:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 7bf81d37 by Marco Simonelli at 2023-07-26T21:52:25+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 28aeacd5 by Marco Simonelli at 2023-07-26T21:52:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 17fd7119 by Marco Simonelli at 2023-07-26T21:52:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 49244d4b by Marco Simonelli at 2023-07-26T21:52:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 516a096f by Marco Simonelli at 2023-07-26T21:52:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - e08f2fc3 by Marco Simonelli at 2023-07-26T21:52:29+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 447b1ded by Gaba at 2023-07-26T21:52:30+02:00 Adding issue and merge request templates - - - - - 91460f85 by Pier Angelo Vendrame at 2023-07-26T21:52:31+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 8fcbe886 by Pier Angelo Vendrame at 2023-07-26T21:52:32+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 5b2779a5 by Dan Ballard at 2023-07-26T21:52:32+02:00 Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac - - - - - 5a3057bf by Pier Angelo Vendrame at 2023-07-26T21:52:33+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - c78741f2 by Dan Ballard at 2023-07-26T21:52:34+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - b4a4bec8 by Matthew Finkel at 2023-07-26T21:52:35+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 81122dd6 by Matthew Finkel at 2023-07-26T21:52:36+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 617b19d0 by Mike Perry at 2023-07-26T21:52:37+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 5107f970 by Alex Catarineu at 2023-07-26T21:52:38+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 5ccd2869 by Georg Koppen at 2023-07-26T21:52:39+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 972b550c by Kathy Brade at 2023-07-26T21:52:39+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 9cfa53dc by Kathy Brade at 2023-07-26T21:52:40+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 4afff71e by Alex Catarineu at 2023-07-26T21:52:41+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - f3231564 by Kathy Brade at 2023-07-26T21:52:42+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 42f24da1 by Arthur Edelstein at 2023-07-26T21:52:43+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 727a1d8b by Alex Catarineu at 2023-07-26T21:52:44+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - e5bc5b12 by Pier Angelo Vendrame at 2023-07-26T21:52:45+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - dfc706b5 by Georg Koppen at 2023-07-26T21:52:46+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - fae932dd by Alex Catarineu at 2023-07-26T21:52:46+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 5d5d652e by cypherpunks1 at 2023-07-26T21:52:47+02:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING - - - - - 35cb57e6 by cypherpunks1 at 2023-07-26T21:52:48+02:00 Bug 41568: Disable LaterRun - - - - - 75bb1ef6 by cypherpunks1 at 2023-07-26T21:52:49+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 683e266e by Pier Angelo Vendrame at 2023-07-26T21:52:50+02:00 Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled. The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled. Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature. - - - - - c10ca88e by Pier Angelo Vendrame at 2023-07-26T21:52:51+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 08d32d39 by Mike Perry at 2023-07-26T21:52:52+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - b469f0bf by Richard Pospesel at 2023-07-26T21:52:53+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 92e56693 by Pier Angelo Vendrame at 2023-07-26T21:52:53+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - e4faff8e by Alex Catarineu at 2023-07-26T21:52:54+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 62ae3e48 by Alex Catarineu at 2023-07-26T21:52:55+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - d8a6dad5 by Alex Catarineu at 2023-07-26T21:52:56+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 5e7fdf93 by Alex Catarineu at 2023-07-26T21:52:57+02:00 Bug 26345: Hide tracking protection UI - - - - - bf0600b5 by Pier Angelo Vendrame at 2023-07-26T21:52:58+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - f86be196 by Alex Catarineu at 2023-07-26T21:52:59+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 54a51fd9 by Mike Perry at 2023-07-26T21:53:00+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - d1149500 by Igor Oliveira at 2023-07-26T21:53:00+02:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome. - - - - - b294d2f2 by Pier Angelo Vendrame at 2023-07-26T21:53:01+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 2de3c3e1 by Matthew Finkel at 2023-07-26T21:53:02+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - ae956fde by Pier Angelo Vendrame at 2023-07-26T21:53:03+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 7dc8381d by hackademix at 2023-07-26T21:53:04+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - b69832f6 by hackademix at 2023-07-26T21:53:05+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 29d68b60 by hackademix at 2023-07-26T21:53:06+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 83e0ee54 by hackademix at 2023-07-26T21:53:06+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 0b245d7d by hackademix at 2023-07-26T21:53:07+02:00 Bug 32308: use direct browser sizing for letterboxing. - - - - - b9381cc9 by hackademix at 2023-07-26T21:53:08+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 31d7df07 by Pier Angelo Vendrame at 2023-07-26T21:53:09+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 60deb682 by Henry Wilkes at 2023-07-26T21:53:10+02:00 Bug 41371: Temporary hack to fix language selector popup position - - - - - 43be7b06 by p13dz at 2023-07-26T21:53:11+02:00 Bug 40283: Workaround for the file upload bug - - - - - 0a7e7744 by Arthur Edelstein at 2023-07-26T21:53:12+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - f799f6d8 by Pier Angelo Vendrame at 2023-07-26T21:53:13+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - 83594880 by Henry Wilkes at 2023-07-26T21:53:14+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages and about:firefoxview. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 88b637f7 by Pier Angelo Vendrame at 2023-07-26T21:53:14+02:00 Bug 41542: Disable the creation of a default profile Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories. We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174. - - - - - 71e39eb0 by Kathy Brade at 2023-07-26T21:53:15+02:00 Bug 13379: Allow using NSS to sign and verify MAR signatures Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary. - - - - - 7315ed21 by Kathy Brade at 2023-07-26T21:53:16+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - c6cf8afc by Nicolas Vigier at 2023-07-26T21:53:17+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 698ee78e by hackademix at 2023-07-26T21:53:18+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 835a208b by hackademix at 2023-07-26T21:53:19+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 7a250899 by Pier Angelo Vendrame at 2023-07-26T21:53:20+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - c963884b by Alex Catarineu at 2023-07-26T21:53:21+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - d164facc by Matthew Finkel at 2023-07-26T21:53:21+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - c4322c27 by Pier Angelo Vendrame at 2023-07-26T21:53:22+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - f23ceeeb by Pier Angelo Vendrame at 2023-07-26T21:53:23+02:00 Bug 40926: Implemented the New Identity feature - - - - - fadc5932 by Henry Wilkes at 2023-07-26T21:53:24+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 401c2be8 by Richard Pospesel at 2023-07-26T21:53:25+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - d2ccf82a by Richard Pospesel at 2023-07-26T21:53:26+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - ea2391d0 by Henry Wilkes at 2023-07-26T21:53:27+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 9b88d8cb by Kathy Brade at 2023-07-26T21:53:27+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 130aa927 by Mike Perry at 2023-07-26T21:53:28+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one - - - - - 74d4cead by Alex Catarineu at 2023-07-26T21:53:29+02:00 Bring back old Firefox onboarding Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson" This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432. Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs" This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2. Bug 28822: Convert onboarding to webextension Partially revert 1564367 (controlCenter in UITour.jsm) - - - - - 28647eb6 by Kathy Brade at 2023-07-26T21:53:30+02:00 Bug 26961: New user onboarding. Reuse the Firefox onboarding mechanism with minimal changes. Localizable strings are pulled in from Torbutton (if Torbutton is not installed, we lack about:tor and no tour will be shown). Replace SVG images with PNGs (see bug 27002), For defense in depth, omit include OnboardingTelemetry.jsm entirely. Added support for the following UITour page event: torBrowserOpenSecuritySettings Also fix bug 27403: the onboarding bubble is not always displayed. Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead. Also fix bug 28628: Change onboarding Security panel to open new Security Level panel. Also fix bug 27484: Improve navigation within onboarding. Bug 27082: enable a limited UITour Disallow access to UITour functionality from all pages other than about:home, about:newtab, and about:tor. Implement a whitelist mechanism for page actions. Bug 26962 - implement new features onboarding (part 1). Add an "Explore" button to the "Circuit Display" panel within new user onboarding which opens the DuckDuckGo .onion and then guides users through a short circuit display tutorial. Allow a few additional UITour actions while limiting as much as possible how it can be used. Tweak the UITour styles to match the Tor Browser branding. All user interface strings are retrieved from Torbutton's browserOnboarding.properties file. Bug 27486 Avoid about:blank tabs when opening onboarding pages. Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion". Bug 29768: Introduce new features to users Add an "update" tour for the Tor Browser 8.5 release that contains two panels: Toolbar and Security (with appropriate description text and images). Display an attention-grabbing dot on the onboarding text bubble when the update tour is active. The animation lasts for 14 seconds. Bug 31768: Introduce toolbar and network settings changes in onboarding Update the "Tor Network" onboarding page to include a note that settings can now be accessed via the application preferences and add an "Adjust Your Tor Network Settings" action button which opens about:preferences#tor. Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one that includes the revised "Tor Network" page and a revised "Toolbar" page. The latter explains that Torbutton's toolbar item has been removed ("Goodbye Onion Button") and explains how to access the New Identity feature using the hamburger menu and new toolbar item. Bug 34321 - Add Learn More onboarding item Bug 40429: Update Onboarding for 10.5 - - - - - a418b858 by sanketh at 2023-07-26T21:53:31+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 9a9c9cd0 by Mike Perry at 2023-07-26T21:53:32+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 6ded175d by Henry Wilkes at 2023-07-26T21:53:33+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 51dbd05f by Pier Angelo Vendrame at 2023-07-26T21:53:34+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - e5a9e4bd by Pier Angelo Vendrame at 2023-07-26T21:53:35+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - ac395e44 by Pier Angelo Vendrame at 2023-07-26T21:53:36+02:00 Bug 40933: Add tor-launcher functionality - - - - - b618f102 by Richard Pospesel at 2023-07-26T21:53:36+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 7ac8e77e by Alex Catarineu at 2023-07-26T21:53:37+02:00 Bug 10760: Integrate TorButton to TorBrowser core Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time. Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time. Additionally, this patch also fixes Bug 27611. Bug 26321: New Circuit and New Identity menu items Bug 14392: Make about:tor behave like other initial pages. Bug 25013: Add torbutton as a tor-browser submodule Bug 31575: Replace Firefox Home (newtab) with about:tor - - - - - 7c6d4f43 by hackademix at 2023-07-26T21:53:38+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 819219bd by Henry Wilkes at 2023-07-26T21:53:39+02:00 Bug 41600: Add a tor circuit display panel. - - - - - e576ab0c by Amogh Pradeep at 2023-07-26T21:53:40+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 65039927 by Matthew Finkel at 2023-07-26T21:53:41+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - b4619b3c by Alex Catarineu at 2023-07-26T21:53:42+02:00 Add TorStrings module for localization - - - - - 59d28fa9 by Kathy Brade at 2023-07-26T21:53:43+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 7b4886ad by Pier Angelo Vendrame at 2023-07-26T21:53:43+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - b7b938b2 by Richard Pospesel at 2023-07-26T21:53:44+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 6b31946b by Richard Pospesel at 2023-07-26T21:53:45+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 3cbd1f50 by Arthur Edelstein at 2023-07-26T21:53:46+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 94185044 by Pier Angelo Vendrame at 2023-07-26T21:53:47+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - f56a18ae by Kathy Brade at 2023-07-26T21:53:48+02:00 Bug 12647: Support symlinks in the updater. - - - - - bc81fa25 by Kathy Brade at 2023-07-26T21:53:49+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 9e7bcd78 by Kathy Brade at 2023-07-26T21:53:50+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - c5fcad3e by Georg Koppen at 2023-07-26T21:53:50+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 90fefc2a by Mike Perry at 2023-07-26T21:53:51+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 8db157b0 by Alex Catarineu at 2023-07-26T21:53:52+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - e9a16e05 by Richard Pospesel at 2023-07-26T21:53:53+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 55675a15 by Kathy Brade at 2023-07-26T21:53:54+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - bb22ce38 by Alex Catarineu at 2023-07-26T21:53:55+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 9d8c5bda by Pier Angelo Vendrame at 2023-07-26T21:53:56+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 29f22cba by Pier Angelo Vendrame at 2023-07-26T21:53:57+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 08860a4e by Pier Angelo Vendrame at 2023-07-26T21:53:58+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 6c1f46dd by Dan Ballard at 2023-07-26T21:53:59+02:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 44a9f9a8 by Henry Wilkes at 2023-07-26T21:53:59+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 855b6979 by hackademix at 2023-07-26T21:54:00+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/ipc/DocAccessibleParent.cpp - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - browser/actors/NetErrorChild.jsm - browser/actors/NetErrorParent.jsm - − browser/actors/RFPHelperChild.jsm - − browser/actors/RFPHelperParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4ce612… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4ce612… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 13.0a1
by richard (＠richard) 26 Jul '23

26 Jul '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 1da7bea1 by Richard Pospesel at 2023-07-26T17:21:44+00:00 alpha: new version, 13.0a1 - - - - - 30 changed files: - update_3/alpha/.htaccess - − update_3/alpha/12.5a4-12.5a7-linux32-ALL.xml - − update_3/alpha/12.5a4-12.5a7-linux64-ALL.xml - − update_3/alpha/12.5a4-12.5a7-macos-ALL.xml - − update_3/alpha/12.5a4-12.5a7-win32-ALL.xml - − update_3/alpha/12.5a4-12.5a7-win64-ALL.xml - − update_3/alpha/12.5a5-12.5a7-linux32-ALL.xml - − update_3/alpha/12.5a5-12.5a7-linux64-ALL.xml - − update_3/alpha/12.5a5-12.5a7-macos-ALL.xml - − update_3/alpha/12.5a5-12.5a7-win32-ALL.xml - − update_3/alpha/12.5a5-12.5a7-win64-ALL.xml - + update_3/alpha/12.5a5-13.0a1-linux32-ALL.xml - + update_3/alpha/12.5a5-13.0a1-linux64-ALL.xml - + update_3/alpha/12.5a5-13.0a1-macos-ALL.xml - + update_3/alpha/12.5a5-13.0a1-win32-ALL.xml - + update_3/alpha/12.5a5-13.0a1-win64-ALL.xml - − update_3/alpha/12.5a6-12.5a7-linux32-ALL.xml - − update_3/alpha/12.5a6-12.5a7-linux64-ALL.xml - − update_3/alpha/12.5a6-12.5a7-macos-ALL.xml - − update_3/alpha/12.5a6-12.5a7-win32-ALL.xml - − update_3/alpha/12.5a6-12.5a7-win64-ALL.xml - + update_3/alpha/12.5a6-13.0a1-linux32-ALL.xml - + update_3/alpha/12.5a6-13.0a1-linux64-ALL.xml - + update_3/alpha/12.5a6-13.0a1-macos-ALL.xml - + update_3/alpha/12.5a6-13.0a1-win32-ALL.xml - + update_3/alpha/12.5a6-13.0a1-win64-ALL.xml - + update_3/alpha/12.5a7-13.0a1-linux32-ALL.xml - + update_3/alpha/12.5a7-13.0a1-linux64-ALL.xml - + update_3/alpha/12.5a7-13.0a1-macos-ALL.xml - + update_3/alpha/12.5a7-13.0a1-win32-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Make Firefox build script more coherent.
by Pier Angelo Vendrame (＠pierov) 26 Jul '23

26 Jul '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 9ddef518 by Pier Angelo Vendrame at 2023-07-26T17:14:18+02:00 Make Firefox build script more coherent. Adjust indentation and always trim newlines after the template blocks. - - - - - ad7a5170 by Pier Angelo Vendrame at 2023-07-26T17:14:35+02:00 Bug 31546: Copy Firefox PDBs for Windows Also copy debug symbols after stripping on Linux 32-bit (we only copied them in Linux 64-bit) and for all our browsers (previously we copied them only for Tor Browser). Include the headers directory with the symbols, because some of them are generated during the build, but they are needed for debugging. - - - - - 2 changed files: - projects/browser/build - projects/firefox/build Changes: ===================================== projects/browser/build ===================================== @@ -401,13 +401,13 @@ SCRIPT_EOF [% IF c("var/updater_enabled") -%] cp $rootdir/[% c('input_files_by_name/firefox') %]/mar-tools-*.zip "$OUTDIR"/ [% END -%] -[% IF c("var/linux-x86_64") -%] - [% IF c("var/tor-browser") -%] - cp $rootdir/[% c('input_files_by_name/firefox') %]/browser-debug.tar.xz "$OUTDIR"/[% c("var/project-name") %]-[% c("var/mar_osname") %]-debug.tar.xz - [% END -%] - [% IF !c("var/asan") -%] - cp $rootdir/[% c('input_files_by_name/firefox') %]/geckodriver-linux64.tar.xz "$OUTDIR"/ +[% IF c("var/linux") -%] + cp $rootdir/[% c('input_files_by_name/firefox') %]/browser-debug.tar.xz "$OUTDIR/[% c('var/project-name') %]-[% c('var/mar_osname') %]-debug.tar.xz" + [% IF c("var/linux-x86_64") && !c("var/asan") -%] + cp $rootdir/[% c('input_files_by_name/firefox') %]/geckodriver.tar.xz "$OUTDIR/geckodriver-[% c('var/mar_osname') %].tar.xz" [% END -%] +[% ELSIF c("var/windows") -%] + cp $rootdir/[% c('input_files_by_name/firefox') %]/browser-debug.zip "$OUTDIR/[% c('var/project-name') %]-[% c('var/mar_osname') %]-debug.zip" [% END -%] [%IF c("var/tor-browser") -%] tor_expert_bundle_src="[% c("input_files_by_name/tor-expert-bundle") %]" ===================================== projects/firefox/build ===================================== @@ -8,7 +8,7 @@ distdir=/var/tmp/dist/[% project %] mkdir -p /var/tmp/build mkdir -p [% dest_dir _ '/' _ c('filename') %] -[% IF c("var/windows") %] +[% IF c("var/windows") -%] # Setting up fxc2 tar -C /var/tmp/dist -xf [% c('input_files_by_name/fxc2') %] export PATH="/var/tmp/dist/fxc2/bin:$PATH" @@ -20,7 +20,7 @@ tar -C /var/tmp/dist -xf [% c('input_files_by_name/nasm') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/node') %] export PATH="/var/tmp/dist/rust/bin:/var/tmp/dist/cbindgen:/var/tmp/dist/nasm/bin:/var/tmp/dist/node/bin:$PATH" -[% IF c("var/linux") %] +[% IF c("var/linux") -%] tar -C /var/tmp/dist -xf [% c('input_files_by_name/clang') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/python') %] export PATH="/var/tmp/dist/python/bin:$PATH" @@ -30,7 +30,7 @@ export PATH="/var/tmp/dist/rust/bin:/var/tmp/dist/cbindgen:/var/tmp/dist/nasm/bi [% IF ! c("var/asan") -%] export PATH="/var/tmp/dist/clang/bin:$PATH" [% END -%] - [% IF c("var/linux-i686") %] + [% IF c("var/linux-i686") -%] # Exporting `PKG_CONFIG_PATH` in the mozconfig file is causing build # breakage in Rust code. It seems that environment variable is not passed # down properly in that case. Thus, we set it here in the build script. @@ -72,7 +72,7 @@ MOZCONFIG_EOF [% c("var/set_MOZ_BUILD_DATE") %] -[% IF c("var/windows") %] +[% IF c("var/windows") -%] # Make sure widl is not inserting random timestamps, see #21837. export WIDL_TIME_OVERRIDE="0" patch -p1 < $rootdir/nsis-uninstall.patch @@ -80,15 +80,15 @@ MOZCONFIG_EOF export LDFLAGS="[% c('var/flag_noSEH') %]" [% END -%] -[% IF c("var/namecoin") %] +[% IF c("var/namecoin") -%] patch -p1 < $rootdir/namecoin-etld.patch [% END -%] -[% IF c("var/namecoin") %] +[% IF c("var/namecoin") -%] pushd toolkit/torbutton patch -p1 < $rootdir/namecoin-torbutton.patch popd -[% END %] +[% END -%] [% IF c("var/override_updater_url") -%] sed -i 's|^URL=https://aus1\.torproject\.org/.*|URL=[% c("var/override_updater_url") %]|' build/application.ini.in @@ -166,23 +166,21 @@ export LANG=C.UTF-8 ./mach configure \ --with-distribution-id=org.torproject \ --with-base-browser-version=[% c("var/torbrowser_version") %] \ - [% IF c("var/updater_enabled") -%] - --enable-update-channel=[% c("var/channel") %] \ - [% END %] \ + [% IF c("var/updater_enabled") -%]--enable-update-channel=[% c("var/channel") %][% END %] \ [% IF !c("var/base-browser") -%]--with-branding=browser/branding/[% c("var/branding_directory_prefix") %]-[% c("var/channel") %][% END %] \ [% IF !c("var/rlbox") -%]--without-wasm-sandboxed-libraries[% END %] ./mach build --verbose -[% IF c("var/has_l10n") %] +[% IF c("var/has_l10n") -%] export MOZ_CHROME_MULTILOCALE="$supported_locales" # No quotes on purpose, see https://firefox-source-docs.mozilla.org/build/buildsystem/locales.html#inst… ./mach package-multi-locale --locales en-US $MOZ_CHROME_MULTILOCALE AB_CD=multi ./mach build stage-package -[% ELSE %] +[% ELSE -%] ./mach build stage-package -[% END %] +[% END -%] -[% IF c("var/macos") %] +[% IF c("var/macos") -%] cp -a obj-*/dist/[% c('var/exe_name') %]/* $distdir [% IF c("var/base-browser") -%] mv "$distdir/Firefox.app" "$distdir/[% c('var/Project_Name') %].app" @@ -198,13 +196,17 @@ export LANG=C.UTF-8 '[% c("var/torbrowser_version") %]' \ '[% c("var/copyright_year") %]' \ [% IF c("var/mullvad-browser") -%]'Mullvad, Tor Browser and Mozilla Developers'[% ELSE -%]'The Tor Project'[% END %] -[% END %] +[% END -%] -[% IF c("var/linux") %] - [% IF c("var/linux-x86_64") && !c("var/asan") %] +[% IF c("var/linux") -%] + [% IF c("var/linux-x86_64") && !c("var/asan") -%] cp obj-*/x86_64-unknown-linux-gnu/release/geckodriver $distdir - [% END %] + [% END -%] cp -a obj-*/dist/[% c('var/exe_name') %]/* $distdir/Browser/ + mkdir -p $distdir/Debug + # Some include files are symlinks, so use -Lr, or the tarball will fail + # silently. Also, on Linux we populate the debug symbols by stripping later. + cp -Lr obj-*/dist/include $distdir/Debug/ # Remove firefox-bin (we don't use it, see ticket #10126) rm -f "$distdir/Browser/[% c('var/exe_name') %]-bin" # TODO: There goes FIPS-140.. We could upload these somewhere unique and @@ -217,16 +219,21 @@ export LANG=C.UTF-8 [% INCLUDE 'start-firefox' -%] RBM_TB_EOF chmod 755 "$distdir/Browser/[% c('var/exe_name') %]" -[% END %] +[% END -%] -[% IF c("var/windows") %] +[% IF c("var/windows") -%] cp -a obj-*/dist/[% c('var/exe_name') %]/* $distdir/Browser/ - [% IF c("var/windows-i686") %] + [% IF c("var/windows-i686") -%] cp -a /var/tmp/dist/fxc2/bin/d3dcompiler_47_32.dll $distdir/Browser/d3dcompiler_47.dll - [% ELSE %] + [% ELSE -%] cp -a /var/tmp/dist/fxc2/bin/d3dcompiler_47.dll $distdir/Browser - [% END %] -[% END %] + [% END -%] + mkdir -p $distdir/Debug/Browser + pushd obj-* + cp -Lr dist/include $distdir/Debug/ + find . $ -path ./dist -o -path ./_tests $ -prune -o -name '*.pdb' -exec cp -l {} $distdir/Debug/Browser/ \; + popd +[% END -%] [% IF c("var/updater_enabled") -%] # Make MAR-based update tools available for use during the bundle phase. @@ -240,23 +247,23 @@ RBM_TB_EOF cp -p tools/update-packaging/*.sh $MARTOOLS/ cp -p obj-*/dist/host/bin/mar $MARTOOLS/ cp -p obj-*/dist/host/bin/mbsdiff $MARTOOLS/ - [% IF c("var/linux") || c("var/macos") %] + [% IF c("var/linux") || c("var/macos") -%] cp -p obj-*/dist/bin/signmar $MARTOOLS/ cp -p obj-*/dist/bin/certutil $MARTOOLS/ cp -p obj-*/dist/bin/pk12util $MARTOOLS/ - [% IF c("var/linux") %] + [% IF c("var/linux") -%] NSS_LIBS="libfreeblpriv3.so libmozsqlite3.so libnss3.so libnssckbi.so libnssutil3.so libsmime3.so libsoftokn3.so libssl3.so" NSPR_LIBS="libnspr4.so libplc4.so libplds4.so" - [% ELSE %] + [% ELSE -%] NSS_LIBS="libfreebl3.dylib libmozglue.dylib libnss3.dylib libnssckbi.dylib libsoftokn3.dylib" # No NSPR_LIBS for macOS NSPR_LIBS="" - [% END %] + [% END -%] for LIB in $NSS_LIBS $NSPR_LIBS; do cp -p obj-*/dist/bin/$LIB $MARTOOLS/ done - [% END %] - [% IF c("var/windows") %] + [% END -%] + [% IF c("var/windows") -%] cp -p obj-*/dist/bin/signmar.exe $MARTOOLS/ cp -p obj-*/dist/bin/certutil.exe $MARTOOLS/ cp -p obj-*/dist/bin/pk12util.exe $MARTOOLS/ @@ -264,38 +271,38 @@ RBM_TB_EOF for LIB in $NSS_LIBS; do cp -p obj-*/dist/bin/$LIB $MARTOOLS/ done - [% END %] + [% END -%] [% END -%] cd $distdir -[% IF c("var/linux-x86_64") %] - [% IF !c("var/asan") %] +[% IF c("var/linux") -%] + [% IF c("var/linux-x86_64") && !c("var/asan") -%] # No need for an unstripped geckodriver strip geckodriver - [% END %] + [% END -%] mkdir -p $distdir/Debug/Browser # Strip and generate debuginfo for the firefox binary that we keep, all *.so # files, the plugin-container, and the updater (see ticket #10126) for LIB in Browser/*.so "Browser/[% c('var/exe_name') %].real" Browser/plugin-container [% IF c("var/updater_enabled") -%]Browser/updater[% END %] do - objcopy --only-keep-debug $LIB Debug/$LIB - strip $LIB - objcopy --add-gnu-debuglink=./Debug/$LIB $LIB + objcopy --only-keep-debug $LIB Debug/$LIB + strip $LIB + objcopy --add-gnu-debuglink=./Debug/$LIB $LIB done -[% END %] +[% END -%] # Re-zipping the omni.ja files is not needed to make them reproductible, # however if we don't re-zip them, the files become corrupt when we # update them using 'zip' and firefox will silently fail to load some # parts. -[% IF c("var/windows") || c("var/linux") %] +[% IF c("var/windows") || c("var/linux") -%] [% c("var/rezip", { rezip_file => 'Browser/omni.ja' }) %] [% c("var/rezip", { rezip_file => 'Browser/browser/omni.ja' }) %] -[% ELSIF c("var/macos") %] +[% ELSIF c("var/macos") -%] [% c("var/rezip", { rezip_file => '"' _ c("var/Project_Name") _ '.app/Contents/Resources/omni.ja"' }) %] [% c("var/rezip", { rezip_file => '"' _ c("var/Project_Name") _ '.app/Contents/Resources/browser/omni.ja"' }) %] -[% END %] +[% END -%] [% IF c("var/macos"); @@ -305,9 +312,9 @@ ELSE; END; %] -[% IF c("var/linux") %] +[% IF c("var/linux") -%] /var/tmp/dist/gcc/bin/g++ $rootdir/abicheck.cc -o Browser/abicheck -std=c++17 - [% IF !c("var/torbrowser") %] + [% IF !c("var/torbrowser") -%] libdest=Browser/libstdc++ mkdir -p "$libdest" # FIXME: tor-browser-build#40749 @@ -316,32 +323,37 @@ END; cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libasan.so.* "$libdest" cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libubsan.so.* "$libdest" [% END -%] - [% END %] -[% END %] + [% END -%] +[% END -%] [% c('tar', { tar_src => [ browserdir ], tar_args => '-caf ' _ dest_dir _ '/' _ c('filename') _ '/browser.tar.' _ c('compress_tar'), }) %] -[% IF c("var/linux-x86_64") %] -[% c('tar', { - tar_src => [ 'Debug' ], - tar_args => '-cJf ' _ dest_dir _ '/' _ c('filename') _ '/browser-debug.tar.xz', +[% IF c("var/linux") -%] + [% c('tar', { + tar_src => [ 'Debug' ], + tar_args => '-cJf ' _ dest_dir _ '/' _ c('filename') _ '/browser-debug.tar.xz', }) %] - [% IF !c("var/asan") %] + [% IF c("var/linux-x86_64") && !c("var/asan") -%] [% c('tar', { - tar_src => [ 'geckodriver' ], - tar_args => '-cJf ' _ dest_dir _ '/' _ c('filename') _ '/geckodriver-linux64.tar.xz', - }) %] - [% END %] -[% END %] + tar_src => [ 'geckodriver' ], + tar_args => '-cJf ' _ dest_dir _ '/' _ c('filename') _ '/geckodriver.tar.xz', + }) %] + [% END -%] +[% ELSIF c("var/windows") -%] + [% c('zip', { + zip_src => [ 'Debug' ], + zip_args => dest_dir _ '/' _ c('filename') _ '/browser-debug.zip', + }) %] +[% END -%] [% IF c("var/updater_enabled") -%] [% c('zip', { - zip_src => [ 'mar-tools' ], - zip_args => dest_dir _ '/' _ c('filename') _ '/' _ c('var/martools_filename'), - }) %] + zip_src => [ 'mar-tools' ], + zip_args => dest_dir _ '/' _ c('filename') _ '/' _ c('var/martools_filename'), + }) %] [% END -%] [% IF c("var/build_infos_json") -%] View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 3 commits: Bug 40906: Add var/essential_deps
by Pier Angelo Vendrame (＠pierov) 26 Jul '23

26 Jul '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 57b1477a by Nicolas Vigier at 2023-07-25T10:43:49+02:00 Bug 40906: Add var/essential_deps var/essential_deps is the same as var/deps, except that we never redefine it in projects config. This is for the packages we want to include in every container (even those of projects where we redefine var/deps). - - - - - 3eaf5abb by Nicolas Vigier at 2023-07-25T10:48:28+02:00 Bug 40596: Switch compress_tar from gz to zst (for builds targeting non-linux) The version of tar in stretch does not know how to extract tar.zst files, so we don't switch to zst for linux builds yet. - - - - - a9d745a2 by Nicolas Vigier at 2023-07-25T10:48:35+02:00 Bug 40596: Compress some build artifacts using zst (for builds targeting non-linux) - - - - - 30 changed files: - README - projects/aiohttp/build - projects/aiohttp/config - projects/aiohttp_socks/build - projects/aiohttp_socks/config - projects/aiorpcx/build - projects/aiorpcx/config - projects/android-components/build - projects/application-services/build - projects/application-services/config - projects/async_timeout/build - projects/async_timeout/config - projects/attr/build - projects/attr/config - projects/binutils/build - projects/binutils/config - projects/browser/build - projects/browser/config - projects/cbindgen/build - projects/cbindgen/config - projects/cctools/build - projects/cctools/config - projects/certifi/build - projects/certifi/config - projects/chardet/build - projects/chardet/config - projects/clang/build - projects/clang/config - projects/cmake/build - projects/cmake/config The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.1.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 25 Jul '23

25 Jul '23

Pier Angelo Vendrame pushed new branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-102.14.0esr-12.5-1
by ma1 (＠ma1) 24 Jul '23

24 Jul '23

ma1 pushed new branch tor-browser-102.14.0esr-12.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-102.14.0esr-12.5-1
by ma1 (＠ma1) 24 Jul '23

24 Jul '23

ma1 pushed new branch base-browser-102.14.0esr-12.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-13.0a1-build2
by richard (＠richard) 24 Jul '23

24 Jul '23

richard pushed new tag mb-13.0a1-build2 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Fix mullvad-browser incrementals and create a build2
by ma1 (＠ma1) 24 Jul '23

24 Jul '23

ma1 pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: a1be4abe by Richard Pospesel at 2023-07-24T17:44:56+00:00 Fix mullvad-browser incrementals and create a build2 - - - - - 1 changed file: - rbm.conf Changes: ===================================== rbm.conf ===================================== @@ -262,8 +262,9 @@ targets: exe_name: mullvadbrowser mar_channel_id: '[% c("var/projectname") %]-mullvad-[% c("var/channel") %]' locales: [] + torbrowser_build: 'build2' torbrowser_incremental_from: - - 12.5a6 + - 12.5a7 torbrowser-testbuild: - testbuild View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_102_14_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 24 Jul '23

24 Jul '23

Pier Angelo Vendrame pushed new tag FIREFOX_102_14_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_1_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 24 Jul '23

24 Jul '23

Pier Angelo Vendrame pushed new tag FIREFOX_115_1_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-13.0a1-build1
by richard (＠richard) 24 Jul '23

24 Jul '23

richard pushed new tag mb-13.0a1-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.0a1-build1
by richard (＠richard) 24 Jul '23

24 Jul '23

richard pushed new tag tbb-13.0a1-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40848, 40873: Prepare Tor and Mullvad Browser 13.0a1
by richard (＠richard) 24 Jul '23

24 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 93c60f6e by Richard Pospesel at 2023-07-21T16:58:27+00:00 Bug 40848, 40873: Prepare Tor and Mullvad Browser 13.0a1 - - - - - 9 changed files: - projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/config - projects/firefox/config - projects/go/config - projects/manual/config - projects/openssl/config - projects/tor/config - projects/translation/config Changes: ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -0,0 +1,74 @@ +Mullvad Browser 13.0a1 - July 20 2023 + * All Platforms + * Updated NoScript to 11.4.25 + * Updated uBlock Origin to 1.50.0 + * Updated mullvad-browser-extension to 0.8.3 + * Updated Firefox to 115.0.2esr + * Bug 166: Enable built-in URL anti-tracking query parameters stripping [mullvad-browser] + * Bug 183: Rebase Mullvad Browser to Firefox 115 [mullvad-browser] + * Bug 213: Add search engines to the default list [mullvad-browser] + * Bug 214: Enable cross-tab identity leak protection in "quiet" mode [mullvad-browser] + * Bug 26277: When "Safest" setting is enabled searching using duckduckgo should always use the Non-Javascript site for searches [tor-browser] + * Bug 33955: Selecting "Copy image" from menu leaks the source URL to the clipboard. This data is often dereferenced by other applications. [tor-browser] + * Bug 41759: Rebase Base Browser to 115 nightly [tor-browser] + * Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons [tor-browser] + * Bug 41854: Download Spam Protection cannot be overridden to allow legitimate downloads [tor-browser] + * Bug 41874: Visual & A11 regressions in add-on badges [tor-browser] + * Windows + * Bug 41806: Prevent Private Browsing start menu item to be added automatically [tor-browser] + * Build System + * All Platforms + * Bug 40089: Clean up usage of get-moz-build-date script [tor-browser-build] + * Bug 40410: Get rid of python2 [tor-browser-build] + * Bug 40487: Bump Python version [tor-browser-build] + * Bug 40802: Drop the patch for making WASI reproducible [tor-browser-build] + * Bug 40836: Update do-all-signing script to also deploy mullvad-browser installer bins to dist.torproject.org [tor-browser-build] + * Bug 40868: Bump Rust to 1.69.0 [tor-browser-build] + * Bug 40881: do-all-signing is asking for nssdb7 password when signing mullvadbrowser [tor-browser-build] + * Bug 40882: Fix static-update-component command in issue_templates [tor-browser-build] + * Bug 40886: Update README with instructions for Arch linux [tor-browser-build] + * Bug 40889: Add mullvad sha256sums URL to tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo [tor-browser-build] + * Bug 40894: Fix format of keyring/boklm.gpg [tor-browser-build] + * Bug 40898: Add doc from tor-browser-spec/processes/ReleaseProcess to gitlab issue templates [tor-browser-build] + * Windows + * Bug 40832: Unify mingw-w64-clang 32+64 bits [tor-browser-build] + * Linux + * Bug 40102: Move from Debian Jessie to Debian Stretch for our Linux builds [tor-browser-build] + +Mullvad Browser 12.5.1 - July 5 2023 + * All Platforms + * Updated Firefox to 102.13.0esr + * Bug 192: Rebase Mullvad Browser 12.5 stable on top of 102.13esr [mullvad-browser] + * Bug 41854: Download Spam Protection cannot be overridden to allow legitimate downloads [tor-browser] + +Mullvad Browser 12.5 - June 21 2023 + * All Platforms + * Updated uBlock Origin to 1.50.0 + * Updated mullvad-browser-extension to version 0.8.3 + * Windows + macOS + Linux + * Bug 41577: Disable profile migration [tor-browser] + * Bug 41595: Disable pagethumbnails capturing [tor-browser] + * Bug 41609: Move the disabling of Firefox Home (Activity Stream) to base-browser [tor-browser] + * Bug 41668: Move part of the updater patches to base browser [tor-browser] + * Bug 41686: Move the 'Bug 11641: Disable remoting by default' commit from base-browser to tor-browser [tor-browser] + * Bug 41695: Port warning on maximized windows without letterboxing from torbutton [tor-browser] + * Bug 41701: Reporting an extension does not work [tor-browser] + * Bug 41711: Race condition when opening a new window in New Identity [tor-browser] + * Bug 41736: Customize the default CustomizableUI toolbar using CustomizableUI.jsm [tor-browser] + * Bug 41738: Replace the patch to disable live reload with its preference [tor-browser] + * Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp [tor-browser] + * Windows + Linux + * Bug 41654: UpdateInfo jumped into Data [tor-browser] + * Linux + * Bug 40860: Improve the transition from the old fontconfig file to the new one [tor-browser-build] + * Bug 41163: Many bundled fonts are blocked in Ubuntu/Fedora because of RFP [tor-browser] + * Bug 41732: implement linux font whitelist as defense-in-depth [tor-browser] + * Build System + * All Platforms + * Bug 40837: Rebase mullvad-browser build changes onto main [tor-browser-build] + * Bug 40870: Remove url without browser name from tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo [tor-browser-build] + * Windows + macOS + Linux + * Bug 40826: Correctly set appname_marfile for basebrowser in tools/signing/nightly/update-responses-base-config.yml [tor-browser-build] + * Bug 40866: Remove `Using ansible to set up a nightly build machine` from README [tor-browser-build] + * macOS + * Bug 40858: Create script to assist testers self sign Mac builds to allow running on Arm processors [tor-browser-build] ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,239 @@ +Tor Browser 13.0a1 - July 20 2023 + * All Platforms + * Updated Translations + * Updated NoScript to 11.4.25 + * Updated OpenSSL to 3.0.9 + * Updated Go to 1.20.6 + * Updated tor to 0.4.8.2-alpha + * Bug 40577: Add "suggest url" in DDG onion's manifest [tor-browser] + * Bug 40885: Bump version of snowflake to v2.6.0 [tor-browser-build] + * Bug 40887: Update Webtunnel version to 38eb5505 [tor-browser-build] + * Bug 41092: Enable tracking query parameters stripping [tor-browser] + * Bug 41399: Update Mozilla's patch for Bug 1675054 to enable brotli encoding for HTTP onions as well [tor-browser] + * Bug 41759: Rebase Base Browser to 115 nightly [tor-browser] + * Bug 41796: Rebase Tor Browser to Firefox 115 [tor-browser] + * Windows + macOS + Linux + * Updated Firefox to 115.0.2esr + * Bug 26277: When "Safest" setting is enabled searching using duckduckgo should always use the Non-Javascript site for searches [tor-browser] + * Bug 33955: Selecting "Copy image" from menu leaks the source URL to the clipboard. This data is often dereferenced by other applications. [tor-browser] + * Bug 41741: Refactor the domain isolator and new circuit [tor-browser] + * Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons [tor-browser] + * Bug 41842: Remove the old removal logics from Torbutton [tor-browser] + * Bug 41845: Stop forcing (bad) pref values for non-PBM users [tor-browser] + * Bug 41854: Download Spam Protection cannot be overridden to allow legitimate downloads [tor-browser] + * Bug 41874: Visual & A11 regressions in add-on badges [tor-browser] + * Build System + * All Platforms + * Bug 40089: Clean up usage of get-moz-build-date script [tor-browser-build] + * Bug 40410: Get rid of python2 [tor-browser-build] + * Bug 40487: Bump Python version [tor-browser-build] + * Bug 40802: Drop the patch for making WASI reproducible [tor-browser-build] + * Bug 40854: Update to OpenSSL 3.0 [tor-browser-build] + * Bug 40855: Update toolchains for Mozilla 115 [tor-browser-build] + * Bug 40868: Bump Rust to 1.69.0 [tor-browser-build] + * Bug 40886: Update README with instructions for Arch linux [tor-browser-build] + * Bug 40889: Add mullvad sha256sums URL to tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo [tor-browser-build] + * Bug 40894: Fix format of keyring/boklm.gpg [tor-browser-build] + * Bug 40898: Add doc from tor-browser-spec/processes/ReleaseProcess to gitlab issue templates [tor-browser-build] + * Windows + * Bug 40832: Unify mingw-w64-clang 32+64 bits [tor-browser-build] + * Linux + * Bug 40102: Move from Debian Jessie to Debian Stretch for our Linux builds [tor-browser-build] + +Tor Browser 12.5.1 - July 5 2023 + * All Platforms + * Updated Translations + * Updated NoScript to 11.4.24 + * Bug 41860: Rebase 12.5 stable to 102.13esr [tor-browser] + * Windows + macOS + Linux + * Updated Firefox to 102.13.0esr + * Bug 41854: Download Spam Protection cannot be overridden to allow legitimate downloads [tor-browser] + * Bug 41856: Onion service authorization prompt's key field does not get focus when clicked [tor-browser] + * Bug 41858: 'Learn more' link in onboarding links to 12.0 release notes and not 12.5 [tor-browser] + * Android + * Updated GeckoView to 102.13.0esr + +Tor Browser 12.5.0 - June 15 2023 + * All Platforms + * Updated Translations + * Bug 40353: Re-enable rlbox [tor-browser-build] + * Bug 40711: Review and expand the stakeholders we communicate major changes to [tor-browser-build] + * Bug 40810: Add Finnish (fi) language support [tor-browser-build] + * Bug 40817: Add basebrowser-incrementals-nightly makefile target [tor-browser-build] + * Bug 40833: base-browser nightly is using the default channel instead of nightly [tor-browser-build] + * Bug 40860: Improve the transition from the old fontconfig file to the new one [tor-browser-build] + * Bug 41066: Circuit Isolation should take containers into account [tor-browser] + * Bug 41351: Move the crypto protection patch earlier in the patchset [tor-browser] + * Bug 41428: Check if we can create our own directories for branding [tor-browser] + * Bug 41514: eslint broken since migrating torbutton [tor-browser] + * Bug 41568: Disable LaterRun [tor-browser] + * Bug 41599: about:networking#networkid should be normalized [tor-browser] + * Bug 41624: Disable unused about: pages [tor-browser] + * Bug 41635: Disable the Normandy component at compile time [tor-browser] + * Bug 41636: Disable back webextension.storage.sync after ensuring NoScript settings won't be lost [tor-browser] + * Bug 41647: Turn --enable-base-browser in --with-base-browser-version [tor-browser] + * Bug 41662: Disable about:sync-logs [tor-browser] + * Bug 41671: Turn media.peerconnection.ice.relay_only to true as defense in depth against WebRTC ICE leaks [tor-browser] + * Bug 41689: Remove startup.homepage_override_url from Base Browser [tor-browser] + * Bug 41704: Immediately return on remoteSettings.pollChanges [tor-browser] + * Bug 41738: Replace the patch to disable live reload with its preference [tor-browser] + * Bug 41763: TTP-02-003 WP1: Data URI allows JS execution despite safest security level (Low) [tor-browser] + * Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp [tor-browser] + * Bug 41818: Remove YEC 2022 strings [tor-browser] + * Windows + macOS + Linux + * Bug 165: Fix maximization warning x button and preference [mullvad-browser] + * Bug 20497: Improve support for non-portable mode [tor-browser] + * Bug 33298: HTTP onion sites do not give a popup warning when submitting form data to non-onion HTTP sites [tor-browser] + * Bug 40144: about:privatebrowsing Firefox branding [tor-browser] + * Bug 40347: URL bar lock icon says connection is not secure when on "view-source:[...].onion" URLs [tor-browser] + * Bug 40552: New texts for the add a bridge manually modal [tor-browser] + * Bug 40701: Improve security warning when downloading a file [tor-browser] + * Bug 40733: Use the new branding directories [tor-browser-build] + * Bug 40745: Allow customizing MOZ_APP_BASENAME [tor-browser-build] + * Bug 40773: Copy some documentation files only on Tor Browser [tor-browser-build] + * Bug 40781: Move translations to new paths [tor-browser-build] + * Bug 40788: Tor Browser 11.0.4-11.0.6 phoning home [tor-browser] + * Bug 40808: Set update URL for nightly base-browser [tor-browser-build] + * Bug 40811: Make testing the updater easier [tor-browser-build] + * Bug 40958: The number of relays displayed for an onion site can be misleading [tor-browser] + * Bug 41038: Update "Click to Copy" button label in circuit display [tor-browser] + * Bug 41080: Some users are choosing an adjacent country for circumvention settings [tor-browser] + * Bug 41084: Reserve red as a button color for dangerous actions [tor-browser] + * Bug 41085: Refactor the UI to remove all bridges [tor-browser] + * Bug 41093: Users don't understand the purpose of bridge-moji [tor-browser] + * Bug 41109: "New circuit..." button gets cut-off when onion name wraps [tor-browser] + * Bug 41350: Move the implementation of Bug 19273 out of Torbutton [tor-browser] + * Bug 41363: Crypto warning popup is not screen reader accessible [tor-browser] + * Bug 41448: User 'danger' style for primary button in new identity modal [tor-browser] + * Bug 41483: Tor Browser says Firefox timed out, confusing users [tor-browser] + * Bug 41503: Disable restart in case of reboot and restore in case of crash [tor-browser] + * Bug 41521: Improve localization notes [tor-browser] + * Bug 41533: Page Info window for view-source:http://...onion addresses says Connection Not Encrypted [tor-browser] + * Bug 41540: Confusing build-id date in about:preferences in alphas [tor-browser] + * Bug 41562: API-triggered fullscreen after F11 causes letterboxing to crop the page [tor-browser] + * Bug 41577: Disable profile migration [tor-browser] + * Bug 41587: Disable the updater for Base Browser [tor-browser] + * Bug 41595: Disable pagethumbnails capturing [tor-browser] + * Bug 41600: Some users have difficulty finding the circuit display [tor-browser] + * Bug 41607: Update "New Circuit" icon [tor-browser] + * Bug 41608: Improve the UX of the location bar's connection status [tor-browser] + * Bug 41609: Move the disabling of Firefox Home (Activity Stream) to base-browser [tor-browser] + * Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs (no hostname, e.g. RFC3966 tel:) [tor-browser] + * Bug 41617: Improve the UX of the built-in bridges dialog [tor-browser] + * Bug 41618: Update the iconography used in the status strip in connection settings [tor-browser] + * Bug 41623: Update connection assist's iconography [tor-browser] + * Bug 41633: Updating from 12.0.2 to 12.0.3 resets NoScript settings [tor-browser] + * Bug 41657: Remove --enable-tor-browser-data-outside-app-dir [tor-browser] + * Bug 41668: Move part of the updater patches to base browser [tor-browser] + * Bug 41686: Move the 'Bug 11641: Disable remoting by default' commit from base-browser to tor-browser [tor-browser] + * Bug 41695: Port warning on maximized windows without letterboxing from torbutton [tor-browser] + * Bug 41699: Tighten up the tor onion alias regular expression [tor-browser] + * Bug 41701: Reporting an extension does not work [tor-browser] + * Bug 41702: The connection pill needs to be centered vertically [tor-browser] + * Bug 41709: sendCommand should not try to send a command forever [tor-browser] + * Bug 41711: Race condition when opening a new window in New Identity [tor-browser] + * Bug 41718: Add the external filetype warning to about:downloads [tor-browser] + * Bug 41719: Update title and button strings in the new circuit display to sentence case [tor-browser] + * Bug 41725: Stray connectionPane.xhtml patch [tor-browser] + * Bug 41726: Animate the torconnect icon to transition between connected states [tor-browser] + * Bug 41734: Add a 'Connected' flag to indicate which built-in bridge option Tor Browser is currently using [tor-browser] + * Bug 41736: Customize the default CustomizableUI toolbar using CustomizableUI.jsm [tor-browser] + * Bug 41749: Replace the onion-glyph with dedicated icon for onion services [tor-browser] + * Bug 41770: Keyboard navigation broken leaving the toolbar tor circuit button [tor-browser] + * Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp [tor-browser] + * Bug 41785: Network monitor in developer tools shows HTTP onion resources as insecure [tor-browser] + * Bug 41792: Drag and Drop protection prevents dragging downloads [tor-browser] + * Bug 41800: Add the external filetype warning to Library / Manage Bookmarks [tor-browser] + * Bug 41801: Fix handleProcessReady in TorSettings.init [tor-browser] + * Bug 41802: Bad regex used to extract transport from bridgeline [tor-browser] + * Bug 41810: Add "Connect" buttons to Request Bridge and Provide Bridge modals [tor-browser] + * Bug 41816: The top navigation in about:torconnect isn't updated correctly [tor-browser] + * Bug 41841: Use the new onion-site.svg icon in the onion-location pill [tor-browser] + * Windows + Linux + * Bug 40714: Ship NoScript in the distribution directory also for Windows and Linux [tor-browser-build] + * Bug 41654: UpdateInfo jumped into Data [tor-browser] + * Windows + * Bug 40772: Check and fix HiDPI issues in the NSIS installer [tor-browser-build] + * Bug 40793: Add some metadata also to the Windows installer [tor-browser-build] + * Bug 40801: Correct the ExecShell for system-wide installs in the NSIS script [tor-browser-build] + * Bug 41459: WebRTC fails to build under mingw [tor-browser] + * Bug 41678: WebRTC build fix patches incorrectly defining pid_t [tor-browser] + * Bug 41806: Prevent Private Browsing start menu item to be added automatically [tor-browser] + * macOS + * Bug 40719: Allow non-universal macOS builds also on base-browser [tor-browser-build] + * Bug 41535: Remove the old, unused and undocumented "-invisible" macOS CLI flag [tor-browser] + * Linux + * Bug 40830: The fontconfig directory is missing in Base Browser [tor-browser-build] + * Bug 41163: Many bundled fonts are blocked in Ubuntu/Fedora because of RFP [tor-browser] + * Bug 41732: implement linux font whitelist as defense-in-depth [tor-browser] + * Android + * Bug 41001: Remove remaining security slider code [tor-browser] + * Bug 41185: Hide learn more about sync [tor-browser] + * Bug 41634: Google Play incorrectly detects that libTor.so is built with OpenSSL 1.1.1b [tor-browser] + * Bug 41667: Enable media.peerconnection.ice.obfuscate_host_addresses on Android for defense-in-depth [tor-browser] + * Bug 41677: Remove the --disable-tor-browser-update flag on Android [tor-browser] + * Build System + * All Platforms + * Updated Go to 1.20.5 + * Bug 40673: Avoid building each go module separately [tor-browser-build] + * Bug 40679: Use the latest translations for nightly builds [tor-browser-build] + * Bug 40689: Update Ubuntu version from projects/mmdebstrap-image/config to 22.04.1 [tor-browser-build] + * Bug 40717: Create a script to prepare changelogs [tor-browser-build] + * Bug 40720: Update fetch-changelogs.py scripts to support new Build System label [tor-browser-build] + * Bug 40750: Find why rlbox hurts reproducibility [tor-browser-build] + * Bug 40751: make signtag-* needs to take project name into account [tor-browser-build] + * Bug 40753: We should not copy mar tools when the updater is disabled [tor-browser-build] + * Bug 40760: Add BSD packager contacts to release prep templates [tor-browser-build] + * Bug 40763: Add support for signing multiple browsers in tools/signing/nightly [tor-browser-build] + * Bug 40783: Update download-unsigned-sha256sums-gpg-signatures-from-people-tpo to use $projectname prefix directory [tor-browser-build] + * Bug 40784: Fix var_p/nightly_torbrowser_incremental_from after #40737 [tor-browser-build] + * Bug 40794: Include the build-id in firefox-l10n output name [tor-browser-build] + * Bug 40795: Trim down tor-browser-build release prep issue templates [tor-browser-build] + * Bug 40796: Bad UX for the changelogs script when using the issue number [tor-browser-build] + * Bug 40805: Define the version flag for all browsers [tor-browser-build] + * Bug 40807: Add config for signing base-browser nightly in tools/signing/nightly [tor-browser-build] + * Bug 40812: Make var/rezip in projects/firefox/config quiet [tor-browser-build] + * Bug 40818: Enable wasm target for rust compiler [tor-browser-build] + * Bug 40828: Use http://archive.debian.org/debian-archive/ for jessie [tor-browser-build] + * Bug 40837: Rebase mullvad-browser build changes onto main [tor-browser-build] + * Bug 40870: Remove url without browser name from tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo [tor-browser-build] + * Bug 41649: Create rebase and security backport gitlab issue templates [tor-browser] + * Bug 41682: Add base-browser nightly mar signing key [tor-browser] + * Windows + macOS + Linux + * Bug 33953: Provide a way for easily updating Go dependencies of projects [tor-browser-build] + * Bug 40713: Use the new tor-browser l10n branch in Firefox [tor-browser-build] + * Bug 40777: Create a Go bootstrap project [tor-browser-build] + * Bug 40778: Disable all translations with testbuilds in Firefox [tor-browser-build] + * Bug 40788: Remove all languages but en-US for privacy-browser build target [tor-browser-build] + * Bug 40809: Remove --enable-tor-browser-update and --enable-verify-mar from projects/firefox/mozconfig [tor-browser-build] + * Bug 40813: Enable var/updater_enabled for basebrowser nightly [tor-browser-build] + * Bug 40823: Update appname_* variables in projects/release/update_responses_config.yml [tor-browser-build] + * Bug 40826: Correctly set appname_marfile for basebrowser in tools/signing/nightly/update-responses-base-config.yml [tor-browser-build] + * Bug 40827: MAR generation uses (mostly) hard-coded MAR update channel [tor-browser-build] + * Bug 40841: Adapt signing scripts to new signing machines [tor-browser-build] + * Bug 40849: Move Go dependencies to the projects dependent on them, not as a standalone projects [tor-browser-build] + * Bug 40866: Remove `Using ansible to set up a nightly build machine` from README [tor-browser-build] + * Bug 40869: obfs4 is renamed to lyrebird [tor-browser-build] + * Windows + * Bug 29185: NSIS Installer not reproducible when icon has an alpha channel [tor-browser-build] + * Bug 40757: Change projects/browser/windows-installer/torbrowser.nsi to a template file [tor-browser-build] + * Windows + macOS + Linux + * Bug 40732: Review Bundle-Data and try not to ship the default profile in base browser [tor-browser-build] + * Linux + Android + * Bug 40653: Build compiler-rt with runtimes instead of the main LLVM build [tor-browser-build] + * macOS + * Bug 40792: signing scripts missing project name prefix to make rule [tor-browser-build] + * Bug 40798: dmg2mar step also takes care of copying the signed+stabled dmg to the signed directory [tor-browser-build] + * Bug 40806: Update the reference to the macOS mozconfig [tor-browser-build] + * Bug 40824: dmg2mar script using hardcoded project names for paths [tor-browser-build] + * Bug 40847: Build filesystem influences the DMG creation [tor-browser-build] + * Bug 40858: Create script to assist testers self sign Mac builds to allow running on Arm processors [tor-browser-build] + * Bug 41453: Rename mozconfig-macos-x86_64 to mozconfig-macos [tor-browser] + * Android + * Bug 40738: Update Android git hashes templates [tor-browser-build] + * Bug 40874: Add commit information also to GV [tor-browser-build] + * Bug 41684: Android improvements for local dev builds [tor-browser] + Tor Browser 12.5a7 - June 08 2023 * All Platforms * Updated Translations ===================================== projects/browser/config ===================================== @@ -103,16 +103,16 @@ input_files: enable: '[% ! c("var/android") %]' - filename: Bundle-Data enable: '[% ! c("var/android") %]' - - URL: https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.… + - URL: https://addons.mozilla.org/firefox/downloads/file/4136347/noscript-11.4.25.… name: noscript - sha256sum: 46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e - - URL: https://addons.mozilla.org/firefox/downloads/file/4103048/ublock_origin-1.4… + sha256sum: 36b44a4af8b57188db230c29284dd64626611ee6b46fbf8ef3e352317fbf55aa + - URL: https://addons.mozilla.org/firefox/downloads/file/4121906/ublock_origin-1.5… name: ublock-origin - sha256sum: 39266486f720cd31d291d2fdad78625b079782a05517e1936eec7e780bc2a84d + sha256sum: 10618003e70b528c3f17996e373146d39e6b15f777ac4ca1f214da2ffdb7a5b3 enable: '[% c("var/mullvad-browser") %]' - - URL: https://github.com/mullvad/browser-extension/releases/download/v0.7.9-firef… + - URL: https://github.com/mullvad/browser-extension/releases/download/v0.8.3-firef… name: mullvad-extension - sha256sum: 17ce31b32e8be0f0db86a5a5ed93607cc84d5e2092341aee0b8eaba1c0746390 + sha256sum: e531ce6e809091eb40848874ea9e695bce61196397b6d8238ab582a152e02ac7 enable: '[% c("var/mullvad-browser") %]' - filename: 'gtk3-settings.ini' enable: '[% c("var/linux") %]' ===================================== projects/firefox/config ===================================== @@ -15,7 +15,7 @@ var: firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '13.0' browser_branch: '[% c("var/browser_series") %]-1' - browser_build: 1 + browser_build: 3 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' @@ -84,7 +84,7 @@ targets: git_url: https://gitlab.torproject.org/tpo/applications/mullvad-browser.git var: branding_directory_prefix: 'mb' - browser_build: 1 + browser_build: 2 gitlab_project: https://gitlab.torproject.org/tpo/applications/mullvad-browser linux-x86_64: ===================================== projects/go/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 1.20.5 +version: 1.20.6 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' container: use_container: 1 @@ -119,7 +119,7 @@ input_files: enable: '[% ! c("var/linux") %]' - URL: 'https://golang.org/dl/go[% c("version") %].src.tar.gz' name: go - sha256sum: 9a15c133ba2cfafe79652f4815b62e7cfc267f68df1b9454c6ab2a3ca8b96a88 + sha256sum: 62ee5bc6fb55b8bae8f705e0cb8df86d6453626b4ecf93279e2867092e0b7f70 - project: go-bootstrap name: go-bootstrap target_replace: ===================================== projects/manual/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! -version: 79869 +version: 88998 filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.gz' container: use_container: 1 @@ -17,8 +17,8 @@ var: input_files: - project: container-image - - URL: 'https://people.torproject.org/~pierov/tbb_files/manual_[% c("version") %].zip' + - URL: 'https://people.torproject.org/~richard/tbb_files/manual_[% c("version") %].zip' name: manual - sha256sum: ee4c6e4ce4998736ae44dc3e6f92875a481b9e03860517764ea9af6c2bba24e0 + sha256sum: 1be6cf35a3c9f243998b7611e9531d4a99591cc257cb55f3924f504b9ead71a7 - filename: packagemanual.py name: package_script ===================================== projects/openssl/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 3.0.8 +version: 3.0.9 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' container: use_container: 1 @@ -33,4 +33,4 @@ input_files: - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' - URL: 'https://www.openssl.org/source/openssl-[% c("version") %].tar.gz' - sha256sum: 6c13d2bf38fdf31eac3ce2a347073673f5d63263398f1f69d0df4a41253e4b3e + sha256sum: eb1ab04781474360f77c318ab89d8c5a03abc38e63d65a603cabbf1b00a1dc90 ===================================== projects/tor/config ===================================== @@ -1,6 +1,6 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' -version: 0.4.7.13 +version: 0.4.8.2-alpha git_hash: 'tor-[% c("version") %]' git_url: https://gitlab.torproject.org/tpo/core/tor.git git_submodule: 1 ===================================== projects/translation/config ===================================== @@ -6,19 +6,19 @@ version: '[% c("abbrev") %]' steps: base-browser: base-browser: '[% INCLUDE build %]' - git_hash: 0a429fd14e8ebe9edcdbaac933c86b4bac8fcb19 + git_hash: 060d9d04b3a4c3e0f09f3f5fa8ad3ab12e2f4e80 targets: nightly: git_hash: 'base-browser' base-browser-fluent: base-browser-fluent: '[% INCLUDE build %]' - git_hash: c68657f80050975474903f170250e2888c2a1fea + git_hash: 6f64004400616a5956d1823a0e8176b60d212090 targets: nightly: git_hash: 'basebrowser-newidentityftl' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 0cd2ac8d14ce4acd8c9781376a9fdcb9c8323b91 + git_hash: d8d2b8f3200aa309f44f2fa80625ff8e6a25bb78 targets: nightly: git_hash: 'tor-browser' @@ -26,7 +26,7 @@ steps: fenix: '[% INCLUDE build %]' # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. - git_hash: 1b094bdfaa444d31f06fe7c0261de89ae67083cc + git_hash: e037147c72348192ddd38c2a21712c65031b912c targets: nightly: git_hash: 'fenix-torbrowserstringsxml' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.0.2esr-13.0-1-build2
by richard (＠richard) 21 Jul '23

21 Jul '23

richard pushed new tag base-browser-115.0.2esr-13.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.0.2esr-13.0-1-build3
by richard (＠richard) 21 Jul '23

21 Jul '23

richard pushed new tag tor-browser-115.0.2esr-13.0-1-build3 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0.2esr-13.0-1] Revert "fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js"
by richard (＠richard) 21 Jul '23

21 Jul '23

richard pushed to branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 93ef5b2d by Richard Pospesel at 2023-07-21T16:49:26+00:00 Revert "fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js" This reverts commit da33ad3bc03cc015d404b6907978a82585518259. - - - - - 1 changed file: - browser/app/profile/000-tor-browser.js Changes: ===================================== browser/app/profile/000-tor-browser.js ===================================== @@ -74,23 +74,28 @@ pref("extensions.torlauncher.quickstart", false); pref("extensions.torlauncher.max_tor_log_entries", 1000); -// On Linux and macOS, Tor Browser can use IPC for the communication with the -// tor daemon, and this is the preferred way. -// You can set the path of the Unix sockets with control_ipc_path. -// If a relative one is provided, it is handled like torrc_path (see below). -// Tor Browser on Windows will use TCP (and it can be used also on Linux and -// macOS, if preferred). -// Host and port can be customized with control_host and control_port. -// This applies both to the control port and to the SOCKS port, but their -// configurations are completely independent. -pref("extensions.torlauncher.control_port_use_ipc", true); -pref("extensions.torlauncher.control_ipc_path", ""); +// By default, Tor Launcher configures a TCP listener for the Tor +// control port, as defined by control_host and control_port. +// Set control_port_use_ipc to true to use an IPC object (e.g., a Unix +// domain socket) instead. You may also modify control_ipc_path to +// override the default IPC object location. If a relative path is used, +// it is handled like torrc_path (see below). pref("extensions.torlauncher.control_host", "127.0.0.1"); pref("extensions.torlauncher.control_port", 9151); -pref("extensions.torlauncher.socks_port_use_ipc", true); -pref("extensions.torlauncher.socks_ipc_path", ""); +pref("extensions.torlauncher.control_port_use_ipc", false); +pref("extensions.torlauncher.control_ipc_path", ""); + +// By default, Tor Launcher configures a TCP listener for the Tor +// SOCKS port. The host is taken from the network.proxy.socks pref and +// the port is taken from the network.proxy.socks_port pref. +// Set socks_port_use_ipc to true to use an IPC object (e.g., a Unix +// domain socket) instead. You may also modify socks_ipc_path to +// override the default IPC object location. If a relative path is used, +// it is handled like torrc_path (see below). // Modify socks_port_flags to use a different set of SocksPort flags (but be // careful). +pref("extensions.torlauncher.socks_port_use_ipc", false); +pref("extensions.torlauncher.socks_ipc_path", ""); pref("extensions.torlauncher.socks_port_flags", "ExtendedErrors IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth"); // The tor_path is relative to the application directory. On Linux and View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/93ef5b2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/93ef5b2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0.2esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 21 Jul '23

21 Jul '23

richard pushed to branch base-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f3faeb09 by Pier Angelo Vendrame at 2023-07-21T16:41:53+00:00 fixup! Firefox preference overrides. Bug 41806: Prevent Private Browsing start menu item to be automatically added. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -521,6 +521,10 @@ pref("browser.taskbar.lists.frequent.enabled", false); pref("browser.taskbar.lists.tasks.enabled", false); pref("browser.taskbar.lists.recent.enabled", false); +// tor-browser#41806: Prevent the browser from adding a new Private Browsing +// start menu item automatically +pref("browser.privacySegmentation.createdShortcut", true); + // Do not re-open the browser automatically after reboots when "Restart apps" is // enabled (tor-browser#41503) pref("toolkit.winRegisterApplicationRestart", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f3faeb0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f3faeb0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0.2esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 21 Jul '23

21 Jul '23

richard pushed to branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 024598ab by Pier Angelo Vendrame at 2023-07-21T16:10:37+02:00 fixup! Firefox preference overrides. Bug 41806: Prevent Private Browsing start menu item to be automatically added. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -521,6 +521,10 @@ pref("browser.taskbar.lists.frequent.enabled", false); pref("browser.taskbar.lists.tasks.enabled", false); pref("browser.taskbar.lists.recent.enabled", false); +// tor-browser#41806: Prevent the browser from adding a new Private Browsing +// start menu item automatically +pref("browser.privacySegmentation.createdShortcut", true); + // Do not re-open the browser automatically after reboots when "Restart apps" is // enabled (tor-browser#41503) pref("toolkit.winRegisterApplicationRestart", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/024598a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/024598a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.0.2esr-13.0-1-build2
by richard (＠richard) 20 Jul '23

20 Jul '23

richard pushed new tag tor-browser-115.0.2esr-13.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0.2esr-13.0-1] fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
by richard (＠richard) 20 Jul '23

20 Jul '23

richard pushed to branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: da33ad3b by Pier Angelo Vendrame at 2023-07-20T19:22:00+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 41872: Use IPC by default on Linux and macOS. The preference is flipped also for Windows, but it is actually ignored. - - - - - 1 changed file: - browser/app/profile/000-tor-browser.js Changes: ===================================== browser/app/profile/000-tor-browser.js ===================================== @@ -74,28 +74,23 @@ pref("extensions.torlauncher.quickstart", false); pref("extensions.torlauncher.max_tor_log_entries", 1000); -// By default, Tor Launcher configures a TCP listener for the Tor -// control port, as defined by control_host and control_port. -// Set control_port_use_ipc to true to use an IPC object (e.g., a Unix -// domain socket) instead. You may also modify control_ipc_path to -// override the default IPC object location. If a relative path is used, -// it is handled like torrc_path (see below). +// On Linux and macOS, Tor Browser can use IPC for the communication with the +// tor daemon, and this is the preferred way. +// You can set the path of the Unix sockets with control_ipc_path. +// If a relative one is provided, it is handled like torrc_path (see below). +// Tor Browser on Windows will use TCP (and it can be used also on Linux and +// macOS, if preferred). +// Host and port can be customized with control_host and control_port. +// This applies both to the control port and to the SOCKS port, but their +// configurations are completely independent. +pref("extensions.torlauncher.control_port_use_ipc", true); +pref("extensions.torlauncher.control_ipc_path", ""); pref("extensions.torlauncher.control_host", "127.0.0.1"); pref("extensions.torlauncher.control_port", 9151); -pref("extensions.torlauncher.control_port_use_ipc", false); -pref("extensions.torlauncher.control_ipc_path", ""); - -// By default, Tor Launcher configures a TCP listener for the Tor -// SOCKS port. The host is taken from the network.proxy.socks pref and -// the port is taken from the network.proxy.socks_port pref. -// Set socks_port_use_ipc to true to use an IPC object (e.g., a Unix -// domain socket) instead. You may also modify socks_ipc_path to -// override the default IPC object location. If a relative path is used, -// it is handled like torrc_path (see below). +pref("extensions.torlauncher.socks_port_use_ipc", true); +pref("extensions.torlauncher.socks_ipc_path", ""); // Modify socks_port_flags to use a different set of SocksPort flags (but be // careful). -pref("extensions.torlauncher.socks_port_use_ipc", false); -pref("extensions.torlauncher.socks_ipc_path", ""); pref("extensions.torlauncher.socks_port_flags", "ExtendedErrors IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth"); // The tor_path is relative to the application directory. On Linux and View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/da33ad3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/da33ad3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 7 commits: Bug 40854: Upgrade to OpenSSL 3
by Pier Angelo Vendrame (＠pierov) 20 Jul '23

20 Jul '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 85031e91 by Pier Angelo Vendrame at 2023-07-14T15:31:43+02:00 Bug 40854: Upgrade to OpenSSL 3 - - - - - b096b32e by Pier Angelo Vendrame at 2023-07-14T15:31:44+02:00 Bug 40487: Bump Python version to 3.11.3 Debian Stretch's Python version is still too old for some of the projects we need to build under it. So, since we needed to review the Python options we use anyway, we decided also to update it to a much more recent version. - - - - - 30db5fad by Pier Angelo Vendrame at 2023-07-14T15:31:44+02:00 Bug 40410: Get rid of python2 - - - - - 34d9e212 by Pier Angelo Vendrame at 2023-07-14T15:31:44+02:00 Bug 40802: Update the wasi-sdk and remove the patch to make it reproducible. We already uplifted the patch, and the new version includes it. - - - - - 4df7d971 by Pier Angelo Vendrame at 2023-07-20T14:05:54+02:00 Bug 40855: Update toolchains for Firefox 115 (common part) Toolchain updates needed for all platforms. Bug 31588 (partially): Create cargo vendor archives locally for cbindgen. The Rust crates we use provide a Cargo.lock. That should be enough to make sure they always use a certain version of a dependency. Therefore, with 115, we could try stop hosting vendor archives on people.tpo and build them locally. In this commit we do that for cbindgen. In next commit we could try to do so for also other projects. - - - - - 028d15c6 by Pier Angelo Vendrame at 2023-07-20T14:05:56+02:00 Bug 40855: Update toolchains for Firefox 115 (Windows part) Windows-only toolchain updates. Also, bug 40832: Unify mingw-w64-clang 32+64 bits The clang binaries used in the mingw-w64-clang artifacts were exactly the same, because Clang allows you to set the target at runtime with CLI options, contrarily to GCC, that allows you to set them at build time. Also, i686 and x86_64 parts that differ have different paths, so they can live in the same mingw-w64 installation. This allows us to save both time, and space on the out directory, since we can safely use only one archive for both platforms. Also, partially bug 40652: drop dependency on libssp. Libssp is not necessary anymore for _FORTIFY_SOURCE. So, we match llvm-mingw, and replace it with empty archives. In the future, we should stop creating these archives, too, when the compiler users stop including it during linking. - - - - - 838f290f by Pier Angelo Vendrame at 2023-07-20T14:05:56+02:00 Bug 40855: Update toolchains for Firefox 115 (macOS part) macOS-only toolchain updates. With this update, we stop downloading the macOS SDK from people.tpo. Instead, we download it from apple.com and we use the same scripts as Mozilla to extract it. We took them from Firefox source tree, and slightly adapted to our build system/containers/needs. Also, we try to be more similar to Mozilla in compiling LLVM runtimes. - - - - - 30 changed files: - Makefile - keyring/python.gpg - projects/browser/build - projects/browser/config - projects/browser/verify_allowed_addons.py - projects/cbindgen/build - projects/cbindgen/config - projects/clang/build - projects/clang/config - + projects/clang/use-fixed-chunk-size-for-uuid.patch - projects/cmake/config - projects/firefox/build - projects/firefox/config - projects/firefox/list_toolchain_updates_checks - projects/fxc2/config - projects/llvm-project/config - projects/macosx-toolchain/build - − projects/macosx-toolchain/compiler-rt-cross-compile.patch - − projects/macosx-toolchain/compiler-rt-no-codesign.patch - projects/macosx-toolchain/config - + projects/macosx-toolchain/macpkg.py - + projects/macosx-toolchain/mozbuild_util.py - + projects/macosx-toolchain/tools.diff - + projects/macosx-toolchain/unpack-sdk.py - projects/mingw-w64-clang/build - projects/mingw-w64-clang/config - − projects/mingw-w64-clang/libssp-Makefile - + projects/mingw-w64-clang/mingw-composition.patch - + projects/mingw-w64-clang/mingw-dispatchqueue.patch - projects/mingw-w64-clang/mingw-dwrite_3.patch The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0.2esr-13.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 20 Jul '23

20 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d23c9e12 by Pier Angelo Vendrame at 2023-07-20T14:43:16+02:00 fixup! Base Browser's .mozconfigs. Bug 41890: Let tor-browser-build set the update channel it prefers. Forgot to update the mozconfig-android-all in the previous commit. - - - - - 1 changed file: - mozconfig-android-all Changes: ===================================== mozconfig-android-all ===================================== @@ -11,10 +11,6 @@ if test -n "$LOCAL_DEV_BUILD"; then ac_add_options --enable-update-channel=default ac_add_options --without-wasm-sandboxed-libraries ac_add_options --with-base-browser-version=dev-build -else - # We want to have a similar fat .aar versioning as Mozilla and make it clear - # we are on the beta channel for GeckoView - ac_add_options --enable-update-channel=beta fi ac_add_options --with-java-bin-path=$JAVA_HOME/bin View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d23c9e1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d23c9e1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0.2esr-13.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 20 Jul '23

20 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f6a44953 by Pier Angelo Vendrame at 2023-07-19T08:44:48+02:00 fixup! Base Browser's .mozconfigs. Always use lld on Android. - - - - - 1 changed file: - browser/config/mozconfigs/base-browser-android Changes: ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -8,6 +8,7 @@ ac_add_options --enable-application=mobile/android CC="clang" CXX="clang++" +ac_add_options --enable-linker=lld ac_add_options --with-java-bin-path=$JAVA_HOME/bin ac_add_options --with-android-sdk=$ANDROID_HOME ac_add_options --with-android-ndk=$ANDROID_NDK_HOME View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f6a4495… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f6a4495… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40056: Improve error message when input file is missing
by richard (＠richard) 19 Jul '23

19 Jul '23

richard pushed to branch main at The Tor Project / Applications / RBM Commits: f40e2236 by Nicolas Vigier at 2023-07-19T12:25:47+02:00 Bug 40056: Improve error message when input file is missing - - - - - 1 changed file: - lib/RBM.pm Changes: ===================================== lib/RBM.pm ===================================== @@ -802,6 +802,7 @@ sub input_file_need_dl { sub input_file_id_hash { my ($fname, $filename) = @_; + exit_error "input_file_id: file $filename is missing" unless $fname; return $filename . ':' . sha256file($fname) if -f $fname; return $filename . ':' . sha256file(readlink $fname) if -l $fname; my @subdirs = sort(map { $_->basename } path($fname)->children); View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/f40e22360457a2d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/f40e22360457a2d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.0.2esr-13.0-1-build1
by Pier Angelo Vendrame (＠pierov) 19 Jul '23

19 Jul '23

Pier Angelo Vendrame pushed new tag base-browser-115.0.2esr-13.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.0.2esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 19 Jul '23

19 Jul '23

Pier Angelo Vendrame pushed new branch base-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.0.2esr-13.0-1-build1
by Pier Angelo Vendrame (＠pierov) 19 Jul '23

19 Jul '23

Pier Angelo Vendrame pushed new tag tor-browser-115.0.2esr-13.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0.2esr-13.0-1] 256 commits: Bug 1832523 - Allow using NSS to sign and verify MAR signatures....
by Pier Angelo Vendrame (＠pierov) 19 Jul '23

19 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d8ccf563 by Pier Angelo Vendrame at 2023-07-18T14:19:45+02:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 69870c5f by Henry Wilkes at 2023-07-18T14:19:46+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - bda88de6 by Henry Wilkes at 2023-07-18T14:19:46+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 9414d8bd by Pier Angelo Vendrame at 2023-07-18T14:19:47+02:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - f5b502cc by Pier Angelo Vendrame at 2023-07-18T14:19:47+02:00 fixup! Bug 41116: Normalize system fonts. Update to the latest proposal to upstream. It fixes build issues on macOS. - - - - - 125a26f0 by Pier Angelo Vendrame at 2023-07-18T14:19:48+02:00 fixup! Bug 41116: Normalize system fonts. ShouldResistFinterprinting now always wants a target. - - - - - 68a2ca7f by Marco Simonelli at 2023-07-18T14:19:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - d7acd8a4 by Marco Simonelli at 2023-07-18T14:19:49+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - b2cff032 by Pier Angelo Vendrame at 2023-07-18T14:19:49+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 2) Reworked the _com_error conversion to string, to use functions that are available also to mingw. - - - - - d88c6366 by Marco Simonelli at 2023-07-18T14:19:50+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 19c4aed5 by Marco Simonelli at 2023-07-18T14:19:50+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - c805ef2f by Pier Angelo Vendrame at 2023-07-18T14:19:50+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 4) Define _CRT_RAND_S as a compiler flag, to avoid problems due to unified sources. - - - - - ec0c0eea by Marco Simonelli at 2023-07-18T14:19:51+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 84048a02 by Marco Simonelli at 2023-07-18T14:19:51+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - cca1a2a3 by hackademix at 2023-07-18T14:25:49+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 61be96e0 by Gaba at 2023-07-18T14:25:51+02:00 Adding issue and merge request templates - - - - - 08ceef46 by Richard Pospesel at 2023-07-18T14:25:51+02:00 fixup! Adding issue and merge request templates - removed exta unneeded dashes - updated Backporting section to better match our desired process going forward: - discourage requests for backport to stable - provide justification for backport request from list proposed at last Tor meeting - added 'consistency' justification for patches/changes which can be difficult to context switch between but don't affect the final build output - added explicit merge destination selection - - - - - 204db329 by Richard Pospesel at 2023-07-18T14:25:52+02:00 fixup! Adding issue and merge request templates - - - - - f213a445 by Pier Angelo Vendrame at 2023-07-18T14:25:52+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 915cf735 by Pier Angelo Vendrame at 2023-07-18T14:25:53+02:00 fixup! Base Browser's .mozconfigs. Do not specify --{enable,disable}-verify-mar in mozconfigs, as this option does not exist anymore, and signed mars are enabled by default. - - - - - adeadb57 by Pier Angelo Vendrame at 2023-07-18T14:25:53+02:00 fixup! Base Browser's .mozconfigs. Use the new flag upstream to replace the Bug 41542 commit. - - - - - 9defa6d0 by Pier Angelo Vendrame at 2023-07-18T14:25:53+02:00 fixup! Base Browser's .mozconfigs. Disable the notification server because of the upstream Bug 1782837. - - - - - 38082522 by Pier Angelo Vendrame at 2023-07-18T14:25:54+02:00 fixup! Base Browser's .mozconfigs. Explicitly say we want verified updates. - - - - - dd96b4d0 by Kathy Brade at 2023-07-18T14:25:54+02:00 fixup! Base Browser's .mozconfigs. Replaces bug 13379: Allow using NSS to sign and verify MAR signatures We have uplifted this commit, so we just need to enable the option in our mozconfigs. - - - - - 0800fef9 by Pier Angelo Vendrame at 2023-07-18T14:25:55+02:00 fixup! Base Browser's .mozconfigs. Bug 41890: Let tor-browser-build set the update channel it prefers. - - - - - 162d8023 by Pier Angelo Vendrame at 2023-07-18T14:25:55+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 7901276f by Pier Angelo Vendrame at 2023-07-18T14:25:56+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 65f80502 by Dan Ballard at 2023-07-18T14:25:56+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 5b8f356a by Matthew Finkel at 2023-07-18T14:25:57+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 84bcbc21 by Matthew Finkel at 2023-07-18T14:25:57+02:00 Bug 28125: Prevent non-Necko network connections - - - - - cf1903ba by Mike Perry at 2023-07-18T14:25:58+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - c6bfb0ff by Alex Catarineu at 2023-07-18T14:25:58+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - cef32b7c by Georg Koppen at 2023-07-18T14:25:58+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 2881471f by Kathy Brade at 2023-07-18T14:25:59+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 835972fa by Kathy Brade at 2023-07-18T14:25:59+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 6a694171 by Alex Catarineu at 2023-07-18T14:26:00+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 80888493 by Kathy Brade at 2023-07-18T14:26:00+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 5fd0c018 by Arthur Edelstein at 2023-07-18T14:26:01+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 86b3ea00 by Alex Catarineu at 2023-07-18T14:26:01+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - f040a8f1 by Pier Angelo Vendrame at 2023-07-18T14:26:02+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Linted - - - - - a9d535c5 by cypherpunks1 at 2023-07-18T14:26:02+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - d65e8068 by Pier Angelo Vendrame at 2023-07-18T14:26:03+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - ae3390db by Georg Koppen at 2023-07-18T14:26:03+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - fd4910a1 by Pier Angelo Vendrame at 2023-07-18T14:26:03+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content - - - - - 3ddf3a21 by Pier Angelo Vendrame at 2023-07-18T14:26:04+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content ShouldResistFinterprinting now always wants a target. - - - - - ffd344b5 by Alex Catarineu at 2023-07-18T14:26:04+02:00 Bug 28369: Stop shipping pingsender executable - - - - - a9cfce0a by Pier Angelo Vendrame at 2023-07-18T14:26:05+02:00 fixup! Bug 28369: Stop shipping pingsender executable Linted - - - - - 7addab97 by cypherpunks1 at 2023-07-18T14:26:07+02:00 Bug 41568: Disable LaterRun - - - - - 1f590a89 by cypherpunks1 at 2023-07-18T14:26:07+02:00 Bug 40717: Hide Windows SSO in settings - - - - - c3c5d58a by Pier Angelo Vendrame at 2023-07-18T14:26:08+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 23d026fd by Mike Perry at 2023-07-18T14:26:08+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 2b00c603 by Pier Angelo Vendrame at 2023-07-18T14:26:09+02:00 fixup! Firefox preference overrides. Bug 41738: Drop the patch to disable live reload and use the pref - - - - - 00504203 by Henry Wilkes at 2023-07-18T14:26:09+02:00 fixup! Firefox preference overrides. Bug 41736 - Stop setting the browser.uiCustomization.state preference. - - - - - 0cf6e3c1 by Pier Angelo Vendrame at 2023-07-18T14:26:10+02:00 fixup! Firefox preference overrides. - - - - - be3db58b by hackademix at 2023-07-18T14:26:10+02:00 fixup! Firefox preference overrides. tor-browser#41764, prevent automatic download stuffing / DOS - - - - - 901e0bdd by Pier Angelo Vendrame at 2023-07-18T14:26:11+02:00 fixup! Firefox preference overrides. Missing comments on tor-browser.git. To be moved there. - - - - - 99e8b017 by Pier Angelo Vendrame at 2023-07-18T14:26:11+02:00 fixup! Firefox preference overrides. Remove other references to Tor Browser prefs - - - - - 3fd91cb7 by Pier Angelo Vendrame at 2023-07-18T14:26:12+02:00 fixup! Firefox preference overrides. Ignore 001-base-profile.js during linting. - - - - - 5fe04186 by Pier Angelo Vendrame at 2023-07-18T14:26:12+02:00 fixup! Firefox preference overrides. Pref name change after uplifting. - - - - - 1d3149b4 by cypherpunks1 at 2023-07-18T14:42:57+02:00 fixup! Firefox preference overrides. Bug 41092: Enable URL query stripping to protect against cross-site tracking - - - - - 4d1b6805 by Richard Pospesel at 2023-07-18T14:42:59+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - db01950b by Pier Angelo Vendrame at 2023-07-18T14:43:00+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 5a263f1f by Alex Catarineu at 2023-07-18T14:43:01+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - fa888868 by Alex Catarineu at 2023-07-18T14:43:02+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - 7180615c by Alex Catarineu at 2023-07-18T14:43:03+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 7935c8ab by Alex Catarineu at 2023-07-18T14:43:03+02:00 Bug 26345: Hide tracking protection UI - - - - - 49d8c54a by Pier Angelo Vendrame at 2023-07-18T14:43:04+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - cd7885b0 by Alex Catarineu at 2023-07-18T14:43:05+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - bf57c222 by Mike Perry at 2023-07-18T14:43:06+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 6c9af063 by Igor Oliveira at 2023-07-18T15:03:31+02:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - d192825b by Pier Angelo Vendrame at 2023-07-18T15:03:35+02:00 fixup! Bug 23104: Add a default line height compensation - - - - - 3c7df1fc by Pier Angelo Vendrame at 2023-07-18T15:03:35+02:00 fixup! Bug 23104: Add a default line height compensation Get the document from aPresContext, which Moz already checks and see it isn't null. - - - - - aa002755 by Pier Angelo Vendrame at 2023-07-18T15:03:36+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 48956c94 by Matthew Finkel at 2023-07-18T15:03:37+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 996dbb4a by cypherpunks1 at 2023-07-18T15:03:37+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 4aaeb861 by cypherpunks1 at 2023-07-18T15:03:38+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 84f2f748 by Pier Angelo Vendrame at 2023-07-18T15:03:39+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 054d23cc by hackademix at 2023-07-18T15:03:39+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 87e05c50 by hackademix at 2023-07-18T15:03:40+02:00 Bug 41434: Letterboxing, improve logging. - - - - - de7f5a39 by hackademix at 2023-07-18T15:03:41+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - b5923325 by hackademix at 2023-07-18T15:03:41+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 212bd32c by hackademix at 2023-07-18T15:03:42+02:00 Bug 32308: use direct browser sizing for letterboxing. - - - - - 37e9ecd2 by hackademix at 2023-07-18T15:03:43+02:00 fixup! Bug 32308: use direct browser sizing for letterboxing. - - - - - b8a827f5 by hackademix at 2023-07-18T15:03:43+02:00 fixup! Bug 32308: use direct browser sizing for letterboxing. - - - - - a3a50651 by hackademix at 2023-07-18T15:03:44+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 7aa059f6 by hackademix at 2023-07-18T15:03:45+02:00 fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 0be48f8f by Pier Angelo Vendrame at 2023-07-18T15:03:45+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - a24ae7cd by p13dz at 2023-07-18T15:03:46+02:00 Bug 40283: Workaround for the file upload bug - - - - - 774182df by Arthur Edelstein at 2023-07-18T15:03:47+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - d55496af by Pier Angelo Vendrame at 2023-07-18T15:03:47+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - 6fc60879 by Henry Wilkes at 2023-07-18T15:03:48+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - e56fe60e by Kathy Brade at 2023-07-18T15:03:49+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 906b4bf2 by Pier Angelo Vendrame at 2023-07-18T15:03:55+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 41654: Move UpdateInfo into Data again - - - - - 8607ee8f by Pier Angelo Vendrame at 2023-07-18T15:03:56+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Linted - - - - - 90b896bd by Pier Angelo Vendrame at 2023-07-18T15:03:57+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp. They are already defined in toolkit/xre/nsUpdateDriver.h. - - - - - e97c8e56 by Pier Angelo Vendrame at 2023-07-18T15:03:57+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Fix another build error on macOS - - - - - 1f1f051f by Nicolas Vigier at 2023-07-18T15:03:58+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 22aa256b by hackademix at 2023-07-18T15:03:59+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 39f84bab by Pier Angelo Vendrame at 2023-07-18T15:03:59+02:00 fixup! Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 22c8acd1 by Pier Angelo Vendrame at 2023-07-18T15:04:00+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 03cfa1e4 by hackademix at 2023-07-18T15:04:01+02:00 fixup! Bug 41698: Reword the recommendation badges in about:addons - - - - - 2c7daa96 by Alex Catarineu at 2023-07-18T15:04:01+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - 0aafe0a6 by Pier Angelo Vendrame at 2023-07-18T15:04:02+02:00 fixup! Bug 40069: Add helpers for message passing with extensions Bug 41877: Fix the NoScript message passing function - - - - - 3d351882 by Matthew Finkel at 2023-07-18T15:04:03+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - f744b3c8 by hackademix at 2023-07-18T15:04:03+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 2d999546 by Pier Angelo Vendrame at 2023-07-18T15:04:04+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 08ca9012 by Pier Angelo Vendrame at 2023-07-18T15:04:05+02:00 fixup! Bug 40925: Implemented the Security Level component Linted - - - - - cce05ab5 by cypherpunks1 at 2023-07-18T15:04:05+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 26277: Skip the redirection page when searching with DuckDuckGo on the safest security level - - - - - 11ec7a04 by Pier Angelo Vendrame at 2023-07-18T15:04:06+02:00 fixup! Bug 40925: Implemented the Security Level component Improve the patch to skip DDG redirection for 115. - - - - - 1df04b4f by Pier Angelo Vendrame at 2023-07-18T15:04:07+02:00 Bug 40926: Implemented the New Identity feature - - - - - 20abf782 by Henry Wilkes at 2023-07-18T15:04:07+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - d08e8684 by Richard Pospesel at 2023-07-18T15:04:08+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 6fe516a9 by Richard Pospesel at 2023-07-18T15:04:08+02:00 fixup! Bug 41649: Create rebase and security backport gitlab issue templates - made formatting consistent between each template - updated the directions around the base-browser rebase to better reflect how we *actually* do it with regards to only rarely needing to rebase base-browser seperately - fixed a few typos and incorrect git cherry-pick examples - moved signing and tagging to their own section in the rebase templates - changed instances of 'origin' to 'upstream' to be consistent with github/gitlab documentation - added firefox-android section and marked android-components and fenix sections as optional for esr102 only so we don't have to urently fix this once we swithc to esr115 - - - - - 523f82f2 by Richard Pospesel at 2023-07-18T15:04:09+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - ff2c5eda by Pier Angelo Vendrame at 2023-07-18T15:04:12+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Added bridges.js to .eslintignore - - - - - 2153ef49 by Henry Wilkes at 2023-07-18T15:04:12+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - a323a784 by Kathy Brade at 2023-07-18T15:04:13+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - b8d3fce8 by Mike Perry at 2023-07-18T15:04:14+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one - - - - - 85adf711 by Pier Angelo Vendrame at 2023-07-18T15:04:15+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41749: Replace the onion-glyph with dedicated icon for onion services - - - - - 8b75bab8 by Pier Angelo Vendrame at 2023-07-18T15:04:15+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Added placeholders for new PBM assets needed on Windows - - - - - c6a2022b by Dan Ballard at 2023-07-18T15:04:16+02:00 fixup! fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41809: restore onion glyph in locations outside location bar - - - - - 0c3afce6 by Pier Angelo Vendrame at 2023-07-18T15:04:17+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Customize the about dialog in the branding commit. This actually depends on the strings commit, but maybe we could move it to earlier in the patchset. - - - - - 972e9aee by sanketh at 2023-07-18T15:04:17+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - c1b85e0b by Pier Angelo Vendrame at 2023-07-18T15:04:18+02:00 fixup! Bug 40209: Implement Basic Crypto Safety Use the new domain isolator interface - - - - - 3b274d20 by Mike Perry at 2023-07-18T15:04:19+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - b779db01 by Dan Ballard at 2023-07-18T15:04:19+02:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 41828: Remove --with-tor-browser-version from tor-browser-android mozconfig - - - - - cbf5ece8 by Henry Wilkes at 2023-07-18T15:04:20+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 11bac831 by Pier Angelo Vendrame at 2023-07-18T15:04:21+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 7909d7da by Pier Angelo Vendrame at 2023-07-18T15:04:21+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Moved from the Firefox preferences override commit. To remove from Base Browser and move to Tor Browser only. - - - - - e71e41cf by Pier Angelo Vendrame at 2023-07-18T15:04:22+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Ignore 000-tor-browser.js during linting - - - - - bc1ab64d by Pier Angelo Vendrame at 2023-07-18T15:04:23+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Remove the defaults for the old preferences we are deleting. - - - - - a2d76b31 by Pier Angelo Vendrame at 2023-07-18T15:04:23+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - e4d738ff by Pier Angelo Vendrame at 2023-07-18T15:04:24+02:00 Bug 40933: Add tor-launcher functionality - - - - - 71dbde30 by Pier Angelo Vendrame at 2023-07-18T15:04:24+02:00 fixup! Bug 40933: Add tor-launcher functionality Switched to lazy. - - - - - cc917488 by Pier Angelo Vendrame at 2023-07-18T15:04:25+02:00 fixup! Bug 40933: Add tor-launcher functionality Added a newnym function - - - - - 57ed4f29 by Pier Angelo Vendrame at 2023-07-18T15:04:26+02:00 fixup! Bug 40933: Add tor-launcher functionality Switched to ES modules for this commit. - - - - - afb6d102 by Pier Angelo Vendrame at 2023-07-18T15:04:27+02:00 fixup! Bug 40933: Add tor-launcher functionality Implemented a function for getting GETINFO net/listeners/socks. - - - - - b7e8e9d6 by Pier Angelo Vendrame at 2023-07-18T15:04:28+02:00 fixup! Bug 40933: Add tor-launcher functionality Bug 41842: Stop migrating torrc: we have not written control/socks ports to it for years! - - - - - 7b7ea905 by Richard Pospesel at 2023-07-18T15:04:28+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - bb307a09 by Henry Wilkes at 2023-07-18T15:04:29+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41608 - Ignore tor connection errors when tor connection is cancelled by the user. This can happen if the bootstrap process is cancelled late in the process. Also remove unused cancelAutoBootstrapping. - - - - - 6b032630 by Pier Angelo Vendrame at 2023-07-18T15:04:30+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41801: Fix handleProcessReady in TorSettings.init - - - - - 7659147e by Alex Catarineu at 2023-07-18T15:04:30+02:00 Bug 10760: Integrate TorButton to TorBrowser core Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time. Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time. Additionally, this patch also fixes Bug 27611. Bug 26321: New Circuit and New Identity menu items Bug 14392: Make about:tor behave like other initial pages. Bug 25013: Add torbutton as a tor-browser submodule Bug 31575: Replace Firefox Home (newtab) with about:tor - - - - - a3977cf6 by Pier Angelo Vendrame at 2023-07-18T15:04:31+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Linted - - - - - b582bdc5 by Pier Angelo Vendrame at 2023-07-18T15:04:32+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 40938: Moving the domain isolator out of torbutton - - - - - 32e2645d by Pier Angelo Vendrame at 2023-07-18T15:04:32+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Extract the new identity button from torbutton - - - - - 46de6404 by Pier Angelo Vendrame at 2023-07-18T15:04:33+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove string changes from Torbutton. We will add them back in the TorStrings commit. - - - - - ab8d594e by Pier Angelo Vendrame at 2023-07-18T15:04:34+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Emergency modularization. - - - - - 9f9065e9 by Pier Angelo Vendrame at 2023-07-18T15:04:35+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Removed references to global.dtd. - - - - - 5f4709ac by Pier Angelo Vendrame at 2023-07-18T15:04:35+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove unused assets. - - - - - 17290975 by Pier Angelo Vendrame at 2023-07-18T15:04:36+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove part of the about:tor additions from the torbutton commit to move them to a commit on their own. - - - - - e20be68c by Pier Angelo Vendrame at 2023-07-18T15:04:37+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Do not send data to about:tor on Torbutton anymore. - - - - - 2494f3bf by Pier Angelo Vendrame at 2023-07-18T15:04:38+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Move the Tor checking functions from torbutton.js to its file. Also, rework the file a little bit, to make it an ES module, and import the file directly, instead of using XPCOM. - - - - - e2422059 by Pier Angelo Vendrame at 2023-07-18T15:04:38+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Continued to rework TorCheckService. Use a ConsoleAPI logger instead of the old Torbutton logger. Reworked the local check, to delegate TorProtocolService to get the listeners, and then improved the rest of the function, in general. Finally, changed the topic name, and notify observers whenever the status change, also if suddenly the check succeeded. - - - - - 26c7afb0 by Pier Angelo Vendrame at 2023-07-18T15:04:39+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Reworked the remote check of TorCheckService. - - - - - 22c90361 by Pier Angelo Vendrame at 2023-07-18T15:04:40+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Move the check service to the about:tor commit. - - - - - 58b9c5c9 by Pier Angelo Vendrame at 2023-07-18T15:04:40+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Stop customizing the about dialog in the Torbutton commit. - - - - - d160e517 by Pier Angelo Vendrame at 2023-07-18T15:04:41+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 41842: Remove the logic to remove cookies|protected-*json Removed the function that deleted some cookie JSON preference file. The function was introduced in torbutton@2dfa0e0c9cff7cfad93664e0b0b6cdc05b24b7f2 in 2019. However, since we have had a watershed release, we don't need it anymore. And because of the 12.0 watershed, we do not need to mess up with some these preferences anymore. - - - - - b0382729 by Pier Angelo Vendrame at 2023-07-18T15:04:43+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 41845: Do not force pref values for non-PBM users anymore. A preference cleanup function will be added later, when we finish removing all the torbutton stuff. - - - - - 13f117f8 by Pier Angelo Vendrame at 2023-07-18T15:04:44+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Add default values for preferencs in the logger. I anticipated the removal of the old defaults, since the logger is going away with another MR, but the cleanup function was already in this one. - - - - - b779ceaf by Pier Angelo Vendrame at 2023-07-18T15:18:32+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Move some about:tor stuff to the correct commit. - - - - - 88eafedf by Arthur Edelstein at 2023-07-18T15:18:45+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 26f5e176 by Pier Angelo Vendrame at 2023-07-18T15:18:46+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Refactors to the old JS code. - - - - - d5ef2667 by Pier Angelo Vendrame at 2023-07-18T15:18:46+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Manage NEWNYM here. - - - - - 0081a555 by Pier Angelo Vendrame at 2023-07-18T15:18:47+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Removed the XPCOM definition of the domain isolator. - - - - - 31d32c09 by Pier Angelo Vendrame at 2023-07-18T15:18:47+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Actually added the new circuit button. - - - - - 2501ae1e by Henry Wilkes at 2023-07-18T15:18:48+02:00 Bug 41600: Add a tor circuit display panel. - - - - - f6138f7f by Pier Angelo Vendrame at 2023-07-18T15:18:48+02:00 fixup! Bug 41600: Add a tor circuit display panel. Linted - - - - - 4c10183e by Henry Wilkes at 2023-07-18T15:18:48+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41770 - Stop blocking event propagation of keydown events that we do not handle. This lets the arrow key events pass on to ToolbarKeyboardNavigator. - - - - - 4b9d7256 by Pier Angelo Vendrame at 2023-07-18T15:18:49+02:00 fixup! Bug 41600: Add a tor circuit display panel. Use the new domain isolator interface. - - - - - 03e5e6c8 by Henry Wilkes at 2023-07-18T15:18:49+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41851: Keep circuit panel open when requesting a new circuit. - - - - - 08b95cd2 by hackademix at 2023-07-18T15:18:50+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 31443c6a by cypherpunks1 at 2023-07-18T15:18:50+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41792: Allow dragging downloads from about:downloads and the download panel - - - - - cefc9416 by Pier Angelo Vendrame at 2023-07-18T15:18:51+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Emergency modernization - - - - - d54a63b6 by Pier Angelo Vendrame at 2023-07-18T15:18:51+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Final part of the modernization: switched to an actual module, and moved out of Torbutton! - - - - - 5d36421f by Amogh Pradeep at 2023-07-18T15:18:52+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - cd5ef58a by Matthew Finkel at 2023-07-18T15:18:52+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 747b0137 by Alex Catarineu at 2023-07-18T15:18:53+02:00 Add TorStrings module for localization - - - - - ccfb0a00 by Henry Wilkes at 2023-07-18T15:18:53+02:00 fixup! Add TorStrings module for localization Bug 41608 - Add new connection status strings. - - - - - 1c1974af by Pier Angelo Vendrame at 2023-07-18T15:18:53+02:00 fixup! Add TorStrings module for localization Bug 40552: New texts for the add a bridge manually modal - - - - - f766a295 by Henry Wilkes at 2023-07-18T15:18:54+02:00 fixup! Add TorStrings module for localization Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - ba3c8258 by Henry Wilkes at 2023-07-18T15:18:54+02:00 fixup! Add TorStrings module for localization Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - 160098ba by Pier Angelo Vendrame at 2023-07-18T15:18:55+02:00 fixup! Add TorStrings module for localization Bug 41818: Remove YEC 2022 strings - - - - - 9831b288 by Pier Angelo Vendrame at 2023-07-18T15:18:55+02:00 fixup! Add TorStrings module for localization Add our DTDs where needed. These changes were originally in the torbutton commit, but I think they are better fit here, with all the strings files. - - - - - 4439867f by Kathy Brade at 2023-07-18T15:18:56+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - ac456557 by Pier Angelo Vendrame at 2023-07-18T15:18:56+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - a953b381 by Richard Pospesel at 2023-07-18T15:18:57+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 671c1d9f by Pier Angelo Vendrame at 2023-07-18T15:18:57+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Linted - - - - - 9c173596 by Henry Wilkes at 2023-07-18T15:18:57+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41608 - Use the torconnect icon for the onion slash. - - - - - fb2f58d7 by Pier Angelo Vendrame at 2023-07-18T15:18:59+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 40552: Improve the description of the modal to provide a bridge manually. - - - - - 008ae84d by Pier Angelo Vendrame at 2023-07-18T15:19:00+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41802: Improve the regex on parseBridgeLine The previous version of the regex took for granted the bridge fingerprint was always available, but it is actually optional. So, parsing some bridge lines (e.g., Conjure) failed, and vanilla bridge was displayed instead of the actual transport. - - - - - a5b7802a by Dan Ballard at 2023-07-18T15:19:00+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41623: Update connection assist's iconography - - - - - 7c324763 by Henry Wilkes at 2023-07-18T15:19:01+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - fab1ee60 by Henry Wilkes at 2023-07-18T15:19:01+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - 4cba2705 by Henry Wilkes at 2023-07-18T15:19:02+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41810 - Add "Connect" button instead of the "Submit" and "OK" button in the bridge request dialog and the manual bridge dialog, respectively. - - - - - 2416ccc5 by Dan Ballard at 2023-07-18T15:19:02+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41809: restore onion glyph in locations outside location bar - - - - - f595b581 by Henry Wilkes at 2023-07-18T15:19:03+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - a359c73a by Henry Wilkes at 2023-07-18T15:19:03+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41848 - Consistently disable the accept/connect button in the bridge dialogs until the user gives some input. - - - - - f6ee38c1 by Henry Wilkes at 2023-07-18T15:19:04+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41849: Use the firefox check.svg since we removed our own equivalent check.svg in tor-browser!663. - - - - - ef070ad4 by Richard Pospesel at 2023-07-18T15:19:49+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds tor connection status to url bar and tweaks UX when not online - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP) - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages) Bug 40773: Update the about:torconnect frontend page to match additional UI flows - - - - - 5d334bf1 by Pier Angelo Vendrame at 2023-07-18T15:19:52+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Linted - - - - - 17ca64a7 by Henry Wilkes at 2023-07-18T15:19:53+02:00 amend! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 80af90b9 by Henry Wilkes at 2023-07-18T15:19:53+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41608 and 41526 - Use KeyboardEvent.repeat to block triggering newly focused buttons in about:torconnect. The approach in tor-browser!607 prevented this by waiting for keyup, but keyup could still be triggered by a key event initialized elsewhere. E.g. when pressing Enter to close a modal dialog, the Enter's keyup event would be sent to the about:torconnect page and trigger the focused button. - - - - - f77c6c35 by Dan Ballard at 2023-07-18T15:19:54+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - 457168e1 by Dan Ballard at 2023-07-18T15:19:54+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - 52881162 by Pier Angelo Vendrame at 2023-07-18T15:19:55+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41815: Wrong connect icons Swapped a couple of icons in about:torconnect, and split the offline CSS class from the connection assist/final error, since they now need a different icon. Also, removed the stroke property, since the new icons do not need it. - - - - - 20a1855a by Pier Angelo Vendrame at 2023-07-18T15:19:55+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41816: Workaround to fix the top navigation Using the top navigation does not always work as expected, because we pass a null connection state, instead of the actual state. We could start storing the state as a member, however further refactors are planned (see tor-browser#41710), so also directly asking the parent for the current state works as a quick&dirty workaround. - - - - - e0367242 by Henry Wilkes at 2023-07-18T15:19:56+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41726 - Animate the connection icon. - - - - - 140eab60 by Henry Wilkes at 2023-07-18T15:19:56+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41836: Rename deinit to uninit. - - - - - 73fffbde by Henry Wilkes at 2023-07-18T15:19:56+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - f70d022c by Henry Wilkes at 2023-07-18T15:19:57+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41850: Don't show tor connection animation for new windows. - - - - - 24f517ba by Pier Angelo Vendrame at 2023-07-18T15:19:57+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Moved the logic of the about:tor redirects before the bootstrap - - - - - d1f2c516 by Kathleen Brade at 2023-07-18T15:19:58+02:00 Bug 7494: Create local home page for TBB. - - - - - 883e6d41 by Pier Angelo Vendrame at 2023-07-18T15:19:58+02:00 fixup! Bug 7494: Create local home page for TBB. Removed unused mobile CSS - - - - - 9816ba44 by Pier Angelo Vendrame at 2023-07-18T15:19:59+02:00 fixup! Bug 7494: Create local home page for TBB. Moved aboutTor.xhtml to its new location and make it use more modern IPC mechanisms. - - - - - 20e6e921 by Pier Angelo Vendrame at 2023-07-18T15:19:59+02:00 fixup! Bug 7494: Create local home page for TBB. First step toward IPC modernizartion (WIP). - - - - - 52400134 by Pier Angelo Vendrame at 2023-07-18T15:20:00+02:00 fixup! Bug 7494: Create local home page for TBB. Populate the page with real data. - - - - - 147d9900 by Pier Angelo Vendrame at 2023-07-18T15:20:00+02:00 fixup! Bug 7494: Create local home page for TBB. Get the TorCheckService by importing the module, instead of using XPCOM. - - - - - e37ad3cd by Pier Angelo Vendrame at 2023-07-18T15:20:00+02:00 fixup! Bug 7494: Create local home page for TBB. If we know that TorCheckService already failed, or that we are invoked by an observer, do not wait for the test again, but show the result immediately. If it changes, the observer will trigger another page update. - - - - - ab1b3278 by Pier Angelo Vendrame at 2023-07-18T15:20:01+02:00 fixup! Bug 7494: Create local home page for TBB. Move TorCheckService here, since it is used only for about:tor. Move here also the check for the TOR_DEFAULT_HOMEPAGE variable. - - - - - 40d19b26 by Pier Angelo Vendrame at 2023-07-18T15:21:19+02:00 fixup! Bug 7494: Create local home page for TBB. Re-apply some changes that were applied in the Torbutton commit because of the rebase. This reverts commit b779ceaf78dae19ce22d50ab4bb3c706eed02631. - - - - - b26130c4 by Arthur Edelstein at 2023-07-18T15:21:46+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 2e7c5d6d by Pier Angelo Vendrame at 2023-07-18T15:21:46+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 022390f3 by Pier Angelo Vendrame at 2023-07-18T15:21:47+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776: Keep shipping the old fontconfig file until users have one - - - - - add6a7f0 by Pier Angelo Vendrame at 2023-07-18T15:21:47+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776 (fix): Added some missing lines to the previous patch - - - - - 415e8657 by Pier Angelo Vendrame at 2023-07-18T15:21:47+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Add back variables removed from the Base Browser part of the rebase. - - - - - 914cf784 by Kathy Brade at 2023-07-18T15:21:48+02:00 Bug 12647: Support symlinks in the updater. - - - - - cb81aa0e by Kathy Brade at 2023-07-18T15:21:48+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - e8d8dd15 by Kathy Brade at 2023-07-18T15:21:49+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 91e61e14 by Pier Angelo Vendrame at 2023-07-18T15:21:49+02:00 fixup! Bug 16940: After update, load local change notes. Define the remote capabilities of about:tbupdate in the correct commit. - - - - - 411786d7 by Pier Angelo Vendrame at 2023-07-18T15:21:50+02:00 fixup! Bug 16940: After update, load local change notes. Removed global.dtd - - - - - f22eb279 by Georg Koppen at 2023-07-18T15:21:50+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 4eeae4b8 by Mike Perry at 2023-07-18T15:21:50+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - c250da26 by Pier Angelo Vendrame at 2023-07-18T15:21:51+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Use the upstream DDG icon - - - - - e0684f53 by cypherpunks1 at 2023-07-18T15:21:51+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40577: Add "suggest url" in DDG onion's manifest - - - - - 46ea1b1a by Alex Catarineu at 2023-07-18T15:21:52+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - da1a3418 by Richard Pospesel at 2023-07-18T15:21:52+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 1b620170 by Pier Angelo Vendrame at 2023-07-18T15:21:53+02:00 fixup! Bug 23247: Communicating security expectations for .onion Reimplement the self-signed onion logic - - - - - b651ef39 by cypherpunks1 at 2023-07-18T15:21:53+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 33298: Warn when submitting form data from http onion sites over an insecure connection - - - - - 1aa54fd3 by cypherpunks1 at 2023-07-18T15:21:54+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41785: Show http onion resources as secure in network monitor - - - - - a789fbc3 by Dan Ballard at 2023-07-18T15:21:54+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41809: restore onion glyph in locations outside location bar - - - - - 0a45abb3 by cypherpunks1 at 2023-07-18T15:21:54+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41399: Enable brotli encoding for http onions - - - - - 9b293fb8 by Kathy Brade at 2023-07-18T15:21:55+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - f0dd6b10 by Pier Angelo Vendrame at 2023-07-18T15:21:55+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Linted - - - - - 9008ad90 by Alex Catarineu at 2023-07-18T15:21:56+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - a99878aa by Henry Wilkes at 2023-07-18T15:21:56+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41608 - Use the same styling for ".onion available" urlbar button as the tor-connect-urlbar-button. This also stops the button from overflowing its container like before. Also move to after the bookmark button. - - - - - 2ee9a773 by Pier Angelo Vendrame at 2023-07-18T15:21:59+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41841: Use the new onion-site.svg icon in the onion-location pill - - - - - cf6600f1 by Pier Angelo Vendrame at 2023-07-18T15:21:59+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 0b484cc5 by Pier Angelo Vendrame at 2023-07-18T15:22:00+02:00 fixup! Bug 40458: Implement .tor.onion aliases Lint - - - - - af4a2537 by Pier Angelo Vendrame at 2023-07-18T15:22:00+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 9645b160 by Pier Angelo Vendrame at 2023-07-18T15:22:01+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 1a53141c by Pier Angelo Vendrame at 2023-07-18T15:22:01+02:00 fixup! Bug 41435: Add a Tor Browser migration function Bug 41845: Clear user values for the prefs we decided not to force anymore. Also, remove some old Torbutton preferences. - - - - - 34a3d408 by Dan Ballard at 2023-07-18T15:22:01+02:00 Bug 40701: Add in pane security warning when downloading a file - - - - - 5a22e012 by Dan Ballard at 2023-07-18T15:22:02+02:00 amend! Bug 40701: Add in pane security warning when downloading a file Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 388948a0 by Pier Angelo Vendrame at 2023-07-18T15:22:02+02:00 fixup! Bug 40701: Add in pane security warning when downloading a file Missed a couple of removed lines. - - - - - a2fc90d9 by Henry Wilkes at 2023-07-18T15:22:03+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 78ae8376 by hackademix at 2023-07-18T15:22:03+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/aboutDialogTor.css - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js - + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/523986… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/523986… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40055: Add support for zst in compress_tar
by boklm (＠boklm) 18 Jul '23

18 Jul '23

boklm pushed to branch main at The Tor Project / Applications / RBM Commits: 6a204182 by Nicolas Vigier at 2023-07-18T16:26:27+02:00 Bug 40055: Add support for zst in compress_tar - - - - - 2 changed files: - doc/options_tar.asc - lib/RBM.pm Changes: ===================================== doc/options_tar.asc ===================================== @@ -33,8 +33,8 @@ git_branch:: compress_tar:: If set, the tarball created will be compressed in the select - format. Possible values: xz, gz, bz2. The default is gz but it - can stay empty to disable compression. + format. Possible values: xz, gz, bz2, zst. The default is gz + but it can stay empty to disable compression. commit_gpg_id:: If set, the commit selected with +git_hash+ will have its ===================================== lib/RBM.pm ===================================== @@ -649,12 +649,14 @@ sub maketar { '--prefix', "$project-$version", "$dest_dir/$tar_file") == 0 || exit_error 'Error running hg archive.'; } - my %compress = ( - xz => ['xz', '-f'], - gz => ['gzip', '--no-name', '-f'], - bz2 => ['bzip2', '-f'], - ); if (my $c = project_config($project, 'compress_tar', $options)) { + my $num_procs = project_config($project, 'num_procs', $options); + my %compress = ( + xz => ['xz', '-f'], + gz => ['gzip', '--no-name', '-f'], + bz2 => ['bzip2', '-f'], + zst => ['zstd', '-qf', '--rm', "--threads=$num_procs"], + ); if (!defined $compress{$c}) { exit_error "Unknow compression $c"; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/6a20418284d94ed… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/6a20418284d94ed… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.0.2esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 18 Jul '23

18 Jul '23

Pier Angelo Vendrame pushed new branch tor-browser-115.0.2esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_0_2esr_RELEASE
by Pier Angelo Vendrame (＠pierov) 18 Jul '23

18 Jul '23

Pier Angelo Vendrame pushed new tag FIREFOX_115_0_2esr_RELEASE at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 17 Jul '23

17 Jul '23

Pier Angelo Vendrame pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 9233e9fb by Pier Angelo Vendrame at 2023-07-17T20:06:58+02:00 fixup! Base Browser's .mozconfigs. Bug 41890: Let tor-browser-build set the update channel it prefers. - - - - - 1 changed file: - browser/config/mozconfigs/base-browser-android Changes: ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -38,9 +38,6 @@ if test -n "$LOCAL_DEV_BUILD"; then # You must use the "default" bogus channel for dev builds ac_add_options --enable-update-channel=default ac_add_options --with-base-browser-version=dev-build -else - # We only use beta GeckoView for now, for official builds - ac_add_options --enable-update-channel=beta fi if test -z "$WASI_SYSROOT"; then View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9233e9f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9233e9f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 17 Jul '23

17 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 3b4752bb by Pier Angelo Vendrame at 2023-07-14T15:54:30+02:00 fixup! Base Browser's .mozconfigs. Bug 41890: Let tor-browser-build set the update channel it prefers. - - - - - 1 changed file: - browser/config/mozconfigs/base-browser-android Changes: ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -38,9 +38,6 @@ if test -n "$LOCAL_DEV_BUILD"; then # You must use the "default" bogus channel for dev builds ac_add_options --enable-update-channel=default ac_add_options --with-base-browser-version=dev-build -else - # We only use beta GeckoView for now, for official builds - ac_add_options --enable-update-channel=beta fi if test -z "$WASI_SYSROOT"; then View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3b4752b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3b4752b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40089: Change how we set MOZ_BUILD_DATE
by boklm (＠boklm) 14 Jul '23

14 Jul '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 69317005 by Nicolas Vigier at 2023-07-14T09:49:46+02:00 Bug 40089: Change how we set MOZ_BUILD_DATE For normal alpha/release builds, we use the date from the commit, on which we add the numbers from the version string as seconds (in order to keep increasing the build date when we release a new version without adding new commits). For nightly-testbuild, we use the date from the commit. For nightly we try to parse the day from the version number, or use the current day at 00:00:01. - - - - - 9 changed files: - projects/android-components/build - − projects/common/get-moz-build-date - projects/fenix/build - projects/firefox/build - projects/firefox/config - − projects/firefox/get-moz-build-date - projects/geckoview/build - projects/geckoview/config - rbm.conf Changes: ===================================== projects/android-components/build ===================================== @@ -9,10 +9,6 @@ builddir=/var/tmp/build/[% project %] mkdir $distdir/[% project %] mkdir /var/tmp/build -cat > get-moz-build-date << "EOF" -[% INCLUDE "get-moz-build-date" %] -EOF - [% IF !c("var/fetch_gradle_dependencies") %] tar -C $distdir -xf [% c('input_files_by_name/geckoview') %] gradle_repo=$rootdir/[% c('input_files_by_name/gradle-dependencies') %] @@ -60,12 +56,7 @@ sed -i 's/tag = getGitHash()/tag = \"[% c('abbrev') %]\"/' publish.gradle export LANG=C.UTF-8 patch -p1 < $rootdir/mavenLocal.patch - eval $(perl $rootdir/get-moz-build-date [% pc("fenix", "var/copyright_year") %] [% pc("fenix", "var/torbrowser_version") %]) - if [ -z $MOZ_BUILD_DATE ] - then - echo "MOZ_BUILD_DATE is not set" - exit 1 - fi + [% c("var/set_MOZ_BUILD_DATE") %] # Increase the maximum memory usage, for when compiling with --disable-install-strip gradle_args="--offline --no-daemon -Dmaven.repo.local=$gradle_repo -Dorg.gradle.jvmargs=-Xmx8g" ===================================== projects/common/get-moz-build-date deleted ===================================== @@ -1,30 +0,0 @@ -#!/usr/bin/perl -w -# Generate a MOZ_BUILD_DATE based on Tor Browser version number - -use strict; - -die "wrong number of arguments" unless @ARGV == 2; -my ($year, $version) = @ARGV; -my $date; -if ($version =~ m/^tbb-nightly\.([^\.]+)\.([^\.]+)\.([^\.]+)$/) { - $date = sprintf("%d%02d%02d010101", $1, $2, $3); -} elsif ($version eq 'testbuild') { - # There is no need for an increasing build date in test builds. Just hardcode - # it to a value that is compatible with the v1 versionCode scheme on Android, - # see: #34163. We adjust the date to the new cutoff according to - # https://github.com/mozilla-mobile/fenix/pull/14952, following Mozilla. - # This should be unproblematic for test builds anyway. - $date = 20141228000000; -} else { - my @v = split(/[\.ab]/, $version); - push @v, '0' if @v < 4; - push @v, '0' if @v < 4; - # When MOZ_BUILD_DATE was based on the firefox version, with - # Tor Browser 8.0.6 and firefox 60.5.1 it was 20190204060201 - # We can remove 5 from the month, while keeping it increasing. - my $month = $v[0] - 5; - $date = 1010101 + $year * 10000000000 + $month * 100000000 - + $v[1] * 1000000 + $v[2] * 10000 + $v[3]; - $date += 1000000 unless $version =~ m/[ab]/; -} -print "export MOZ_BUILD_DATE=$date\n"; ===================================== projects/fenix/build ===================================== @@ -9,10 +9,6 @@ builddir=/var/tmp/build/[% project %] mkdir -p $distdir/[% project %] mkdir -p /var/tmp/build -cat > get-moz-build-date << "EOF" -[% INCLUDE "get-moz-build-date" %] -EOF - [% IF !c("var/fetch_gradle_dependencies") %] tar -C $distdir -xf [% c('input_files_by_name/geckoview') %] gradle_repo=$rootdir/[% c('input_files_by_name/gradle-dependencies') %] @@ -71,12 +67,7 @@ v=[% c("variant") %] export LANG=C.UTF-8 patch -p1 < $rootdir/mavenLocal.patch - eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %]) - if [ -z $MOZ_BUILD_DATE ] - then - echo "MOZ_BUILD_DATE is not set" - exit 1 - fi + [% c("var/set_MOZ_BUILD_DATE") %] # Bug 40485: Inject deterministic build date into Glean. echo "ext.gleanBuildDate = \"0\"" >> app/build.gradle ===================================== projects/firefox/build ===================================== @@ -70,12 +70,7 @@ MOZCONFIG_EOF export ASAN_OPTIONS="detect_leaks=0" [% END -%] -eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %]) -if [ -z $MOZ_BUILD_DATE ] -then - echo "MOZ_BUILD_DATE is not set" - exit 1 -fi +[% c("var/set_MOZ_BUILD_DATE") %] [% IF c("var/windows") %] # Make sure widl is not inserting random timestamps, see #21837. ===================================== projects/firefox/config ===================================== @@ -153,7 +153,6 @@ input_files: - project: container-image - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' - - filename: get-moz-build-date - project: binutils name: binutils enable: '[% c("var/linux") %]' ===================================== projects/firefox/get-moz-build-date deleted ===================================== @@ -1,27 +0,0 @@ -#!/usr/bin/perl -w -# Generate a MOZ_BUILD_DATE based on Tor Browser version number - -use strict; - -die "wrong number of arguments" unless @ARGV == 2; -my ($year, $version) = @ARGV; -my $date; -if ($version =~ m/^tbb-nightly\.([^\.]+)\.([^\.]+)\.([^\.]+)$/) { - $date = sprintf("%d%02d%02d010101", $1, $2, $3); -} elsif ($version eq 'testbuild') { - # There is no need for an increasing build date in test builds. Just hardcode - # it. - $date = 20010101010101; -} else { - my @v = split(/[\.ab]/, $version); - push @v, '0' if @v < 4; - push @v, '0' if @v < 4; - # When MOZ_BUILD_DATE was based on the firefox version, with - # Tor Browser 8.0.6 and firefox 60.5.1 it was 20190204060201 - # We can remove 5 from the month, while keeping it increasing. - my $month = $v[0] - 5; - $date = 1010101 + $year * 10000000000 + $month * 100000000 - + $v[1] * 1000000 + $v[2] * 10000 + $v[3]; - $date += 1000000 unless $version =~ m/[ab]/; -} -print "export MOZ_BUILD_DATE=$date\n"; ===================================== projects/geckoview/build ===================================== @@ -8,13 +8,6 @@ distdir=/var/tmp/dist mkdir -p /var/tmp/build mkdir -p $distdir/[% project %] -# We need to have the get-moz-build-date script available in the container -# but we can't include it via input_files as it is a script shared between -# projects. -cat > get-moz-build-date << "EOF" -[% INCLUDE "get-moz-build-date" %] -EOF - tar -C /var/tmp/dist -xf [% c('input_files_by_name/rust') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/cbindgen') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/nasm') %] @@ -49,12 +42,7 @@ export MOZ_SOURCE_REPO="[% c('var/gitlab_project') %]" export MOZ_SOURCE_CHANGESET=[% c("var/git_commit") %] MOZCONFIG_EOF -eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %]) -if [ -z $MOZ_BUILD_DATE ] -then - echo "MOZ_BUILD_DATE is not set" - exit 1 -fi +[% c("var/set_MOZ_BUILD_DATE") %] export JAVA_HOME=/usr/lib/jvm/java-1.11.0-openjdk-amd64 gradle_repo=/var/tmp/dist/gradle-dependencies ===================================== projects/geckoview/config ===================================== @@ -48,10 +48,6 @@ steps: mkdir -p /var/tmp/build mkdir -p $distdir/[% project %] - cat > get-moz-build-date << "EOF" - [% INCLUDE "get-moz-build-date" %] - EOF - tar -C $distdir -xf [% c('input_files_by_name/node') %] export PATH="/var/tmp/dist/node/bin:$PATH" @@ -73,12 +69,7 @@ steps: ln -s mozconfig-android-all .mozconfig echo 'mk_add_options MOZ_PARALLEL_BUILD=[% c("num_procs") %]' >> .mozconfig - eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %]) - if [ -z $MOZ_BUILD_DATE ] - then - echo "MOZ_BUILD_DATE is not set" - exit 1 - fi + [% c("var/set_MOZ_BUILD_DATE") %] export JAVA_HOME=/usr/lib/jvm/java-1.11.0-openjdk-amd64 gradle_repo=/var/tmp/dist/gradle-dependencies ===================================== rbm.conf ===================================== @@ -218,6 +218,7 @@ var: [% END -%] DOCSDIR_project: '[% project %]' + set_MOZ_BUILD_DATE: 'export MOZ_BUILD_DATE=[% c("var_p/MOZ_BUILD_DATE") %]' targets: notarget: linux-x86_64 @@ -717,5 +718,31 @@ gpg_allow_expired_keys: 1 } return [@res]; }, + MOZ_BUILD_DATE => sub { + use POSIX qw(strftime); + my ($project, $options) = @_; + my $nightly = project_config($project, 'var/nightly', $options); + my $testbuild = project_config($project, 'var/testbuild', $options); + + if ($nightly && !$testbuild) { + my $torbrowser_version = project_config($project, 'var/torbrowser_version', $options); + return sprintf("%d%02d%02d000001", $1, $2, $3) + if $torbrowser_version =~ m/^tbb-nightly\.([^\.]+)\.([^\.]+)\.([^\.]+)$/; + return strftime("%Y%m%d000001", gmtime); + } + + my $timestamp = project_config($project, 'timestamp', $options); + if (!$nightly) { + my $torbrowser_version = project_config($project, 'var/torbrowser_version', $options); + my @n = reverse split /[\.\D]/, $torbrowser_version; + my $i = 1; + unshift @n, 0 if @n < 3; + for my $n (@n) { + $timestamp += $n * $i; + $i = $i * 10; + } + } + return strftime "%Y%m%d%H%M%S", gmtime($timestamp); + }, }, ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40898: Add doc from tor-browser-spec/processes/ReleaseProcess to gitlab issue templates
by richard (＠richard) 13 Jul '23

13 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 0a782e66 by Nicolas Vigier at 2023-07-13T11:09:15+02:00 Bug 40898: Add doc from tor-browser-spec/processes/ReleaseProcess to gitlab issue templates - - - - - 2 changed files: - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md Changes: ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -169,6 +169,7 @@ Tor Browser Alpha (and Nightly) are on the `main` branch ### signing - **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long - [ ] On `$(STAGING_SERVER)`, ensure updated: + - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N) && git checkout tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N)` - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) @@ -215,6 +216,35 @@ Tor Browser Alpha (and Nightly) are on the `main` branch </details> +<details> + <summary>Signature verification</summary> + + <details> + <summary>Check whether the .exe files got properly signed and timestamped</summary> + ``` + # Point OSSLSIGNCODE to your osslsigncode binary + pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION + OSSLSIGNCODE=/path/to/osslsigncode + ../../../tools/authenticode_check.sh + popd + ``` + </details> + <details> + <summary>Check whether the MAR files got properly signed</summary> + ``` + # Point NSSDB to your nssdb containing the mar signing certificate + # Point SIGNMAR to your signmar binary + # Point LD_LIBRARY_PATH to your mar-tools directory + pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION + NSSDB=/path/to/nssdb + SIGNMAR=/path/to/mar-tools/signmar + LD_LIBRARY_PATH=/path/to/mar-tools/ + ../../../tools/marsigning_check.sh + popd + ``` + </details> +</details> + <details> <summary>Publishing</summary> @@ -233,6 +263,7 @@ Tor Browser Alpha (and Nightly) are on the `main` branch ### blog: https://gitlab.torproject.org/tpo/web/blog.git - [ ] Duplicate previous Stable or Alpha release blog post as appropriate to new directory under `content/blog/new-release-tor-browser-$(TOR_BROWSER_VERSION)` and update with info on release : + - [ ] Run `tools/signing/create-blog-post` which should create the new blog post from a template (edit set-config.blog to set you local blog directory) - [ ] Update Tor Browser version numbers - [ ] Note any ESR rebase - [ ] Link to any Firefox security updates from ESR upgrade ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -166,6 +166,7 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE ### signing - **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long - [ ] On `$(STAGING_SERVER)`, ensure updated: + - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N) && git checkout tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N)` - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) @@ -212,6 +213,35 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE </details> +<details> + <summary>Signature verification</summary> + + <details> + <summary>Check whether the .exe files got properly signed and timestamped</summary> + ``` + # Point OSSLSIGNCODE to your osslsigncode binary + pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION + OSSLSIGNCODE=/path/to/osslsigncode + ../../../tools/authenticode_check.sh + popd + ``` + </details> + <details> + <summary>Check whether the MAR files got properly signed</summary> + ``` + # Point NSSDB to your nssdb containing the mar signing certificate + # Point SIGNMAR to your signmar binary + # Point LD_LIBRARY_PATH to your mar-tools directory + pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION + NSSDB=/path/to/nssdb + SIGNMAR=/path/to/mar-tools/signmar + LD_LIBRARY_PATH=/path/to/mar-tools/ + ../../../tools/marsigning_check.sh + popd + ``` + </details> +</details> + <details> <summary>Publishing</summary> @@ -230,6 +260,7 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE ### blog: https://gitlab.torproject.org/tpo/web/blog.git - [ ] Duplicate previous Stable or Alpha release blog post as appropriate to new directory under `content/blog/new-release-tor-browser-$(TOR_BROWSER_VERSION)` and update with info on release : + - [ ] Run `tools/signing/create-blog-post` which should create the new blog post from a template (edit set-config.blog to set you local blog directory) - [ ] Update Tor Browser version numbers - [ ] Note any ESR rebase - [ ] Link to any Firefox security updates from ESR upgrade View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-spec][main] 2 commits: Bug 40049: processes/ReleaseProcess is replaced by gitlab issue templates
by richard (＠richard) 13 Jul '23

13 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-spec Commits: 2b13c342 by Nicolas Vigier at 2023-07-13T11:20:54+02:00 Bug 40049: processes/ReleaseProcess is replaced by gitlab issue templates - - - - - b79d4e8a by richard at 2023-07-13T20:07:11+00:00 Merge branch 'bug_40049' into 'main' Bug 40049: processes/ReleaseProcess is replaced by gitlab issue templates Closes #40049 See merge request tpo/applications/tor-browser-spec!45 - - - - - 1 changed file: - processes/ReleaseProcess Changes: ===================================== processes/ReleaseProcess ===================================== @@ -1,362 +1,8 @@ # Magical Tor Browser Release Process Incantations # -# "May this part of our job one day be replaced by a small shell script" +# The Tor Browser Release Process is now documented as gitlab issue templates: +# - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/mai… +# - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/mai… # - -##################### -### Prepare build ### -##################### - -#. Tag any relevant component versions. -# In particular: before tagging the tor-browser tag, the final code from -# Torbutton needs to get included and in order to avoid unnecessary commit -# inflation the commit for bumping the git submodule should be a fixup commit -# to the one with "Bug 25013: Add torbutton as a tor-browser submodule" in -# its commit message. - -#. Update changelog and relevant config files in tor-browser-build. - cd tor-browser-build - vim projects/firefox/config - vim ChangeLog.txt - vim rbm.conf - -#. Tag a build tag in tor-browser-build. - make signtag-release # or `make signtag-alpha` for an alpha build - -#. Push tag and version to tor-browser-build.git. In case of doing a stable -# release with a maintenance branch use that one instead of `master`. - torsocks git push origin master:master - torsocks git push origin --tags - - -##################### -### Build ### -##################### - -#. Build and generate incremental MAR files. - git tag -v tbb-$TORBROWSER_VERSION-buildN - git checkout tbb-$TORBROWSER_VERSION-buildN - make && make incrementals-release # `make alpha && make incrementals-alpha` - -#. Compare the SHA256 sums of the bundles and MAR files with an independent -# builder. - sha256sum tor-browser-build/release/unsigned/$TORBROWSER_BUILDDIR/sha256sums-unsigned-build.txt - sha256sum tor-browser-build/release/unsigned/$TORBROWSER_BUILDDIR/sha256sums-unsigned-build.incrementals.txt - -#. If the sums match (download and) upload the bundles to your build dir on -# people.torproject.org. Fix permissions. - chmod 755 $TORBROWSER_BUILDDIR - chmod 644 $TORBROWSER_BUILDDIR/* - chmod 644 $TORBROWSER_BUILDDIR/.htaccess - torsocks ssh people.torproject.org "mkdir ~/public_html/builds/${TORBROWSER_BUILDDIR}" - torsocks rsync -avP $TORBROWSER_BUILDDIR/ people.torproject.org:public_html/builds/$TORBROWSER_BUILDDIR - -#. (Optional): Upload your binaries to people using partial rsync over old version - torsocks ssh people.torproject.org "mv ~/public_html/builds/${TORBROWSER_VERSION}-build1 ~/public_html/builds/$TORBROWSER_BUILDDIR" - torsocks rsync -avP $TORBROWSER_BUILDDIR/ people.torproject.org:public_html/builds/$TORBROWSER_BUILDDIR - -#. Distribute build to tor-qa(a)lists.torproject.org - # XXX: Currently manual email with link to candidate build, important changes, - # and changelog. - # For stable releases put tails-dev(a)boum.org into Cc. - - -####################### -### Android signing ### -####################### - -#. The Android signing is done separately from the desktop signing. To -# do the Android signing you'll need to boot from a Tails usb stick, -# with persistent storage enabled. - -#. Install the openjdk-11-jdk-headless package - apt install openjdk-11-jdk-headless - -#. Make sure you have the android keys, for example in the -# ~/Persistent/android-keys directory. This directory should include -# the tba_alpha.p12 and tba_release.p12 files. - -#. Clone tor-browser-build, and checkout the tag for the release - git tag -v tbb-$TORBROWSER_VERSION-buildN - git checkout tbb-$TORBROWSER_VERSION-buildN - -#. Update set-config.tbb-version and set-config.android-signing - cd tools/signing - vim set-config.tbb-version - vim set-config.android-signing - -#. Run the android-signing script. This script will download the -# unsigned apks from the `pkgstage` machine (where `do-all-signing` -# is run), signed them, and upload back the signed apks to the -# `pkgstage` machine. It should be done before the hash_signed_bundles.sh -# step. - ./android-signing - - -########################## -### Signing and upload ### -########################## - -#. You need a `pkgstage` machine to store the bundles during the signing -# process. This machine should be: -# - secure (you will ssh to the signing machines and staticiforme -# from there) -# - with good bandwidth (you will download/upload bundles from there) -# -# All steps from the `Signing and upload` are run from the `pkgstage` -# machine unless mentioned otherwise. -# -# The signing scripts are located in the tor-browser-build/tools/signing -# directory. -# -# Alternatively, you can run the script `./do-all-signing`, which will -# do all the signing steps automatically, until the static-update-component -# commands on staticiforme. Also the script does not currently handle -# removing the old versions on staticiforme, so you have to do that -# manually. The script is also not running `./macos-signer-proxy` which -# needs to be started and stopped manually. - -#. Checkout the tor-browser-build.git commit corresponding to the -# tor browser version you need to sign/publish. - cd tor-browser-build - git tag -v tbb-$TORBROWSER_VERSION-buildN - git checkout tbb-$TORBROWSER_VERSION-buildN - -#. Change to the tor-browser-build/tools/signing directory. All following -# commands are run from this directory. - cd tor-browser-build/tools/signing - -#. Set hosts information. - vim set-config.hosts - -#. Set tor browser version information. You should set tbb_version, -# tbb_version_build, tbb_version_type. This should match the information -# in rbm.conf. - vim set-config.tbb-version - -#. Download the tor browser build to the `pkgstage` machine from your -# build machine (configured in set-config.hosts). - ./sync-builder-unsigned-to-local-signed - -#. Codesign the macOS dmg files. -# -# Updload the tor browser dmg files to `macos-signer` - ./sync-macos-local-to-macos-signer - -# Upload updated signing scripts to `macos-signer`. The scripts are -# located in the `signing-release` or `signing-alpha` directory on -# `macos-signer`. - ./sync-scripts-to-macos-signer - -# Run proxy for `macos-signer`. You may need to kill an old proxy -# process on `macos-signer` if it was still running. - ./macos-signer-proxy - -# Enable networking on the `macos-signer`. - macos-signer$ networksetup -setsecurewebproxystate Ethernet on - -# Sign the bundles. On `macos-signer`. -# (replace signing-release with signing-alpha for an alpha release) - macos-signer$ ~/signing-release/macos-signer-gatekeeper-signing - -# Notarize the bundles. On `macos-signer`. -# (replace signing-release with signing-alpha for an alpha release) - macos-signer$ ~/signing-release/macos-signer-notarization - -# Staple the bundles. On `macos-signer`. -# (replace signing-release with signing-alpha for an alpha release) - macos-signer$ ~/signing-release/macos-signer-stapler - -# Disable networking on the `macos-signer`. - macos-signer$ networksetup -setsocksfirewallproxystate Ethernet off - -# Download the stapled bundles to `pkgstage`. - ./sync-macos-signer-stapled-to-macos-local-stapled - -#. Regenerate macOS DMG files from stapled zip files. - ./gatekeeper-bundling.sh - -#. Regenerate macOS MAR files from code signed dmg files. - ./dmg2mar - -#. Sync bundles to `linux-signer`. - ./sync-local-to-linux-signer - -#. Upload updated signing scripts to `linux-signer`. The scripts are -# located in the `signing-release` or `signing-alpha` directory on -# `linux-signer`. - ./sync-scripts-to-linux-signer - -#. Sign the MAR files. On `linux-signer`. -# (replace signing-release with signing-alpha for an alpha release) - linux-signer$ ~/signing-release/linux-signer-signmars - -#. Authenticode signing of exe files. On `linux-signer`. - linux-signer$ ~/signing-release/linux-signer-authenticode-signing - -#. Authenticode timestamping. - ./sync-linux-signer-to-local - ./authenticode-timestamping.sh - -#. Create sha256sums-signed-build files - ./hash_signed_bundles.sh - -#. Upload sha256sums-signed-build and updated exe files to `linux-signer`. - ./sync-local-to-linux-signer - -#. Gpg signing. - ./linux-signer-gpg-sign - -#. Fetch signatures on unsigned sha256sums from other builds - ./download-unsigned-sha256sums-gpg-signatures-from-people-tpo - -#. Remove old builds on `staticiforme` - # IMPORTANT: Remove the oldest version in a series in case there is more - # than 1 available on dist.torproject.org before proceeding - # XXX: TORBROWSER_VERSION_OLDEST needs to be set - staticiforme$ rm -rf /srv/dist-master.torproject.org/htdocs/torbrowser/$TORBROWSER_VERSION_OLDEST - staticiforme$ static-update-component dist.torproject.org - -#. Upload new build to `staticiforme` - ./sync-local-to-staticiforme - -#. Check diskspace available on cdn.tpo -# We currently have enough disk space to host two alpha and stable -# releases. However with the size of each Tor Browser release increasing, -# it may become necessary to increase disk space. The server hosting -# the files for cdn.tpo is savii.tpo and its disk usage can be monitored -# by going to https://grafana.torproject.org/d/Z7T7Cfemz/node-exporter-full -# and selecting the hosts: web-fsn-02.torproject.org, web-cymru-01.torproject.org, -# web-fsn-01.torproject.org, and cdn-backend-sunet-01.torproject.org - -#. Remove the oldest *.mar files from cdn.tpo to save space - staticiforme$ rm -rf /srv/cdn-master.torproject.org/htdocs/aus1/torbrowser/$TORBROWSER_VERSION_OLDEST - staticiforme$ static-update-component cdn.torproject.org - -#. Sync files to dist.tpo and cdn.tpo mirrored web servers -# (replace signing-release with signing-alpha for an alpha release) -# It is a good idea to run the static-update-component inside screen -# or tmux so that the upload continues if your connection to -# staticiforme is closed. - $ ./sync-scripts-to-staticiforme - staticiforme$ ~/signing-release/staticiforme-prepare-cdn-dist-upload - staticiforme$ static-update-component cdn.torproject.org && \ - static-update-component dist.torproject.org - -#. Make sure we really built from the proper Mozilla build tag by consulting - # the respective ESR release branch (for a good overview for ESR78 see - # https://hg.mozilla.org/releases/mozilla-esr78/graph/) For the platforms following - # rapid release (only Android, currently), consult the beta repo - # (https://hg.mozilla.org/releases/mozilla-beta/graph/) or the release repo - # (https://hg.mozilla.org/releases/mozilla-release/graph/) - -#. Update website's torbrowser versions file in the website git - cd tpo - torsocks git pull origin - # Update `win32` in the `torbrowser-stable` section as well if we - # include a new stable tor version (called the Windows Expert Bundle - # on the website). See: #14152. - vim databags/versions.ini - git commit databags/versions.ini -m "Add new Tor Browser version" - torsocks git push origin master:master - cd .. - # Check build success/failure: - # https://jenkins.torproject.org/job/lektor-website-tpo-translation/ - # https://jenkins.torproject.org/job/lektor-website-tpo-translation-install/ - -#. Add new locales to the download page - # If this release is introducing new locales, add them to the - # databags/download-alternatives.ini file (for a stable release) or - # the databags/download-alternatives-alpha.ini file (for an alpha - # release). - cd tpo - torsocks git pull origin - vim databags/download-alternatives.ini # or databags/download-alternatives-alpha.ini - git commit databags/download-alternatives.ini -m "Add new Tor Browser locales" - torsocks git push origin master:master - cd .. - -#. Create blog post from changelog -# Edit set-config.blog to set you local blog directory. -# Don't forget to link to Mozilla's security advisories if this is a security -# update. - ./create-blog-post - -#. Check whether the .exe files got properly signed and timestamped - # Point OSSLSIGNCODE to your osslsigncode binary - pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION - OSSLSIGNCODE=/path/to/osslsigncode - ../../../tools/authenticode_check.sh - popd - -#. Check whether the MAR files got properly signed - # Point NSSDB to your nssdb containing the mar signing certificate - # Point SIGNMAR to your signmar binary - # Point LD_LIBRARY_PATH to your mar-tools directory - pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION - NSSDB=/path/to/nssdb - SIGNMAR=/path/to/mar-tools/signmar - LD_LIBRARY_PATH=/path/to/mar-tools/ - ../../../tools/marsigning_check.sh - popd - -#. Generate and upload update_responses to staticiforme - ./upload-update_responses-to-staticiforme - -#. Enable update. On `staticiforme`. -# (for alpha release, use deploy_update_responses-alpha.sh instead) - staticiforme$ ~/deploy_update_responses-release.sh - -#. Clean linux-signer and macos-signer - ./finished-signing-clean-linux-signer - ./finished-signing-clean-macos-signer - -# Upload APKs to Google Play - Log into https://play.google.com/apps/publish - Select correct app (Tor Browser or Tor Browser Alpha) - Under left-side navigation bar, select "Production" under "Release" - Select "Create new release" button at upper right-side - Under "App bundles and APKs" section, "Upload" each signed APK - After uploading APKs: - - The "Release Name" should be automatically filled with the Firefox version - - Next to "Release notes" click "Copy from a previous release" - - Select the previous release and adjust the blog post url for this release - - Save, review, and configure rollout percentage at the bottom - - Use 25% rollout when publishing a scheduled update (without a security driver) - - Use 100% rollout when publishing an unscheduled update or security-driven release - Roll out. - - Note, you may receive three warning messages about: - 1) app is larger than it is necessary (android app bundle), - 2) missing deobfuscation file for better crash analysis - 3) missing debug symbol file - - These warnings are expected and should be accepted. - - See below for updating the rollout percentage. - -# Release on F-Droid - Publication on F-Droid via the Guardian Project's repository should be - automatic. Hans is responsible for maintaining this automation. - -# Update rollout percentage - After 24 hours, check the Release Daskboard: - - "Release"->"Production" and select the "Release Dashboard" tab - If the Release Dashboard does not show any concerning trends (significant - increase in crashes or ANRs (Application Not Responding)), then continue on - to the next paragraph and increase rollout from 25% to 100%. Otherwise - consider halting rollout as described in the `RollingBackUpdate` process. - - Select the "Releases" tab on the "Production" page. The current released - version should indicate 25% rollout: "Available to 25% of users on Google Play" - On the right-side of the "View release details" button of the release there - should be a button labeled "Manage rollout" with a down-arrow. Clicking on - that button should show two options: - - Update rollout - - Halt rollout - - Select "Update rollout" and increase to 100% and click "Update". The change - should be immediately implemented and the "Manage rollout" button disappears. - -#. Write an email to tor-announce in case this release is concerned with getting -# a stable version out. Using the contents of the blog entry should do it. +# See also the open release prep issues: +# https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=update… View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/compare/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/compare/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] fixup! Bug 23247: Communicating security expectations for .onion
by ma1 (＠ma1) 13 Jul '23

13 Jul '23

ma1 pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 82c31751 by cypherpunks1 at 2023-07-12T16:18:15-08:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41399: Enable brotli encoding for http onions - - - - - 1 changed file: - netwerk/protocol/http/HttpBaseChannel.cpp Changes: ===================================== netwerk/protocol/http/HttpBaseChannel.cpp ===================================== @@ -340,6 +340,7 @@ void HttpBaseChannel::AddClassificationFlags(uint32_t aClassificationFlags, static bool isSecureOrTrustworthyURL(nsIURI* aURI) { return aURI->SchemeIs("https") || + nsMixedContentBlocker::IsPotentiallyTrustworthyOnion(aURI) || (StaticPrefs::network_http_encoding_trustworthy_is_https() && nsMixedContentBlocker::IsPotentiallyTrustworthyLoopbackURL(aURI)); } @@ -366,7 +367,6 @@ nsresult HttpBaseChannel::Init(nsIURI* aURI, uint32_t aCaps, // Construct connection info object nsAutoCString host; int32_t port = -1; - bool isHTTPS = isSecureOrTrustworthyURL(mURI); nsresult rv = mURI->GetAsciiHost(host); if (NS_FAILED(rv)) return rv; @@ -395,7 +395,7 @@ nsresult HttpBaseChannel::Init(nsIURI* aURI, uint32_t aCaps, if (NS_FAILED(rv)) return rv; rv = gHttpHandler->AddStandardRequestHeaders( - &mRequestHead, isHTTPS, aContentPolicyType, + &mRequestHead, isSecureOrTrustworthyURL(mURI), aContentPolicyType, nsContentUtils::ShouldResistFingerprinting(this)); if (NS_FAILED(rv)) return rv; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/82c3175… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/82c3175… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-spec][main] Bug 31161: Document Android signing key creation/usage
by boklm (＠boklm) 13 Jul '23

13 Jul '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-spec Commits: 2b940775 by Matthew Finkel at 2023-07-13T10:14:42+02:00 Bug 31161: Document Android signing key creation/usage - - - - - 2 changed files: - + processes/APKSigning - processes/KeyGeneration Changes: ===================================== processes/APKSigning ===================================== @@ -0,0 +1,29 @@ +Signing Tor Browser for Android on a Linux machine +================================================== + +Signing +------- + +1) Ensure pkcs11 configuration file is available + +# Create a file containing the Provider arguments +- cat > /tmp/pkcs11_java.cfg << EOF +name = OpenSC-PKCS11 +description = SunPKCS11 via OpenSC +library = /usr/lib/x86_64-linux-gnu/opensc-pkcs11.so +slotListIndex = 0 +EOF + +2) Test the configuration file with `keytool` and confirm it can access the smartcard +- keytool -providerClass sun.security.pkcs11.SunPKCS11 \ + -providerArg /tmp/pkcs11_java.cfg -keystore NONE \ + -storetype PKCS11 -list + + +3) Signing the exectuable(s): + +- path/to/apksigner sign --verbose --provider-class sun.security.pkcs11.SunPKCS11 \ + --provider-arg pkcs11_java.cfg --ks NONE --ks-type PKCS11 \ + --debuggable-apk-permitted=false \ + --out tor-browser-${VERSION}-android-${arch}-multi-qa.apk \ + tor-browser-${VERSION}-android-${arch}-multi-unsigned.apk ===================================== processes/KeyGeneration ===================================== @@ -100,3 +100,71 @@ certtool r CertificateSigningRequest.certSigningRequest security add-certificates ~/developerID_application.cer security find-identity + + +APK Signing Key +=============== + +These instructions are for a Nitrokey, as described in +https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/26536 + +Software needed: +---------------- + +1) Android SDK build tools + + - Latest (at time of writing): + - https://developer.android.com/studio?hl=i#downloads + - https://dl.google.com/android/repository/commandlinetools-linux-6609375_lat… + - 89f308315e041c93a37a79e0627c47f21d5c5edbe5e80ea8dc0aac8a649e0e92 + +Installation +------------ + +1) Requirements + +- for the signing: sudo apt-get install nitrokey-app opensc-pkcs11 opensc openjdk-8-jdk + - https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/26536#n… + +`nitrokey-app` should automatically detect the nitrokey if it is connected +Debian Stretch provides version 0.6.3-1. + + $ nitrokey-app + +Expect: "Application started successfully." + + +Key Generation +-------------- + +1) Generate 4096-bit RSA key pair + + $ openssl genrsa -out secretkey.pem -aes128 -rand /dev/urandom 4096 + +2) Create CSR + + $ openssl req -new -key secretkey.pem -out request.pem -subj "/CN=Tor Browser/O=The Tor Project/L=Seattle/ST=WA/C=US" + +3) Generate certificate (Google Play requires minimum expiratation date of 22 October 2033 + # If you plan to publish your apps on Google Play, the key you use to sign + # your app must have a validity period ending after 22 October 2033. Google + # Play enforces this requirement to ensure that users can seamlessly + # upgrade apps when new versions are available. + # https://developer.android.com/studio/publish/app-signing#considerations + + $ openssl x509 -req -days 5475 -in request.pem -signkey secretkey.pem -out certificate.pem -extfile openssl.cnf -extensions usr_cert + +4) Export secret key and certificate in PKCS12 + + $ openssl pkcs12 -export -out secret_and_certificate.p12 -in certificate.pem -inkey secretkey.pem -aes128 + +5) Extract RSA public key + + $ openssl rsa -in secretkey.pem -pubout -out publickey.pem + +Install private signing key on Nitrokey +--------------------------------------- + +- pkcs15-init --delete-objects privkey,pubkey,chain \ + --id 3 --store-private-key secret_and_certificate.p12 \ + --format pkcs12 --auth-id 3 --verify-pin View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/commit/2b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/commit/2b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] Bug 41092: Add a RemoteSettings JSON dump for query-stripping
by ma1 (＠ma1) 12 Jul '23

12 Jul '23

ma1 pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 0a89389f by cypherpunks1 at 2023-07-13T00:40:56+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 2 changed files: - services/settings/static-dumps/main/moz.build - + services/settings/static-dumps/main/query-stripping.json Changes: ===================================== services/settings/static-dumps/main/moz.build ===================================== @@ -5,6 +5,7 @@ FINAL_TARGET_FILES.defaults.settings.main += [ "doh-config.json", "doh-providers.json", + "query-stripping.json", ] if CONFIG["MOZ_BUILD_APP"] == "browser": ===================================== services/settings/static-dumps/main/query-stripping.json ===================================== @@ -0,0 +1,44 @@ +{ + "data": [ + { + "schema": 1678379807899, + "allowList": [], + "stripList": [ + "gclid", + "dclid", + "msclkid", + "_openstat", + "yclid", + "wickedid", + "twclid", + "_hsenc", + "__hssc", + "__hstc", + "__hsfp", + "hsctatracking", + "wbraid", + "gbraid", + "ysclid" + ], + "id": "85078bad-f31e-4d93-bb8a-81088b25d6dd", + "last_modified": 1678736907773 + }, + { + "schema": 1649695008608, + "allowList": [], + "stripList": [ + "mc_eid", + "oly_anon_id", + "oly_enc_id", + "__s", + "vero_id", + "_hsenc", + "mkt_tok", + "fbclid" + ], + "id": "76495cfc-fac9-4079-9b5f-9ff0784484de", + "last_modified": 1649762862679 + } + ], + "timestamp": 1678736907773 +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0a89389… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0a89389… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] Bug 33955: When copying an image only copy the image contents to the clipboard
by richard (＠richard) 12 Jul '23

12 Jul '23

richard pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 53c25feb by cypherpunks1 at 2023-07-12T22:21:16+00:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 2 changed files: - browser/base/content/browser-context.inc - dom/base/nsCopySupport.cpp Changes: ===================================== browser/base/content/browser-context.inc ===================================== @@ -219,7 +219,7 @@ #ifdef CONTEXT_COPY_IMAGE_CONTENTS <menuitem id="context-copyimage-contents" data-l10n-id="main-context-menu-image-copy" - oncommand="goDoCommand('cmd_copyImage');"/> + oncommand="goDoCommand('cmd_copyImageContents');"/> #endif <menuitem id="context-copyimage" data-l10n-id="main-context-menu-image-copy-link" ===================================== dom/base/nsCopySupport.cpp ===================================== @@ -503,7 +503,7 @@ nsresult nsCopySupport::ImageCopy(nsIImageLoadingContent* aImageElement, trans->SetReferrerInfo(referrerInfo); } -#ifdef XP_WIN +#if defined(XP_WIN) && !defined(BASE_BROWSER_VERSION) rv = AppendImagePromise(trans, imgRequest, aImageElement); NS_ENSURE_SUCCESS(rv, rv); #endif View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/53c25fe… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/53c25fe… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] Bug 33955: When copying an image only copy the image contents to the clipboard
by richard (＠richard) 12 Jul '23

12 Jul '23

richard pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 1fde2e0f by cypherpunks1 at 2023-07-12T22:20:31+00:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 2 changed files: - browser/base/content/browser-context.inc - dom/base/nsCopySupport.cpp Changes: ===================================== browser/base/content/browser-context.inc ===================================== @@ -219,7 +219,7 @@ #ifdef CONTEXT_COPY_IMAGE_CONTENTS <menuitem id="context-copyimage-contents" data-l10n-id="main-context-menu-image-copy" - oncommand="goDoCommand('cmd_copyImage');"/> + oncommand="goDoCommand('cmd_copyImageContents');"/> #endif <menuitem id="context-copyimage" data-l10n-id="main-context-menu-image-copy-link" ===================================== dom/base/nsCopySupport.cpp ===================================== @@ -503,7 +503,7 @@ nsresult nsCopySupport::ImageCopy(nsIImageLoadingContent* aImageElement, trans->SetReferrerInfo(referrerInfo); } -#ifdef XP_WIN +#if defined(XP_WIN) && !defined(BASE_BROWSER_VERSION) rv = AppendImagePromise(trans, imgRequest, aImageElement); NS_ENSURE_SUCCESS(rv, rv); #endif View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1fde2e0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1fde2e0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] 2 commits: fixup! Firefox preference overrides.
by ma1 (＠ma1) 12 Jul '23

12 Jul '23

ma1 pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 44eff978 by cypherpunks1 at 2023-07-12T14:35:28+00:00 fixup! Firefox preference overrides. Bug 41092: Enable URL query stripping to protect against cross-site tracking - - - - - 9740e17d by cypherpunks1 at 2023-07-12T14:35:28+00:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 3 changed files: - browser/app/profile/001-base-profile.js - services/settings/static-dumps/main/moz.build - + services/settings/static-dumps/main/query-stripping.json Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -505,6 +505,11 @@ pref("corroborator.enabled", false); // stop using .textContent. pref("intl.multilingual.liveReload", false); +// Enable URL query stripping to protect against cross-site tracking (tor-browser#41092) +pref("privacy.query_stripping.enabled", true); +pref("privacy.query_stripping.enabled.pbmode", true); +pref("privacy.query_stripping.strip_on_share.enabled", true); + #ifdef XP_WIN // prefs to disable jump-list entries in the taskbar on Windows (see bug #12885) // this pref changes the app's set AUMID to be dependent on the profile path, rather than ===================================== services/settings/static-dumps/main/moz.build ===================================== @@ -5,6 +5,7 @@ FINAL_TARGET_FILES.defaults.settings.main += [ "doh-config.json", "doh-providers.json", + "query-stripping.json", ] if CONFIG["MOZ_BUILD_APP"] == "browser": ===================================== services/settings/static-dumps/main/query-stripping.json ===================================== @@ -0,0 +1,44 @@ +{ + "data": [ + { + "schema": 1678379807899, + "allowList": [], + "stripList": [ + "gclid", + "dclid", + "msclkid", + "_openstat", + "yclid", + "wickedid", + "twclid", + "_hsenc", + "__hssc", + "__hstc", + "__hsfp", + "hsctatracking", + "wbraid", + "gbraid", + "ysclid" + ], + "id": "85078bad-f31e-4d93-bb8a-81088b25d6dd", + "last_modified": 1678736907773 + }, + { + "schema": 1649695008608, + "allowList": [], + "stripList": [ + "mc_eid", + "oly_anon_id", + "oly_enc_id", + "__s", + "vero_id", + "_hsenc", + "mkt_tok", + "fbclid" + ], + "id": "76495cfc-fac9-4079-9b5f-9ff0784484de", + "last_modified": 1649762862679 + } + ], + "timestamp": 1678736907773 +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5b4fa6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5b4fa6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] Bug 41791: Omit the source URL when copying page contents to the clipboard
by richard (＠richard) 12 Jul '23

12 Jul '23

richard pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 6c9e419d by cypherpunks1 at 2023-07-12T14:29:21+00:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 2 changed files: - dom/base/nsCopySupport.cpp - widget/windows/nsDataObj.cpp Changes: ===================================== dom/base/nsCopySupport.cpp ===================================== @@ -284,6 +284,7 @@ static nsresult CreateTransferable( NS_ENSURE_SUCCESS(rv, rv); } +#if !defined(BASE_BROWSER_VERSION) // Try and get source URI of the items that are being dragged nsIURI* uri = aDocument.GetDocumentURI(); if (uri) { @@ -304,6 +305,7 @@ static nsresult CreateTransferable( NS_ENSURE_SUCCESS(rv, rv); } } +#endif } else { if (!aEncodedDocumentWithContext.mSerializationForTextUnicode.IsEmpty()) { // Add the unicode DataFlavor to the transferable ===================================== widget/windows/nsDataObj.cpp ===================================== @@ -520,11 +520,13 @@ nsDataObj::nsDataObj(nsIURI* uri) m_enumFE = new CEnumFormatEtc(); m_enumFE->AddRef(); +#if !defined(BASE_BROWSER_VERSION) if (uri) { // A URI was obtained, so pass this through to the DataObject // so it can create a SourceURL for CF_HTML flavour uri->GetSpec(mSourceURL); } +#endif } //----------------------------------------------------- // destruction @@ -1978,6 +1980,7 @@ nsresult nsDataObj ::BuildPlatformHTML(const char* inOurHTML, *outPlatformHTML = nullptr; nsDependentCString inHTMLString(inOurHTML); +#if !defined(BASE_BROWSER_VERSION) // Do we already have mSourceURL from a drag? if (mSourceURL.IsEmpty()) { nsAutoString url; @@ -1985,6 +1988,7 @@ nsresult nsDataObj ::BuildPlatformHTML(const char* inOurHTML, AppendUTF16toUTF8(url, mSourceURL); } +#endif constexpr auto kStartHTMLPrefix = "Version:0.9\r\nStartHTML:"_ns; constexpr auto kEndHTMLPrefix = "\r\nEndHTML:"_ns; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6c9e419… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6c9e419… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] Bug 41791: Omit the source URL when copying page contents to the clipboard
by richard (＠richard) 12 Jul '23

12 Jul '23

richard pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 5b4fa6e2 by cypherpunks1 at 2023-07-12T14:27:48+00:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 2 changed files: - dom/base/nsCopySupport.cpp - widget/windows/nsDataObj.cpp Changes: ===================================== dom/base/nsCopySupport.cpp ===================================== @@ -284,6 +284,7 @@ static nsresult CreateTransferable( NS_ENSURE_SUCCESS(rv, rv); } +#if !defined(BASE_BROWSER_VERSION) // Try and get source URI of the items that are being dragged nsIURI* uri = aDocument.GetDocumentURI(); if (uri) { @@ -304,6 +305,7 @@ static nsresult CreateTransferable( NS_ENSURE_SUCCESS(rv, rv); } } +#endif } else { if (!aEncodedDocumentWithContext.mSerializationForTextUnicode.IsEmpty()) { // Add the unicode DataFlavor to the transferable ===================================== widget/windows/nsDataObj.cpp ===================================== @@ -520,11 +520,13 @@ nsDataObj::nsDataObj(nsIURI* uri) m_enumFE = new CEnumFormatEtc(); m_enumFE->AddRef(); +#if !defined(BASE_BROWSER_VERSION) if (uri) { // A URI was obtained, so pass this through to the DataObject // so it can create a SourceURL for CF_HTML flavour uri->GetSpec(mSourceURL); } +#endif } //----------------------------------------------------- // destruction @@ -1978,6 +1980,7 @@ nsresult nsDataObj ::BuildPlatformHTML(const char* inOurHTML, *outPlatformHTML = nullptr; nsDependentCString inHTMLString(inOurHTML); +#if !defined(BASE_BROWSER_VERSION) // Do we already have mSourceURL from a drag? if (mSourceURL.IsEmpty()) { nsAutoString url; @@ -1985,6 +1988,7 @@ nsresult nsDataObj ::BuildPlatformHTML(const char* inOurHTML, AppendUTF16toUTF8(url, mSourceURL); } +#endif constexpr auto kStartHTMLPrefix = "Version:0.9\r\nStartHTML:"_ns; constexpr auto kEndHTMLPrefix = "\r\nEndHTML:"_ns; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5b4fa6e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5b4fa6e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40889: Add mullvad sha256sums URL to...
by richard (＠richard) 12 Jul '23

12 Jul '23

richard pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 8140af32 by Nicolas Vigier at 2023-07-12T13:56:25+00:00 Bug 40889: Add mullvad sha256sums URL to download-unsigned-sha256sums-gpg-signatures-from-people-tpo - - - - - 2 changed files: - + keyring/jb.gpg - tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo Changes: ===================================== keyring/jb.gpg ===================================== Binary files /dev/null and b/keyring/jb.gpg differ ===================================== tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo ===================================== @@ -3,16 +3,24 @@ set -e script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) source "$script_dir/functions" -for builder in $tb_builders +for builder in $tb_builders jb do - for file in sha256sums-unsigned-build.txt.asc sha256sums-unsigned-build.incrementals.txt.asc + for file in sha256sums-unsigned-build.txt sha256sums-unsigned-build.incrementals.txt do tmpfile=$(mktemp) chmod 644 "$tmpfile" - for url in \ - "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ - "https://tb-build-04.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ - "https://tb-build-05.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" + if test "$builder" = 'jb'; then + file="$file.gpg" + urls=("https://cdn.devmole.eu/hashes//$SIGNING_PROJECTNAME/$tbb_version-build$tbb_…") + else + file="$file.asc" + urls=( \ + "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ + "https://tb-build-04.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ + "https://tb-build-05.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ + ) + fi + for url in "${urls[@]}" do if wget -q -O "$tmpfile" "$url"; then mv "$tmpfile" "$signed_version_dir/$file-$builder" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40889: Add mullvad sha256sums URL to...
by richard (＠richard) 12 Jul '23

12 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 3c23c8a8 by Nicolas Vigier at 2023-07-07T11:46:30+02:00 Bug 40889: Add mullvad sha256sums URL to download-unsigned-sha256sums-gpg-signatures-from-people-tpo - - - - - 2 changed files: - + keyring/jb.gpg - tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo Changes: ===================================== keyring/jb.gpg ===================================== Binary files /dev/null and b/keyring/jb.gpg differ ===================================== tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo ===================================== @@ -3,16 +3,24 @@ set -e script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) source "$script_dir/functions" -for builder in $tb_builders +for builder in $tb_builders jb do - for file in sha256sums-unsigned-build.txt.asc sha256sums-unsigned-build.incrementals.txt.asc + for file in sha256sums-unsigned-build.txt sha256sums-unsigned-build.incrementals.txt do tmpfile=$(mktemp) chmod 644 "$tmpfile" - for url in \ - "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ - "https://tb-build-04.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ - "https://tb-build-05.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" + if test "$builder" = 'jb'; then + file="$file.gpg" + urls=("https://cdn.devmole.eu/hashes//$SIGNING_PROJECTNAME/$tbb_version-build$tbb_…") + else + file="$file.asc" + urls=( \ + "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ + "https://tb-build-04.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ + "https://tb-build-05.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ + ) + fi + for url in "${urls[@]}" do if wget -q -O "$tmpfile" "$url"; then mv "$tmpfile" "$signed_version_dir/$file-$builder" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] Bug 41854: Allow overriding download spam protection.
by richard (＠richard) 11 Jul '23

11 Jul '23

richard pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 84e468a9 by hackademix at 2023-07-11T22:19:11+00:00 Bug 41854: Allow overriding download spam protection. - - - - - 4 changed files: - browser/components/downloads/DownloadSpamProtection.sys.mjs - toolkit/components/downloads/DownloadCore.sys.mjs - toolkit/components/downloads/DownloadIntegration.sys.mjs - uriloader/exthandler/nsExternalHelperAppService.cpp Changes: ===================================== browser/components/downloads/DownloadSpamProtection.sys.mjs ===================================== @@ -94,8 +94,9 @@ class WindowSpamProtection { * Add a blocked download to the spamList or increment the count of an * existing blocked download, then notify listeners about this. * @param {String} url + * @param {DownloadSpamEnabler} enabler */ - addDownloadSpam(url) { + addDownloadSpam(url, enabler) { this._blocking = true; // Start listening on registered downloads views, if any exist. this._maybeAddViews(); @@ -109,7 +110,7 @@ class WindowSpamProtection { } // Otherwise, create a new DownloadSpam object for the URL, add it to the // spamList, and open the downloads panel. - let downloadSpam = new DownloadSpam(url); + let downloadSpam = new DownloadSpam(url, enabler); this.spamList.add(downloadSpam); this._downloadSpamForUrl.set(url, downloadSpam); this._notifyDownloadSpamAdded(downloadSpam); @@ -193,6 +194,39 @@ class WindowSpamProtection { } } +/** + * Helper to grant a certain principal permission for automatic downloads + * and to clear its download spam messages from the UI + */ +class DownloadSpamEnabler{ + /** + * Constructs a DownloadSpamEnabler object + * @param {nsIPrincipal} principal + * @param {DownloadSpamProtection} downloadSpamProtection + */ + constructor(principal, downloadSpamProtection) { + this.principal = principal; + this.downloadSpamProtection = downloadSpamProtection; + } + /** + * Allows a DownloadSpam item + * @param {DownloadSpam} downloadSpam + */ + allow(downloadSpam) { + const pm = Services.perms; + pm.addFromPrincipal( + this.principal, + "automatic-download", + pm.ALLOW_ACTION, + pm.EXPIRE_SESSION + ); + downloadSpam.hasBlockedData = downloadSpam.hasPartialData = false; + const {url} = downloadSpam.source; + for (let window of lazy.BrowserWindowTracker.orderedWindows) { + this.downloadSpamProtection.removeDownloadSpamForWindow(url, window); + } + } +} /** * Responsible for detecting events related to downloads spam and notifying the * relevant window's WindowSpamProtection object. This is a singleton object, @@ -210,9 +244,11 @@ export class DownloadSpamProtection { * download was blocked. This is invoked when a download is blocked by * nsExternalAppHandler::IsDownloadSpam * @param {String} url - * @param {Window} window + * @param {nsILoadInfo} loadInfo */ - update(url, window) { + update(url, loadInfo) { + loadInfo = loadInfo.QueryInterface(Ci.nsILoadInfo); + const window = loadInfo.browsingContext.topChromeWindow; if (window == null) { lazy.DownloadsCommon.log( "Download spam blocked in a non-chrome window. URL: ", @@ -226,7 +262,7 @@ export class DownloadSpamProtection { let wsp = this._forWindowMap.get(window) ?? new WindowSpamProtection(window); this._forWindowMap.set(window, wsp); - wsp.addDownloadSpam(url); + wsp.addDownloadSpam(url, new DownloadSpamEnabler(loadInfo.triggeringPrincipal, this)); } /** @@ -285,8 +321,9 @@ export class DownloadSpamProtection { * @extends Download */ class DownloadSpam extends Download { - constructor(url) { + constructor(url, downloadSpamEnabler) { super(); + this._downloadSpamEnabler = downloadSpamEnabler; this.hasBlockedData = true; this.stopped = true; this.error = new DownloadError({ @@ -297,4 +334,13 @@ class DownloadSpam extends Download { this.source = { url }; this.blockedDownloadsCount = 1; } + + /** + * Allows the principal which triggered this download to perform automatic downloads + * and clears the UI from messages reporting this download spam + */ + allow() { + this._downloadSpamEnabler.allow(this); + this._notifyChange(); + } } ===================================== toolkit/components/downloads/DownloadCore.sys.mjs ===================================== @@ -713,6 +713,10 @@ Download.prototype = { } this._promiseUnblock = (async () => { + if (this.allow) { + this.allow(); + return; + } try { await IOUtils.move(this.target.partFilePath, this.target.path); await this.target.refresh(); @@ -721,7 +725,6 @@ Download.prototype = { this._promiseUnblock = null; throw ex; } - this.succeeded = true; this.hasBlockedData = false; this._notifyChange(); @@ -951,7 +954,9 @@ Download.prototype = { await this._promiseCanceled; } // Ask the saver object to remove any partial data. - await this.saver.removeData(); + if (this.saver) { + await this.saver.removeData(); + } // For completeness, clear the number of bytes transferred. if (this.currentBytes != 0 || this.hasPartialData) { this.currentBytes = 0; ===================================== toolkit/components/downloads/DownloadIntegration.sys.mjs ===================================== @@ -1162,7 +1162,7 @@ var DownloadObserver = { DownloadIntegration._initializeDownloadSpamProtection(); DownloadIntegration.downloadSpamProtection.update( aData, - aSubject.topChromeWindow + aSubject ); } break; ===================================== uriloader/exthandler/nsExternalHelperAppService.cpp ===================================== @@ -1907,13 +1907,11 @@ bool nsExternalAppHandler::IsDownloadSpam(nsIChannel* aChannel) { if (capability == nsIPermissionManager::PROMPT_ACTION) { nsCOMPtr<nsIObserverService> observerService = mozilla::services::GetObserverService(); - RefPtr<BrowsingContext> browsingContext; - loadInfo->GetBrowsingContext(getter_AddRefs(browsingContext)); nsAutoCString cStringURI; loadInfo->TriggeringPrincipal()->GetPrePath(cStringURI); observerService->NotifyObservers( - browsingContext, "blocked-automatic-download", + loadInfo, "blocked-automatic-download", NS_ConvertASCIItoUTF16(cStringURI.get()).get()); // FIXME: In order to escape memory leaks, currently we cancel blocked // downloads. This is temporary solution, because download data should be View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/84e468a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/84e468a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] Bug 41854: Allow overriding download spam protection.
by richard (＠richard) 11 Jul '23

11 Jul '23

richard pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 5d4adde4 by hackademix at 2023-07-11T21:46:55+00:00 Bug 41854: Allow overriding download spam protection. - - - - - 4 changed files: - browser/components/downloads/DownloadSpamProtection.sys.mjs - toolkit/components/downloads/DownloadCore.sys.mjs - toolkit/components/downloads/DownloadIntegration.sys.mjs - uriloader/exthandler/nsExternalHelperAppService.cpp Changes: ===================================== browser/components/downloads/DownloadSpamProtection.sys.mjs ===================================== @@ -94,8 +94,9 @@ class WindowSpamProtection { * Add a blocked download to the spamList or increment the count of an * existing blocked download, then notify listeners about this. * @param {String} url + * @param {DownloadSpamEnabler} enabler */ - addDownloadSpam(url) { + addDownloadSpam(url, enabler) { this._blocking = true; // Start listening on registered downloads views, if any exist. this._maybeAddViews(); @@ -109,7 +110,7 @@ class WindowSpamProtection { } // Otherwise, create a new DownloadSpam object for the URL, add it to the // spamList, and open the downloads panel. - let downloadSpam = new DownloadSpam(url); + let downloadSpam = new DownloadSpam(url, enabler); this.spamList.add(downloadSpam); this._downloadSpamForUrl.set(url, downloadSpam); this._notifyDownloadSpamAdded(downloadSpam); @@ -193,6 +194,39 @@ class WindowSpamProtection { } } +/** + * Helper to grant a certain principal permission for automatic downloads + * and to clear its download spam messages from the UI + */ +class DownloadSpamEnabler{ + /** + * Constructs a DownloadSpamEnabler object + * @param {nsIPrincipal} principal + * @param {DownloadSpamProtection} downloadSpamProtection + */ + constructor(principal, downloadSpamProtection) { + this.principal = principal; + this.downloadSpamProtection = downloadSpamProtection; + } + /** + * Allows a DownloadSpam item + * @param {DownloadSpam} downloadSpam + */ + allow(downloadSpam) { + const pm = Services.perms; + pm.addFromPrincipal( + this.principal, + "automatic-download", + pm.ALLOW_ACTION, + pm.EXPIRE_SESSION + ); + downloadSpam.hasBlockedData = downloadSpam.hasPartialData = false; + const {url} = downloadSpam.source; + for (let window of lazy.BrowserWindowTracker.orderedWindows) { + this.downloadSpamProtection.removeDownloadSpamForWindow(url, window); + } + } +} /** * Responsible for detecting events related to downloads spam and notifying the * relevant window's WindowSpamProtection object. This is a singleton object, @@ -210,9 +244,11 @@ export class DownloadSpamProtection { * download was blocked. This is invoked when a download is blocked by * nsExternalAppHandler::IsDownloadSpam * @param {String} url - * @param {Window} window + * @param {nsILoadInfo} loadInfo */ - update(url, window) { + update(url, loadInfo) { + loadInfo = loadInfo.QueryInterface(Ci.nsILoadInfo); + const window = loadInfo.browsingContext.topChromeWindow; if (window == null) { lazy.DownloadsCommon.log( "Download spam blocked in a non-chrome window. URL: ", @@ -226,7 +262,7 @@ export class DownloadSpamProtection { let wsp = this._forWindowMap.get(window) ?? new WindowSpamProtection(window); this._forWindowMap.set(window, wsp); - wsp.addDownloadSpam(url); + wsp.addDownloadSpam(url, new DownloadSpamEnabler(loadInfo.triggeringPrincipal, this)); } /** @@ -285,8 +321,9 @@ export class DownloadSpamProtection { * @extends Download */ class DownloadSpam extends Download { - constructor(url) { + constructor(url, downloadSpamEnabler) { super(); + this._downloadSpamEnabler = downloadSpamEnabler; this.hasBlockedData = true; this.stopped = true; this.error = new DownloadError({ @@ -297,4 +334,13 @@ class DownloadSpam extends Download { this.source = { url }; this.blockedDownloadsCount = 1; } + + /** + * Allows the principal which triggered this download to perform automatic downloads + * and clears the UI from messages reporting this download spam + */ + allow() { + this._downloadSpamEnabler.allow(this); + this._notifyChange(); + } } ===================================== toolkit/components/downloads/DownloadCore.sys.mjs ===================================== @@ -713,6 +713,10 @@ Download.prototype = { } this._promiseUnblock = (async () => { + if (this.allow) { + this.allow(); + return; + } try { await IOUtils.move(this.target.partFilePath, this.target.path); await this.target.refresh(); @@ -721,7 +725,6 @@ Download.prototype = { this._promiseUnblock = null; throw ex; } - this.succeeded = true; this.hasBlockedData = false; this._notifyChange(); @@ -951,7 +954,9 @@ Download.prototype = { await this._promiseCanceled; } // Ask the saver object to remove any partial data. - await this.saver.removeData(); + if (this.saver) { + await this.saver.removeData(); + } // For completeness, clear the number of bytes transferred. if (this.currentBytes != 0 || this.hasPartialData) { this.currentBytes = 0; ===================================== toolkit/components/downloads/DownloadIntegration.sys.mjs ===================================== @@ -1162,7 +1162,7 @@ var DownloadObserver = { DownloadIntegration._initializeDownloadSpamProtection(); DownloadIntegration.downloadSpamProtection.update( aData, - aSubject.topChromeWindow + aSubject ); } break; ===================================== uriloader/exthandler/nsExternalHelperAppService.cpp ===================================== @@ -1907,13 +1907,11 @@ bool nsExternalAppHandler::IsDownloadSpam(nsIChannel* aChannel) { if (capability == nsIPermissionManager::PROMPT_ACTION) { nsCOMPtr<nsIObserverService> observerService = mozilla::services::GetObserverService(); - RefPtr<BrowsingContext> browsingContext; - loadInfo->GetBrowsingContext(getter_AddRefs(browsingContext)); nsAutoCString cStringURI; loadInfo->TriggeringPrincipal()->GetPrePath(cStringURI); observerService->NotifyObservers( - browsingContext, "blocked-automatic-download", + loadInfo, "blocked-automatic-download", NS_ConvertASCIItoUTF16(cStringURI.get()).get()); // FIXME: In order to escape memory leaks, currently we cancel blocked // downloads. This is temporary solution, because download data should be View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5d4adde… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5d4adde… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] 25 commits: fixup! Bug 40933: Add tor-launcher functionality
by richard (＠richard) 11 Jul '23

11 Jul '23

richard pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 1492a00d by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 40933: Add tor-launcher functionality Switched to ES modules for this commit. - - - - - 60a28f46 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 40933: Add tor-launcher functionality Implemented a function for getting GETINFO net/listeners/socks. - - - - - 168a3899 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove unused assets. - - - - - 5bea8348 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove part of the about:tor additions from the torbutton commit to move them to a commit on their own. - - - - - e089589f by Kathleen Brade at 2023-07-11T21:38:01+00:00 Bug 7494: Create local home page for TBB. - - - - - fa669b81 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. Removed unused mobile CSS - - - - - 448ac064 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. Moved aboutTor.xhtml to its new location and make it use more modern IPC mechanisms. - - - - - 1aeaceb8 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. First step toward IPC modernizartion (WIP). - - - - - 1865d68c by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. Populate the page with real data. - - - - - 8d33aa91 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Do not send data to about:tor on Torbutton anymore. - - - - - ec0f4a89 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Move the Tor checking functions from torbutton.js to its file. Also, rework the file a little bit, to make it an ES module, and import the file directly, instead of using XPCOM. - - - - - 61c0fed5 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. Get the TorCheckService by importing the module, instead of using XPCOM. - - - - - ee3f0a7f by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Continued to rework TorCheckService. Use a ConsoleAPI logger instead of the old Torbutton logger. Reworked the local check, to delegate TorProtocolService to get the listeners, and then improved the rest of the function, in general. Finally, changed the topic name, and notify observers whenever the status change, also if suddenly the check succeeded. - - - - - 2a10a930 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. If we know that TorCheckService already failed, or that we are invoked by an observer, do not wait for the test again, but show the result immediately. If it changes, the observer will trigger another page update. - - - - - 9fcb8789 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Reworked the remote check of TorCheckService. - - - - - 1ed38c58 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Move the check service to the about:tor commit. - - - - - 983b1f77 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 7494: Create local home page for TBB. Move TorCheckService here, since it is used only for about:tor. Move here also the check for the TOR_DEFAULT_HOMEPAGE variable. - - - - - 3173b2c0 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Stop customizing the about dialog in the Torbutton commit. - - - - - 71a828ca by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Customize the about dialog in the branding commit. This actually depends on the strings commit, but maybe we could move it to earlier in the patchset. - - - - - 993f3151 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 41842: Remove the logic to remove cookies|protected-*json Removed the function that deleted some cookie JSON preference file. The function was introduced in torbutton@2dfa0e0c9cff7cfad93664e0b0b6cdc05b24b7f2 in 2019. However, since we have had a watershed release, we don't need it anymore. And because of the 12.0 watershed, we do not need to mess up with some these preferences anymore. - - - - - 4f033ea0 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 40933: Add tor-launcher functionality Bug 41842: Stop migrating torrc: we have not written control/socks ports to it for years! - - - - - e75aa843 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 41845: Do not force pref values for non-PBM users anymore. A preference cleanup function will be added later, when we finish removing all the torbutton stuff. - - - - - 7943e632 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Add default values for preferencs in the logger. I anticipated the removal of the old defaults, since the logger is going away with another MR, but the cleanup function was already in this one. - - - - - a5366a9a by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Remove the defaults for the old preferences we are deleting. - - - - - cda83a31 by Pier Angelo Vendrame at 2023-07-11T21:38:01+00:00 fixup! Bug 41435: Add a Tor Browser migration function Bug 41845: Clear user values for the prefs we decided not to force anymore. Also, remove some old Torbutton preferences. - - - - - 30 changed files: - browser/app/profile/000-tor-browser.js - browser/base/content/aboutDialog.xhtml - toolkit/torbutton/chrome/skin/aboutDialog.css → browser/base/content/aboutDialogTor.css - browser/base/jar.mn - browser/components/BrowserGlue.sys.mjs - + browser/components/abouttor/AboutTorChild.sys.mjs - + browser/components/abouttor/AboutTorParent.sys.mjs - + browser/components/abouttor/HomepageOverride.sys.mjs - + browser/components/abouttor/TorCheckService.sys.mjs - toolkit/torbutton/chrome/skin/aboutTor.css → browser/components/abouttor/content/aboutTor.css - + browser/components/abouttor/content/aboutTor.js - + browser/components/abouttor/content/aboutTor.xhtml - toolkit/torbutton/chrome/skin/banner-warning.svg → browser/components/abouttor/content/banner-warning.svg - toolkit/torbutton/chrome/skin/dax-logo.svg → browser/components/abouttor/content/dax-logo.svg - + browser/components/abouttor/jar.mn - + browser/components/abouttor/moz.build - browser/components/moz.build - docshell/base/nsAboutRedirector.cpp - toolkit/components/tor-launcher/TorBootstrapRequest.jsm → toolkit/components/tor-launcher/TorBootstrapRequest.sys.mjs - toolkit/components/tor-launcher/TorLauncherUtil.jsm → toolkit/components/tor-launcher/TorLauncherUtil.sys.mjs - toolkit/components/tor-launcher/TorMonitorService.jsm → toolkit/components/tor-launcher/TorMonitorService.sys.mjs - toolkit/components/tor-launcher/TorParsers.jsm → toolkit/components/tor-launcher/TorParsers.sys.mjs - toolkit/components/tor-launcher/TorProcess.jsm → toolkit/components/tor-launcher/TorProcess.sys.mjs - toolkit/components/tor-launcher/TorProtocolService.jsm → toolkit/components/tor-launcher/TorProtocolService.sys.mjs - toolkit/components/tor-launcher/TorStartupService.jsm → toolkit/components/tor-launcher/TorStartupService.sys.mjs - toolkit/components/tor-launcher/components.conf - toolkit/components/tor-launcher/moz.build - toolkit/themes/shared/desktop-jar.inc.mn - toolkit/torbutton/chrome/skin/about-wordmark.png → toolkit/themes/shared/illustrations/about-wordmark.png - − toolkit/torbutton/chrome/content/aboutTor/aboutTor-content.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/a884f3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/a884f3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-bundle-testsuite][main] Bug 40075: Move nightly builds from tb-build-01 to tb-build-06
by richard (＠richard) 11 Jul '23

11 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-bundle-testsuite Commits: 1d3428d9 by Nicolas Vigier at 2023-07-05T18:22:14+02:00 Bug 40075: Move nightly builds from tb-build-01 to tb-build-06 - - - - - 3 changed files: - config/tb-build-01.torproject.org → config/tb-build-06.torproject.org - rbm-config/tb-build-01.torproject.org.rbm.local.conf → rbm-config/tb-build-06.torproject.org.rbm.local.conf - tools/tb-build-01-start-nightly-build → tools/tb-build-06-start-nightly-build Changes: ===================================== config/tb-build-01.torproject.org → config/tb-build-06.torproject.org ===================================== @@ -36,7 +36,7 @@ my $testsuite = TBBTestSuite::TestSuite::TorBrowserBuild->new({ tbb_version => $tbb_version, publish_dir => "$builds_dir_root/tor-browser-builds/$tbb_version", publish_url => "https://nightlies.tbb.torproject.org/nightly-builds/tor-browser-builds/$tbb…", - rbm_local_conf => "$FindBin::Bin/rbm-config/tb-build-01.torproject.org.rbm.local.conf", + rbm_local_conf => "$FindBin::Bin/rbm-config/tb-build-06.torproject.org.rbm.local.conf", make_clean => 1, }); @@ -56,7 +56,7 @@ my %res = ( 'pierov(a)torproject.org', 'richard(a)torproject.org', ], - 'email-from' => 'Tor Browser Nightly Builds <tb-builder(a)tb-build-01.torproject.org>', + 'email-from' => 'Tor Browser Nightly Builds <tb-builder(a)tb-build-06.torproject.org>', 'test_post' => $run_rsync, ); %res; ===================================== rbm-config/tb-build-01.torproject.org.rbm.local.conf → rbm-config/tb-build-06.torproject.org.rbm.local.conf ===================================== ===================================== tools/tb-build-01-start-nightly-build → tools/tb-build-06-start-nightly-build ===================================== @@ -2,7 +2,7 @@ set -e function getlock { - lockfile=/run/lock/tb-build-01-start-nightly-build.lock + lockfile=/run/lock/tb-build-06-start-nightly-build.lock if test -f $lockfile then old_pid=$(cat $lockfile) @@ -25,7 +25,7 @@ today_version=$(date '+tbb-nightly.%Y.%m.%d') cd /home/tb-builder/tor-browser-bundle-testsuite export RBM_NO_DEBUG=1 -./tbb-testsuite --config=tb-build-01.torproject.org "$@" +./tbb-testsuite --config=tb-build-06.torproject.org "$@" # Archive today's build archive_dir=~/tor-browser-builds-archive/"$today_version" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] fixup! Bug 41698: Reword the recommendation badges in about:addons
by ma1 (＠ma1) 11 Jul '23

11 Jul '23

ma1 pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: eba10c40 by hackademix at 2023-07-11T16:45:09+02:00 fixup! Bug 41698: Reword the recommendation badges in about:addons - - - - - 3 changed files: - toolkit/content/widgets/moz-support-link/moz-support-link.mjs - toolkit/mozapps/extensions/content/aboutaddons.html - toolkit/mozapps/extensions/content/aboutaddons.js Changes: ===================================== toolkit/content/widgets/moz-support-link/moz-support-link.mjs ===================================== @@ -52,6 +52,23 @@ export default class MozSupportLink extends HTMLAnchorElement { this.setAttribute("target", "_blank"); this.addEventListener("click", this); if (!this.getAttribute("data-l10n-id")) { + const fixupL10nId = this.getAttribute("data-basebrowser-l10n-fixup"); + if (fixupL10nId) { + document.l10n.formatValue(fixupL10nId).then(title => { + this.setAttribute("title", title); + // NOTE: Mozilla adds identical aria-label and title attributes. This is + // generally bad practice because this link has no text content, so the + // title alone will already act as the accessible name. + // Normally setting both aria-label and title will lead to the title being + // used as the accessible description, but since they are identical + // the LocalAccessible::Description method will make an exception and keep + // the description empty. + // Since this component is outside of our fork's control, we follow the + // same practice just in case Mozilla ever adds some text content. + this.setAttribute("aria-label", title); + }); + return; + } document.l10n.setAttributes(this, "moz-support-link-text"); } document.l10n.translateFragment(this); ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -359,6 +359,7 @@ is="moz-support-link" support-page="add-on-badges" utm-content="promoted-addon-badge" + data-basebrowser-l10n-fixup="basebrowser-addon-badge-recommended" hidden > </a> @@ -376,6 +377,7 @@ is="moz-support-link" support-page="add-on-badges" utm-content="promoted-addon-badge" + data-basebrowser-l10n-fixup="basebrowser-addon-badge-verified" hidden > </a> ===================================== toolkit/mozapps/extensions/content/aboutaddons.js ===================================== @@ -4220,29 +4220,6 @@ async function initialize() { ); } } - - // At the moment we need to do this, because Weblate still does not support - // attributes in Fluent. - const [recommended, verified] = await document.l10n.formatValues([ - { id: "basebrowser-addon-badge-recommended" }, - { id: "basebrowser-addon-badge-verified" }, - ]); - - importTemplate("card"); - _templates.card.content - .querySelector(".addon-badge-recommended") - .setAttribute("title", recommended); - _templates.card.content - .querySelector(".addon-badge-verified") - .setAttribute("title", verified); - - // We also update any template copy that has already been created. - for (const badge of document.querySelectorAll(".addon-badge-recommended")) { - badge.setAttribute("title", recommended); - } - for (const badge of document.querySelectorAll(".addon-badge-verified")) { - badge.setAttribute("title", verified); - } } window.promiseInitialized = new Promise(resolve => { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/eba10c4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/eba10c4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] fixup! Bug 40069: Add helpers for message passing with extensions
by Pier Angelo Vendrame (＠pierov) 11 Jul '23

11 Jul '23

Pier Angelo Vendrame pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 95d711c9 by Pier Angelo Vendrame at 2023-07-11T16:41:03+02:00 fixup! Bug 40069: Add helpers for message passing with extensions Bug 41877: Fix the NoScript message passing function - - - - - 1 changed file: - toolkit/components/extensions/ExtensionParent.sys.mjs Changes: ===================================== toolkit/components/extensions/ExtensionParent.sys.mjs ===================================== @@ -2274,7 +2274,7 @@ async function torSendExtensionMessage(extensionId, message) { // pages listening to browser.runtime.onMessage. const result = await ProxyMessenger.conduit.castRuntimeMessage("messenger", { extensionId, - holder: new StructuredCloneHolder(message), + holder: new StructuredCloneHolder("torSendExtensionMessage", null, message), firstResponse: true, sender: { id: extensionId, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/95d711c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/95d711c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] fixup! Bug 41698: Reword the recommendation badges in about:addons
by ma1 (＠ma1) 11 Jul '23

11 Jul '23

ma1 pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: a884f352 by hackademix at 2023-07-11T15:48:11+02:00 fixup! Bug 41698: Reword the recommendation badges in about:addons - - - - - 3 changed files: - toolkit/content/widgets/moz-support-link/moz-support-link.mjs - toolkit/mozapps/extensions/content/aboutaddons.html - toolkit/mozapps/extensions/content/aboutaddons.js Changes: ===================================== toolkit/content/widgets/moz-support-link/moz-support-link.mjs ===================================== @@ -52,6 +52,23 @@ export default class MozSupportLink extends HTMLAnchorElement { this.setAttribute("target", "_blank"); this.addEventListener("click", this); if (!this.getAttribute("data-l10n-id")) { + const fixupL10nId = this.getAttribute("data-basebrowser-l10n-fixup"); + if (fixupL10nId) { + document.l10n.formatValue(fixupL10nId).then(title => { + this.setAttribute("title", title); + // NOTE: Mozilla adds identical aria-label and title attributes. This is + // generally bad practice because this link has no text content, so the + // title alone will already act as the accessible name. + // Normally setting both aria-label and title will lead to the title being + // used as the accessible description, but since they are identical + // the LocalAccessible::Description method will make an exception and keep + // the description empty. + // Since this component is outside of our fork's control, we follow the + // same practice just in case Mozilla ever adds some text content. + this.setAttribute("aria-label", title); + }); + return; + } document.l10n.setAttributes(this, "moz-support-link-text"); } document.l10n.translateFragment(this); ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -359,6 +359,7 @@ is="moz-support-link" support-page="add-on-badges" utm-content="promoted-addon-badge" + data-basebrowser-l10n-fixup="basebrowser-addon-badge-recommended" hidden > </a> @@ -376,6 +377,7 @@ is="moz-support-link" support-page="add-on-badges" utm-content="promoted-addon-badge" + data-basebrowser-l10n-fixup="basebrowser-addon-badge-verified" hidden > </a> ===================================== toolkit/mozapps/extensions/content/aboutaddons.js ===================================== @@ -4220,29 +4220,6 @@ async function initialize() { ); } } - - // At the moment we need to do this, because Weblate still does not support - // attributes in Fluent. - const [recommended, verified] = await document.l10n.formatValues([ - { id: "basebrowser-addon-badge-recommended" }, - { id: "basebrowser-addon-badge-verified" }, - ]); - - importTemplate("card"); - _templates.card.content - .querySelector(".addon-badge-recommended") - .setAttribute("title", recommended); - _templates.card.content - .querySelector(".addon-badge-verified") - .setAttribute("title", verified); - - // We also update any template copy that has already been created. - for (const badge of document.querySelectorAll(".addon-badge-recommended")) { - badge.setAttribute("title", recommended); - } - for (const badge of document.querySelectorAll(".addon-badge-verified")) { - badge.setAttribute("title", verified); - } } window.promiseInitialized = new Promise(resolve => { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a884f35… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a884f35… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] fixup! Bug 40069: Add helpers for message passing with extensions
by Pier Angelo Vendrame (＠pierov) 11 Jul '23

11 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e431eb45 by Pier Angelo Vendrame at 2023-07-11T12:17:35+02:00 fixup! Bug 40069: Add helpers for message passing with extensions Bug 41877: Fix the NoScript message passing function - - - - - 1 changed file: - toolkit/components/extensions/ExtensionParent.sys.mjs Changes: ===================================== toolkit/components/extensions/ExtensionParent.sys.mjs ===================================== @@ -2274,7 +2274,7 @@ async function torSendExtensionMessage(extensionId, message) { // pages listening to browser.runtime.onMessage. const result = await ProxyMessenger.conduit.castRuntimeMessage("messenger", { extensionId, - holder: new StructuredCloneHolder(message), + holder: new StructuredCloneHolder("torSendExtensionMessage", null, message), firstResponse: true, sender: { id: extensionId, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e431eb4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e431eb4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40895: Update go_vendor_sha256sum for lyrebird in nightly
by richard (＠richard) 06 Jul '23

06 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: af4a370f by Nicolas Vigier at 2023-07-06T20:03:30+00:00 Bug 40895: Update go_vendor_sha256sum for lyrebird in nightly - - - - - 1 changed file: - projects/lyrebird/config Changes: ===================================== projects/lyrebird/config ===================================== @@ -17,7 +17,7 @@ targets: version: '[% c("abbrev") %]' tag_gpg_id: 0 var: - go_vendor_sha256sum: d95d1fa8ce3904b76395b20ef169e8ef2b039fa485764b74739bb6290631537d + go_vendor_sha256sum: 8e9a5fd52f5a3a2b2b891389a224fcfc83b6c081658161bf40882b23fb58834c steps: build: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40894: Fix format of keyring/boklm.gpg
by richard (＠richard) 06 Jul '23

06 Jul '23

richard pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 16785a1b by Nicolas Vigier at 2023-07-06T19:52:01+00:00 Bug 40894: Fix format of keyring/boklm.gpg In #40871 I incorrectly set `keyring/boklm.gpg` in format `GPG keybox database version 1`, instead of `PGP/GPG key public ring (v4)`. This was fixed with: gpg --no-default-keyring --keyring ./keyring/boklm.gpg --export > ./keyring/boklm-2.gpg mv ./keyring/boklm-2.gpg ./keyring/boklm.gpg - - - - - 1 changed file: - keyring/boklm.gpg Changes: ===================================== keyring/boklm.gpg ===================================== Binary files a/keyring/boklm.gpg and b/keyring/boklm.gpg differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40894: Fix format of keyring/boklm.gpg
by richard (＠richard) 06 Jul '23

06 Jul '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 6e2c33ed by Nicolas Vigier at 2023-07-04T12:11:47+02:00 Bug 40894: Fix format of keyring/boklm.gpg In #40871 I incorrectly set `keyring/boklm.gpg` in format `GPG keybox database version 1`, instead of `PGP/GPG key public ring (v4)`. This was fixed with: gpg --no-default-keyring --keyring ./keyring/boklm.gpg --export > ./keyring/boklm-2.gpg mv ./keyring/boklm-2.gpg ./keyring/boklm.gpg - - - - - 1 changed file: - keyring/boklm.gpg Changes: ===================================== keyring/boklm.gpg ===================================== Binary files a/keyring/boklm.gpg and b/keyring/boklm.gpg differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.0esrbase-13.0-1] Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons
by ma1 (＠ma1) 06 Jul '23

06 Jul '23

ma1 pushed to branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e4fae18a by hackademix at 2023-07-06T15:46:27+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 1 changed file: - toolkit/mozapps/extensions/content/aboutaddons.js Changes: ===================================== toolkit/mozapps/extensions/content/aboutaddons.js ===================================== @@ -1492,8 +1492,9 @@ class AddonOptions extends HTMLElement { el.disabled = false; el.hidden = false; document.l10n.setAttributes(el, "remove-addon-button"); - } else if (addon.isBuiltin) { - // Likely the built-in themes, can't be removed, that's fine. + } else if (true || addon.isBuiltin) { + // Just hide the uninstall button for any "special" add-on + // which can't be removed (tor-browser#41834) el.hidden = true; } else { // Likely sideloaded, mention that it can't be removed with a link. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4fae18… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4fae18… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons
by ma1 (＠ma1) 06 Jul '23

06 Jul '23

ma1 pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: b06f6190 by hackademix at 2023-07-06T00:10:24+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 1 changed file: - toolkit/mozapps/extensions/content/aboutaddons.js Changes: ===================================== toolkit/mozapps/extensions/content/aboutaddons.js ===================================== @@ -1492,8 +1492,9 @@ class AddonOptions extends HTMLElement { el.disabled = false; el.hidden = false; document.l10n.setAttributes(el, "remove-addon-button"); - } else if (addon.isBuiltin) { - // Likely the built-in themes, can't be removed, that's fine. + } else if (true || addon.isBuiltin) { + // Just hide the uninstall button for any "special" add-on + // which can't be removed (tor-browser#41834) el.hidden = true; } else { // Likely sideloaded, mention that it can't be removed with a link. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b06f619… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b06f619… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.0esrbase-13.0-1-build1
by richard (＠richard) 05 Jul '23

05 Jul '23

richard pushed new tag base-browser-115.0esrbase-13.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.0esrbase-13.0-1
by richard (＠richard) 05 Jul '23

05 Jul '23

richard pushed new branch base-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] fixup! Adding issue and merge request templates
by richard (＠richard) 05 Jul '23

05 Jul '23

richard pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 33fdfcfc by Richard Pospesel at 2023-07-05T16:04:41+00:00 fixup! Adding issue and merge request templates - - - - - 1 changed file: - .gitlab/merge_request_templates/default.md Changes: ===================================== .gitlab/merge_request_templates/default.md ===================================== @@ -25,12 +25,34 @@ ### Merging - [ ] Merge to `tor-browser` - `!fixups` to `tor-browser`-specific commits, new features, security backports -- [ ] Merge to `base-browser` -`!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports +- [ ] Merge to `base-browser` - `!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports - **NOTE**: if your changeset includes patches to both `base-browser` and `tor-browser` please clearly label in the change description which commits should be cherry-picked to `base-browser` after merging ### Issue Tracking - [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation -## Change Description - - \ No newline at end of file +### Review + +#### Request Reviewer + +- [ ] Request review from an applications developer depending on modified system: + - **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer) + - **accessibility** : henry + - **android** : dan + - **build system** : boklm + - **extensions** : ma1 + - **firefox internals (XUL/JS/XPCOM)** : ma1 + - **fonts** : pierov + - **frontend (implementation)** : henry + - **frontend (review)** : donuts, richard + - **localization** : henry, pierov + - **nightly builds** : boklm + - **rebases/release-prep** : dan_b, ma1, pierov, richard + - **security** : ma1 + - **signing** : boklm, richard + - **updater** : pierov + - **misc/other** : pierov, richard + +#### Change Description + + View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/33fdfcf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/33fdfcf… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] release: new version, 12.5.1
by richard (＠richard) 04 Jul '23

04 Jul '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 0b1f5144 by Richard Pospesel at 2023-07-04T17:00:34+00:00 release: new version, 12.5.1 - - - - - 30 changed files: - update_3/release/.htaccess - − update_3/release/12.0.5-12.5-linux32-ALL.xml - − update_3/release/12.0.5-12.5-linux64-ALL.xml - − update_3/release/12.0.5-12.5-macos-ALL.xml - − update_3/release/12.0.5-12.5-win32-ALL.xml - − update_3/release/12.0.5-12.5-win64-ALL.xml - − update_3/release/12.0.6-12.5-linux32-ALL.xml - − update_3/release/12.0.6-12.5-linux64-ALL.xml - − update_3/release/12.0.6-12.5-macos-ALL.xml - − update_3/release/12.0.6-12.5-win32-ALL.xml - − update_3/release/12.0.6-12.5-win64-ALL.xml - + update_3/release/12.0.6-12.5.1-linux32-ALL.xml - + update_3/release/12.0.6-12.5.1-linux64-ALL.xml - + update_3/release/12.0.6-12.5.1-macos-ALL.xml - + update_3/release/12.0.6-12.5.1-win32-ALL.xml - + update_3/release/12.0.6-12.5.1-win64-ALL.xml - − update_3/release/12.0.7-12.5-linux32-ALL.xml - − update_3/release/12.0.7-12.5-linux64-ALL.xml - − update_3/release/12.0.7-12.5-macos-ALL.xml - − update_3/release/12.0.7-12.5-win32-ALL.xml - − update_3/release/12.0.7-12.5-win64-ALL.xml - + update_3/release/12.0.7-12.5.1-linux32-ALL.xml - + update_3/release/12.0.7-12.5.1-linux64-ALL.xml - + update_3/release/12.0.7-12.5.1-macos-ALL.xml - + update_3/release/12.0.7-12.5.1-win32-ALL.xml - + update_3/release/12.0.7-12.5.1-win64-ALL.xml - + update_3/release/12.5-12.5.1-linux32-ALL.xml - + update_3/release/12.5-12.5.1-linux64-ALL.xml - + update_3/release/12.5-12.5.1-macos-ALL.xml - + update_3/release/12.5-12.5.1-win32-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
by Pier Angelo Vendrame (＠pierov) 04 Jul '23

04 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 339eec2e by cypherpunks1 at 2023-07-03T11:42:15-08:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40577: Add "suggest url" in DDG onion's manifest - - - - - 1 changed file: - browser/components/search/extensions/ddg-onion/manifest.json Changes: ===================================== browser/components/search/extensions/ddg-onion/manifest.json ===================================== @@ -20,7 +20,9 @@ "name": "DuckDuckGoOnion", "search_url": "https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion", "search_form": "https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/?q={…", - "search_url_get_params": "q={searchTerms}" + "search_url_get_params": "q={searchTerms}", + "suggest_url": "https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/ac/", + "suggest_url_get_params": "q={searchTerms}&type=list" } } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/339eec2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/339eec2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-12.5.1-build1
by Pier Angelo Vendrame (＠pierov) 04 Jul '23

04 Jul '23

Pier Angelo Vendrame pushed new tag mb-12.5.1-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-12.5.1-build1
by Pier Angelo Vendrame (＠pierov) 03 Jul '23

03 Jul '23

Pier Angelo Vendrame pushed new tag tbb-12.5.1-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40888+40891: Prepared 12.5.1 TBB+MB stable releases
by Pier Angelo Vendrame (＠pierov) 03 Jul '23

03 Jul '23

Pier Angelo Vendrame pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 6cd137bf by Pier Angelo Vendrame at 2023-06-30T11:08:47+02:00 Bug 40888+40891: Prepared 12.5.1 TBB+MB stable releases - - - - - 9 changed files: - projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/allowed_addons.json - projects/browser/config - projects/firefox/config - projects/geckoview/config - projects/manual/config - projects/translation/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -1,3 +1,9 @@ +Mullvad Browser 12.5.1 - July 5 2023 + * All Platforms + * Updated Firefox to 102.13.0esr + * Bug 192: Rebase Mullvad Browser 12.5 stable on top of 102.13esr [mullvad-browser] + * Bug 41854: Download Spam Protection cannot be overridden to allow legitimate downloads [tor-browser] + Mullvad Browser 12.5 - June 21 2023 * All Platforms * Updated uBlock Origin to 1.50.0 ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,16 @@ +Tor Browser 12.5.1 - July 5 2023 + * All Platforms + * Updated Translations + * Updated NoScript to 11.4.24 + * Bug 41860: Rebase 12.5 stable to 102.13esr [tor-browser] + * Windows + macOS + Linux + * Updated Firefox to 102.13.0esr + * Bug 41854: Download Spam Protection cannot be overridden to allow legitimate downloads [tor-browser] + * Bug 41856: Onion service authorization prompt's key field does not get focus when clicked [tor-browser] + * Bug 41858: 'Learn more' link in onboarding links to 12.0 release notes and not 12.5 [tor-browser] + * Android + * Updated GeckoView to 102.13.0esr + Tor Browser 12.5.0 - June 15 2023 * All Platforms * Updated Translations ===================================== projects/browser/allowed_addons.json ===================================== @@ -17,7 +17,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/34/9734/13299734/13299734.pn…" } ], - "average_daily_users": 982673, + "average_daily_users": 976479, "categories": { "android": [ "experimental", @@ -31,7 +31,7 @@ "contributions_url": "https://opencollective.com/darkreader?utm_content=product-page-contribute&u…", "created": "2017-09-19T07:03:00Z", "current_version": { - "id": 5550694, + "id": 5584147, "compatibility": { "firefox": { "min": "54.0", @@ -42,7 +42,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/darkreader/versions/55506…", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/darkreader/versions/55841…", "is_strict_compatibility_enabled": false, "license": { "id": 22, @@ -53,22 +53,22 @@ "url": "http://www.opensource.org/license/mit" }, "release_notes": { - "en-US": "- Site toggle panel (detect dark theme and shortcut).\n- App toggle panel (automation and shortcut).\n- Improved Site List indexing.\n- Users' fixes for websites." + "en-US": "- Using passive event listeners.\n- Fixed System Automation on Firefox.\n- Fixed News section.\n- Users' fixes for websites." }, - "reviewed": "2023-04-13T13:17:06Z", - "version": "4.9.63", + "reviewed": "2023-06-26T12:31:32Z", + "version": "4.9.64", "files": [ { - "id": 4095037, - "created": "2023-04-10T09:52:02Z", - "hash": "sha256:16ba6337fcff7ad85e08ad51b384ba26ff751b2b2ded12309f75e8337ace925a", + "id": 4128489, + "created": "2023-06-22T06:55:05Z", + "hash": "sha256:c09ed43a96dccab1de3445aac263de0569e3333da330d645094e3f938f13b30e", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 658318, + "size": 664243, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4095037/darkreader-4.9.63…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4128489/darkreader-4.9.64…", "permissions": [ "alarms", "contextMenus", @@ -146,7 +146,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2023-04-13T13:17:06Z", + "last_updated": "2023-06-26T12:31:32Z", "name": { "ar": "Dark Reader", "bn": "Dark Reader", @@ -221,10 +221,10 @@ "category": "recommended" }, "ratings": { - "average": 4.5607, - "bayesian_average": 4.559536123193746, - "count": 5044, - "text_count": 1586 + "average": 4.56, + "bayesian_average": 4.5588356415270255, + "count": 5048, + "text_count": 1588 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/reviews/", "requires_payment": false, @@ -321,7 +321,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/versions/", - "weekly_downloads": 22770 + "weekly_downloads": 22317 }, "notes": null }, @@ -337,7 +337,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/56/7656/6937656/6937656.png?…" } ], - "average_daily_users": 256947, + "average_daily_users": 254700, "categories": { "android": [ "security-privacy" @@ -553,8 +553,8 @@ "category": "recommended" }, "ratings": { - "average": 4.8119, - "bayesian_average": 4.807250604207324, + "average": 4.8141, + "bayesian_average": 4.809441565441486, "count": 1345, "text_count": 239 }, @@ -641,7 +641,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/versions/", - "weekly_downloads": 3251 + "weekly_downloads": 3367 }, "notes": null }, @@ -657,7 +657,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/73/4073/5474073/5474073.png?…" } ], - "average_daily_users": 1115434, + "average_daily_users": 1106740, "categories": { "android": [ "security-privacy" @@ -669,7 +669,7 @@ "contributions_url": "https://paypal.me/SupportEFF?utm_content=product-page-contribute&utm_medium…", "created": "2014-05-01T18:23:16Z", "current_version": { - "id": 5580775, + "id": 5584898, "compatibility": { "firefox": { "min": "60.0", @@ -680,7 +680,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/privacy-badger17/versions…", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/privacy-badger17/versions…", "is_strict_compatibility_enabled": false, "license": { "id": 6, @@ -691,22 +691,22 @@ "url": "http://www.gnu.org/licenses/gpl-3.0.html" }, "release_notes": { - "en-US": "<ul><li>Privacy Badger now comes with the largest blocklist yet, thanks to improved tracking detection and continually expanding <a href=\"https://prod.outgoing.prod.webservices.mozgcp.net/v1/e7679342a72ee118b720d9…" rel=\"nofollow\">pre-training</a>. In addition to learning from tracking techniques like cookies and canvas fingerprinting, Privacy Badger now also learns from the <a href=\"https://prod.outgoing.prod.webservices.mozgcp.net/v1/5a177129df8c5230a116e1…" rel=\"nofollow\">Beacon API</a>.</li><li>Fixed blocking trackers from just-closed tabs or from pages you recently navigated away from</li><li>Improved display of tracking domains on the options page on larger screens</li><li>Fixed various site breakages</li><li>Improved Italian translations</li></ul>" + "en-US": "2023.6.23 is a bug fix release addressing various site breakages.\n\nNotes for 2023.6.14:\n<ul><li>Privacy Badger now comes with the largest blocklist yet, thanks to improved tracking detection and continually expanding <a href=\"https://prod.outgoing.prod.webservices.mozgcp.net/v1/e7679342a72ee118b720d9…" rel=\"nofollow\">pre-training</a>. In addition to learning from tracking techniques like cookies and canvas fingerprinting, Privacy Badger now also learns from the <a href=\"https://prod.outgoing.prod.webservices.mozgcp.net/v1/5a177129df8c5230a116e1…" rel=\"nofollow\">Beacon API</a>.</li><li>Fixed blocking trackers from just-closed tabs or from pages you recently navigated away from</li><li>Improved display of tracking domains on the options page on larger screens</li><li>Fixed various site breakages</li><li>Improved Italian translations</li></ul>" }, - "reviewed": "2023-06-19T17:01:43Z", - "version": "2023.6.14", + "reviewed": "2023-06-28T16:18:01Z", + "version": "2023.6.23", "files": [ { - "id": 4125117, - "created": "2023-06-14T17:05:30Z", - "hash": "sha256:feacbe17f76ebb6be90e9f981f6ae396534818b5c1e14c790d70802ed188738d", + "id": 4129240, + "created": "2023-06-23T20:19:09Z", + "hash": "sha256:ce79513710b2aed96bf03ec63d8be2e8274329e8d90911f5b8962c777e006e96", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 1998602, + "size": 1968096, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4125117/privacy_badger17-…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4129240/privacy_badger17-…", "permissions": [ "tabs", "http://*/*", @@ -1134,7 +1134,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2023-06-19T17:01:43Z", + "last_updated": "2023-06-28T16:18:01Z", "name": { "en-US": "Privacy Badger" }, @@ -1180,9 +1180,9 @@ "category": "recommended" }, "ratings": { - "average": 4.7999, - "bayesian_average": 4.797120240256834, - "count": 2244, + "average": 4.8001, + "bayesian_average": 4.797318686786584, + "count": 2246, "text_count": 430 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/reviews/", @@ -1207,7 +1207,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/versions/", - "weekly_downloads": 16215 + "weekly_downloads": 16212 }, "notes": null }, @@ -1223,7 +1223,7 @@ "picture_url": null } ], - "average_daily_users": 6378625, + "average_daily_users": 6343757, "categories": { "android": [ "security-privacy" @@ -1388,7 +1388,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2023-06-21T13:30:28Z", + "last_updated": "2023-06-29T19:20:30Z", "name": { "ar": "uBlock Origin", "bg": "uBlock Origin", @@ -1533,10 +1533,10 @@ "category": "recommended" }, "ratings": { - "average": 4.7817, - "bayesian_average": 4.781300892645942, - "count": 15576, - "text_count": 4053 + "average": 4.7818, + "bayesian_average": 4.781401064910532, + "count": 15597, + "text_count": 4062 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/reviews/", "requires_payment": false, @@ -1598,7 +1598,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/", - "weekly_downloads": 126617 + "weekly_downloads": 124486 }, "notes": null }, @@ -1614,7 +1614,7 @@ "picture_url": null } ], - "average_daily_users": 168607, + "average_daily_users": 168312, "categories": { "android": [ "photos-media" @@ -1713,9 +1713,9 @@ "category": "recommended" }, "ratings": { - "average": 4.4915, - "bayesian_average": 4.486363954483497, - "count": 1121, + "average": 4.492, + "bayesian_average": 4.486860720506839, + "count": 1122, "text_count": 420 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/re…", @@ -1738,7 +1738,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/ve…", - "weekly_downloads": 389 + "weekly_downloads": 341 }, "notes": null }, @@ -1754,7 +1754,7 @@ "picture_url": null } ], - "average_daily_users": 88146, + "average_daily_users": 87436, "categories": { "android": [ "experimental", @@ -1892,7 +1892,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/versions/", - "weekly_downloads": 1518 + "weekly_downloads": 1599 }, "notes": null }, @@ -1908,7 +1908,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/64/9064/12929064/12929064.pn…" } ], - "average_daily_users": 261388, + "average_daily_users": 259583, "categories": { "android": [ "photos-media", @@ -2127,10 +2127,10 @@ "category": "recommended" }, "ratings": { - "average": 4.6521, - "bayesian_average": 4.64742573695812, - "count": 1285, - "text_count": 247 + "average": 4.6496, + "bayesian_average": 4.6449294901011795, + "count": 1287, + "text_count": 248 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/reviews/", "requires_payment": false, @@ -2151,7 +2151,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/versions/", - "weekly_downloads": 3796 + "weekly_downloads": 3731 }, "notes": null }, @@ -2174,7 +2174,7 @@ "picture_url": null } ], - "average_daily_users": 111758, + "average_daily_users": 111659, "categories": { "android": [ "other" @@ -2457,9 +2457,9 @@ "category": "recommended" }, "ratings": { - "average": 4.4424, - "bayesian_average": 4.4377342397439135, - "count": 1216, + "average": 4.4396, + "bayesian_average": 4.43492961003513, + "count": 1217, "text_count": 323 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/reviews/", @@ -2480,7 +2480,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/versions/", - "weekly_downloads": 29 + "weekly_downloads": 17 }, "notes": null }, @@ -2496,7 +2496,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/43/0143/143/143.png?modified…" } ], - "average_daily_users": 309632, + "average_daily_users": 307856, "categories": { "android": [ "performance", @@ -2510,7 +2510,7 @@ "contributions_url": "https://www.paypal.com/donate/?hosted_button_id=9ERKTU5MBH4EW&utm_content=p…", "created": "2005-05-13T10:51:32Z", "current_version": { - "id": 5566736, + "id": 5587303, "compatibility": { "firefox": { "min": "59.0", @@ -2521,7 +2521,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/noscript/versions/5566736", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/noscript/versions/5587303", "is_strict_compatibility_enabled": false, "license": { "id": 13, @@ -2532,22 +2532,22 @@ "url": "http://www.gnu.org/licenses/gpl-2.0.html" }, "release_notes": { - "en-US": "v 11.4.22\n============================================================\nx [L10n] Updated uk\nx Consistently apply DEFAULT policy to top-level data: URLs" + "en-US": "v 11.4.24\n============================================================\nx [XSS] Fix Base64 hash checks interfering with query string\n checks (thanks barbaz for reporting)\nx [TabGuard] Stop exempting domains bidirectionally by\n default\nx [TabGuard] Fix destination domain being reported as the\n trigger of a warning prompt when all the other tab-tied\n domains have been exempted (thanks barbaz for report)" }, - "reviewed": "2023-05-18T09:07:59Z", - "version": "11.4.22", + "reviewed": "2023-06-29T16:56:20Z", + "version": "11.4.24", "files": [ { - "id": 4111078, - "created": "2023-05-15T08:32:54Z", - "hash": "sha256:46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e", + "id": 4131645, + "created": "2023-06-29T15:56:08Z", + "hash": "sha256:e4b69777d7b9e06e93fcba93d065a246a53c2fa5e113605207836374e48a4fb5", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 948900, + "size": 950051, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4131645/noscript-11.4.24.…", "permissions": [ "contextMenus", "storage", @@ -2614,7 +2614,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2023-06-16T07:25:26Z", + "last_updated": "2023-06-29T16:56:20Z", "name": { "de": "NoScript", "el": "NoScript", @@ -2686,9 +2686,9 @@ "category": "recommended" }, "ratings": { - "average": 4.4054, - "bayesian_average": 4.402692912971343, - "count": 2077, + "average": 4.4062, + "bayesian_average": 4.403489797240767, + "count": 2080, "text_count": 807 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/reviews/", @@ -2733,7 +2733,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/", - "weekly_downloads": 7146 + "weekly_downloads": 6997 }, "notes": null }, @@ -2749,7 +2749,7 @@ "picture_url": null } ], - "average_daily_users": 151172, + "average_daily_users": 150711, "categories": { "android": [ "performance", @@ -2864,10 +2864,10 @@ "category": "recommended" }, "ratings": { - "average": 3.9016, - "bayesian_average": 3.897342889562755, - "count": 1138, - "text_count": 402 + "average": 3.901, + "bayesian_average": 3.8967503054386836, + "count": 1141, + "text_count": 403 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/revi…", "requires_payment": false, @@ -2886,7 +2886,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/vers…", - "weekly_downloads": 1813 + "weekly_downloads": 1697 }, "notes": null } ===================================== projects/browser/config ===================================== @@ -103,9 +103,9 @@ input_files: enable: '[% ! c("var/android") %]' - filename: Bundle-Data enable: '[% ! c("var/android") %]' - - URL: https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.… + - URL: https://addons.mozilla.org/firefox/downloads/file/4131645/noscript-11.4.24.… name: noscript - sha256sum: 46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e + sha256sum: e4b69777d7b9e06e93fcba93d065a246a53c2fa5e113605207836374e48a4fb5 - URL: https://addons.mozilla.org/firefox/downloads/file/4121906/ublock_origin-1.5… name: ublock-origin sha256sum: 10618003e70b528c3f17996e373146d39e6b15f777ac4ca1f214da2ffdb7a5b3 ===================================== projects/firefox/config ===================================== @@ -11,11 +11,11 @@ container: use_container: 1 var: - firefox_platform_version: 102.12.0 + firefox_platform_version: 102.13.0 firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '12.5' browser_branch: '[% c("var/browser_series") %]-1' - browser_build: 4 + browser_build: 2 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' @@ -85,7 +85,7 @@ targets: git_url: https://gitlab.torproject.org/tpo/applications/mullvad-browser.git var: branding_directory_prefix: 'mb' - browser_build: 2 + browser_build: 1 gitlab_project: https://gitlab.torproject.org/tpo/applications/mullvad-browser linux-x86_64: ===================================== projects/geckoview/config ===================================== @@ -11,9 +11,9 @@ container: use_container: 1 var: - geckoview_version: 102.12.0esr + geckoview_version: 102.13.0esr browser_branch: 12.5-1 - browser_build: 4 + browser_build: 2 copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser git_commit: '[% exec("git rev-parse HEAD") %]' ===================================== projects/manual/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! -version: 85332 +version: 86602 filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.gz' container: use_container: 1 @@ -17,8 +17,8 @@ var: input_files: - project: container-image - - URL: 'https://people.torproject.org/~richard/tbb_files/manual_[% c("version") %].zip' + - URL: 'https://people.torproject.org/~pierov/tbb_files/manual_[% c("version") %].zip' name: manual - sha256sum: b1d628f541231e1764cb9b155a7950918e65da6b342f9c9871587284c0e51573 + sha256sum: ee3c5b7fbe9aa3dfaca546e2f6a57f2f740fb3d6332e8c827e5ba6cbf99299b3 - filename: packagemanual.py name: package_script ===================================== projects/translation/config ===================================== @@ -6,19 +6,19 @@ version: '[% c("abbrev") %]' steps: base-browser: base-browser: '[% INCLUDE build %]' - git_hash: 481e743d406d38b7cb2504e19e0d5107b1dd8442 + git_hash: f43ccce2bc26ec711d94ef3e0246000f16d012df targets: nightly: git_hash: 'base-browser' base-browser-fluent: base-browser-fluent: '[% INCLUDE build %]' - git_hash: 86657602203218195d7590040d059932175d0291 + git_hash: 1d597e0a5b6f1402c1170e2f65642810bdd586e3 targets: nightly: git_hash: 'basebrowser-newidentityftl' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 9eab586de15310d8384e1f3a2dc5adc8932247e4 + git_hash: ac9790fa9367c36fc0e2771409b1f0f3661d168d targets: nightly: git_hash: 'tor-browser' @@ -26,7 +26,7 @@ steps: fenix: '[% INCLUDE build %]' # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. - git_hash: 0d1e2c85507303006e692496f81e164335e3e385 + git_hash: 399d0fcee55eacdc7e2d68cd84c824c4d924357f targets: nightly: git_hash: 'fenix-torbrowserstringsxml' ===================================== rbm.conf ===================================== @@ -94,12 +94,12 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '12.5' - torbrowser_build: 'build2' + torbrowser_version: '12.5.1' + torbrowser_build: 'build1' torbrowser_incremental_from: + - 12.5 - 12.0.7 - 12.0.6 - - 12.0.5 updater_enabled: 1 build_mar: 1 mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0esrbase-13.0-1] 217 commits: Bug 1832523 - Allow using NSS to sign and verify MAR signatures....
by Pier Angelo Vendrame (＠pierov) 03 Jul '23

03 Jul '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 80150d98 by Pier Angelo Vendrame at 2023-06-29T12:06:57+02:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 0368a31d by Henry Wilkes at 2023-06-29T12:06:58+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 8204d110 by Henry Wilkes at 2023-06-29T12:06:58+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 01637eae by Pier Angelo Vendrame at 2023-06-29T12:06:59+02:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 43cb46cb by Pier Angelo Vendrame at 2023-06-29T12:06:59+02:00 fixup! Bug 41116: Normalize system fonts. Update to the latest proposal to upstream. It fixes build issues on macOS. - - - - - db40f711 by Pier Angelo Vendrame at 2023-06-29T12:07:00+02:00 fixup! Bug 41116: Normalize system fonts. ShouldResistFinterprinting now always wants a target. - - - - - cecd8762 by Marco Simonelli at 2023-06-29T12:07:00+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - e3e4be18 by Marco Simonelli at 2023-06-29T12:07:01+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - cd6bbf55 by Pier Angelo Vendrame at 2023-06-29T12:07:01+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 2) Reworked the _com_error conversion to string, to use functions that are available also to mingw. - - - - - 88118f0b by Marco Simonelli at 2023-06-29T12:07:02+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 9dac9da5 by Marco Simonelli at 2023-06-29T12:07:02+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - f747579b by Pier Angelo Vendrame at 2023-06-29T12:07:02+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 4) Define _CRT_RAND_S as a compiler flag, to avoid problems due to unified sources. - - - - - 26639502 by Marco Simonelli at 2023-06-29T12:07:03+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 482b6b0e by Marco Simonelli at 2023-06-29T12:07:03+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 55b6c5ce by Gaba at 2023-06-29T12:07:04+02:00 Adding issue and merge request templates - - - - - 6ec63423 by Richard Pospesel at 2023-06-29T12:07:04+02:00 fixup! Adding issue and merge request templates - removed exta unneeded dashes - updated Backporting section to better match our desired process going forward: - discourage requests for backport to stable - provide justification for backport request from list proposed at last Tor meeting - added 'consistency' justification for patches/changes which can be difficult to context switch between but don't affect the final build output - added explicit merge destination selection - - - - - 9408b55a by Pier Angelo Vendrame at 2023-06-29T12:07:05+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 51a83fc3 by Pier Angelo Vendrame at 2023-06-29T12:07:05+02:00 fixup! Base Browser's .mozconfigs. Do not specify --{enable,disable}-verify-mar in mozconfigs, as this option does not exist anymore, and signed mars are enabled by default. - - - - - 5cb79e69 by Pier Angelo Vendrame at 2023-06-29T12:07:05+02:00 fixup! Base Browser's .mozconfigs. Use the new flag upstream to replace the Bug 41542 commit. - - - - - fd968d51 by Pier Angelo Vendrame at 2023-06-29T12:07:06+02:00 fixup! Base Browser's .mozconfigs. Disable the notification server because of the upstream Bug 1782837. - - - - - d06b2145 by Pier Angelo Vendrame at 2023-06-29T12:07:06+02:00 fixup! Base Browser's .mozconfigs. Explicitly say we want verified updates. - - - - - f1df84ae by Kathy Brade at 2023-06-29T13:27:57+02:00 fixup! Base Browser's .mozconfigs. Replaces bug 13379: Allow using NSS to sign and verify MAR signatures We have uplifted this commit, so we just need to enable the option in our mozconfigs. - - - - - 2f0bdbde by Pier Angelo Vendrame at 2023-06-29T13:28:06+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 8f30656f by Pier Angelo Vendrame at 2023-06-29T13:28:07+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 0d303919 by Dan Ballard at 2023-06-29T13:28:07+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 3d49a99e by Matthew Finkel at 2023-06-29T13:28:07+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - d6a5dbfc by Matthew Finkel at 2023-06-29T13:28:08+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 0275e9b9 by Mike Perry at 2023-06-29T13:28:08+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 5edfd94e by Alex Catarineu at 2023-06-29T13:28:09+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 2e69bcf7 by Georg Koppen at 2023-06-29T13:28:09+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 53eb2d06 by Kathy Brade at 2023-06-29T13:28:10+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - f499f5a5 by Kathy Brade at 2023-06-29T13:28:10+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 6534a3ce by Alex Catarineu at 2023-06-29T13:28:10+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 370f292d by Kathy Brade at 2023-06-29T13:28:11+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 225ffc0c by Arthur Edelstein at 2023-06-29T13:28:11+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 164c73eb by Alex Catarineu at 2023-06-29T13:28:12+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 42bb0bb0 by Pier Angelo Vendrame at 2023-06-29T13:28:12+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Linted - - - - - d6f07ad0 by Pier Angelo Vendrame at 2023-06-29T13:28:13+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 8e13721a by Georg Koppen at 2023-06-29T13:28:13+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - a415d539 by Pier Angelo Vendrame at 2023-06-29T13:28:13+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content - - - - - ff014208 by Pier Angelo Vendrame at 2023-06-29T13:28:14+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content ShouldResistFinterprinting now always wants a target. - - - - - 806d7c14 by Alex Catarineu at 2023-06-29T13:28:14+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 4aeaa0dc by Pier Angelo Vendrame at 2023-06-29T13:28:15+02:00 fixup! Bug 28369: Stop shipping pingsender executable Linted - - - - - 8b087842 by cypherpunks1 at 2023-06-29T13:28:15+02:00 Bug 41568: Disable LaterRun - - - - - 069ef79b by cypherpunks1 at 2023-06-29T13:28:16+02:00 Bug 40717: Hide Windows SSO in settings - - - - - b0ac6019 by Pier Angelo Vendrame at 2023-06-29T13:28:16+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - ea9c5901 by Mike Perry at 2023-06-29T13:28:17+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - f605ed46 by Pier Angelo Vendrame at 2023-06-29T13:28:17+02:00 fixup! Firefox preference overrides. Bug 41738: Drop the patch to disable live reload and use the pref - - - - - e71c96cc by Henry Wilkes at 2023-06-29T13:28:20+02:00 fixup! Firefox preference overrides. Bug 41736 - Stop setting the browser.uiCustomization.state preference. - - - - - 15a8bc1b by Pier Angelo Vendrame at 2023-06-29T13:28:21+02:00 fixup! Firefox preference overrides. - - - - - 4a51780d by hackademix at 2023-06-29T13:28:21+02:00 fixup! Firefox preference overrides. tor-browser#41764, prevent automatic download stuffing / DOS - - - - - 47ea65cf by Pier Angelo Vendrame at 2023-06-29T13:28:21+02:00 fixup! Firefox preference overrides. Missing comments on tor-browser.git. To be moved there. - - - - - 0f43f3a2 by Pier Angelo Vendrame at 2023-06-29T13:28:22+02:00 fixup! Firefox preference overrides. Remove other references to Tor Browser prefs - - - - - cd6ed8af by Pier Angelo Vendrame at 2023-06-29T13:28:22+02:00 fixup! Firefox preference overrides. Ignore 001-base-profile.js during linting. - - - - - c038d92b by Pier Angelo Vendrame at 2023-06-29T13:28:23+02:00 fixup! Firefox preference overrides. Pref name change after uplifting. - - - - - 12559c45 by Richard Pospesel at 2023-06-29T13:28:23+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - f4d3ce96 by Pier Angelo Vendrame at 2023-06-29T13:28:24+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 348ee770 by Alex Catarineu at 2023-06-29T13:28:24+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - ec41c8be by Alex Catarineu at 2023-06-29T13:28:24+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - 8513b857 by Alex Catarineu at 2023-06-29T13:28:25+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 2692cf93 by Alex Catarineu at 2023-06-29T13:28:25+02:00 Bug 26345: Hide tracking protection UI - - - - - ceb9d0c7 by Pier Angelo Vendrame at 2023-06-29T13:28:26+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - de069f2d by Alex Catarineu at 2023-06-29T13:28:26+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 7193a6ae by Mike Perry at 2023-06-29T13:28:27+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - badd9487 by Igor Oliveira at 2023-06-29T13:28:27+02:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - d2171f06 by Pier Angelo Vendrame at 2023-06-29T13:28:27+02:00 fixup! Bug 23104: Add a default line height compensation - - - - - bd0c0b59 by Pier Angelo Vendrame at 2023-06-29T13:28:28+02:00 fixup! Bug 23104: Add a default line height compensation Get the document from aPresContext, which Moz already checks and see it isn't null. - - - - - cb75a2b5 by Pier Angelo Vendrame at 2023-06-29T13:28:28+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 43a6a55e by Matthew Finkel at 2023-06-29T13:28:29+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 050a7003 by Pier Angelo Vendrame at 2023-06-29T13:28:29+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 0483bdeb by hackademix at 2023-06-29T13:28:30+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 24eeb607 by hackademix at 2023-06-29T13:28:30+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 441abe32 by hackademix at 2023-06-29T13:28:30+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 2766d4b2 by hackademix at 2023-06-29T13:28:31+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 309e715f by hackademix at 2023-06-29T13:28:31+02:00 Bug 32308: use direct browser sizing for letterboxing. - - - - - eda36ce9 by hackademix at 2023-06-29T13:28:32+02:00 fixup! Bug 32308: use direct browser sizing for letterboxing. - - - - - 85127be9 by hackademix at 2023-06-29T13:28:32+02:00 fixup! Bug 32308: use direct browser sizing for letterboxing. - - - - - 3ec4554d by hackademix at 2023-06-29T13:28:32+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - d13e4947 by hackademix at 2023-06-29T13:28:33+02:00 fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - a05687ee by Pier Angelo Vendrame at 2023-06-29T13:28:33+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 98f957e4 by p13dz at 2023-06-29T13:28:34+02:00 Bug 40283: Workaround for the file upload bug - - - - - 44a9395d by Arthur Edelstein at 2023-06-29T13:28:34+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 5e06de21 by Pier Angelo Vendrame at 2023-06-29T13:28:35+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - a2a539da by Henry Wilkes at 2023-06-29T13:28:40+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 20f790f2 by Kathy Brade at 2023-06-29T13:28:57+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 3352b1c9 by Pier Angelo Vendrame at 2023-06-29T13:28:59+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 41654: Move UpdateInfo into Data again - - - - - e80a7ab2 by Pier Angelo Vendrame at 2023-06-29T13:29:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Linted - - - - - f2425b67 by Pier Angelo Vendrame at 2023-06-29T13:29:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp. They are already defined in toolkit/xre/nsUpdateDriver.h. - - - - - 31f61b66 by Pier Angelo Vendrame at 2023-06-29T13:29:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Fix another build error on macOS - - - - - f1a7ad9a by Nicolas Vigier at 2023-06-29T13:29:01+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - abface60 by hackademix at 2023-06-29T13:29:01+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - ff010b61 by Pier Angelo Vendrame at 2023-06-29T13:29:02+02:00 fixup! Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - f0c7c953 by Pier Angelo Vendrame at 2023-06-29T13:29:02+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 146e7232 by Alex Catarineu at 2023-06-29T13:29:03+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - cab719a2 by Matthew Finkel at 2023-06-29T13:29:03+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - dccd5f57 by Pier Angelo Vendrame at 2023-06-29T13:29:03+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 0b766d6b by Pier Angelo Vendrame at 2023-06-29T13:29:04+02:00 fixup! Bug 40925: Implemented the Security Level component Linted - - - - - 24ab2f48 by cypherpunks1 at 2023-06-29T13:29:04+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 26277: Skip the redirection page when searching with DuckDuckGo on the safest security level - - - - - de446ffa by Pier Angelo Vendrame at 2023-06-29T13:29:05+02:00 fixup! Bug 40925: Implemented the Security Level component Improve the patch to skip DDG redirection for 115. - - - - - 8af214eb by Pier Angelo Vendrame at 2023-06-29T13:29:05+02:00 Bug 40926: Implemented the New Identity feature - - - - - 7cf17d72 by Henry Wilkes at 2023-06-29T13:29:06+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 57e825b9 by Richard Pospesel at 2023-06-29T13:29:06+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 9100c324 by Richard Pospesel at 2023-06-29T13:29:06+02:00 fixup! Bug 41649: Create rebase and security backport gitlab issue templates - made formatting consistent between each template - updated the directions around the base-browser rebase to better reflect how we *actually* do it with regards to only rarely needing to rebase base-browser seperately - fixed a few typos and incorrect git cherry-pick examples - moved signing and tagging to their own section in the rebase templates - changed instances of 'origin' to 'upstream' to be consistent with github/gitlab documentation - added firefox-android section and marked android-components and fenix sections as optional for esr102 only so we don't have to urently fix this once we swithc to esr115 - - - - - 4f4a60a4 by Richard Pospesel at 2023-06-29T13:29:07+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 6027cfff by Pier Angelo Vendrame at 2023-06-29T13:29:07+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Added bridges.js to .eslintignore - - - - - 937f00ae by Henry Wilkes at 2023-06-29T13:29:08+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 093cd756 by Kathy Brade at 2023-06-29T13:29:08+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - a6ee7217 by Mike Perry at 2023-06-29T13:29:09+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one - - - - - ef582de0 by Pier Angelo Vendrame at 2023-06-29T13:29:09+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41749: Replace the onion-glyph with dedicated icon for onion services - - - - - fd1c2e3a by Pier Angelo Vendrame at 2023-06-29T13:29:09+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Added placeholders for new PBM assets needed on Windows - - - - - 227f099c by Dan Ballard at 2023-06-29T13:29:10+02:00 fixup! fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41809: restore onion glyph in locations outside location bar - - - - - 6d782db3 by sanketh at 2023-06-29T13:29:10+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - d46d45b9 by Pier Angelo Vendrame at 2023-06-29T13:29:11+02:00 fixup! Bug 40209: Implement Basic Crypto Safety Use the new domain isolator interface - - - - - 60ce49ae by Mike Perry at 2023-06-29T13:29:11+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 7d1bbb1d by Dan Ballard at 2023-06-29T13:29:12+02:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 41828: Remove --with-tor-browser-version from tor-browser-android mozconfig - - - - - 95613521 by Henry Wilkes at 2023-06-29T13:29:12+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 27558879 by Pier Angelo Vendrame at 2023-06-29T13:29:12+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 164c2310 by Pier Angelo Vendrame at 2023-06-29T13:29:13+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Moved from the Firefox preferences override commit. To remove from Base Browser and move to Tor Browser only. - - - - - dcaf66d0 by Pier Angelo Vendrame at 2023-06-29T13:29:13+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Ignore 000-tor-browser.js during linting - - - - - 097c9b55 by Pier Angelo Vendrame at 2023-06-29T13:29:19+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 1f26c168 by Pier Angelo Vendrame at 2023-06-29T13:29:19+02:00 Bug 40933: Add tor-launcher functionality - - - - - 0ee02b12 by Pier Angelo Vendrame at 2023-06-29T13:29:20+02:00 fixup! Bug 40933: Add tor-launcher functionality Switched to lazy. - - - - - 3fc3b37e by Pier Angelo Vendrame at 2023-06-29T13:29:20+02:00 fixup! Bug 40933: Add tor-launcher functionality Added a newnym function - - - - - c0ea39b4 by Richard Pospesel at 2023-06-29T13:29:21+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 9846297e by Henry Wilkes at 2023-06-29T13:29:21+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41608 - Ignore tor connection errors when tor connection is cancelled by the user. This can happen if the bootstrap process is cancelled late in the process. Also remove unused cancelAutoBootstrapping. - - - - - cddbc1e2 by Pier Angelo Vendrame at 2023-06-29T13:29:21+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41801: Fix handleProcessReady in TorSettings.init - - - - - ba6566ab by Alex Catarineu at 2023-06-29T13:29:22+02:00 Bug 10760: Integrate TorButton to TorBrowser core Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time. Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time. Additionally, this patch also fixes Bug 27611. Bug 26321: New Circuit and New Identity menu items Bug 14392: Make about:tor behave like other initial pages. Bug 25013: Add torbutton as a tor-browser submodule Bug 31575: Replace Firefox Home (newtab) with about:tor - - - - - 88d31abc by Pier Angelo Vendrame at 2023-06-29T13:29:22+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Linted - - - - - 94b1d59e by Pier Angelo Vendrame at 2023-06-29T13:29:23+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 40938: Moving the domain isolator out of torbutton - - - - - e55fdfad by Pier Angelo Vendrame at 2023-06-29T13:29:23+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Extract the new identity button from torbutton - - - - - 63965afe by Pier Angelo Vendrame at 2023-06-29T13:29:24+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove string changes from Torbutton. We will add them back in the TorStrings commit. - - - - - 21199f4f by Pier Angelo Vendrame at 2023-06-29T13:29:24+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Emergency modularization. - - - - - 4c0d6049 by Pier Angelo Vendrame at 2023-06-29T13:29:25+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Removed references to global.dtd. - - - - - 1aa4ad4e by hackademix at 2023-06-29T13:29:25+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - be5168d7 by cypherpunks1 at 2023-06-29T13:29:26+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41792: Allow dragging downloads from about:downloads and the download panel - - - - - 6f47dda8 by Pier Angelo Vendrame at 2023-06-29T13:29:26+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Emergency modernization - - - - - 8e033b30 by Pier Angelo Vendrame at 2023-06-29T13:29:27+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Final part of the modernization: switched to an actual module, and moved out of Torbutton! - - - - - 163fe8cb by Arthur Edelstein at 2023-06-29T13:29:27+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 2a56f627 by Pier Angelo Vendrame at 2023-06-29T13:29:28+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Refactors to the old JS code. - - - - - b6249f7f by Pier Angelo Vendrame at 2023-06-29T13:29:28+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Manage NEWNYM here. - - - - - de8767dc by Pier Angelo Vendrame at 2023-06-29T13:29:28+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Removed the XPCOM definition of the domain isolator. - - - - - 2cd8a2f3 by Pier Angelo Vendrame at 2023-06-29T13:29:29+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Actually added the new circuit button. - - - - - 9e185348 by Henry Wilkes at 2023-06-29T13:29:29+02:00 Bug 41600: Add a tor circuit display panel. - - - - - 802b9689 by Pier Angelo Vendrame at 2023-06-29T13:29:30+02:00 fixup! Bug 41600: Add a tor circuit display panel. Linted - - - - - 39f0140f by Henry Wilkes at 2023-06-29T13:29:30+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41770 - Stop blocking event propagation of keydown events that we do not handle. This lets the arrow key events pass on to ToolbarKeyboardNavigator. - - - - - 9d211e10 by Pier Angelo Vendrame at 2023-06-29T13:29:31+02:00 fixup! Bug 41600: Add a tor circuit display panel. Use the new domain isolator interface. - - - - - 3ab80b59 by Henry Wilkes at 2023-06-29T13:29:31+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41851: Keep circuit panel open when requesting a new circuit. - - - - - 18bed7a3 by Amogh Pradeep at 2023-06-29T13:29:32+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 402103e0 by Matthew Finkel at 2023-06-29T13:29:32+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 93759f8e by Alex Catarineu at 2023-06-29T13:29:32+02:00 Add TorStrings module for localization - - - - - 94daf47c by Henry Wilkes at 2023-06-29T13:29:33+02:00 fixup! Add TorStrings module for localization Bug 41608 - Add new connection status strings. - - - - - bde08b87 by Pier Angelo Vendrame at 2023-06-29T13:29:34+02:00 fixup! Add TorStrings module for localization Bug 40552: New texts for the add a bridge manually modal - - - - - 6fe2cdad by Henry Wilkes at 2023-06-29T13:29:35+02:00 fixup! Add TorStrings module for localization Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - 72c444f8 by Henry Wilkes at 2023-06-29T13:29:35+02:00 fixup! Add TorStrings module for localization Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - 8c2f90dc by Pier Angelo Vendrame at 2023-06-29T13:29:35+02:00 fixup! Add TorStrings module for localization Bug 41818: Remove YEC 2022 strings - - - - - 685a7e85 by Pier Angelo Vendrame at 2023-06-29T13:29:36+02:00 fixup! Add TorStrings module for localization Add our DTDs where needed. These changes were originally in the torbutton commit, but I think they are better fit here, with all the strings files. - - - - - 6e0e3c74 by Kathy Brade at 2023-06-29T13:29:36+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 263633ff by Pier Angelo Vendrame at 2023-06-29T13:29:37+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - b84dcbed by Richard Pospesel at 2023-06-29T13:29:37+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - e491f15d by Pier Angelo Vendrame at 2023-06-29T13:29:38+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Linted - - - - - 83f26a5b by Henry Wilkes at 2023-06-29T13:29:38+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41608 - Use the torconnect icon for the onion slash. - - - - - 25a70ab1 by Pier Angelo Vendrame at 2023-06-29T13:29:39+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 40552: Improve the description of the modal to provide a bridge manually. - - - - - c2911585 by Pier Angelo Vendrame at 2023-06-29T13:29:39+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41802: Improve the regex on parseBridgeLine The previous version of the regex took for granted the bridge fingerprint was always available, but it is actually optional. So, parsing some bridge lines (e.g., Conjure) failed, and vanilla bridge was displayed instead of the actual transport. - - - - - 94a9c8d5 by Dan Ballard at 2023-06-29T13:29:39+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41623: Update connection assist's iconography - - - - - fafa8778 by Henry Wilkes at 2023-06-29T13:29:40+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - 619fff39 by Henry Wilkes at 2023-06-29T13:29:40+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - 72de7a73 by Henry Wilkes at 2023-06-29T13:29:41+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41810 - Add "Connect" button instead of the "Submit" and "OK" button in the bridge request dialog and the manual bridge dialog, respectively. - - - - - 0df37eb8 by Dan Ballard at 2023-06-29T13:29:41+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41809: restore onion glyph in locations outside location bar - - - - - 26e1ff7d by Henry Wilkes at 2023-06-29T13:29:42+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - e270341b by Henry Wilkes at 2023-06-29T13:29:42+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41848 - Consistently disable the accept/connect button in the bridge dialogs until the user gives some input. - - - - - 9ba127a5 by Henry Wilkes at 2023-06-29T13:29:43+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41849: Use the firefox check.svg since we removed our own equivalent check.svg in tor-browser!663. - - - - - a02c515f by Richard Pospesel at 2023-06-29T13:29:43+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds tor connection status to url bar and tweaks UX when not online - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP) - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages) Bug 40773: Update the about:torconnect frontend page to match additional UI flows - - - - - 276b0ed6 by Pier Angelo Vendrame at 2023-06-29T13:29:43+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Linted - - - - - 298856d2 by Henry Wilkes at 2023-06-29T13:29:44+02:00 amend! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 471c809f by Henry Wilkes at 2023-06-29T13:29:44+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41608 and 41526 - Use KeyboardEvent.repeat to block triggering newly focused buttons in about:torconnect. The approach in tor-browser!607 prevented this by waiting for keyup, but keyup could still be triggered by a key event initialized elsewhere. E.g. when pressing Enter to close a modal dialog, the Enter's keyup event would be sent to the about:torconnect page and trigger the focused button. - - - - - d24bd84a by Dan Ballard at 2023-06-29T13:29:45+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - 02d56da6 by Dan Ballard at 2023-06-29T13:29:45+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - 8d16683d by Pier Angelo Vendrame at 2023-06-29T13:29:46+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41815: Wrong connect icons Swapped a couple of icons in about:torconnect, and split the offline CSS class from the connection assist/final error, since they now need a different icon. Also, removed the stroke property, since the new icons do not need it. - - - - - 8d8af111 by Pier Angelo Vendrame at 2023-06-29T13:29:46+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41816: Workaround to fix the top navigation Using the top navigation does not always work as expected, because we pass a null connection state, instead of the actual state. We could start storing the state as a member, however further refactors are planned (see tor-browser#41710), so also directly asking the parent for the current state works as a quick&dirty workaround. - - - - - 0e3cd929 by Henry Wilkes at 2023-06-29T13:29:47+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41726 - Animate the connection icon. - - - - - 01bb1519 by Henry Wilkes at 2023-06-29T13:29:47+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41836: Rename deinit to uninit. - - - - - d73cf1d7 by Henry Wilkes at 2023-06-29T13:29:48+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - 4fa75c0e by Henry Wilkes at 2023-06-29T13:29:48+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41850: Don't show tor connection animation for new windows. - - - - - c3637be5 by Pier Angelo Vendrame at 2023-06-29T13:29:48+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Moved the logic of the about:tor redirects before the bootstrap - - - - - c9ac3b9c by Arthur Edelstein at 2023-06-29T13:29:56+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - e961ef8a by Pier Angelo Vendrame at 2023-06-29T13:29:57+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - df279d96 by Pier Angelo Vendrame at 2023-06-29T13:29:57+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776: Keep shipping the old fontconfig file until users have one - - - - - 3ec916f6 by Pier Angelo Vendrame at 2023-06-29T13:29:58+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776 (fix): Added some missing lines to the previous patch - - - - - ba0b3900 by Pier Angelo Vendrame at 2023-06-29T13:29:58+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Add back variables removed from the Base Browser part of the rebase. - - - - - ae913bc6 by Kathy Brade at 2023-06-29T13:29:59+02:00 Bug 12647: Support symlinks in the updater. - - - - - d82868ba by Kathy Brade at 2023-06-29T13:29:59+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - a5504656 by Kathy Brade at 2023-06-29T13:30:00+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - d7033579 by Pier Angelo Vendrame at 2023-06-29T13:30:00+02:00 fixup! Bug 16940: After update, load local change notes. Define the remote capabilities of about:tbupdate in the correct commit. - - - - - 6d89f788 by Pier Angelo Vendrame at 2023-06-29T13:30:01+02:00 fixup! Bug 16940: After update, load local change notes. Removed global.dtd - - - - - c1955e0b by Georg Koppen at 2023-06-29T13:30:01+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 118fb4cf by Mike Perry at 2023-06-29T13:30:02+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 56543e97 by Pier Angelo Vendrame at 2023-06-29T13:30:02+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Use the upstream DDG icon - - - - - ee7e8dae by Alex Catarineu at 2023-06-29T13:30:03+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - dbe18400 by Richard Pospesel at 2023-06-29T13:30:03+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - d178ce1b by Pier Angelo Vendrame at 2023-06-29T13:30:04+02:00 fixup! Bug 23247: Communicating security expectations for .onion Reimplement the self-signed onion logic - - - - - ef4ff7f5 by cypherpunks1 at 2023-06-29T13:30:04+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 33298: Warn when submitting form data from http onion sites over an insecure connection - - - - - 8cd7740e by cypherpunks1 at 2023-06-29T13:30:05+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41785: Show http onion resources as secure in network monitor - - - - - a0df6e13 by Dan Ballard at 2023-06-29T13:30:05+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41809: restore onion glyph in locations outside location bar - - - - - 8853c8bd by Kathy Brade at 2023-06-29T13:30:06+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 10a5f445 by Pier Angelo Vendrame at 2023-06-29T13:30:06+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Linted - - - - - d116aba8 by Alex Catarineu at 2023-06-29T13:30:07+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - a3e6af1c by Henry Wilkes at 2023-06-29T13:30:07+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41608 - Use the same styling for ".onion available" urlbar button as the tor-connect-urlbar-button. This also stops the button from overflowing its container like before. Also move to after the bookmark button. - - - - - a8e34ae4 by Pier Angelo Vendrame at 2023-06-29T13:30:08+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41841: Use the new onion-site.svg icon in the onion-location pill - - - - - d478e144 by Pier Angelo Vendrame at 2023-06-29T13:30:09+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 21aa53ce by Pier Angelo Vendrame at 2023-06-29T13:30:09+02:00 fixup! Bug 40458: Implement .tor.onion aliases Lint - - - - - 034ae300 by Pier Angelo Vendrame at 2023-06-29T13:30:10+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 972ef7d3 by Pier Angelo Vendrame at 2023-06-29T13:30:10+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 275c0c28 by Dan Ballard at 2023-06-29T13:31:57+02:00 Bug 40701: Add in pane security warning when downloading a file - - - - - acab274e by Dan Ballard at 2023-06-29T13:32:28+02:00 amend! Bug 40701: Add in pane security warning when downloading a file Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 60ffb63e by Pier Angelo Vendrame at 2023-06-29T13:32:30+02:00 fixup! Bug 40701: Add in pane security warning when downloading a file Missed a couple of removed lines. - - - - - 8ec3f403 by Henry Wilkes at 2023-06-29T13:32:30+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - eac41fb2 by hackademix at 2023-06-29T13:32:31+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js - + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - + browser/base/content/browser-doctype.inc The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9c1386… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9c1386… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.13.0esr-12.5-1-build2
by Pier Angelo Vendrame (＠pierov) 03 Jul '23

03 Jul '23

Pier Angelo Vendrame pushed new tag tor-browser-102.13.0esr-12.5-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Fix typos in the rel prep issue template.
by Pier Angelo Vendrame (＠pierov) 30 Jun '23

30 Jun '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: be51c385 by Pier Angelo Vendrame at 2023-06-30T10:42:55+02:00 Fix typos in the rel prep issue template. Add some missing spaces that make GitLab not understand the markup correctly. - - - - - 2 changed files: - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md Changes: ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -101,9 +101,9 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - **NOTE** : If you used the issue number, you will need to write the Tor Browser version manually - [ ] ***(Optional)*** Under `All Platforms` include any version updates for: - [ ] Translations - - [ ]OpenSSL - - [ ]NoScript - - [ ]zlib + - [ ] OpenSSL + - [ ] NoScript + - [ ] zlib - [ ] tor daemon - [ ] ***(Optional)*** Under `Windows + macOS + Linux` include updates for: - [ ] Firefox ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -101,9 +101,9 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - **NOTE** : If you used the issue number, you will need to write the Tor Browser version manually - [ ] ***(Optional)*** Under `All Platforms` include any version updates for: - [ ] Translations - - [ ]OpenSSL - - [ ]NoScript - - [ ]zlib + - [ ] OpenSSL + - [ ] NoScript + - [ ] zlib - [ ] tor daemon - [ ] ***(Optional)*** Under `Windows + macOS + Linux` include updates for: - [ ] Firefox View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.0esrbase-13.0-1
by Pier Angelo Vendrame (＠pierov) 29 Jun '23

29 Jun '23

Pier Angelo Vendrame pushed new branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-102.13.0esr-12.5-1
by Pier Angelo Vendrame (＠pierov) 29 Jun '23

29 Jun '23

Pier Angelo Vendrame pushed new branch base-browser-102.13.0esr-12.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-102.13.0esr-12.5-1-build1
by Pier Angelo Vendrame (＠pierov) 29 Jun '23

29 Jun '23

Pier Angelo Vendrame pushed new tag base-browser-102.13.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.13.0esr-12.5-1-build1
by Pier Angelo Vendrame (＠pierov) 29 Jun '23

29 Jun '23

Pier Angelo Vendrame pushed new tag tor-browser-102.13.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.13.0esr-12.5-1] fixup! Bug 26961: New user onboarding.
by ma1 (＠ma1) 29 Jun '23

29 Jun '23

ma1 pushed to branch tor-browser-102.13.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 4dcf0094 by hackademix at 2023-06-29T09:41:08+02:00 fixup! Bug 26961: New user onboarding. - - - - - 1 changed file: - browser/extensions/onboarding/content/Onboarding.jsm Changes: ===================================== browser/extensions/onboarding/content/Onboarding.jsm ===================================== @@ -909,7 +909,7 @@ class Onboarding { } const kOnionURL = "https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/"; // DuckDuckGo - const kLearnMore = "https://www.torproject.org/releases/tor-browser-12-0/"; + const kLearnMore = "https://www.torproject.org/releases/tor-browser-12-5/"; let handledTourActionClick = false; switch (id) { case "onboarding-overlay-button-icon": View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4dcf009… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4dcf009… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.13.0esr-12.5-1] 178 commits: Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
by Pier Angelo Vendrame (＠pierov) 29 Jun '23

29 Jun '23

Pier Angelo Vendrame pushed to branch tor-browser-102.13.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 897532aa by Pier Angelo Vendrame at 2023-06-28T20:39:36+02:00 Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms. Differential Revision: https://phabricator.services.mozilla.com/D150400 - - - - - d138138f by Pier Angelo Vendrame at 2023-06-28T20:39:37+02:00 Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS). Differential Revision: https://phabricator.services.mozilla.com/D146300 - - - - - c2418fbf by Jamie Nicol at 2023-06-28T20:39:37+02:00 Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D154897 - - - - - 9bb53193 by Pier Angelo Vendrame at 2023-06-28T20:39:37+02:00 Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D157843 - - - - - e718ead0 by Neill Miller at 2023-06-28T20:39:38+02:00 Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with Bug 1123480. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition. Differential Revision: https://phabricator.services.mozilla.com/D157800 - - - - - 36132cda by Gabriele Svelto at 2023-06-28T20:39:38+02:00 Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium macOS unfair locks enforce that a lock can only be released by the thread which locked it. On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing. Differential Revision: https://phabricator.services.mozilla.com/D148287 - - - - - d2818a7c by Gabriele Svelto at 2023-06-28T20:39:39+02:00 Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium Depends on D148287 Differential Revision: https://phabricator.services.mozilla.com/D99280 - - - - - 7e976938 by Kershaw Chang at 2023-06-28T20:39:39+02:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - c16fae73 by Kathy Brade at 2023-06-28T20:39:40+02:00 Bug 1769028: Disable DNS lookup in nsProfileLock when the proxy bypass protection is enabled r=mossop Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1 when the proxy bypass protection is enabled. Differential Revision: https://phabricator.services.mozilla.com/D161264 - - - - - c277ac26 by Gabriele Svelto at 2023-06-28T20:39:40+02:00 Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone Differential Revision: https://phabricator.services.mozilla.com/D149599 - - - - - bb3c8936 by Gabriele Svelto at 2023-06-28T20:39:40+02:00 Bug 1784018 - Remove deprecated OSSpinLocks r=glandium On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core. Differential Revision: https://phabricator.services.mozilla.com/D154205 - - - - - d56cb93e by Hubert Boma Manilla at 2023-06-28T20:39:41+02:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers - Block redirects on sourceMappingUrl - Add debugger test Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 29ce8717 by Hubert Boma Manilla at 2023-06-28T20:39:41+02:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739 - - - - - 5b6dfa7d by Jonathan Kew at 2023-06-28T20:39:42+02:00 Bug 1792157 - Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families. r=gfx-reviewers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D175350 - - - - - f1984021 by Rob Wu at 2023-06-28T20:39:42+02:00 Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin Depends on D164656 Differential Revision: https://phabricator.services.mozilla.com/D166108 - - - - - 600f75f1 by Kash Shampur at 2023-06-28T20:39:43+02:00 Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so. Differential Revision: https://phabricator.services.mozilla.com/D167167 - - - - - b57cc852 by Pier Angelo Vendrame at 2023-06-28T20:39:43+02:00 Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden Now it displays app display name, instead of having Firefox hardcoded. Differential Revision: https://phabricator.services.mozilla.com/D168562 - - - - - fa0880d4 by Jon Coppeard at 2023-06-28T20:39:43+02:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely. This fixes the crash produced by the testcase. Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - f51391ef by Jon Coppeard at 2023-06-28T20:39:44+02:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC. Depends on D169701 Differential Revision: https://phabricator.services.mozilla.com/D169702 - - - - - 6f6208db by Pier Angelo Vendrame at 2023-06-28T20:39:44+02:00 Bug 1817756 - Add a seed to the network ID. r=valentin,necko-reviewers This helps to prevent linkability of users in the same network. Differential Revision: https://phabricator.services.mozilla.com/D170373 - - - - - 96f19b7d by John Lin at 2023-06-28T20:39:45+02:00 Bug 1832832 - protect encoder accesses in Java callbacks. r=media-playback-reviewers,alwu a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D178564 - - - - - f0c394ae by Richard Pospesel at 2023-06-28T20:39:45+02:00 fixup! Bug 1832832 - protect encoder accesses in Java callbacks. r=media-playback-reviewers,alwu a=pascalc - MOZ_GUARDED_BY is just GUARDED_BY in esr 102 - - - - - 897a17fa by Arsen Arsenović at 2023-06-28T20:39:46+02:00 Bug 1811714 - Add a few missing <cstdint> includes r=gfx-reviewers,nical GCC 13s libstdc++ reduced its dependency on some headers like <cstdint>, so it's no longer transitively included through various headers. Include it explicitly. See also: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes 11:16.32 .../components/telemetry/pingsender/pingsender.cpp:30:7: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kConnectionTimeoutMs = 30 * 1000; 11:16.33 ^ 11:16.33 ... /components/telemetry/pingsender/pingsender.cpp:76:9: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kBufferSize = 4 * 1024 - 1; 11:16.34 ^ 11:16.44 2 errors generated. (et al) Differential Revision: https://phabricator.services.mozilla.com/D167491 - - - - - eca71d13 by Georg Koppen at 2023-06-28T20:39:46+02:00 Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM" This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f. This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed. - - - - - 4eb4056d by Henry Wilkes at 2023-06-28T20:39:46+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 4458802b by Henry Wilkes at 2023-06-28T20:39:47+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 3b6e35c8 by Pier Angelo Vendrame at 2023-06-28T20:39:47+02:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - e42ac18a by Marco Simonelli at 2023-06-28T20:39:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 51e473f6 by Marco Simonelli at 2023-06-28T20:39:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 519bc6ba by Marco Simonelli at 2023-06-28T20:39:49+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 2f4b1e29 by Marco Simonelli at 2023-06-28T20:39:49+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 91903e20 by Marco Simonelli at 2023-06-28T20:39:49+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 0079ff89 by Marco Simonelli at 2023-06-28T20:39:50+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 8385fc8a by Gaba at 2023-06-28T20:39:50+02:00 Adding issue and merge request templates - - - - - 8db8a4d0 by Richard Pospesel at 2023-06-28T20:39:51+02:00 fixup! Adding issue and merge request templates - removed exta unneeded dashes - updated Backporting section to better match our desired process going forward: - discourage requests for backport to stable - provide justification for backport request from list proposed at last Tor meeting - added 'consistency' justification for patches/changes which can be difficult to context switch between but don't affect the final build output - added explicit merge destination selection - - - - - be1ea16c by Richard Pospesel at 2023-06-28T20:39:51+02:00 fixup! Adding issue and merge request templates - added potential reviewer list with associated focus areas - - - - - 12c17e76 by Pier Angelo Vendrame at 2023-06-28T20:39:58+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - c150de1b by Pier Angelo Vendrame at 2023-06-28T20:39:59+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - c606497c by Dan Ballard at 2023-06-28T20:39:59+02:00 Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac - - - - - c346e52b by Pier Angelo Vendrame at 2023-06-28T20:40:00+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 33240bc6 by Dan Ballard at 2023-06-28T20:40:00+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 0bb79530 by Matthew Finkel at 2023-06-28T20:40:01+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 0629d7fa by Matthew Finkel at 2023-06-28T20:40:01+02:00 Bug 28125: Prevent non-Necko network connections - - - - - cd6b2202 by Mike Perry at 2023-06-28T20:40:01+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 82d12e9a by Alex Catarineu at 2023-06-28T20:40:02+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - aa57c4c4 by Georg Koppen at 2023-06-28T20:40:02+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - a5ba9774 by Kathy Brade at 2023-06-28T20:40:03+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 708f78b2 by Kathy Brade at 2023-06-28T20:40:03+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 67c7fcc5 by Alex Catarineu at 2023-06-28T20:40:03+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 8bd2bb82 by Kathy Brade at 2023-06-28T20:40:04+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - ba9e513b by Arthur Edelstein at 2023-06-28T20:40:04+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - da4884e3 by Alex Catarineu at 2023-06-28T20:40:05+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 57205838 by Pier Angelo Vendrame at 2023-06-28T20:40:05+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 404dd0cc by Georg Koppen at 2023-06-28T20:40:05+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 283ba7a8 by Alex Catarineu at 2023-06-28T20:40:06+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 61e469aa by cypherpunks1 at 2023-06-28T20:40:06+02:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING - - - - - 5392d0f3 by cypherpunks1 at 2023-06-28T20:40:07+02:00 Bug 41568: Disable LaterRun - - - - - 02a63d68 by cypherpunks1 at 2023-06-28T20:40:07+02:00 Bug 40717: Hide Windows SSO in settings - - - - - dd5f9241 by Pier Angelo Vendrame at 2023-06-28T20:40:08+02:00 Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled. The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled. Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature. - - - - - 730aa49d by Pier Angelo Vendrame at 2023-06-28T20:40:08+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - d1f26d3a by Mike Perry at 2023-06-28T20:40:08+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 6bbdedd7 by Pier Angelo Vendrame at 2023-06-28T20:40:09+02:00 fixup! Firefox preference overrides. Bug 41729: Fix screen readers on Windows - - - - - 45f551bc by hackademix at 2023-06-28T20:40:09+02:00 fixup! Firefox preference overrides. - - - - - 20ba87ac by hackademix at 2023-06-28T20:40:10+02:00 fixup! Firefox preference overrides. - - - - - eb471e9f by Richard Pospesel at 2023-06-28T20:40:10+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 9aef96d6 by Pier Angelo Vendrame at 2023-06-28T20:40:10+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 90b344b2 by Alex Catarineu at 2023-06-28T20:40:11+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 246c63e9 by Alex Catarineu at 2023-06-28T20:40:11+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - 705b0e9e by Alex Catarineu at 2023-06-28T20:40:12+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - e20c8d26 by Alex Catarineu at 2023-06-28T20:40:12+02:00 Bug 26345: Hide tracking protection UI - - - - - 432bea32 by Pier Angelo Vendrame at 2023-06-28T20:40:12+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 34911f73 by Alex Catarineu at 2023-06-28T20:40:14+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 0dae285d by Mike Perry at 2023-06-28T20:40:15+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 62e7306a by Igor Oliveira at 2023-06-28T20:40:15+02:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome. - - - - - 84fcf558 by Pier Angelo Vendrame at 2023-06-28T20:40:16+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 01fa4855 by Matthew Finkel at 2023-06-28T20:40:16+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 27163b9e by Pier Angelo Vendrame at 2023-06-28T20:40:16+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 6c3612c6 by hackademix at 2023-06-28T20:40:17+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - f116ece4 by hackademix at 2023-06-28T20:40:17+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 23611c37 by hackademix at 2023-06-28T20:40:18+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 668edd16 by hackademix at 2023-06-28T20:40:18+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - dbac889c by hackademix at 2023-06-28T20:40:18+02:00 Bug 32308: use direct browser sizing for letterboxing. - - - - - 2521f686 by hackademix at 2023-06-28T20:40:19+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 955935bc by hackademix at 2023-06-28T20:40:19+02:00 fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 473c261f by Pier Angelo Vendrame at 2023-06-28T20:40:20+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 9097ad20 by Henry Wilkes at 2023-06-28T20:40:20+02:00 Bug 41371: Temporary hack to fix language selector popup position - - - - - bcdf5419 by p13dz at 2023-06-28T20:40:21+02:00 Bug 40283: Workaround for the file upload bug - - - - - 5971051a by Arthur Edelstein at 2023-06-28T20:40:21+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 221d3a1e by Pier Angelo Vendrame at 2023-06-28T20:40:21+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - c1eace3e by Henry Wilkes at 2023-06-28T20:40:22+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages and about:firefoxview. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - de5854f5 by Pier Angelo Vendrame at 2023-06-28T20:40:22+02:00 Bug 41542: Disable the creation of a default profile Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories. We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174. - - - - - 6ddbbf0d by Kathy Brade at 2023-06-28T20:40:23+02:00 Bug 13379: Allow using NSS to sign and verify MAR signatures Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary. - - - - - 9162685c by Kathy Brade at 2023-06-28T20:40:23+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 47b6e2d9 by Nicolas Vigier at 2023-06-28T20:40:23+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 0e11bc5e by hackademix at 2023-06-28T20:40:24+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - c079889e by hackademix at 2023-06-28T20:40:24+02:00 fixup! Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 3231814a by hackademix at 2023-06-28T20:40:25+02:00 Bug 41854: Allow overriding download spam protection. - - - - - ff89f43a by Pier Angelo Vendrame at 2023-06-28T20:40:25+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 5a89ad1d by Alex Catarineu at 2023-06-28T20:40:26+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - b3d6b11d by Matthew Finkel at 2023-06-28T20:40:26+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - d38755c6 by Pier Angelo Vendrame at 2023-06-28T20:40:26+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 3399c98e by Pier Angelo Vendrame at 2023-06-28T20:40:27+02:00 Bug 40926: Implemented the New Identity feature - - - - - 34e1452f by Henry Wilkes at 2023-06-28T20:40:27+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 262108ed by Richard Pospesel at 2023-06-28T20:40:28+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 2412723c by Richard Pospesel at 2023-06-28T20:40:28+02:00 fixup! Bug 41649: Create rebase and security backport gitlab issue templates - made formatting consistent between each template - updated the directions around the base-browser rebase to better reflect how we *actually* do it with regards to only rarely needing to rebase base-browser seperately - fixed a few typos and incorrect git cherry-pick examples - moved signing and tagging to their own section in the rebase templates - changed instances of 'origin' to 'upstream' to be consistent with github/gitlab documentation - added firefox-android section and marked android-components and fenix sections as optional for esr102 only so we don't have to urently fix this once we swithc to esr115 - - - - - 03c2abd1 by Richard Pospesel at 2023-06-28T20:40:28+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - bd5f1ad5 by Henry Wilkes at 2023-06-28T20:44:11+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 9629555c by Kathy Brade at 2023-06-28T20:44:15+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - f2384e67 by Mike Perry at 2023-06-28T20:44:15+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one - - - - - dc605b09 by Dan Ballard at 2023-06-28T20:44:16+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41809: restore onion glyph in locations outside location bar - - - - - 000a3b5f by Alex Catarineu at 2023-06-28T20:44:16+02:00 Bring back old Firefox onboarding Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson" This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432. Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs" This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2. Bug 28822: Convert onboarding to webextension Partially revert 1564367 (controlCenter in UITour.jsm) - - - - - 3ade9cb2 by Kathy Brade at 2023-06-28T20:44:17+02:00 Bug 26961: New user onboarding. Reuse the Firefox onboarding mechanism with minimal changes. Localizable strings are pulled in from Torbutton (if Torbutton is not installed, we lack about:tor and no tour will be shown). Replace SVG images with PNGs (see bug 27002), For defense in depth, omit include OnboardingTelemetry.jsm entirely. Added support for the following UITour page event: torBrowserOpenSecuritySettings Also fix bug 27403: the onboarding bubble is not always displayed. Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead. Also fix bug 28628: Change onboarding Security panel to open new Security Level panel. Also fix bug 27484: Improve navigation within onboarding. Bug 27082: enable a limited UITour Disallow access to UITour functionality from all pages other than about:home, about:newtab, and about:tor. Implement a whitelist mechanism for page actions. Bug 26962 - implement new features onboarding (part 1). Add an "Explore" button to the "Circuit Display" panel within new user onboarding which opens the DuckDuckGo .onion and then guides users through a short circuit display tutorial. Allow a few additional UITour actions while limiting as much as possible how it can be used. Tweak the UITour styles to match the Tor Browser branding. All user interface strings are retrieved from Torbutton's browserOnboarding.properties file. Bug 27486 Avoid about:blank tabs when opening onboarding pages. Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion". Bug 29768: Introduce new features to users Add an "update" tour for the Tor Browser 8.5 release that contains two panels: Toolbar and Security (with appropriate description text and images). Display an attention-grabbing dot on the onboarding text bubble when the update tour is active. The animation lasts for 14 seconds. Bug 31768: Introduce toolbar and network settings changes in onboarding Update the "Tor Network" onboarding page to include a note that settings can now be accessed via the application preferences and add an "Adjust Your Tor Network Settings" action button which opens about:preferences#tor. Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one that includes the revised "Tor Network" page and a revised "Toolbar" page. The latter explains that Torbutton's toolbar item has been removed ("Goodbye Onion Button") and explains how to access the New Identity feature using the hamburger menu and new toolbar item. Bug 34321 - Add Learn More onboarding item Bug 40429: Update Onboarding for 10.5 - - - - - 64da935a by sanketh at 2023-06-28T20:44:17+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 99e81594 by Mike Perry at 2023-06-28T20:44:18+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 63381d2a by Dan Ballard at 2023-06-28T20:44:18+02:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 41828: Remove --with-tor-browser-version from tor-browser-android mozconfig - - - - - 1f463392 by Henry Wilkes at 2023-06-28T20:44:18+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - a5cdffe9 by Pier Angelo Vendrame at 2023-06-28T20:44:19+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 320d4efd by Pier Angelo Vendrame at 2023-06-28T20:44:19+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - a418ddc0 by Pier Angelo Vendrame at 2023-06-28T20:44:20+02:00 Bug 40933: Add tor-launcher functionality - - - - - 33f372c4 by Richard Pospesel at 2023-06-28T20:44:20+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - bf8c9029 by Pier Angelo Vendrame at 2023-06-28T20:44:21+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41801: Fix handleProcessReady in TorSettings.init - - - - - 8a49041c by Alex Catarineu at 2023-06-28T20:44:21+02:00 Bug 10760: Integrate TorButton to TorBrowser core Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time. Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time. Additionally, this patch also fixes Bug 27611. Bug 26321: New Circuit and New Identity menu items Bug 14392: Make about:tor behave like other initial pages. Bug 25013: Add torbutton as a tor-browser submodule Bug 31575: Replace Firefox Home (newtab) with about:tor - - - - - 5d9b2d57 by hackademix at 2023-06-28T20:44:21+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - b364e931 by cypherpunks1 at 2023-06-28T20:44:22+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41792: Allow dragging downloads from about:downloads and the download panel - - - - - 44402105 by Henry Wilkes at 2023-06-28T20:44:22+02:00 Bug 41600: Add a tor circuit display panel. - - - - - 12803b6f by Henry Wilkes at 2023-06-28T20:44:23+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41851: Keep circuit panel open when requesting a new circuit. - - - - - adb5d3b5 by Amogh Pradeep at 2023-06-28T20:44:23+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - d40eeaa1 by Matthew Finkel at 2023-06-28T20:44:23+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 9da52692 by Alex Catarineu at 2023-06-28T20:44:24+02:00 Add TorStrings module for localization - - - - - 4cbd1ac6 by Pier Angelo Vendrame at 2023-06-28T20:44:24+02:00 fixup! Add TorStrings module for localization Bug 40552: New texts for the add a bridge manually modal - - - - - 39ba7f88 by Henry Wilkes at 2023-06-28T20:44:25+02:00 fixup! Add TorStrings module for localization Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - c8bcfd72 by Henry Wilkes at 2023-06-28T20:44:25+02:00 fixup! Add TorStrings module for localization Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - 354120b4 by Pier Angelo Vendrame at 2023-06-28T20:44:27+02:00 fixup! Add TorStrings module for localization Bug 41818: Remove YEC 2022 strings - - - - - 81d1d04c by Kathy Brade at 2023-06-28T20:44:28+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 49c753bc by Pier Angelo Vendrame at 2023-06-28T20:44:28+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - 0ce8bc32 by Richard Pospesel at 2023-06-28T20:44:29+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 8f5d81f5 by Pier Angelo Vendrame at 2023-06-28T20:44:29+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 40552: Improve the description of the modal to provide a bridge manually. - - - - - acd3d920 by Pier Angelo Vendrame at 2023-06-28T20:44:29+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41802: Improve the regex on parseBridgeLine The previous version of the regex took for granted the bridge fingerprint was always available, but it is actually optional. So, parsing some bridge lines (e.g., Conjure) failed, and vanilla bridge was displayed instead of the actual transport. - - - - - a7845969 by Dan Ballard at 2023-06-28T20:44:30+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41623: Update connection assist's iconography - - - - - c31a0fce by Henry Wilkes at 2023-06-28T20:44:30+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - 49f63480 by Henry Wilkes at 2023-06-28T20:44:31+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - faebb665 by Henry Wilkes at 2023-06-28T20:44:31+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41810 - Add "Connect" button instead of the "Submit" and "OK" button in the bridge request dialog and the manual bridge dialog, respectively. - - - - - dd69a908 by Dan Ballard at 2023-06-28T20:44:32+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41809: restore onion glyph in locations outside location bar - - - - - 10b3d1a9 by Henry Wilkes at 2023-06-28T20:44:32+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - a0047221 by Henry Wilkes at 2023-06-28T20:44:32+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41848 - Consistently disable the accept/connect button in the bridge dialogs until the user gives some input. - - - - - 744f9384 by Henry Wilkes at 2023-06-28T20:44:33+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41849: Use the firefox check.svg since we removed our own equivalent check.svg in tor-browser!663. - - - - - 5b371062 by Richard Pospesel at 2023-06-28T20:44:33+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - d15856f7 by Dan Ballard at 2023-06-28T20:44:34+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - c74197f0 by Dan Ballard at 2023-06-28T20:44:34+02:00 fixup! fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - e369c833 by Pier Angelo Vendrame at 2023-06-28T20:44:35+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41815: Wrong connect icons Swapped a couple of icons in about:torconnect, and split the offline CSS class from the connection assist/final error, since they now need a different icon. Also, removed the stroke property, since the new icons do not need it. - - - - - 4b185bf1 by Pier Angelo Vendrame at 2023-06-28T20:44:35+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41816: Workaround to fix the top navigation Using the top navigation does not always work as expected, because we pass a null connection state, instead of the actual state. We could start storing the state as a member, however further refactors are planned (see tor-browser#41710), so also directly asking the parent for the current state works as a quick&dirty workaround. - - - - - 7f3356ca by Henry Wilkes at 2023-06-28T20:44:35+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41726 - Animate the connection icon. - - - - - 45093a8f by Henry Wilkes at 2023-06-28T20:44:36+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41836: Rename deinit to uninit. - - - - - 2f1a7a61 by Henry Wilkes at 2023-06-28T20:44:36+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - bb99f9c2 by Henry Wilkes at 2023-06-28T20:44:37+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41850: Don't show tor connection animation for new windows. - - - - - 3e7a19e6 by Arthur Edelstein at 2023-06-28T20:44:37+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 299252fb by Pier Angelo Vendrame at 2023-06-28T20:44:37+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 029e89f7 by Pier Angelo Vendrame at 2023-06-28T20:44:38+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776: Keep shipping the old fontconfig file until users have one - - - - - 09c262af by Pier Angelo Vendrame at 2023-06-28T20:44:38+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776 (fix): Added some missing lines to the previous patch - - - - - f34a4de8 by Kathy Brade at 2023-06-28T20:44:39+02:00 Bug 12647: Support symlinks in the updater. - - - - - d1451528 by Kathy Brade at 2023-06-28T20:44:39+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 929c2d76 by Kathy Brade at 2023-06-28T20:44:40+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 47c01fb4 by Georg Koppen at 2023-06-28T20:44:40+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - f54f363b by Mike Perry at 2023-06-28T20:44:41+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - cec178bf by Alex Catarineu at 2023-06-28T20:44:41+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - 21f3283e by Richard Pospesel at 2023-06-28T20:44:41+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 40e2eea1 by Dan Ballard at 2023-06-28T20:44:42+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41809: restore onion glyph in locations outside location bar - - - - - 9e3028ef by Kathy Brade at 2023-06-28T20:44:43+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 2020539d by hackademix at 2023-06-28T20:44:44+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 2cc083d4 by Alex Catarineu at 2023-06-28T20:44:44+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 01295fcc by Pier Angelo Vendrame at 2023-06-28T20:44:44+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41841: Use the new onion-site.svg icon in the onion-location pill - - - - - 718075ff by Pier Angelo Vendrame at 2023-06-28T20:44:45+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 73ec837b by Pier Angelo Vendrame at 2023-06-28T20:44:45+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - ea944bd4 by Pier Angelo Vendrame at 2023-06-28T20:44:46+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 9e0eaf09 by Dan Ballard at 2023-06-28T20:44:46+02:00 Bug 40701: Add in pane security warning when downloading a file - - - - - c450d2e6 by Dan Ballard at 2023-06-28T20:44:47+02:00 amend! Bug 40701: Add in pane security warning when downloading a file Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 4a60d825 by Henry Wilkes at 2023-06-28T20:44:47+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - a0aa4297 by hackademix at 2023-06-28T20:44:47+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - browser/actors/NetErrorChild.jsm - browser/actors/NetErrorParent.jsm - − browser/actors/RFPHelperChild.jsm - − browser/actors/RFPHelperParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js - + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/eceebf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/eceebf… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40890: Make sur version is a string in downloads.json
by richard (＠richard) 28 Jun '23

28 Jun '23

richard pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 6366bc2d by Nicolas Vigier at 2023-06-28T18:55:01+00:00 Bug 40890: Make sur version is a string in downloads.json Some version numbers like 12.5 can be stored as a numeric value instead of a string, so we should explicitely store the version as a string. At the same time we do the same for tag/git_tag (although tags are less likely to look like a number). - - - - - 1 changed file: - tools/update-responses/update_responses Changes: ===================================== tools/update-responses/update_responses ===================================== @@ -176,8 +176,8 @@ sub get_perplatform_downloads { next; } $downloads->{$os} = { - version => $version, - git_tag => $gittag, + version => "$version", + git_tag => "$gittag", binary => "$download_url/$file", sig => "$download_url/$file.asc", }; @@ -459,8 +459,8 @@ sub write_downloads_json { my $version = $config->{channels}{$channel}; my $tag = get_config($config, $version, 'any', 'tag'); my $data = { - version => $version, - tag => $tag, + version => "$version", + tag => "$tag", downloads => get_version_downloads($config, $version), }; write_htdocs($channel, 'downloads.json', View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40890: Make sur version is a string in downloads.json
by richard (＠richard) 28 Jun '23

28 Jun '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: ffcd536e by Nicolas Vigier at 2023-06-28T14:16:30+02:00 Bug 40890: Make sur version is a string in downloads.json Some version numbers like 12.5 can be stored as a numeric value instead of a string, so we should explicitely store the version as a string. At the same time we do the same for tag/git_tag (although tags are less likely to look like a number). - - - - - 1 changed file: - tools/update-responses/update_responses Changes: ===================================== tools/update-responses/update_responses ===================================== @@ -176,8 +176,8 @@ sub get_perplatform_downloads { next; } $downloads->{$os} = { - version => $version, - git_tag => $gittag, + version => "$version", + git_tag => "$gittag", binary => "$download_url/$file", sig => "$download_url/$file.asc", }; @@ -459,8 +459,8 @@ sub write_downloads_json { my $version = $config->{channels}{$channel}; my $tag = get_config($config, $version, 'any', 'tag'); my $data = { - version => $version, - tag => $tag, + version => "$version", + tag => "$tag", downloads => get_version_downloads($config, $version), }; write_htdocs($channel, 'downloads.json', View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-bundle-testsuite][main] Bug 40074: Add nightly builds of openssl for linux-arm
by richard (＠richard) 28 Jun '23

28 Jun '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-bundle-testsuite Commits: 63d0f7a7 by Nicolas Vigier at 2023-06-28T18:44:40+00:00 Bug 40074: Add nightly builds of openssl for linux-arm - - - - - 2 changed files: - TBBTestSuite/TestSuite/TorBrowserBuild.pm - tools/rsync-to-tbb-nightlies-master Changes: ===================================== TBBTestSuite/TestSuite/TorBrowserBuild.pm ===================================== @@ -281,6 +281,18 @@ sub set_tests { publish_dir => 'basebrowser-nightly-macos', projectname => 'basebrowser', }, + # openssl build for linux-arm (#40074) + { + name => 'openssl-nightly-linux-arm', + descr => 'build openssl nightly linux-arm', + type => 'rbm_build', + project => 'openssl', + targets => [ + 'nightly', + 'torbrowser-linux-arm', + ], + publish_dir => 'openssl-nightly-linux-arm', + }, ]; } ===================================== tools/rsync-to-tbb-nightlies-master ===================================== @@ -11,6 +11,7 @@ if (-f $lockfile) { } path($lockfile)->spew_utf8($$); +system('chmod', '-R', 'go+rX', '/home/tb-builder/nightly-builds/'); my $res = system('rsync', '-aH', '--delete-before', '/home/tb-builder/nightly-builds/', 'tbb-nightlies@tbb-nightlies-master.torproject.org:/'); # Run static-update-component on tbb-nightlies-master: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-102.13.0esr-12.5-1
by Pier Angelo Vendrame (＠pierov) 28 Jun '23

28 Jun '23

Pier Angelo Vendrame pushed new branch tor-browser-102.13.0esr-12.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_102_13_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 28 Jun '23

28 Jun '23

Pier Angelo Vendrame pushed new tag FIREFOX_102_13_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.0b5-13.0-1] 120 commits: Bug 41649: Create rebase and security backport gitlab issue templates
by Pier Angelo Vendrame (＠pierov) 28 Jun '23

28 Jun '23

Pier Angelo Vendrame pushed to branch tor-browser-115.0b5-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 796625a7 by Richard Pospesel at 2023-06-14T09:46:55+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - f4c1bd50 by Richard Pospesel at 2023-06-14T09:46:56+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 77c88ccb by Pier Angelo Vendrame at 2023-06-14T09:46:57+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Added bridges.js to .eslintignore - - - - - 7d3d1898 by Kathy Brade at 2023-06-14T09:46:57+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 9b44e71d by Mike Perry at 2023-06-14T09:46:58+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one - - - - - b51150af by Pier Angelo Vendrame at 2023-06-14T09:46:58+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41749: Replace the onion-glyph with dedicated icon for onion services - - - - - bff0ab96 by Pier Angelo Vendrame at 2023-06-14T09:46:59+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Added placeholders for new PBM assets needed on Windows - - - - - 7153bf50 by sanketh at 2023-06-14T09:46:59+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 58c358a8 by Mike Perry at 2023-06-14T09:47:00+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 82cffe4c by Henry Wilkes at 2023-06-14T09:47:00+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - c92e7608 by Pier Angelo Vendrame at 2023-06-14T09:47:00+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 1891c4f4 by Pier Angelo Vendrame at 2023-06-14T09:47:01+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Moved from the Firefox preferences override commit. To remove from Base Browser and move to Tor Browser only. - - - - - 98da7d5a by Pier Angelo Vendrame at 2023-06-14T09:47:01+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Ignore 000-tor-browser.js during linting - - - - - ed3367e6 by Pier Angelo Vendrame at 2023-06-14T09:47:02+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - ecf1f3b0 by Pier Angelo Vendrame at 2023-06-14T09:47:02+02:00 Bug 40933: Add tor-launcher functionality - - - - - 513ad9dc by Pier Angelo Vendrame at 2023-06-14T09:47:03+02:00 fixup! Bug 40933: Add tor-launcher functionality Switched to lazy. - - - - - f9c68576 by Richard Pospesel at 2023-06-14T09:47:03+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 013594d7 by Henry Wilkes at 2023-06-14T09:47:03+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41608 - Ignore tor connection errors when tor connection is cancelled by the user. This can happen if the bootstrap process is cancelled late in the process. Also remove unused cancelAutoBootstrapping. - - - - - 3009a246 by Pier Angelo Vendrame at 2023-06-14T09:47:04+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41801: Fix handleProcessReady in TorSettings.init - - - - - 9ea54081 by Alex Catarineu at 2023-06-14T09:47:04+02:00 Bug 10760: Integrate TorButton to TorBrowser core Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time. Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time. Additionally, this patch also fixes Bug 27611. Bug 26321: New Circuit and New Identity menu items Bug 14392: Make about:tor behave like other initial pages. Bug 25013: Add torbutton as a tor-browser submodule Bug 31575: Replace Firefox Home (newtab) with about:tor - - - - - 2d2e48c8 by Pier Angelo Vendrame at 2023-06-14T09:47:05+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Linted - - - - - 17bf3f82 by hackademix at 2023-06-14T09:47:05+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 25424be7 by Henry Wilkes at 2023-06-14T09:47:06+02:00 Bug 41600: Add a tor circuit display panel. - - - - - 7371f696 by Pier Angelo Vendrame at 2023-06-14T09:47:06+02:00 fixup! Bug 41600: Add a tor circuit display panel. Linted - - - - - 6d02111a by Henry Wilkes at 2023-06-14T09:47:07+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41770 - Stop blocking event propagation of keydown events that we do not handle. This lets the arrow key events pass on to ToolbarKeyboardNavigator. - - - - - b847018d by Amogh Pradeep at 2023-06-14T09:47:07+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 0ba6a113 by Matthew Finkel at 2023-06-14T09:47:07+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 5e5073f3 by Alex Catarineu at 2023-06-14T09:47:08+02:00 Add TorStrings module for localization - - - - - e50c1131 by Henry Wilkes at 2023-06-14T09:47:08+02:00 fixup! Add TorStrings module for localization Bug 41608 - Add new connection status strings. - - - - - 896efd81 by Kathy Brade at 2023-06-14T09:47:09+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 9e2a9670 by Pier Angelo Vendrame at 2023-06-14T09:47:09+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - bd394039 by Richard Pospesel at 2023-06-14T09:47:10+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 4194a32a by Pier Angelo Vendrame at 2023-06-14T09:47:10+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Linted - - - - - 29d3d7c0 by Henry Wilkes at 2023-06-14T09:47:10+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41608 - Use the torconnect icon for the onion slash. - - - - - 3ed482b9 by Richard Pospesel at 2023-06-14T09:47:13+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds tor connection status to url bar and tweaks UX when not online - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP) - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages) Bug 40773: Update the about:torconnect frontend page to match additional UI flows - - - - - ca65448f by Pier Angelo Vendrame at 2023-06-14T09:47:13+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Linted - - - - - ca5c0735 by Henry Wilkes at 2023-06-14T09:47:14+02:00 amend! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 8169138c by Henry Wilkes at 2023-06-14T09:47:14+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41608 and 41526 - Use KeyboardEvent.repeat to block triggering newly focused buttons in about:torconnect. The approach in tor-browser!607 prevented this by waiting for keyup, but keyup could still be triggered by a key event initialized elsewhere. E.g. when pressing Enter to close a modal dialog, the Enter's keyup event would be sent to the about:torconnect page and trigger the focused button. - - - - - 092e6036 by Arthur Edelstein at 2023-06-14T09:47:15+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 16c56865 by Pier Angelo Vendrame at 2023-06-14T09:47:15+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 38d9b4e8 by Pier Angelo Vendrame at 2023-06-14T09:47:16+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776: Keep shipping the old fontconfig file until users have one - - - - - 868eb3c9 by Pier Angelo Vendrame at 2023-06-14T09:47:16+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41776 (fix): Added some missing lines to the previous patch - - - - - adbe3db7 by Pier Angelo Vendrame at 2023-06-14T09:47:16+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Add back variables removed from the Base Browser part of the rebase. - - - - - 0ab5f27f by Kathy Brade at 2023-06-14T09:47:17+02:00 Bug 12647: Support symlinks in the updater. - - - - - 92cffda5 by Kathy Brade at 2023-06-14T09:47:17+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 47a01248 by Kathy Brade at 2023-06-14T09:47:18+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 07c55aa6 by Pier Angelo Vendrame at 2023-06-14T09:47:18+02:00 fixup! Bug 16940: After update, load local change notes. Define the remote capabilities of about:tbupdate in the correct commit. - - - - - 0d642de1 by Georg Koppen at 2023-06-14T09:47:19+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 6265e136 by Mike Perry at 2023-06-14T09:47:19+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 4b849a9c by Pier Angelo Vendrame at 2023-06-14T09:47:20+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Use the upstream DDG icon - - - - - 00da3619 by Alex Catarineu at 2023-06-14T09:47:20+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - 9c5130ab by Richard Pospesel at 2023-06-14T09:47:20+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - d2e8767b by Pier Angelo Vendrame at 2023-06-14T09:47:21+02:00 fixup! Bug 23247: Communicating security expectations for .onion Reimplement the self-signed onion logic - - - - - d97eee90 by cypherpunks1 at 2023-06-14T09:47:21+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 33298: Warn when submitting form data from http onion sites over an insecure connection - - - - - db9bf091 by cypherpunks1 at 2023-06-14T09:47:22+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41785: Show http onion resources as secure in network monitor - - - - - 91f9a4b9 by Kathy Brade at 2023-06-16T10:44:36+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 2d7199aa by Pier Angelo Vendrame at 2023-06-16T10:44:55+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Linted - - - - - 59d9dcd3 by Alex Catarineu at 2023-06-16T10:44:55+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - c2b796f4 by Henry Wilkes at 2023-06-16T10:44:56+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41608 - Use the same styling for ".onion available" urlbar button as the tor-connect-urlbar-button. This also stops the button from overflowing its container like before. Also move to after the bookmark button. - - - - - 3517b09d by Pier Angelo Vendrame at 2023-06-16T10:44:56+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 10bc857c by Pier Angelo Vendrame at 2023-06-16T10:44:57+02:00 fixup! Bug 40458: Implement .tor.onion aliases Lint - - - - - 51857f1d by Pier Angelo Vendrame at 2023-06-16T10:44:57+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 7cf754ce by Pier Angelo Vendrame at 2023-06-16T10:44:57+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 78367b68 by Dan Ballard at 2023-06-16T10:44:58+02:00 Bug 40701: Add in pane security warning when downloading a file - - - - - f18d29f7 by Henry Wilkes at 2023-06-16T10:44:58+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - d84340d8 by hackademix at 2023-06-16T10:45:00+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 803088de by Henry Wilkes at 2023-06-16T10:45:01+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - e79a74e7 by Dan Ballard at 2023-06-16T10:45:01+02:00 amend! Bug 40701: Add in pane security warning when downloading a file Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 82d5fdc7 by Pier Angelo Vendrame at 2023-06-16T10:45:02+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 40552: Improve the description of the modal to provide a bridge manually. - - - - - 205a107c by Pier Angelo Vendrame at 2023-06-16T10:45:02+02:00 fixup! Add TorStrings module for localization Bug 40552: New texts for the add a bridge manually modal - - - - - 53ec47f0 by cypherpunks1 at 2023-06-16T10:45:02+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41792: Allow dragging downloads from about:downloads and the download panel - - - - - cf1574c9 by Pier Angelo Vendrame at 2023-06-16T10:45:03+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41802: Improve the regex on parseBridgeLine The previous version of the regex took for granted the bridge fingerprint was always available, but it is actually optional. So, parsing some bridge lines (e.g., Conjure) failed, and vanilla bridge was displayed instead of the actual transport. - - - - - 9846bb41 by Dan Ballard at 2023-06-16T10:45:03+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - 49af0f51 by Dan Ballard at 2023-06-16T10:45:04+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41623: Update connection assist's iconography - - - - - d3bfbadc by Dan Ballard at 2023-06-16T10:45:04+02:00 fixup! fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41623: Update connection assist's iconography - - - - - ab7c1583 by Henry Wilkes at 2023-06-16T10:45:04+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - e76daef3 by Henry Wilkes at 2023-06-16T10:45:05+02:00 fixup! Add TorStrings module for localization Bug 41734 - Add a connected label to the built-in bridge dialog. - - - - - e1786cb9 by Pier Angelo Vendrame at 2023-06-16T10:45:05+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41815: Wrong connect icons Swapped a couple of icons in about:torconnect, and split the offline CSS class from the connection assist/final error, since they now need a different icon. Also, removed the stroke property, since the new icons do not need it. - - - - - f9c4f924 by Pier Angelo Vendrame at 2023-06-16T10:45:06+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41816: Workaround to fix the top navigation Using the top navigation does not always work as expected, because we pass a null connection state, instead of the actual state. We could start storing the state as a member, however further refactors are planned (see tor-browser#41710), so also directly asking the parent for the current state works as a quick&dirty workaround. - - - - - 23f711b3 by Henry Wilkes at 2023-06-16T10:45:06+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - a3e9d638 by Henry Wilkes at 2023-06-16T10:45:07+02:00 fixup! Add TorStrings module for localization Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences. - - - - - 32da309f by Henry Wilkes at 2023-06-16T10:45:07+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41726 - Animate the connection icon. - - - - - f2022f24 by Henry Wilkes at 2023-06-16T10:45:07+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41810 - Add "Connect" button instead of the "Submit" and "OK" button in the bridge request dialog and the manual bridge dialog, respectively. - - - - - 4164e088 by Dan Ballard at 2023-06-16T10:45:08+02:00 fixup! fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 41809: restore onion glyph in locations outside location bar - - - - - fa2b3adc by Dan Ballard at 2023-06-16T10:45:08+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 41809: restore onion glyph in locations outside location bar - - - - - 51b913b3 by Dan Ballard at 2023-06-16T10:45:09+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41809: restore onion glyph in locations outside location bar - - - - - e5e275da by Pier Angelo Vendrame at 2023-06-16T10:45:09+02:00 fixup! Add TorStrings module for localization Bug 41818: Remove YEC 2022 strings - - - - - 5dae43f0 by Pier Angelo Vendrame at 2023-06-16T10:45:10+02:00 fixup! Bug 40933: Add tor-launcher functionality Added a newnym function - - - - - 306fdd9b by Pier Angelo Vendrame at 2023-06-16T10:45:10+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 40938: Moving the domain isolator out of torbutton - - - - - 71bf4be8 by Arthur Edelstein at 2023-06-16T10:45:10+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - da71d1c4 by Pier Angelo Vendrame at 2023-06-16T10:45:11+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Refactors to the old JS code. - - - - - aec9a9f9 by Pier Angelo Vendrame at 2023-06-16T10:45:11+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Manage NEWNYM here. - - - - - 0db0a8c5 by Pier Angelo Vendrame at 2023-06-16T10:45:12+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Removed the XPCOM definition of the domain isolator. - - - - - 16c3c029 by Pier Angelo Vendrame at 2023-06-16T10:45:12+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Extract the new identity button from torbutton - - - - - d39f5d21 by Pier Angelo Vendrame at 2023-06-16T10:45:13+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Actually added the new circuit button. - - - - - c15468c4 by Pier Angelo Vendrame at 2023-06-16T10:45:13+02:00 fixup! Bug 41600: Add a tor circuit display panel. Use the new domain isolator interface. - - - - - 97f55730 by Pier Angelo Vendrame at 2023-06-16T10:45:13+02:00 fixup! Bug 40209: Implement Basic Crypto Safety Use the new domain isolator interface - - - - - d60adf11 by Pier Angelo Vendrame at 2023-06-16T10:45:14+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Remove string changes from Torbutton. We will add them back in the TorStrings commit. - - - - - 92606de9 by Pier Angelo Vendrame at 2023-06-16T10:45:14+02:00 fixup! Add TorStrings module for localization Add our DTDs where needed. These changes were originally in the torbutton commit, but I think they are better fit here, with all the strings files. - - - - - b26e881a by Henry Wilkes at 2023-06-16T10:45:15+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41836: Rename deinit to uninit. - - - - - 2c13c604 by Pier Angelo Vendrame at 2023-06-16T10:45:18+02:00 fixup! Bug 21952: Implement Onion-Location Bug 41841: Use the new onion-site.svg icon in the onion-location pill - - - - - 755a45e9 by cypherpunks1 at 2023-06-16T10:45:18+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 26277: Skip the redirection page when searching with DuckDuckGo on the safest security level - - - - - 3e0e1f21 by Henry Wilkes at 2023-06-16T10:45:18+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - c94b0be0 by Henry Wilkes at 2023-06-16T10:45:19+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences. - - - - - 960c8921 by Henry Wilkes at 2023-06-16T10:45:19+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41848 - Consistently disable the accept/connect button in the bridge dialogs until the user gives some input. - - - - - c1e03343 by Henry Wilkes at 2023-06-16T10:45:20+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41849: Use the firefox check.svg since we removed our own equivalent check.svg in tor-browser!663. - - - - - ac853a1a by Henry Wilkes at 2023-06-16T10:45:20+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41850: Don't show tor connection animation for new windows. - - - - - c149eeff by Richard Pospesel at 2023-06-16T10:45:21+02:00 fixup! Bug 41649: Create rebase and security backport gitlab issue templates - made formatting consistent between each template - updated the directions around the base-browser rebase to better reflect how we *actually* do it with regards to only rarely needing to rebase base-browser seperately - fixed a few typos and incorrect git cherry-pick examples - moved signing and tagging to their own section in the rebase templates - changed instances of 'origin' to 'upstream' to be consistent with github/gitlab documentation - added firefox-android section and marked android-components and fenix sections as optional for esr102 only so we don't have to urently fix this once we swithc to esr115 - - - - - 9f785f3b by Richard Pospesel at 2023-06-16T10:45:21+02:00 fixup! Adding issue and merge request templates - removed exta unneeded dashes - updated Backporting section to better match our desired process going forward: - discourage requests for backport to stable - provide justification for backport request from list proposed at last Tor meeting - added 'consistency' justification for patches/changes which can be difficult to context switch between but don't affect the final build output - added explicit merge destination selection - - - - - 5d07962c by Henry Wilkes at 2023-06-20T18:10:41+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41851: Keep circuit panel open when requesting a new circuit. - - - - - df1b9b74 by Dan Ballard at 2023-06-26T21:03:21+02:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 41828: Remove --with-tor-browser-version from tor-browser-android mozconfig - - - - - d34475cd by Pier Angelo Vendrame at 2023-06-26T21:03:21+02:00 Unpublished commits start here After here are only commits that were added to make 115 work. So, they don't have a counterpart in 102.xx.0esr-13.0. - - - - - 1ad5807c by Pier Angelo Vendrame at 2023-06-26T21:03:22+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Emergency modularization. - - - - - dd526ed0 by Pier Angelo Vendrame at 2023-06-26T21:03:24+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Emergency modernization - - - - - 0ac3a905 by Pier Angelo Vendrame at 2023-06-26T21:03:24+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core Removed references to global.dtd. - - - - - e187ff83 by Pier Angelo Vendrame at 2023-06-27T14:46:47+02:00 fixup! Bug 16940: After update, load local change notes. Removed global.dtd - - - - - 36f3dae3 by Pier Angelo Vendrame at 2023-06-27T14:46:54+02:00 fixup! Bug 40925: Implemented the Security Level component Improve the patch to skip DDG redirection for 115. - - - - - e15186f2 by Pier Angelo Vendrame at 2023-06-27T14:46:55+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Final part of the modernization: switched to an actual module, and moved out of Torbutton! - - - - - e286ad1e by Pier Angelo Vendrame at 2023-06-27T15:51:49+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Moved the logic of the about:tor redirects before the bootstrap - - - - - d9711f94 by Pier Angelo Vendrame at 2023-06-27T16:00:23+02:00 fixup! Bug 40701: Add in pane security warning when downloading a file Missed a couple of removed lines. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - + browser/app/profile/000-tor-browser.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js - + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - + browser/base/content/browser-doctype.inc - browser/base/content/browser-menubar.inc - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.js - browser/base/content/browser.xhtml - browser/base/content/default-bookmarks.html - browser/base/content/hiddenWindowMac.xhtml - browser/base/content/main-popupset.inc.xhtml - browser/base/content/navigator-toolbox.inc.xhtml - browser/base/content/pageinfo/pageInfo.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/433115… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/433115… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_ESR_115_BASE
by Pier Angelo Vendrame (＠pierov) 28 Jun '23

28 Jun '23

Pier Angelo Vendrame pushed new tag FIREFOX_ESR_115_BASE at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_E… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40887: Update Webtunnel Version to 38eb5505 + fix vendor pin
by boklm (＠boklm) 28 Jun '23

28 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 54b471d4 by Shelikhoo at 2023-06-28T12:06:58+00:00 Bug 40887: Update Webtunnel Version to 38eb5505 + fix vendor pin - - - - - 1 changed file: - projects/webtunnel/config Changes: ===================================== projects/webtunnel/config ===================================== @@ -19,6 +19,6 @@ steps: pkg_type: go_vendor project: webtunnel norec: - sha256sum: 4dafb6e138d00e7587eacc2e61d0e0b9a3467835059e4ae9eb85afbe3f38df0a + sha256sum: e3b5a9b3c3939aafa5389246f3a7a7e78d70fe623bed495f99c39cc37bbbe645 target_replace: '^torbrowser-.*': 'torbrowser-linux-x86_64' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] Fix downloads.json for 12.5 (tor-browser-build#40890)
by boklm (＠boklm) 28 Jun '23

28 Jun '23

boklm pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: bf455dbc by Nicolas Vigier at 2023-06-28T13:51:18+02:00 Fix downloads.json for 12.5 (tor-browser-build#40890) Set the version as a string instead of a number. - - - - - 10 changed files: - update_3/release/download-android-aarch64.json - update_3/release/download-android-armv7.json - update_3/release/download-android-x86.json - update_3/release/download-android-x86_64.json - update_3/release/download-linux-i686.json - update_3/release/download-linux-x86_64.json - update_3/release/download-macos.json - update_3/release/download-windows-i686.json - update_3/release/download-windows-x86_64.json - update_3/release/downloads.json Changes: ===================================== update_3/release/download-android-aarch64.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-aarch6…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-aarch6…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-aarch6…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-aarch6…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-android-armv7.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-armv7-…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-armv7-…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-armv7-…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-armv7-…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-android-x86.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86-mu…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86-mu…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86-mu…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86-mu…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-android-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86_64…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86_64…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86_64…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-12.5-android-x86_64…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-linux-i686.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-linux-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-macos.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg.a…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg.a…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-windows-i686.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/download-windows-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…","version":12.5} \ No newline at end of file +{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…","git_tag":"tbb-12.5-build2","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…","version":"12.5"} \ No newline at end of file ===================================== update_3/release/downloads.json ===================================== @@ -1 +1 @@ -{"downloads":{"linux32":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…"}},"linux64":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…"}},"macos":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg","sig":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg.a…"}},"win32":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe…"}},"win64":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…"}}},"tag":"tbb-12.5-build2","version":12.5} \ No newline at end of file +{"downloads":{"linux32":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux32-12.5_ALL.ta…"}},"linux64":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…","sig":"https://dist.torproject.org/torbrowser/12.5/tor-browser-linux64-12.5_ALL.ta…"}},"macos":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg","sig":"https://dist.torproject.org/torbrowser/12.5/TorBrowser-12.5-macos_ALL.dmg.a…"}},"win32":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-12.5_ALL.exe…"}},"win64":{"ALL":{"binary":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…","sig":"https://dist.torproject.org/torbrowser/12.5/torbrowser-install-win64-12.5_A…"}}},"tag":"tbb-12.5-build2","version":"12.5"} \ No newline at end of file View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.5-1] 2 commits: Bug 41854: Allow overriding download spam protection.
by ma1 (＠ma1) 28 Jun '23

28 Jun '23

ma1 pushed to branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 38cb023e by hackademix at 2023-06-28T08:12:58+02:00 Bug 41854: Allow overriding download spam protection. - - - - - d3b18f88 by hackademix at 2023-06-28T08:16:35+02:00 fixup! Firefox preference overrides. - - - - - 5 changed files: - browser/app/profile/001-base-profile.js - browser/components/downloads/DownloadSpamProtection.jsm - toolkit/components/downloads/DownloadCore.jsm - toolkit/components/downloads/DownloadIntegration.jsm - uriloader/exthandler/nsExternalHelperAppService.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -48,6 +48,9 @@ pref("security.nocertdb", true); pref("browser.download.useDownloadDir", false); pref("browser.download.manager.addToRecentDocs", false); +// Prevent download stuffing / DOS (tor-browser#41764) +pref("browser.download.enable_spam_prevention", true); + // Misc privacy: Disk pref("signon.rememberSignons", false); pref("browser.formfill.enable", false); ===================================== browser/components/downloads/DownloadSpamProtection.jsm ===================================== @@ -18,6 +18,8 @@ var { XPCOMUtils } = ChromeUtils.import( "resource://gre/modules/XPCOMUtils.jsm" ); +var { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); + XPCOMUtils.defineLazyModuleGetters(this, { BrowserWindowTracker: "resource:///modules/BrowserWindowTracker.jsm", Downloads: "resource://gre/modules/Downloads.jsm", @@ -45,17 +47,18 @@ class DownloadSpamProtection { return this.list; } - update(url) { + update(url, principal) { if (this._blockedURLToDownloadSpam.has(url)) { let downloadSpam = this._blockedURLToDownloadSpam.get(url); this.spamList.remove(downloadSpam); + downloadSpam.principal = principal; downloadSpam.blockedDownloadsCount += 1; this.spamList.add(downloadSpam); this._indicator.onDownloadStateChanged(downloadSpam); return; } - let downloadSpam = new DownloadSpam(url); + let downloadSpam = new DownloadSpam(url, principal, this); this.spamList.add(downloadSpam); this._blockedURLToDownloadSpam.set(url, downloadSpam); let hasActiveDownloads = DownloadsCommon.summarizeDownloads( @@ -85,8 +88,10 @@ class DownloadSpamProtection { * @extends Download */ class DownloadSpam extends Download { - constructor(url) { + constructor(url, principal, protectionController) { super(); + this.protectionController = protectionController; + this.principal = principal.QueryInterface(Ci.nsIPrincipal); this.hasBlockedData = true; this.stopped = true; this.error = new DownloadError({ @@ -97,4 +102,16 @@ class DownloadSpam extends Download { this.source = { url }; this.blockedDownloadsCount = 1; } + allow() { + const pm = Services.perms; + pm.addFromPrincipal( + this.principal, + "automatic-download", + pm.ALLOW_ACTION, + pm.EXPIRE_SESSION + ); + this.hasBlockedData = this.hasPartialData = false; + this.protectionController.clearDownloadSpam(this.source.url); + this._notifyChange(); + } } ===================================== toolkit/components/downloads/DownloadCore.jsm ===================================== @@ -717,6 +717,10 @@ Download.prototype = { } this._promiseUnblock = (async () => { + if (this.allow) { + this.allow(); + return; + } try { await IOUtils.move(this.target.partFilePath, this.target.path); await this.target.refresh(); @@ -725,7 +729,6 @@ Download.prototype = { this._promiseUnblock = null; throw ex; } - this.succeeded = true; this.hasBlockedData = false; this._notifyChange(); @@ -955,7 +958,9 @@ Download.prototype = { await this._promiseCanceled; } // Ask the saver object to remove any partial data. - await this.saver.removeData(); + if (this.saver) { + await this.saver.removeData(); + } // For completeness, clear the number of bytes transferred. if (this.currentBytes != 0 || this.hasPartialData) { this.currentBytes = 0; ===================================== toolkit/components/downloads/DownloadIntegration.jsm ===================================== @@ -1234,7 +1234,7 @@ var DownloadObserver = { ) { DownloadIntegration._initializeDownloadSpamProtection(); } - DownloadIntegration.downloadSpamProtection.update(aData); + DownloadIntegration.downloadSpamProtection.update(aData, aSubject); break; } }, ===================================== uriloader/exthandler/nsExternalHelperAppService.cpp ===================================== @@ -1975,7 +1975,7 @@ bool nsExternalAppHandler::IsDownloadSpam(nsIChannel* aChannel) { nsAutoCString cStringURI; loadInfo->TriggeringPrincipal()->GetPrePath(cStringURI); observerService->NotifyObservers( - nullptr, "blocked-automatic-download", + principal, "blocked-automatic-download", NS_ConvertASCIItoUTF16(cStringURI.get()).get()); // FIXME: In order to escape memory leaks, currently we cancel blocked // downloads. This is temporary solution, because download data should be @@ -1989,7 +1989,7 @@ bool nsExternalAppHandler::IsDownloadSpam(nsIChannel* aChannel) { if (!loadInfo->GetHasValidUserGestureActivation()) { permissionManager->AddFromPrincipal( principal, type, nsIPermissionManager::PROMPT_ACTION, - nsIPermissionManager::EXPIRE_NEVER, 0 /* expire time */); + nsIPermissionManager::EXPIRE_SESSION, 0 /* expire time */); } return false; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4a13c2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4a13c2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40102: Use Debian Stretch for Linux builds
by boklm (＠boklm) 27 Jun '23

27 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: c606a927 by Nicolas Vigier at 2023-06-27T16:53:41+02:00 Bug 40102: Use Debian Stretch for Linux builds - - - - - 18 changed files: - projects/binutils/build - projects/binutils/config - − projects/bison/build - − projects/bison/config - projects/cmake/build - projects/container-image/config - projects/firefox/build - projects/firefox/config - projects/firefox/mozconfig - projects/gcc/build - projects/gcc/config - − projects/mmdebstrap-image/apt-key-allow-expired-key.patch - projects/mmdebstrap-image/config - projects/ninja/build - projects/rust/build - projects/sqlcipher/build - projects/stemns/build - rbm.conf Changes: ===================================== projects/binutils/build ===================================== @@ -2,17 +2,7 @@ [% c("var/set_default_env") -%] mkdir /var/tmp/dist distdir=/var/tmp/dist/binutils -[% IF c("var/linux") %] - # Config options for hardening-wrapper - export DEB_BUILD_HARDENING=1 - export DEB_BUILD_HARDENING_STACKPROTECTOR=1 - export DEB_BUILD_HARDENING_FORTIFY=1 - export DEB_BUILD_HARDENING_FORMAT=1 - export DEB_BUILD_HARDENING_PIE=1 - - tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/bison') %] - export PATH=/var/tmp/dist/bison/bin:$PATH -[% END %] +[% IF c("var/linux"); GET c("var/set_hardened_build_flags"); END %] tar xf [% project %]-[% c("version") %].tar.xz cd [% project %]-[% c("version") %] @@ -23,20 +13,6 @@ cd [% project %]-[% c("version") %] make -j[% c("num_procs") %] MAKEINFO=true make install MAKEINFO=true -# gold is disabled for linux-cross, because of -# https://sourceware.org/bugzilla/show_bug.cgi?id=14995 -# Once we upgrade to glibc 2.26, we might be able to enable gold for -# linux-cross. -[% IF c("var/linux") && ! c("var/linux-cross") %] - # Make sure gold is used with the hardening wrapper for full RELRO, see #13031. - cd $distdir/bin - rm ld - cp /usr/bin/hardened-ld ./ - mv ld.gold ld.gold.real - ln -sf hardened-ld ld.gold - ln -sf ld.gold ld -[% END %] - cd /var/tmp/dist [% c('tar', { tar_src => [ project ], ===================================== projects/binutils/config ===================================== @@ -22,7 +22,3 @@ input_files: file_gpg_id: 1 gpg_keyring: binutils.gpg - project: container-image - - project: bison - name: bison - # We try to use system's bison, but Jessie's is too old - enable: '[% c("var/linux") %]' ===================================== projects/bison/build deleted ===================================== @@ -1,13 +0,0 @@ -#!/bin/bash -[% c("var/set_default_env") -%] -distdir=/var/tmp/dist/bison -tar xf [% project %]-[% c("version") %].tar.xz -cd [% project %]-[% c("version") %] -./configure --prefix=$distdir -make -j[% c("num_procs") %] -make install -cd /var/tmp/dist -[% c('tar', { - tar_src => [ project ], - tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'), - }) %] ===================================== projects/bison/config deleted ===================================== @@ -1,10 +0,0 @@ -# vim: filetype=yaml sw=2 -version: 3.8.2 -filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.gz' -container: - use_container: 1 - -input_files: - - URL: https://ftp.gnu.org/gnu/bison/bison-[% c("version") %].tar.xz - sha256: 9bba0214ccf7f1079c5d59210045227bcf619519840ebfa80cd3849cff5a5bf2 - - project: container-image ===================================== projects/cmake/build ===================================== @@ -5,7 +5,7 @@ distdir=/var/tmp/dist/[% project %] [% pc('gcc', 'var/setup', { compiler_tarfile => c('input_files_by_name/gcc'), hardened_gcc => 0 }) %] [% END -%] -mkdir /var/tmp/build +mkdir -p /var/tmp/build tar -C /var/tmp/build -xf [% project %]-[% c('version') %].tar.gz cd /var/tmp/build/[% project %]-[% c('version') %] ./bootstrap --prefix=$distdir ===================================== projects/container-image/config ===================================== @@ -11,8 +11,8 @@ var: lsb_release: id: Debian - codename: jessie - release: 8.11 + codename: stretch + release: 9.13 targets: no_containers: @@ -33,18 +33,13 @@ pre: | # version of required packages. apt-get update -y -q [% IF pc(c('origin_project'), 'var/pre_pkginst', { step => c('origin_step') }) -%] - [% pc(c('origin_project'), 'var/pre_pkginst', { step => c('origin_step') }) %] - [% IF c("var/linux-cross") -%] - dpkg --add-architecture [% c("var/arch_debian") %] - [% END -%] - [% IF c("var/container/suite") == "jessie" -%] - # We need to use faketime to run `apt-get update` on jessie, because of - # expired key. See tor-browser-build#40693 - dpkg -i ./libfaketime_0.9.6-3_amd64.deb ./faketime_0.9.6-3_amd64.deb - [% END -%] - # Update the package cache again because `pre_pkginst` may change the - # package manager configuration. - [% IF c("var/container/suite") == "jessie" %]faketime '2018-12-24 08:15:42' [% END %]apt-get update -y -q + [% pc(c('origin_project'), 'var/pre_pkginst', { step => c('origin_step') }) %] + [% IF c("var/linux-cross") -%] + dpkg --add-architecture [% c("var/arch_debian") %] + [% END -%] + # Update the package cache again because `pre_pkginst` may change the + # package manager configuration. + apt-get update -y -q [% END -%] apt-get upgrade -y -q [% @@ -87,9 +82,3 @@ input_files: - project: mmdebstrap-image target: - '[% c("var/container/suite") %]-[% c("var/container/arch") %]' - - URL: http://archive.debian.org/debian/pool/main/f/faketime/faketime_0.9.6-3_amd6… - sha256sum: 19b2a01a2fae7e6d5a8b741fc0bc626451cb4c2cc884ee79f1136dd3c2c26213 - enable: '[% c("var/container/suite") == "jessie" %]' - - URL: http://archive.debian.org/debian/pool/main/f/faketime/libfaketime_0.9.6-3_a… - sha256sum: 82747d5815b226cfed7f6f9a751bf8c20d457f3ba786add6017d6904dea4fdb4 - enable: '[% c("var/container/suite") == "jessie" %]' ===================================== projects/firefox/build ===================================== @@ -1,6 +1,9 @@ #!/bin/bash [% c("var/set_default_env") -%] -[% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] +[% pc(c('var/compiler'), 'var/setup', { + compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')), + hardened_gcc => 0, # don't set hardened_gcc since firefox is setting the hardened flags + }) %] distdir=/var/tmp/dist/[% project %] mkdir -p /var/tmp/build mkdir -p [% dest_dir _ '/' _ c('filename') %] ===================================== projects/firefox/config ===================================== @@ -96,7 +96,6 @@ targets: - libgtk-3-dev - libdbus-glib-1-dev - libxt-dev - - hardening-wrapper # To pass configure since ESR 31 - libpulse-dev # To pass configure since ESR 52 @@ -116,7 +115,6 @@ targets: - libgtk-3-dev:i386 - libdbus-glib-1-dev:i386 - libxt-dev:i386 - - hardening-wrapper # To pass configure since ESR 31 - libpulse-dev:i386 # To pass configure since ESR 52 ===================================== projects/firefox/mozconfig ===================================== @@ -10,6 +10,9 @@ HOST_CXX=$CXX export BINDGEN_CFLAGS='--gcc-toolchain=/var/tmp/dist/gcc' + + # set LDFLAGS for Full RELRO + export LDFLAGS="-Wl,-z,relro -Wl,-z,now" [% END -%] [% IF c("var/windows") -%] ===================================== projects/gcc/build ===================================== @@ -1,23 +1,23 @@ #!/bin/sh [% c("var/set_default_env") -%] -[% IF c("var/linux") -%] - # Config options for hardening-wrapper +mkdir -p /var/tmp/build +[% IF c("var/linux") && ! c("var/linux-cross") -%] + # Config options for hardening export DEB_BUILD_HARDENING=1 - export DEB_BUILD_HARDENING_STACKPROTECTOR=1 - export DEB_BUILD_HARDENING_FORTIFY=1 # Since r223796 landed on GCC master enforcing PIE breaks GCC compilation. # The compiler gets built with `-fno-PIE` and linked with `-no-pie` as not # doing so would make precompiled headers (PCH) fail. # It is okay for us to omit this right now as it does not change any hardening # flags in the resulting bundles. - export DEB_BUILD_HARDENING_PIE=0 + # # We need to disable `-Werror=format-security` as GCC does not build with it # anymore. It seems it got audited for those problems already: # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48817. - export DEB_BUILD_HARDENING_FORMAT=0 + export DEB_BUILD_OPTIONS=hardening=+bindnow,+relro,-pie,+fortify,+stackprotector,+stackprotectorstrong,-format + eval $(cd /var/tmp/build; dpkg-buildflags --export=sh) + export OPT_LDFLAGS="$LDFLAGS" [% END -%] distdir=/var/tmp/dist/[% c("var/distdir") %] -mkdir /var/tmp/build [% IF c("var/linux-cross") -%] ===================================== projects/gcc/config ===================================== @@ -18,26 +18,7 @@ var: [% IF ! c("var/linux-cross") -%] export LD_LIBRARY_PATH=/var/tmp/dist/[% c("var/distdir") %]/lib64:/var/tmp/dist/[% c("var/distdir") %]/lib32 [% END -%] - - [% IF c("hardened_gcc") -%] - # Config options for hardening-wrapper - export DEB_BUILD_HARDENING=1 - export DEB_BUILD_HARDENING_STACKPROTECTOR=1 - export DEB_BUILD_HARDENING_FORTIFY=1 - export DEB_BUILD_HARDENING_FORMAT=1 - export DEB_BUILD_HARDENING_PIE=1 - - # Make sure we use the hardening wrapper - pushd /var/tmp/dist/[% c("var/distdir") %]/bin - cp /usr/bin/hardened-cc ./ - mv [% c("var/target_prefix") %]gcc [% c("var/target_prefix") %]gcc.real - mv [% c("var/target_prefix") %]c++ [% c("var/target_prefix") %]c++.real - mv [% c("var/target_prefix") %]g++ [% c("var/target_prefix") %]g++.real - ln -sf hardened-cc [% c("var/target_prefix") %]gcc - ln -sf hardened-cc [% c("var/target_prefix") %]c++ - ln -sf hardened-cc [% c("var/target_prefix") %]g++ - popd - [% END -%] + [% IF c("hardened_gcc"); GET c("var/set_hardened_build_flags"); END %] targets: windows: @@ -51,7 +32,6 @@ targets: var: configure_opt: --enable-multilib --enable-languages=c,c++ --with-arch_32=i686 arch_deps: - - hardening-wrapper - libc6-dev-i386 linux-cross: var: @@ -64,7 +44,6 @@ targets: glibc_version: 2.26 linux_version: 4.10.1 arch_deps: - - hardening-wrapper - libc6-dev-i386 - gawk linux-arm: ===================================== projects/mmdebstrap-image/apt-key-allow-expired-key.patch deleted ===================================== @@ -1,23 +0,0 @@ ---- o/apt-key 2022-11-30 14:57:12.742026261 +0000 -+++ n/apt-key 2022-12-01 08:38:08.170140893 +0000 -@@ -815,11 +815,18 @@ - create_gpg_home - fi - setup_merged_keyring -+ tmpfile=$(mktemp) -+ set +e - if [ -n "$FORCED_KEYRING" ]; then -- "$GPGV" --homedir "${GPGHOMEDIR}" --keyring "$(dearmor_filename "${FORCED_KEYRING}")" --ignore-time-conflict "$@" -+ (eval "exec ${GPGSTATUSFD}>$tmpfile"; "$GPGV" --homedir "${GPGHOMEDIR}" --keyring "$(dearmor_filename "${FORCED_KEYRING}")" --ignore-time-conflict "$@") - else -- "$GPGV" --homedir "${GPGHOMEDIR}" --keyring "${GPGHOMEDIR}/pubring.gpg" --ignore-time-conflict "$@" -+ (eval "exec ${GPGSTATUSFD}>$tmpfile"; "$GPGV" --homedir "${GPGHOMEDIR}" --keyring "${GPGHOMEDIR}/pubring.gpg" --ignore-time-conflict "$@") - fi -+ err=$? -+ set -e -+ cat "$tmpfile" | sed 's/^\[GNUPG:\] EXPKEYSIG /\[GNUPG:\] GOODSIG /' >&${GPGSTATUSFD} -+ rm -f "$tmpfile" -+ exit $err - ;; - help) - usage ===================================== projects/mmdebstrap-image/config ===================================== @@ -6,7 +6,7 @@ container: use_container: 1 var: - ubuntu_version: 22.04.1 + ubuntu_version: 22.04.2 pre: | #!/bin/sh @@ -16,14 +16,6 @@ pre: | apt-get update -y -q apt-get install -y -q debian-archive-keyring ubuntu-keyring mmdebstrap gnupg - [% IF c("var/container/suite") == "jessie" -%] - apt-get install -y -q patch - cd /usr/bin - # The gpg key for jessie is expired. We patch apt-key to accept expired keys. - patch -p1 < $rootdir/apt-key-allow-expired-key.patch - cd $rootdir - [% END -%] - export SOURCE_DATE_EPOCH='[% c("timestamp") %]' tar -xf [% c('input_files_by_name/mmdebstrap') %] ./mmdebstrap/mmdebstrap --mode=unshare [% c("var/container/mmdebstrap_opt") %] [% c("var/container/suite") %] output.tar.gz [% c("var/container/debian_mirror") %] @@ -39,16 +31,16 @@ pre: | mv output.tar.gz [% dest_dir %]/[% c("filename") %] targets: - jessie-amd64: + stretch-amd64: var: - minimal_apt_version: 1.0.9.8.6 - + minimal_apt_version: 1.4.11 container: - suite: jessie + suite: stretch arch: amd64 debian_mirror: > - "deb [signed-by=/usr/share/keyrings/debian-archive-removed-keys.gpg] http://archive.debian.org/debian-archive/debian/ jessie main" - "deb [signed-by=/usr/share/keyrings/debian-archive-removed-keys.gpg] http://archive.debian.org/debian-archive/debian-security/ jessie/updates main" + "deb [signed-by=/usr/share/keyrings/debian-archive-keyring.gpg] http://archive.debian.org/debian-archive/debian/ stretch main" + "deb [signed-by=/usr/share/keyrings/debian-archive-keyring.gpg] http://archive.debian.org/debian-archive/debian-security/ stretch/updates main" + bullseye-amd64: var: @@ -62,6 +54,4 @@ input_files: name: mmdebstrap - URL: 'https://cdimage.ubuntu.com/ubuntu-base/releases/[% c("var/ubuntu_version") %]/release/ubuntu-base-[% c("var/ubuntu_version") %]-base-amd64.tar.gz' filename: 'container-image_ubuntu-base-[% c("var/ubuntu_version") %]-base-amd64.tar.gz' - sha256sum: e1f9200c99da008a473c9ae7b51e13f5ea05dc4c2e12beb43f0f9cbbbf6216f4 - - filename: apt-key-allow-expired-key.patch - enable: '[% c("var/container/suite") == "jessie" %]' + sha256sum: 373f064df30519adc3344a08d774f437caabd1479d846fa2ca6fed727ea7a53d ===================================== projects/ninja/build ===================================== @@ -8,7 +8,7 @@ distdir=/var/tmp/dist/[% project %] [% IF c("var/linux") -%] [% pc('python', 'var/setup', { python_tarfile => c('input_files_by_name/python') }) %] [% END -%] -mkdir /var/tmp/build +mkdir -p /var/tmp/build tar -C /var/tmp/build -xf [% project %]-[% c('version') %].tar.gz cd /var/tmp/build/[% project %]-[% c('version') %] ===================================== projects/rust/build ===================================== @@ -50,7 +50,7 @@ EOF [% END %] cd $rootdir -mkdir /var/tmp/build +mkdir -p /var/tmp/build tar -C /var/tmp/build -xf [% c('input_files_by_name/rust') %] cd /var/tmp/build/rustc-[% c('version') %]-src ===================================== projects/sqlcipher/build ===================================== @@ -3,7 +3,7 @@ [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] distdir=/var/tmp/dist/sqlcipher builddir=/var/tmp/build/[% project %] -mkdir /var/tmp/build +mkdir -p /var/tmp/build tar -C /var/tmp/dist -xf [% c('input_files_by_name/nss') %] [% IF ! c("var/sqlcipher-linux-x86_64") -%] ===================================== projects/stemns/build ===================================== @@ -1,8 +1,8 @@ #!/bin/sh [% c("var/set_default_env") -%] distdir=/var/tmp/dist/StemNS -mkdir /var/tmp/build -mkdir /var/tmp/dist +mkdir -p /var/tmp/build +mkdir -p /var/tmp/dist # Extract StemNS tar -C /var/tmp/build -xf [% project %]-[% c('version') %].tar.gz ===================================== rbm.conf ===================================== @@ -491,7 +491,7 @@ targets: # Temporarily disabled until we have a fix for tor-browser-build#40845 #namecoin: '[% c("var/nightly") && c("var/tor-browser") %]' container: - suite: jessie + suite: stretch arch: amd64 pre_pkginst: dpkg --add-architecture i386 deps: @@ -503,13 +503,18 @@ targets: - build-essential - python - bison - - hardening-wrapper - automake - libtool - zip - unzip - xz-utils - patch + - less + set_hardened_build_flags: | + export DEB_BUILD_HARDENING=1 + export DEB_BUILD_OPTIONS='hardening=+bindnow,+relro,+pie,+fortify,+stackprotector,+stackprotectorstrong,+format' + mkdir -p /var/tmp/build + eval $(cd /var/tmp/build; dpkg-buildflags --export=sh) linux-asan: var: asan: 1 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.5-1] fixup! Bug 30237: Add v3 onion services client authentication prompt
by ma1 (＠ma1) 27 Jun '23

27 Jun '23

ma1 pushed to branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 4a13c283 by hackademix at 2023-06-27T07:54:52+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 1 changed file: - browser/components/onionservices/content/authPrompt.js Changes: ===================================== browser/components/onionservices/content/authPrompt.js ===================================== @@ -73,8 +73,18 @@ const OnionAuthPrompt = (function() { ); }, + _autoFocus(event) { + event.target.ownerGlobal.focus(); + }, + _onPromptShowing(aWarningMessage) { let xulDoc = this._browser.ownerDocument; + + // Force back focus: tor-browser#41856 + (this._popupElem = xulDoc.getElementById( + `${OnionAuthUtil.domid.notification}-notification` + ))?.addEventListener("click", this._autoFocus); + let descElem = xulDoc.getElementById(OnionAuthUtil.domid.description); if (descElem) { // Handle replacement of the onion name within the localized @@ -159,6 +169,9 @@ const OnionAuthPrompt = (function() { this._boundOnKeyFieldInput = undefined; } } + if (this._popupElem) { + this._popupElem.removeEventListener("click", this._autoFocus); + } }, _onKeyFieldKeyPress(aEvent) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4a13c28… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4a13c28… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40085: Bump version of snowflake to v2.6.0
by boklm (＠boklm) 26 Jun '23

26 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: bac08eff by Cecylia Bocovich at 2023-06-26T14:15:23+00:00 Bug 40085: Bump version of snowflake to v2.6.0 - - - - - 1 changed file: - projects/snowflake/config Changes: ===================================== projects/snowflake/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snow… -git_hash: 7b77001eaa90e09d41172a2b170dabd3f1922b4a +git_hash: 08d1c6d6551464d526d4bbe608384b8e7dec32ee #v2.6.0 container: use_container: 1 @@ -20,6 +20,6 @@ steps: pkg_type: go_vendor project: snowflake norec: - sha256sum: a4bfd990bb3c0ce131ddd056c779d1c7be8f624aaff6fa1dbf865cc9f2950620 + sha256sum: 62f9065881f5a3cbe5ea5a9802e961e1821d9e468cb2a85ebab1e8afcc0cc953 target_replace: '^torbrowser-.*': 'torbrowser-linux-x86_64' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40887: Update Webtunnel Version to 38eb5505
by boklm (＠boklm) 26 Jun '23

26 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 3aeaa51c by Shelikhoo at 2023-06-26T14:04:15+00:00 Bug 40887: Update Webtunnel Version to 38eb5505 - - - - - 1 changed file: - projects/webtunnel/config Changes: ===================================== projects/webtunnel/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/webt… -git_hash: 2ecf64381bad8a5db45c5871dcad7d12831dca69 +git_hash: 38eb55054a5c3c072acc1d8f9a9afa36e3a5c9b7 container: use_container: 1 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-12.5-build1
by richard (＠richard) 23 Jun '23

23 Jun '23

richard pushed new tag mb-12.5-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] ChangeLog.txt updates
by richard (＠richard) 23 Jun '23

23 Jun '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: c5bfcc1a by Richard Pospesel at 2023-06-23T17:05:58+00:00 ChangeLog.txt updates - migrated Docs-PB to Docs-MB in browser project - updated browser build script to take new path into account - created separate ChangeLog-MB.txt softlink, migrate ChangeLog.txt softlink to ChangeLog-TBB.txt - updated changelog-format-blog-post script to reference correct file and fix bug in raw changelog link - - - - - 6 changed files: - + ChangeLog-MB.txt - ChangeLog.txt → ChangeLog-TBB.txt - + projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-PB/Licenses/uBlockOrigin.txt → projects/browser/Bundle-Data/Docs-MB/Licenses/uBlockOrigin.txt - projects/browser/build - tools/changelog-format-blog-post Changes: ===================================== ChangeLog-MB.txt ===================================== @@ -0,0 +1 @@ +projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt \ No newline at end of file ===================================== ChangeLog.txt → ChangeLog-TBB.txt ===================================== ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== ===================================== projects/browser/Bundle-Data/Docs-PB/Licenses/uBlockOrigin.txt → projects/browser/Bundle-Data/Docs-MB/Licenses/uBlockOrigin.txt ===================================== ===================================== projects/browser/build ===================================== @@ -241,7 +241,7 @@ do [% IF ! c("var/namecoin") %]--exclude=*Electrum-NMC* --exclude=*ncprop279*[% END %] \ -c . | tar -C "$tbdir[% IF ! c("var/macos") %]/[% c('var/ProjectName') %][% END %]" -x [% ELSIF c("var/mullvad-browser") -%] - cp -a Bundle-Data/Docs-PB/* "$tbdir/$DOCSPATH" + cp -a Bundle-Data/Docs-MB/* "$tbdir/$DOCSPATH" [% END -%] done ===================================== tools/changelog-format-blog-post ===================================== @@ -12,7 +12,7 @@ sub version_type { my ($changelog, $current_tbversion, $last_tbversion); -if (!open(CHANGELOG, '<', "$FindBin::Bin/../ChangeLog.txt")) { +if (!open(CHANGELOG, '<', "$FindBin::Bin/../ChangeLog-TBB.txt")) { print STDERR "Error opening changelog file\n"; exit 1; } @@ -49,6 +49,6 @@ if (! ( $current_tbversion =~ m/a/ ) ) { my @v = split(/\./, $current_tbversion); $changelog_branch = "maint-$v[0].$v[1]"; } -print "The full changelog since [Tor Browser $last_tbversion](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$changelog_branch/projects/browser/Bundle-Data/Docs/ChangeLog.txt) is:\n\n"; +print "The full changelog since [Tor Browser $last_tbversion](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$changelog_branch/projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt) is:\n\n"; print $changelog; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] 2 commits: ChangeLog.txt updates
by richard (＠richard) 23 Jun '23

23 Jun '23

richard pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: dbd79b03 by Richard Pospesel at 2023-06-21T21:06:53+00:00 ChangeLog.txt updates - migrated Docs-PB to Docs-MB in browser project - updated browser build script to take new path into account - created separate ChangeLog-MB.txt softlink, migrate ChangeLog.txt softlink to ChangeLog-TBB.txt - updated changelog-format-blog-post script to reference correct file and fix bug in raw changelog link - - - - - 0836bd0b by Richard Pospesel at 2023-06-22T20:03:17+00:00 Bug 40872: Mullvad Browser 12.5 - - - - - 9 changed files: - + ChangeLog-MB.txt - ChangeLog.txt → ChangeLog-TBB.txt - + projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-PB/Licenses/uBlockOrigin.txt → projects/browser/Bundle-Data/Docs-MB/Licenses/uBlockOrigin.txt - projects/browser/build - projects/browser/config - projects/firefox/config - rbm.conf - tools/changelog-format-blog-post Changes: ===================================== ChangeLog-MB.txt ===================================== @@ -0,0 +1 @@ +projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt \ No newline at end of file ===================================== ChangeLog.txt → ChangeLog-TBB.txt ===================================== ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -0,0 +1,31 @@ +Mullvad Browser 12.5 - June 21 2023 + * All Platforms + * Updated uBlock Origin to 1.50.0 + * Updated mullvad-browser-extension to version 0.8.3 + * Windows + macOS + Linux + * Bug 41577: Disable profile migration [tor-browser] + * Bug 41595: Disable pagethumbnails capturing [tor-browser] + * Bug 41609: Move the disabling of Firefox Home (Activity Stream) to base-browser [tor-browser] + * Bug 41668: Move part of the updater patches to base browser [tor-browser] + * Bug 41686: Move the 'Bug 11641: Disable remoting by default' commit from base-browser to tor-browser [tor-browser] + * Bug 41695: Port warning on maximized windows without letterboxing from torbutton [tor-browser] + * Bug 41701: Reporting an extension does not work [tor-browser] + * Bug 41711: Race condition when opening a new window in New Identity [tor-browser] + * Bug 41736: Customize the default CustomizableUI toolbar using CustomizableUI.jsm [tor-browser] + * Bug 41738: Replace the patch to disable live reload with its preference [tor-browser] + * Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp [tor-browser] + * Windows + Linux + * Bug 41654: UpdateInfo jumped into Data [tor-browser] + * Linux + * Bug 40860: Improve the transition from the old fontconfig file to the new one [tor-browser-build] + * Bug 41163: Many bundled fonts are blocked in Ubuntu/Fedora because of RFP [tor-browser] + * Bug 41732: implement linux font whitelist as defense-in-depth [tor-browser] + * Build System + * All Platforms + * Bug 40837: Rebase mullvad-browser build changes onto main [tor-browser-build] + * Bug 40870: Remove url without browser name from tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo [tor-browser-build] + * Windows + macOS + Linux + * Bug 40826: Correctly set appname_marfile for basebrowser in tools/signing/nightly/update-responses-base-config.yml [tor-browser-build] + * Bug 40866: Remove `Using ansible to set up a nightly build machine` from README [tor-browser-build] + * macOS + * Bug 40858: Create script to assist testers self sign Mac builds to allow running on Arm processors [tor-browser-build] ===================================== projects/browser/Bundle-Data/Docs-PB/Licenses/uBlockOrigin.txt → projects/browser/Bundle-Data/Docs-MB/Licenses/uBlockOrigin.txt ===================================== ===================================== projects/browser/build ===================================== @@ -237,7 +237,7 @@ do [% IF ! c("var/namecoin") %]--exclude=*Electrum-NMC* --exclude=*ncprop279*[% END %] \ -c . | tar -C "$tbdir[% IF ! c("var/macos") %]/[% c('var/ProjectName') %][% END %]" -x [% ELSIF c("var/mullvad-browser") -%] - cp -a Bundle-Data/Docs-PB/* "$tbdir/$DOCSPATH" + cp -a Bundle-Data/Docs-MB/* "$tbdir/$DOCSPATH" [% END -%] done ===================================== projects/browser/config ===================================== @@ -106,13 +106,13 @@ input_files: - URL: https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.… name: noscript sha256sum: 46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e - - URL: https://addons.mozilla.org/firefox/downloads/file/4103048/ublock_origin-1.4… + - URL: https://addons.mozilla.org/firefox/downloads/file/4121906/ublock_origin-1.5… name: ublock-origin - sha256sum: 39266486f720cd31d291d2fdad78625b079782a05517e1936eec7e780bc2a84d + sha256sum: 10618003e70b528c3f17996e373146d39e6b15f777ac4ca1f214da2ffdb7a5b3 enable: '[% c("var/mullvad-browser") %]' - - URL: https://github.com/mullvad/browser-extension/releases/download/v0.7.9-firef… + - URL: https://github.com/mullvad/browser-extension/releases/download/v0.8.3-firef… name: mullvad-extension - sha256sum: 17ce31b32e8be0f0db86a5a5ed93607cc84d5e2092341aee0b8eaba1c0746390 + sha256sum: e531ce6e809091eb40848874ea9e695bce61196397b6d8238ab582a152e02ac7 enable: '[% c("var/mullvad-browser") %]' - filename: 'gtk3-settings.ini' enable: '[% c("var/linux") %]' ===================================== projects/firefox/config ===================================== @@ -85,7 +85,7 @@ targets: git_url: https://gitlab.torproject.org/tpo/applications/mullvad-browser.git var: branding_directory_prefix: 'mb' - browser_build: 1 + browser_build: 2 gitlab_project: https://gitlab.torproject.org/tpo/applications/mullvad-browser linux-x86_64: ===================================== rbm.conf ===================================== @@ -277,8 +277,7 @@ targets: exe_name: mullvadbrowser mar_channel_id: '[% c("var/projectname") %]-mullvad-[% c("var/channel") %]' locales: [] - torbrowser_incremental_from: - - 12.5a6 + torbrowser_build: 'build1' torbrowser-testbuild: - testbuild ===================================== tools/changelog-format-blog-post ===================================== @@ -12,7 +12,7 @@ sub version_type { my ($changelog, $current_tbversion, $last_tbversion); -if (!open(CHANGELOG, '<', "$FindBin::Bin/../ChangeLog.txt")) { +if (!open(CHANGELOG, '<', "$FindBin::Bin/../ChangeLog-TBB.txt")) { print STDERR "Error opening changelog file\n"; exit 1; } @@ -49,6 +49,6 @@ if (! ( $current_tbversion =~ m/a/ ) ) { my @v = split(/\./, $current_tbversion); $changelog_branch = "maint-$v[0].$v[1]"; } -print "The full changelog since [Tor Browser $last_tbversion](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$changelog_branch/projects/browser/Bundle-Data/Docs/ChangeLog.txt) is:\n\n"; +print "The full changelog since [Tor Browser $last_tbversion](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$changelog_branch/projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt) is:\n\n"; print $changelog; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] release: new version, 12.5
by richard (＠richard) 22 Jun '23

22 Jun '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 741176fa by Richard Pospesel at 2023-06-22T18:46:35+00:00 release: new version, 12.5 - - - - - 30 changed files: - update_3/release/.htaccess - − update_3/release/12.0.4-12.0.7-linux32-ALL.xml - − update_3/release/12.0.4-12.0.7-linux64-ALL.xml - − update_3/release/12.0.4-12.0.7-macos-ALL.xml - − update_3/release/12.0.4-12.0.7-win32-ALL.xml - − update_3/release/12.0.4-12.0.7-win64-ALL.xml - − update_3/release/12.0.5-12.0.7-linux32-ALL.xml - − update_3/release/12.0.5-12.0.7-linux64-ALL.xml - − update_3/release/12.0.5-12.0.7-macos-ALL.xml - − update_3/release/12.0.5-12.0.7-win32-ALL.xml - − update_3/release/12.0.5-12.0.7-win64-ALL.xml - + update_3/release/12.0.5-12.5-linux32-ALL.xml - + update_3/release/12.0.5-12.5-linux64-ALL.xml - + update_3/release/12.0.5-12.5-macos-ALL.xml - + update_3/release/12.0.5-12.5-win32-ALL.xml - + update_3/release/12.0.5-12.5-win64-ALL.xml - − update_3/release/12.0.6-12.0.7-linux32-ALL.xml - − update_3/release/12.0.6-12.0.7-linux64-ALL.xml - − update_3/release/12.0.6-12.0.7-macos-ALL.xml - − update_3/release/12.0.6-12.0.7-win32-ALL.xml - − update_3/release/12.0.6-12.0.7-win64-ALL.xml - + update_3/release/12.0.6-12.5-linux32-ALL.xml - + update_3/release/12.0.6-12.5-linux64-ALL.xml - + update_3/release/12.0.6-12.5-macos-ALL.xml - + update_3/release/12.0.6-12.5-win32-ALL.xml - + update_3/release/12.0.6-12.5-win64-ALL.xml - + update_3/release/12.0.7-12.5-linux32-ALL.xml - + update_3/release/12.0.7-12.5-linux64-ALL.xml - + update_3/release/12.0.7-12.5-macos-ALL.xml - + update_3/release/12.0.7-12.5-win32-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40886: Add Arch instructions to README
by boklm (＠boklm) 22 Jun '23

22 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: cb783947 by Dan Ballard at 2023-06-21T16:17:32-07:00 Bug 40886: Add Arch instructions to README - - - - - 1 changed file: - README Changes: ===================================== README ===================================== @@ -42,6 +42,20 @@ If you are running Debian or Ubuntu, you can install them with: libfile-copy-recursive-perl libfile-slurp-perl git \ mercurial uidmap +If you are running an Arch based system, you should be able to install them with: + +# pacman -S perl-datetime perl-path-tiny perl-yaml perl-yaml-libyaml \ + perl-yaml-tiny perl-template-toolkit perl-io-captureoutput \ + perl-file-copy-recursive perl-string-shellquote \ + perl-sort-versions perl-data-uuid perl-data-dump perl-json \ + perl-digest-sha1 perl-io-all perl-file-slurp perl-sys-syscall \ + perl-parallel-forkmanager perl-xml-libxml perl-lwp-protocol-https + +On Arch based systems you also need to generate some .ph files RBM expects: + + # cd /usr/include/sys; h2ph syscall.h + # cd /usr/include/; h2ph asm/unistd.h asm/unistd_64.h bits/syscall.h + The build system is based on rbm, which is included as a git submodule in the rbm/ directory. You can fetch the rbm git submodule by running 'make submodule-update'. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.5-1] fixup! Adding issue and merge request templates
by richard (＠richard) 21 Jun '23

21 Jun '23

richard pushed to branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 9d876ebb by Richard Pospesel at 2023-06-21T18:06:08+00:00 fixup! Adding issue and merge request templates - added potential reviewer list with associated focus areas - - - - - 1 changed file: - .gitlab/merge_request_templates/default.md Changes: ===================================== .gitlab/merge_request_templates/default.md ===================================== @@ -25,12 +25,34 @@ ### Merging - [ ] Merge to `tor-browser` - `!fixups` to `tor-browser`-specific commits, new features, security backports -- [ ] Merge to `base-browser` -`!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports +- [ ] Merge to `base-browser` - `!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports - **NOTE**: if your changeset includes patches to both `base-browser` and `tor-browser` please clearly label in the change description which commits should be cherry-picked to `base-browser` after merging ### Issue Tracking - [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation -## Change Description - - \ No newline at end of file +### Review + +#### Request Reviewer + +- [ ] Request review from an applications developer depending on modified system: + - **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer) + - **accessibility** : henry + - **android** : dan + - **build system** : boklm + - **extensions** : ma1 + - **firefox internals (XUL/JS/XPCOM)** : ma1 + - **fonts** : pierov + - **frontend (implementation)** : henry + - **frontend (review)** : donuts, richard + - **localization** : henry, pierov + - **nightly builds** : boklm + - **rebases/release-prep** : dan_b, ma1, pierov, richard + - **security** : ma1 + - **signing** : boklm, richard + - **updater** : pierov + - **misc/other** : pierov, richard + +#### Change Description + + View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9d876eb… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9d876eb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Updated gitlab merge request template
by richard (＠richard) 21 Jun '23

21 Jun '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: aafb2ab9 by Richard Pospesel at 2023-06-20T21:22:57+00:00 Updated gitlab merge request template - - - - - 82bb2187 by Richard Pospesel at 2023-06-20T21:22:59+00:00 Release Prep issue template updates - - - - - 5 changed files: - + .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md - .gitlab/issue_templates/Release Prep - Mullvad Browser Stable.md - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md - .gitlab/merge_request_templates/default.md Changes: ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md ===================================== @@ -0,0 +1,195 @@ +<details> + <summary>Explanation of variables</summary> + +- `$(BUILD_SERVER)` : the server the main builder is using to build a mullvad-browser release +- `$(BUILDER)` : whomever is building the release on the $(BUILD_SERVER) + - **example** : `pierov` +- `$(STAGING_SERVER)` : the server the signer is using to to run the signing process +- `$(ESR_VERSION)` : the Mozilla defined ESR version, used in various places for building mullvad-browser tags, labels, etc + - **example** : `91.6.0` +- `$(MULLVAD_BROWSER_MAJOR)` : the Mullvad Browser major version + - **example** : `11` +- `$(MULLVAD_BROWSER_MINOR)` : the Mullvad Browser minor version + - **example** : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` +- `$(MULLVAD_BROWSER_VERSION)` : the Mullvad Browser version in the format + - **example** : `12.5a3`, `12.0.3` +- `$(BUILD_N)` : a project's build revision within a its branch; this is separate from the `$(MULLVAD_BROWSER_BUILD_N)` value; many of the Firefox-related projects have a `$(BUILD_N)` suffix and may differ between projects even when they contribute to the same build. + - **example** : `build1` +- `$(MULLVAD_BROWSER_BUILD_N)` : the mullvad-browser build revision for a given Mullvad Browser release; used in tagging git commits + - **example** : `build2` + - **NOTE** : A project's `$(BUILD_N)` and `$(MULLVAD_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For **example** : + - if we have multiple Mullvad Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(MULLVAD_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(MULLVAD_BROWSER_VERSION)` will increase) + - if we have build failures unrelated to `mullvad-browser`, the `$(MULLVAD_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. +- `$(MULLVAD_BROWSER_VERSION)` : the published Mullvad Browser version + - **example** : `11.5a6`, `11.0.7` +- `$(MB_BUILD_TAG)` : the `tor-browser-build` build tag used to build a given Mullvad Browser version + - **example** : `mb-12.0.7-build1` +</details> + +**NOTE** It is assumed that the `tor-browser` alpha rebase and security backport tasks have been completed + +<details> + <summary>Building</summary> + +### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git +Mullvad Browser Alpha (and Nightly) are on the `main` branch + +- [ ] Update `rbm.conf` + - [ ] `var/torbrowser_version` : update to next version + - [ ] `var/torbrowser_build` : update to `$(MULLVAD_BROWSER_BUILD_N)` + - [ ] `var/torbrowser_incremental_from` : update to previous Desktop version + - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make mullvadbrowser-incrementals-*` step will fail +- [ ] Update build configs + - [ ] Update `projects/firefox/config` + - [ ] `browser_build` : update to match `mullvad-browser` tag + - [ ] ***(Optional)*** `var/firefox_platform_version` : update to latest `$(ESR_VERSION)` if rebased + - [ ] Update `projects/translation/config`: + - [ ] run `make list_translation_updates-alpha` to get updated hashes + - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch + - [ ] `steps/base-browser-fluent/git_hash` : update with `HEAD` commit of project's `basebrowser-newidentityftl` branch +- [ ] Update common build configs + - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript + - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` + - [ ] Check for uBlock-origin updates here : https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/ + - [ ] ***(Optional)*** If new version available, update `ublock-origin` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` + - [ ] Check for Mullvad Privacy Companion updates here : https://github.com/mullvad/browser-extension/releases + - [ ] ***(Optional)*** If new version available, update `mullvad-extension` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` +- [ ] Open MR with above changes +- [ ] Merge +- [ ] Sign/Tag commit: `make mullvadbrowser-signtag-alpha` +- [ ] Push tag to `origin` +- [ ] Begin build on `$(BUILD_SERVER)` (fix any issues in subsequent MRs) +- [ ] **TODO** Submit build-tag to Mullvad build infra +- [ ] Ensure builders have matching builds + +</details> + +<details> + <summary>QA</summary> + +### send the build + + - [ ] Email Mullvad QA: support(a)mullvad.net, rui(a)mullvad.net + <details> + <summary>email template</summary> + + Subject: + New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (unsigned) + + Body: + unsigned builds: https://tb-build-05.torproject.org/~$(BUILDER)/builds/mullvadbrowser/releas… + + changelog: + ... + + </details> + + - ***(Optional)*** Add additional information: + - [ ] Note any new functionality which needs testing + - [ ] Link to any known issues + +</details> + +<details> + <summary>Signing</summary> + +### signing +- [ ] On `$(STAGING_SERVER)`, ensure updated: + - [ ] `tor-browser-build/tools/signing/set-config.hosts` + - `ssh_host_builder` : ssh hostname of machine with unsigned builds + - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) + - `ssh_host_linux_signer` : ssh hostname of linux signing machine + - `ssh_host_macos_signer` : ssh hostname of macOS signing machine + - [ ] `tor-browser-build/tools/signing/set-config.macos-notarization` + - `macos_notarization_user` : the email login for a mullvad notariser Apple Developer account + - [ ] `set-config.update-responses` + - `update_responses_repository_dir` : directory where you cloned `git@gitlab.torproject.org:tpo/applications/mullvad-browser-update-responses.git` + - [ ] `tor-browser-build/tools/signing/set-config.tbb-version` + - `tbb_version` : mullvad browser version string, same as `var/torbrowser_version` in `rbm.conf` (examples: `11.5a12`, `11.0.13`) + - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) + - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, run the macOS proxy script: + - `cd tor-browser-build/tools/signing/` + - `./macos-signer-proxy` +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 +- [ ] run do-all-signing script: + - `cd tor-browser-build/tools/signing/` + - `./do-all-signing.mullvadbrowser` +- **NOTE**: at this point the signed binaries should have been copied to `staticiforme` +- [ ] Update `staticiforme.torproject.org`: + - From `screen` session on `staticiforme.torproject.org`: + - [ ] Static update components : `static-update-component dist.torproject.org` + - [ ] Remove old release data from `/srv/dist-master.torproject.org/htdocs/mullvadbrowser` + - [ ] Static update components (again) : `static-update-component dist.torproject.org` + +</details> + +<details> + <summary>Publishing</summary> + +### email + +- [ ] Email Mullvad with release information: support(a)mullvad.net, rui(a)mullvad.net + <details> + <summary>email template</summary> + + Subject: + New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (signed) + + Body: + signed builds: https://dist.torproject.org/mullvadbrowser/$(MULLVAD_BROWSER_VERSION) + + update_response hashes: $(MULLVAD_UPDATE_RESPONSES_HASH) + + changelog: + ... + + </details> + +### mullvad-browser (github): https://github.com/mullvad/mullvad-browser/ +- [ ] Push this release's associated `mullvad-browser.git` branch to github +- [ ] Push this release's associated tags to github: + - [ ] Firefox ESR tag + - **example** : `FIREFOX_102_12_0esr_BUILD1,` + - [ ] `base-browser` tag + - **example** : `base-browser-102.12.0esr-12.0-1-build1` + - [ ] `mullvad-browser` tag + - **example** : `mullvad-browser-102.12.0esr-12.0-1-build1` +- [ ] Sign+Tag additionally the `mullvad-browser.git` `firefox` commit used in build: + - **Tag**: `$(MULLVAD_BROWSER_VERSION)` + - **example** : `12.5a7` + - **Message**: `$(ESR_VERSION)esr-based $(MULLVAD_BROWSER_VERSION)` + - **example** : `102.12.0esr-based 12.5a7` + - [ ] Push tag to github + +</details> + +<details> + <summary>Downstream</summary> + +### notify packagers + +- [ ] **(Optional, Once Mullvad Updates their Github Releases Page)** Email downstream consumers: + <details> + <summary>email template</summary> + + ... + + ... + + </details> + + - **NOTE**: This is an optional step and only necessary close a major release/transition from alpha to stable, or if there are major packing changes these developers need to be aware of + - [ ] flathub package maintainer: proletarius101(a)protonmail.com + - [ ] arch package maintainer: bootctl(a)gmail.com + - [ ] nixOS package maintainer: dev(a)felschr.com + +</details> + +/label ~"Release Prep" ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Stable.md ===================================== @@ -2,32 +2,36 @@ <summary>Explanation of variables</summary> - `$(BUILD_SERVER)` : the server the main builder is using to build a mullvad-browser release +- `$(BUILDER)` : whomever is building the release on the $(BUILD_SERVER) + - **example** : `pierov` - `$(STAGING_SERVER)` : the server the signer is using to to run the signing process - `$(ESR_VERSION)` : the Mozilla defined ESR version, used in various places for building mullvad-browser tags, labels, etc - - example : `91.6.0` + - **example** : `91.6.0` - `$(MULLVAD_BROWSER_MAJOR)` : the Mullvad Browser major version - - example : `11` + - **example** : `11` - `$(MULLVAD_BROWSER_MINOR)` : the Mullvad Browser minor version - - example : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` + - **example** : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` - `$(MULLVAD_BROWSER_VERSION)` : the Mullvad Browser version in the format - - example: `12.5a3`, `12.0.3` + - **example** : `12.5a3`, `12.0.3` - `$(BUILD_N)` : a project's build revision within a its branch; this is separate from the `$(MULLVAD_BROWSER_BUILD_N)` value; many of the Firefox-related projects have a `$(BUILD_N)` suffix and may differ between projects even when they contribute to the same build. - - example : `build1` + - **example** : `build1` - `$(MULLVAD_BROWSER_BUILD_N)` : the mullvad-browser build revision for a given Mullvad Browser release; used in tagging git commits - - example : `build2` - - **NOTE** : A project's `$(BUILD_N)` and `$(MULLVAD_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For example : - - if we have multiple Mullvad Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(MULLVAD_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(MULLVAD_BROWSER_VERSION)` will increase) - - if we have build failures unrelated to `mullvad-browser`, the `$(MULLVAD_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. + - **example** : `build2` + - **NOTE** : A project's `$(BUILD_N)` and `$(MULLVAD_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For **example** : + - if we have multiple Mullvad Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(MULLVAD_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(MULLVAD_BROWSER_VERSION)` will increase) + - if we have build failures unrelated to `mullvad-browser`, the `$(MULLVAD_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. - `$(MULLVAD_BROWSER_VERSION)` : the published Mullvad Browser version - - example : `11.5a6`, `11.0.7` + - **example** : `11.5a6`, `11.0.7` +- `$(MB_BUILD_TAG)` : the `tor-browser-build` build tag used to build a given Mullvad Browser version + - **example** : `mb-12.0.7-build1` </details> -**NOTE** It is assumed that the `tor-browser` rebase and security backport tasks have been completed +**NOTE** It is assumed that the `tor-browser` stable rebase and security backport tasks have been completed <details> - <summary>Build Configs</summary> + <summary>Building</summary> -### tor-browser-build: https://gitlab.mullvadproject.org/tpo/applications/tor-browser-build.git +### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MULLVAD_BROWSER_MINOR)` (and possibly more specific) branches - [ ] Update `rbm.conf` @@ -57,30 +61,55 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - [ ] `URL` - [ ] `sha256sum` - [ ] Open MR with above changes -- [ ] Begin build on `$(BUILD_SERVER)` (and fix any issues which come up and update MR) - [ ] Merge - [ ] Sign/Tag commit: `make mullvadbrowser-signtag-release` - [ ] Push tag to `origin` +- [ ] Begin build on `$(BUILD_SERVER)` (fix any issues in subsequent MRs) +- [ ] **TODO** Submit build-tag to Mullvad build infra +- [ ] Ensure builders have matching builds + +</details> + +<details> + <summary>QA</summary> + +### send the build + + - [ ] Email Mullvad QA: support(a)mullvad.net, rui(a)mullvad.net + <details> + <summary>email template</summary> + + Subject: + New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (unsigned) + + Body: + unsigned builds: https://tb-build-05.torproject.org/~$(BUILDER)/builds/mullvadbrowser/releas… + + changelog: + ... + + </details> + + - ***(Optional)*** Add additional information: + - [ ] Note any new functionality which needs testing + - [ ] Link to any known issues </details> <details> <summary>Signing</summary> -### signing + publishing -- [ ] Ensure builders have matching builds +### signing - [ ] On `$(STAGING_SERVER)`, ensure updated: - - [ ] `tor-browser-build/tools/signing/set-config` - - `NSS_DB_DIR` : location of the `nssdb7` direcmullvady - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` direcmullvady) + - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) - `ssh_host_linux_signer` : ssh hostname of linux signing machine - `ssh_host_macos_signer` : ssh hostname of macOS signing machine - [ ] `tor-browser-build/tools/signing/set-config.macos-notarization` - `macos_notarization_user` : the email login for a mullvad notariser Apple Developer account - [ ] `set-config.update-responses` - - `update_responses_reposimullvady_dir` : direcmullvady where you cloned `git@gitlab.mullvadproject.org:tpo/applications/mullvad-browser-update-responses.git` + - `update_responses_repository_dir` : directory where you cloned `git@gitlab.torproject.org:tpo/applications/mullvad-browser-update-responses.git` - [ ] `tor-browser-build/tools/signing/set-config.tbb-version` - `tbb_version` : mullvad browser version string, same as `var/torbrowser_version` in `rbm.conf` (examples: `11.5a12`, `11.0.13`) - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) @@ -91,7 +120,7 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 - [ ] run do-all-signing script: - `cd tor-browser-build/tools/signing/` - - `./do-all-signing.sh` + - `./do-all-signing.mullvadbrowser` - **NOTE**: at this point the signed binaries should have been copied to `staticiforme` - [ ] Update `staticiforme.torproject.org`: - From `screen` session on `staticiforme.torproject.org`: @@ -101,19 +130,64 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU </details> +<details> + <summary>Publishing</summary> + +### email + +- [ ] Email Mullvad with release information: support(a)mullvad.net, rui(a)mullvad.net + <details> + <summary>email template</summary> + + Subject: + New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (signed) + + Body: + signed builds: https://dist.torproject.org/mullvadbrowser/$(MULLVAD_BROWSER_VERSION) + + update_response hashes: $(MULLVAD_UPDATE_RESPONSES_HASH) + + changelog: + ... + + </details> + +### mullvad-browser (github): https://github.com/mullvad/mullvad-browser/ +- [ ] Push this release's associated `mullvad-browser.git` branch to github +- [ ] Push this release's associated tags to github: + - [ ] Firefox ESR tag + - **example** : `FIREFOX_102_12_0esr_BUILD1,` + - [ ] `base-browser` tag + - **example** : `base-browser-102.12.0esr-12.0-1-build1` + - [ ] `mullvad-browser` tag + - **example** : `mullvad-browser-102.12.0esr-12.0-1-build1` +- [ ] Sign+Tag additionally the `mullvad-browser.git` `firefox` commit used in build: + - **Tag**: `$(MULLVAD_BROWSER_VERSION)` + - **example** : `12.0.7` + - **Message**: `$(ESR_VERSION)esr-based $(MULLVAD_BROWSER_VERSION)` + - **example** : `102.12.0esr-based 12.0.7` + - [ ] Push tag to github + +</details> + <details> <summary>Downstream</summary> -### notify stakeholders +### notify packagers + +- [ ] **(Once Mullvad Updates their Github Releases Page)** Email downstream consumers: + <details> + <summary>email template</summary> + + ... + + ... + + </details> -- [ ] Email Mullvad with release information: rui(a)mullvad.net - - [ ] Build artifact download list - - [ ] New `mullvad-browser` project branch and tags - - [ ] mullvad-browser-update-responses git hash - - [ ] changelog -- [ ] Email downstream consumers: - [ ] flathub package maintainer: proletarius101(a)protonmail.com - [ ] arch package maintainer: bootctl(a)gmail.com + - [ ] nixOS package maintainer: dev(a)felschr.com ### merge requests ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -2,28 +2,34 @@ <summary>Explanation of variables</summary> - `$(BUILD_SERVER)` : the server the main builder is using to build a tor-browser release +- `$(BUILDER)` : whomever is building the release on the $(BUILD_SERVER) + - **example** : `pierov` - `$(STAGING_SERVER)` : the server the signer is using to to run the signing process - `$(ESR_VERSION)` : the Mozilla defined ESR version, used in various places for building tor-browser tags, labels, etc - - example : `91.6.0` + - **example** : `91.6.0` - `$(TOR_BROWSER_MAJOR)` : the Tor Browser major version - - example : `11` + - **example** : `11` - `$(TOR_BROWSER_MINOR)` : the Tor Browser minor version - - example : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` + - **example** : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` +- `$(TOR_BROWSER_VERSION)` : the Tor Browser version in the format + - **example** : `12.5a3`, `12.0.3` - `$(BUILD_N)` : a project's build revision within a its branch; this is separate from the `$(TOR_BROWSER_BUILD_N)` value; many of the Firefox-related projects have a `$(BUILD_N)` suffix and may differ between projects even when they contribute to the same build. - - example : `build1` + - **example** : `build1` - `$(TOR_BROWSER_BUILD_N)` : the tor-browser build revision for a given Tor Browser release; used in tagging git commits - - example : `build2` - - **NOTE** : A project's `$(BUILD_N)` and `$(TOR_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For example : - - if we have multiple Tor Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(TOR_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(TOR_BROWSER_VERSION)` will increase) - - if we have build failures unrelated to `tor-browser`, the `$(TOR_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. + - **example** : `build2` + - **NOTE** : A project's `$(BUILD_N)` and `$(TOR_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For example : + - if we have multiple Tor Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(TOR_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(TOR_BROWSER_VERSION)` will increase) + - if we have build failures unrelated to `tor-browser`, the `$(TOR_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. - `$(TOR_BROWSER_VERSION)` : the published Tor Browser version - - example : `11.5a6`, `11.0.7` + - **example** : `11.5a6`, `11.0.7` +- `$(TBB_BUILD_TAG)` : the `tor-browser-build` build tag used to build a given Tor Browser version + - **example** : `tbb-12.5a7-build1` </details> -**NOTE** It is assumed that the `tor-browser` rebase and security backport tasks have been completed +**NOTE** It is assumed that the `tor-browser` stable rebase and security backport tasks have been completed <details> - <summary>Build Updates</summary> + <summary>Building</summary> ### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git Tor Browser Alpha (and Nightly) are on the `main` branch @@ -44,7 +50,7 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch - [ ] Update Android-specific build configs - - [ ] ***(Optional)*** Update `projects/geckoview/config` + - [ ] Update `projects/geckoview/config` - [ ] `browser_build` : update to match `tor-browser` tag - [ ] ***(Optional)*** `var/geckoview_version` : update to latest `$(ESR_VERSION)` if rebased - [ ] ***(Optional)*** Update `projects/tor-android-service/config` @@ -56,7 +62,6 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] `android_components_build` : update to match alpha android-components tag - [ ] ***(Optional)*** Update `projects/fenix/config` - [ ] `fenix_build` : update to match fenix tag - - [ ] ***(Optional)*** `var/fenix_version` : update to latest `$(ESR_VERSION)` if rebased - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - [ ] Update common build configs @@ -79,14 +84,13 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] ***(Optional)*** Update `projects/go/config` - [ ] `version` : update go version - [ ] `input_files/sha256sum` for `go` : update sha256sum of archive (sha256 sums are displayed on the go download page) - - [ ] Update the manual : https://gitlab.torproject.org/tpo/web/manual/-/jobs/ - - [ ] Download the `artifacts.zip` file from latest build stage row (download icon button on the right) - - [ ] Rename it to `manual_$PIPELINEID.zip` - - [ ] Upload it to people.tpo - - [ ] Update `projects/manual/config` - - [ ] Change the version to `$PIPELINEID` - - [ ] Update the hash in the input_files section - - [ ] Update the URL if you have uploaded to a different people.tpo home + - [ ] Check for manual updates by running (from `tor-browser-build` root): `./tools/fetch-manual.py` + - [ ] ***(Optional)*** If new version is available: + - [ ] Upload the downloaded `manual_$PIPELINEID.zip` file to people.tpo + - [ ] Update `projects/manual/config`: + - [ ] Change the `version` to `$PIPELINEID` + - [ ] Update `sha256sum` in the `input_files` section + - [ ] ***(Optional)*** Update the URL if you have uploaded to a different people.tpo home - [ ] Update `ChangeLog.txt` - [ ] Ensure ChangeLog.txt is sync'd between alpha and stable branches - [ ] Check the linked issues: ask people to check if any are missing, remove the not fixed ones @@ -94,19 +98,26 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - Make sure you have `requests` installed (e.g., `apt install python3-requests`) - The first time you run this script you will need to generate an access token; the script will guide you - [ ] Copy the output of the script to the beginning of `ChangeLog.txt` and adjust its output - - If you used the issue number, you will need to write the Tor Browser version manually - - [ ] Include any version updates for: - - [ ] translations - - [ ] OpenSSL - - [ ] NoScript + - **NOTE** : If you used the issue number, you will need to write the Tor Browser version manually + - [ ] ***(Optional)*** Under `All Platforms` include any version updates for: + - [ ] Translations + - [ ]OpenSSL + - [ ]NoScript + - [ ]zlib + - [ ] tor daemon + - [ ] ***(Optional)*** Under `Windows + macOS + Linux` include updates for: + - [ ] Firefox + - [ ] ***(Optional)*** Under `Android`, include updates for: + - [ ] Geckoview + - [ ] ***(Optional)*** Under `Build System/All Platforms` include updates for: - [ ] Go - - [ ] zlib - - [ ] Include any ESR rebase for Firefox and GeckoView - [ ] Open MR with above changes -- [ ] Begin build on `$(BUILD_SERVER)` (fix any issues which come up and update MR) - [ ] Merge - [ ] Sign/Tag commit: `make torbrowser-signtag-alpha` - [ ] Push tag to `origin` +- [ ] Begin build on `$(BUILD_SERVER)` (fix any issues in subsequent MRs) +- [ ] **TODO** Submit build-tag to Mullvad build infra +- [ ] Ensure builders have matching builds </details> @@ -118,6 +129,10 @@ Tor Browser Alpha (and Nightly) are on the `main` branch <details> <summary>email template</summary> + Subject: + Tor Browser $(TOR_BROWSER_VERION) (Android, Windows, macOS, Linux) + + Body: Hello All, Unsigned Tor Browser $(TOR_BROWSER_VERSION) alpha candidate builds are now available for testing: @@ -126,15 +141,15 @@ Tor Browser Alpha (and Nightly) are on the `main` branch The full changelog can be found here: - - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/main… + - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/$(T… </details> - [ ] Email tor-qa mailing list: tor-qa(a)lists.torproject.org - - Additional information: + - ***(Optional)*** Additional information: - [ ] Note any new functionality which needs testing - [ ] Link to any known issues -- [ ] ***(Optional, only around build/packaging changes)*** Email downstream consumers: +- [ ] ***(Optional, only around build/packaging changes)*** Email packagers: - Recipients: - Tails dev mailing list: tails-dev(a)boum.org - Guardian Project: nathan(a)guardianproject.info @@ -142,7 +157,7 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - FreeBSD port: freebsd(a)sysctl.cz  - OpenBSD port: caspar(a)schutijser.com  - [ ] Note any changes which may affect packaging/downstream integration -- [ ] Email upstream stakeholders: +- [ ] Email external partners: - ***(Optional, after ESR migration)*** Cloudflare: ask-research(a)cloudflare.com - **NOTE** : We need to provide them with updated user agent string so they can update their internal machinery to prevent Tor Browser users from getting so many CAPTCHAs @@ -151,11 +166,9 @@ Tor Browser Alpha (and Nightly) are on the `main` branch <details> <summary>Signing</summary> -### signing + publishing -- [ ] Ensure builders have matching builds +### signing +- **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long - [ ] On `$(STAGING_SERVER)`, ensure updated: - - [ ] `tor-browser-build/tools/signing/set-config` - - `NSS_DB_DIR` : location of the `nssdb7` directory - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) @@ -182,7 +195,7 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] Static update components : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` - [ ] Enable update responses : `sudo -u tb-release ./deploy_update_responses-alpha.sh` - [ ] Remove old release data from following places: - - **NOTE** : Skip this step if the current release is Android or Desktop *only* + - **NOTE** : Skip this step if we need to hold on to older versions for some reason (for example, this is an Andoid or Desktop-only release, or if we need to hold back installers in favor of build-to-build updates if there are signing issues, etc) - [ ] `/srv/cdn-master.torproject.org/htdocs/aus1/torbrowser` - [ ] `/srv/dist-master.torproject.org/htdocs/torbrowser` - [ ] Static update components (again) : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` @@ -236,7 +249,24 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] Publish after CI passes and website has been updated ### tor-announce mailing list -- [ ] Send an email to tor-announce(a)lists.torproject.org, using the same content as the blog post and subject "Tor Browser $version is released". + <details> + <summary>email template</summary> + + Subject: + New Release: Tor Browser $(TOR_BROWSER_VERSION) (Android, Windows, macOS, Linux) + + Body: + Hi everyone, + + Tor Browser $(TOR_BROWSER_VERSION) has now been published for all platforms. For details please see our blog post: + + - $(BLOG_POST_URL) + + </details> + +- [ ] Email tor-announce mailing list: tor-announce(a)lists.torproject.org + - **(Optional)** Additional information: + - [ ] Link to any known issues </details> ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -2,33 +2,34 @@ <summary>Explanation of variables</summary> - `$(BUILD_SERVER)` : the server the main builder is using to build a tor-browser release +- `$(BUILDER)` : whomever is building the release on the $(BUILD_SERVER) + - **example** : `pierov` - `$(STAGING_SERVER)` : the server the signer is using to to run the signing process - `$(ESR_VERSION)` : the Mozilla defined ESR version, used in various places for building tor-browser tags, labels, etc - - example : `91.6.0` -- `$(ESR_TAG)` : the Mozilla defined hg (Mercurial) tag associated with `$(ESR_VERSION)` - - exmaple : `FIREFOX_91_7_0esr_BUILD2` -- `$(ESR_TAG_PREV)` : the Mozilla defined hg (Mercurial) tag associated with the previous ESR version when rebasing (ie, the ESR version we are rebasing from) + - **example** : `91.6.0` - `$(TOR_BROWSER_MAJOR)` : the Tor Browser major version - - example : `11` + - **example** : `11` - `$(TOR_BROWSER_MINOR)` : the Tor Browser minor version - - example : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` + - **example** : either `0` or `5`; Alpha's is always `(Stable + 5) % 10` - `$(TOR_BROWSER_VERSION)` : the Tor Browser version in the format - - example: `12.5a3`, `12.0.3` + - **example** : `12.5a3`, `12.0.3` - `$(BUILD_N)` : a project's build revision within a its branch; this is separate from the `$(TOR_BROWSER_BUILD_N)` value; many of the Firefox-related projects have a `$(BUILD_N)` suffix and may differ between projects even when they contribute to the same build. - - example : `build1` + - **example** : `build1` - `$(TOR_BROWSER_BUILD_N)` : the tor-browser build revision for a given Tor Browser release; used in tagging git commits - - example : `build2` - - **NOTE** : A project's `$(BUILD_N)` and `$(TOR_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For example : - - if we have multiple Tor Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(TOR_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(TOR_BROWSER_VERSION)` will increase) - - if we have build failures unrelated to `tor-browser`, the `$(TOR_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. + - **example** : `build2` + - **NOTE** : A project's `$(BUILD_N)` and `$(TOR_BROWSER_BUILD_N)` may be the same, but it is possible for them to diverge. For example : + - if we have multiple Tor Browser releases on a given ESR branch the two will become out of sync as the `$(BUILD_N)` value will increase, while the `$(TOR_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(TOR_BROWSER_VERSION)` will increase) + - if we have build failures unrelated to `tor-browser`, the `$(TOR_BROWSER_BUILD_N)` value will increase while the `$(BUILD_N)` will stay the same. - `$(TOR_BROWSER_VERSION)` : the published Tor Browser version - - example : `11.5a6`, `11.0.7` + - **example** : `11.5a6`, `11.0.7` +- `$(TBB_BUILD_TAG)` : the `tor-browser-build` build tag used to build a given Tor Browser version + - **example** : `tbb-12.0.7-build1` </details> -**NOTE** It is assumed that the `tor-browser` rebase and security backport tasks have been completed +**NOTE** It is assumed that the `tor-browser` stable rebase and security backport tasks have been completed <details> - <summary>Build Configs</summary> + <summary>Building</summary> ### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)` (and possibly more specific) branches @@ -37,7 +38,7 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] `var/torbrowser_version` : update to next version - [ ] `var/torbrowser_build` : update to `$(TOR_BROWSER_BUILD_N)` - [ ] ***(Desktop Only)***`var/torbrowser_incremental_from` : update to previous Desktop version - - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make incrementals-*` step will fail + - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make torbrowser-incrementals-*` step will fail - [ ] Update Desktop-specific build configs - [ ] Update `projects/firefox/config` - [ ] `browser_build` : update to match `tor-browser` tag @@ -49,7 +50,7 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch - [ ] Update Android-specific build configs - - [ ] ***(Optional)*** Update `projects/geckoview/config` + - [ ] Update `projects/geckoview/config` - [ ] `browser_build` : update to match `tor-browser` tag - [ ] ***(Optional)*** `var/geckoview_version` : update to latest `$(ESR_VERSION)` if rebased - [ ] ***(Optional)*** Update `projects/tor-android-service/config` @@ -58,10 +59,9 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE **NOTE** we don't currently have any of our own patches for this project - [ ] `git_hash` : update to appropriate git commit associated with `$(ESR_VERSION)` - [ ] ***(Optional)*** Update `projects/android-components/config`: - - [ ] `android_components_build` : update to match android-components tag + - [ ] `android_components_build` : update to match stable android-components tag - [ ] ***(Optional)*** Update `projects/fenix/config` - [ ] `fenix_build` : update to match fenix tag - - [ ] ***(Optional)*** `var/fenix_version` : update to latest `$(ESR_VERSION)` if rebased - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - [ ] Update common build configs @@ -84,14 +84,13 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] ***(Optional)*** Update `projects/go/config` - [ ] `version` : update go version - [ ] `input_files/sha256sum` for `go` : update sha256sum of archive (sha256 sums are displayed on the go download page) - - [ ] Update the manual : https://gitlab.torproject.org/tpo/web/manual/-/jobs/ - - [ ] Download the `artifacts.zip` file from latest build stage row (download icon button on the right) - - [ ] Rename it to `manual_$PIPELINEID.zip` - - [ ] Upload it to people.tpo - - [ ] Update `projects/manual/config` - - [ ] Change the version to `$PIPELINEID` - - [ ] Update the hash in the input_files section - - [ ] Update the URL if you have uploaded to a different people.tpo home + - [ ] Check for manual updates by running (from `tor-browser-build` root): `./tools/fetch-manual.py` + - [ ] ***(Optional)*** If new version is available: + - [ ] Upload the downloaded `manual_$PIPELINEID.zip` file to people.tpo + - [ ] Update `projects/manual/config`: + - [ ] Change the `version` to `$PIPELINEID` + - [ ] Update `sha256sum` in the `input_files` section + - [ ] ***(Optional)*** Update the URL if you have uploaded to a different people.tpo home - [ ] Update `ChangeLog.txt` - [ ] Ensure ChangeLog.txt is sync'd between alpha and stable branches - [ ] Check the linked issues: ask people to check if any are missing, remove the not fixed ones @@ -99,19 +98,26 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - Make sure you have `requests` installed (e.g., `apt install python3-requests`) - The first time you run this script you will need to generate an access token; the script will guide you - [ ] Copy the output of the script to the beginning of `ChangeLog.txt` and adjust its output - - If you used the issue number, you will need to write the Tor Browser version manually - - [ ] Include any version updates for: - - [ ] translations - - [ ] OpenSSL - - [ ] NoScript + - **NOTE** : If you used the issue number, you will need to write the Tor Browser version manually + - [ ] ***(Optional)*** Under `All Platforms` include any version updates for: + - [ ] Translations + - [ ]OpenSSL + - [ ]NoScript + - [ ]zlib + - [ ] tor daemon + - [ ] ***(Optional)*** Under `Windows + macOS + Linux` include updates for: + - [ ] Firefox + - [ ] ***(Optional)*** Under `Android`, include updates for: + - [ ] Geckoview + - [ ] ***(Optional)*** Under `Build System/All Platforms` include updates for: - [ ] Go - - [ ] zlib - - [ ] Include any ESR rebase for Firefox and GeckoView - [ ] Open MR with above changes -- [ ] Begin build on `$(BUILD_SERVER)` (and fix any issues which come up and update MR) - [ ] Merge - [ ] Sign/Tag commit: `make torbrowser-signtag-release` - [ ] Push tag to `origin` +- [ ] Begin build on `$(BUILD_SERVER)` (fix any issues in subsequent MRs) +- [ ] **TODO** Submit build-tag to Mullvad build infra +- [ ] Ensure builders have matching builds </details> @@ -123,6 +129,10 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE <details> <summary>email template</summary> + Subject: + Tor Browser $(TOR_BROWSER_VERION) (Android, Windows, macOS, Linux) + + Body: Hello All, Unsigned Tor Browser $(TOR_BROWSER_VERSION) release candidate builds are now available for testing: @@ -131,36 +141,31 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE The full changelog can be found here: - - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/main… + - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/$(T… </details> - [ ] Email tor-qa mailing list: tor-qa(a)lists.torproject.org - - Additional information: + - ***(Optional)*** Additional information: - [ ] Note any new functionality which needs testing - [ ] Link to any known issues -- [ ] Email downstream consumers: +- [ ] Email packagers: - Recipients: - Tails dev mailing list: tails-dev(a)boum.org - Guardian Project: nathan(a)guardianproject.info - torbrowser-launcher: micah(a)micahflee.com - FreeBSD port: freebsd(a)sysctl.cz  - OpenBSD port: caspar(a)schutijser.com  - - [ ] Note any changes which may affect packaging/downstream integration -- [ ] Email upstream stakeholders: - - ***(Optional, after ESR migration)*** Cloudflare: ask-research(a)cloudflare.com - - **NOTE** : We need to provide them with updated user agent string so they can update their internal machinery to prevent Tor Browser users from getting so many CAPTCHAs + - [ ] ***(Optional)*** Note any changes which may affect packaging/downstream integration </details> <details> <summary>Signing</summary> -### signing + publishing -- [ ] Ensure builders have matching builds +### signing +- **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long - [ ] On `$(STAGING_SERVER)`, ensure updated: - - [ ] `tor-browser-build/tools/signing/set-config` - - `NSS_DB_DIR` : location of the `nssdb7` directory - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) @@ -180,14 +185,14 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 - [ ] run do-all-signing script: - `cd tor-browser-build/tools/signing/` - - `./do-all-signing.sh` + - `./do-all-signing.torbrowser` - **NOTE**: at this point the signed binaries should have been copied to `staticiforme` - [ ] Update `staticiforme.torproject.org`: - From `screen` session on `staticiforme.torproject.org`: - [ ] Static update components : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` - [ ] Enable update responses : `sudo -u tb-release ./deploy_update_responses-release.sh` - [ ] Remove old release data from following places: - - **NOTE** : Skip this step if the current release is Android or Desktop *only* + - **NOTE** : Skip this step if we need to hold on to older versions for some reason (for example, this is an Andoid or Desktop-only release, or if we need to hold back installers in favor of build-to-build updates if there are signing issues, etc) - [ ] `/srv/cdn-master.torproject.org/htdocs/aus1/torbrowser` - [ ] `/srv/dist-master.torproject.org/htdocs/torbrowser` - [ ] Static update components (again) : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` @@ -241,7 +246,24 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] Publish after CI passes and website has been updated ### tor-announce mailing list -- [ ] Send an email to tor-announce(a)lists.torproject.org, using the same content as the blog post and subject "Tor Browser $version is released". + <details> + <summary>email template</summary> + + Subject: + New Release: Tor Browser $(TOR_BROWSER_VERSION) (Android, Windows, macOS, Linux) + + Body: + Hi everyone, + + Tor Browser $(TOR_BROWSER_VERSION) has now been published for all platforms. For details please see our blog post: + + - $(BLOG_POST_URL) + + </details> + +- [ ] Email tor-announce mailing list: tor-announce(a)lists.torproject.org + - **(Optional)** Additional information: + - [ ] Link to any known issues </details> ===================================== .gitlab/merge_request_templates/default.md ===================================== @@ -2,20 +2,52 @@  -- ### Related Issues - - tor-browser#xxxxx - - tor-browser-build#xxxxx - - etc +### Related Issues +- tor-browser#xxxxx +- mullvad-browser#xxxxx +- tor-browser-build#xxxxx -- ### Backport Timeline - - [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build) - - [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport - - [ ] **Eventually** - patchset that needs to be verified in alpha before backport - - [ ] **No Backport** - patchset for the next major stable +### Backporting -- ### Issue Tracking - - [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation +#### Timeline +- [ ] **Immediate**: patchset needed as soon as possible +- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport +- [ ] **Eventually**: patchset that needs to be verified in alpha before backport +- [ ] **No Backport (preferred)**: patchset for the next major stable -## Change Description +#### (Optional) Justification +- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc +- [ ] **Censorship event**: patchset enables censorship circumvention +- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality +- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc +- [ ] **Sponsor required**: patchset required for sponsor +- [ ] **Other**: please explain - \ No newline at end of file +### Issue Tracking +- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation + +### Review + +#### Request Reviewer + +- [ ] Request review from an applications developer depending on modified system: + - **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer) + - **accessibility** : henry + - **android** : dan + - **build system** : boklm + - **extensions** : ma1 + - **firefox internals (XUL/JS/XPCOM)** : ma1 + - **fonts** : pierov + - **frontend (implementation)** : henry + - **frontend (review)** : donuts, richard + - **localization** : henry, pierov + - **nightly builds** : boklm + - **rebases/release-prep** : dan_b, ma1, pierov, richard + - **security** : ma1 + - **signing** : boklm, richard + - **updater** : pierov + - **misc/other** : pierov, richard + +#### Change Description + + View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0