<div dir="ltr">Hi George,<div><br></div><div>I think it looks good. Only comment I have is that it would be nice to have an option to change the ipv6 subset, though I imagine people who would use it can easily recompile with their own setting.</div><div><br></div><div>I'm also including Gabbi who is working on this now.</div><div><br></div><div>Best,</div><div>Mahrud</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Sep 15, 2018 at 10:07 AM George Kadianakis <<a href="mailto:desnacked@riseup.net">desnacked@riseup.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mahrud S <<a href="mailto:dinovirus@gmail.com" target="_blank">dinovirus@gmail.com</a>> writes:<br>
<br>
> Hi George,<br>
><br>
> I was trying to find a way to use the virtual port (i.e.<br>
> blahblah.onion:*port*) as dst_port, but I couldn't find a suitable in time.<br>
> For our purposes specifically, we only needed virtual port 443 for https,<br>
> so I hard-coded 443 in an almost identical branch on top of<br>
> 0.3.5.0-alpha-dev here:<br>
> <a href="https://github.com/mahrud/tor/commit/a81eac6d0c0a35adc6036e736565f4a8e2f806fd" rel="noreferrer" target="_blank">https://github.com/mahrud/tor/commit/a81eac6d0c0a35adc6036e736565f4a8e2f806fd</a><br>
><br>
> As far as I know we haven't run into any issues so I kept it minimal, but<br>
> the torrc option would be very much appreciated!<br>
><br>
<br>
Hey Mahrud,<br>
<br>
we have a ready-to-merge version of #4700 ready.<br>
<br>
Check: <a href="https://github.com/torproject/tor/pull/343" rel="noreferrer" target="_blank">https://github.com/torproject/tor/pull/343</a><br>
for the latest PR.<br>
<br>
and <a href="https://trac.torproject.org/projects/tor/ticket/4700#comment:21" rel="noreferrer" target="_blank">https://trac.torproject.org/projects/tor/ticket/4700#comment:21</a><br>
    <a href="https://github.com/torproject/tor/pull/327" rel="noreferrer" target="_blank">https://github.com/torproject/tor/pull/327</a> (the old PR)<br>
if you want to read the review comments and bugs.<br>
<br>
Let us know if you have any questions or if you don't like something.<br>
<br>
Thanks! :)<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">mahrud <<a href="http://algorithms.jux-foundation.org/~mahrud/blog" target="_blank">algorithms.jux-foundation.org/~mahrud/blog</a>><br></div></div>