<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!--P{margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>This is a bit outside of my area but shouldn't VS2013 Express support C99? That is available for free.</p>
<p> Yaron</p>
<p><br>
</p>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> tor-dev <tor-dev-bounces@lists.torproject.org> on behalf of Владимир Мартьянов <vilgeforce@gmail.com><br>
<b>Sent:</b> Thursday, October 16, 2014 11:33 AM<br>
<b>To:</b> tor-dev@lists.torproject.org<br>
<b>Subject:</b> Re: [tor-dev] Building TOR using Visual Studio</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>As far as I know only Visual Studio 2013 has C99 support. Upgrade to VS2013 costs about 300$ for commercial versions, a lot of code was written in earlier versions...
<br>
</div>
By the way, I fixed only about 10 lines of code and finally I managed to build the TOR using VS2008, so i think it's not so hard to make the code suitable for VS2008. How can I show you my changes? Make a diff in git and attach to the message?<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2014-10-16 22:16 GMT+04:00 Nick Mathewson <span dir="ltr">
<<a href="mailto:nickm@freehaven.net" target="_blank">nickm@freehaven.net</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div class="HOEnZb">
<div class="h5">On Thu, Oct 16, 2014 at 7:40 AM, Владимир Мартьянов<br>
<<a href="mailto:vilgeforce@gmail.com">vilgeforce@gmail.com</a>> wrote:<br>
> Hi all! I'm new at this list :-)<br>
><br>
> I decided to understand how TOR works and I want to build it in VS to debug<br>
> it and explore it's internals. I have Visual Studio on my first PC and I got<br>
> errors during build on address.c. I investigated the reason: commit<br>
> 0ca83872468af59b94e14fe7fdfcb38cb5a3f496<br>
><br>
> I have Visual Studio express 2013 on my second PC and I didn't have any<br>
> problems building the TOR.<br>
><br>
> So I have two questions: did you decide not to support old Visual Studio<br>
> versions or it'll be better to build TOR in VS2008 too? If old versions<br>
> aren't supported, should it be some #error directives in sources to explain<br>
> this decision? It was really hard to understand where's the problem, so I<br>
> think #error will be very helpfull.<br>
><br>
> If you give me some instructions about the problem, I'll try to commit the<br>
> changes. Thank you.<br>
<br>
</div>
</div>
Hello, Vladimir!<br>
<br>
That's the commit where we decided that, since C99 is 15 years old<br>
now, it's probably okay for us to require a compiler to support it. I<br>
thought that I would get more feedback by breaking the master branch<br>
than by asking on a mailing list.<br>
<br>
I'd be happy to take a patch that added #error directives for<br>
compilers that don't have basic C99 support.<br>
<br>
But first, I'd like to ask you, and anyone else who sometimes uses<br>
compilers that don't support C99: Is it important for Tor that we keep<br>
supporting C89? Are there a lot of VS2008 users who can't upgrade?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Nick<br>
_______________________________________________<br>
tor-dev mailing list<br>
<a href="mailto:tor-dev@lists.torproject.org">tor-dev@lists.torproject.org</a><br>
<a href="https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev" target="_blank">https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev</a><br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</div>
</body>
</html>