<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 5/15/2014 9:38 AM,
<a class="moz-txt-link-abbreviated" href="mailto:michael@schloh.com">michael@schloh.com</a> wrote:<br>
</div>
<blockquote cite="mid:20140515163814.GH15593@elotro.europalab.com"
type="cite">
<pre wrap="">
Hello list,
If anybody's feeling particularly friendly, then it would be nice of
you to do the favour of reviewing the proposed solution to bug #9701:
<a class="moz-txt-link-freetext" href="https://trac.torproject.org/projects/tor/ticket/9701">https://trac.torproject.org/projects/tor/ticket/9701</a>
It relates to clipboard turds of the Tor Browser in violation of
the premise of disk avoidance by design. The code in question is
attached to the bug report.
Georg (GK) has signalled interest, in case you want to coordinate.
Thanks in advance!
Cheers,
Michael
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
tor-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:tor-dev@lists.torproject.org">tor-dev@lists.torproject.org</a>
<a class="moz-txt-link-freetext" href="https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev">https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev</a>
</pre>
</blockquote>
Hi Michael,<br>
<br>
I'm new to the tor-dev mailing list so I don't know what the proper
protocol is for this type of response. I have a couple of concerns
about this proposed change.<br>
<br>
1. Some versions of the SunOS--maybe Solaris too, I'm not sure--had
a provision where you could copy text without any explicit clip
board action. You could just select the text and middle click in the
destination. Will this change break that behavior or are these
systems still supported?<br>
<br>
2. My second concern is a style issue. If I read msvb-9701.diff
correctly, you propose to just comment out the offending code with a
preprocessor directive. I, along with others who are more
knowledgeable, think that this process is bad form. It tends to
leave the source code cluttered with a great deal of non-functioning
code. While it is worthwhile to preserve the history, that is what
source code control systems are for.<br>
<br>
Regards<br>
<br>
Ken Keys<br>
</body>
</html>