[tor-commits] [Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Modify UI/UX

Dan Ballard (@dan) git at gitlab.torproject.org
Thu Sep 28 16:42:31 UTC 2023



Dan Ballard pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android


Commits:
c5b1df66 by Dan Ballard at 2023-09-27T23:48:46-07:00
fixup! Modify UI/UX

Bug 42134: Remove Android icon shortcuts for new tab and logins/passwords

- - - - -


5 changed files:

- fenix/app/src/beta/res/xml/shortcuts.xml
- fenix/app/src/debug/res/xml/shortcuts.xml
- fenix/app/src/main/res/xml/shortcuts.xml
- fenix/app/src/nightly/res/xml/shortcuts.xml
- fenix/app/src/release/res/xml/shortcuts.xml


Changes:

=====================================
fenix/app/src/beta/res/xml/shortcuts.xml
=====================================
@@ -3,28 +3,28 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android">
-    <shortcut
-        android:shortcutId="password_manager"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_password_shortcut"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"
-            android:targetPackage="org.mozilla.firefox_beta"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
-    <shortcut
-        android:shortcutId="open_new_tab"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_shortcut_tab"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_TAB"
-            android:targetPackage="org.torproject.torbrowser_alpha"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
+<!--    <shortcut-->
+<!--        android:shortcutId="password_manager"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_password_shortcut"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"-->
+<!--            android:targetPackage="org.mozilla.firefox_beta"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
+<!--    <shortcut-->
+<!--        android:shortcutId="open_new_tab"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_shortcut_tab"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_TAB"-->
+<!--            android:targetPackage="org.torproject.torbrowser_alpha"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
     <shortcut
         android:shortcutId="open_new_private_tab"
         android:enabled="true"


=====================================
fenix/app/src/debug/res/xml/shortcuts.xml
=====================================
@@ -4,28 +4,28 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android">
-    <shortcut
-        android:shortcutId="password_manager"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_password_shortcut"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"
-            android:targetPackage="org.mozilla.fenix.debug"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
-    <shortcut
-        android:shortcutId="open_new_tab"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_shortcut_tab"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_TAB"
-            android:targetPackage="org.torproject.torbrowser_debug"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
+<!--    <shortcut-->
+<!--        android:shortcutId="password_manager"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_password_shortcut"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"-->
+<!--            android:targetPackage="org.mozilla.fenix.debug"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
+<!--    <shortcut-->
+<!--        android:shortcutId="open_new_tab"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_shortcut_tab"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_TAB"-->
+<!--            android:targetPackage="org.torproject.torbrowser_debug"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
     <shortcut
         android:shortcutId="open_new_private_tab"
         android:enabled="true"


=====================================
fenix/app/src/main/res/xml/shortcuts.xml
=====================================
@@ -4,28 +4,28 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android">
-    <shortcut
-        android:shortcutId="password_manager"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_password_shortcut"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"
-            android:targetPackage="org.mozilla.fenix"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
-    <shortcut
-        android:shortcutId="open_new_tab"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_shortcut_tab"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_TAB"
-            android:targetPackage="org.torproject.torbrowser_dev"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
+<!--    <shortcut-->
+<!--        android:shortcutId="password_manager"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_password_shortcut"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"-->
+<!--            android:targetPackage="org.mozilla.fenix"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
+<!--    <shortcut-->
+<!--        android:shortcutId="open_new_tab"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_shortcut_tab"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_TAB"-->
+<!--            android:targetPackage="org.torproject.torbrowser_dev"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
     <shortcut
         android:shortcutId="open_new_private_tab"
         android:enabled="true"


=====================================
fenix/app/src/nightly/res/xml/shortcuts.xml
=====================================
@@ -4,28 +4,28 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android">
-    <shortcut
-        android:shortcutId="password_manager"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_password_shortcut"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"
-            android:targetPackage="org.mozilla.fenix"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
-    <shortcut
-        android:shortcutId="open_new_tab"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_shortcut_tab"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_TAB"
-            android:targetPackage="org.torproject.torbrowser_nightly"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
+<!--    <shortcut-->
+<!--        android:shortcutId="password_manager"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_password_shortcut"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"-->
+<!--            android:targetPackage="org.mozilla.fenix"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
+<!--    <shortcut-->
+<!--        android:shortcutId="open_new_tab"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_shortcut_tab"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_TAB"-->
+<!--            android:targetPackage="org.torproject.torbrowser_nightly"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
     <shortcut
         android:shortcutId="open_new_private_tab"
         android:enabled="true"
@@ -37,4 +37,4 @@
             android:targetPackage="org.torproject.torbrowser_nightly"
             android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
     </shortcut>
-</shortcuts>
\ No newline at end of file
+</shortcuts>


=====================================
fenix/app/src/release/res/xml/shortcuts.xml
=====================================
@@ -3,28 +3,28 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android">
-    <shortcut
-        android:shortcutId="password_manager"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_password_shortcut"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"
-            android:targetPackage="org.mozilla.firefox"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
-    <shortcut
-        android:shortcutId="open_new_tab"
-        android:enabled="true"
-        android:icon="@drawable/ic_static_shortcut_tab"
-        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"
-        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">
-        <intent
-            android:action="org.mozilla.fenix.OPEN_TAB"
-            android:targetPackage="org.torproject.torbrowser"
-            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />
-    </shortcut>
+<!--    <shortcut-->
+<!--        android:shortcutId="password_manager"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_password_shortcut"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_password_screen"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_password_screen">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_PASSWORD_MANAGER"-->
+<!--            android:targetPackage="org.mozilla.firefox"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
+<!--    <shortcut-->
+<!--        android:shortcutId="open_new_tab"-->
+<!--        android:enabled="true"-->
+<!--        android:icon="@drawable/ic_static_shortcut_tab"-->
+<!--        android:shortcutShortLabel="@string/home_screen_shortcut_open_new_tab_2"-->
+<!--        android:shortcutLongLabel="@string/home_screen_shortcut_open_new_tab_2">-->
+<!--        <intent-->
+<!--            android:action="org.mozilla.fenix.OPEN_TAB"-->
+<!--            android:targetPackage="org.torproject.torbrowser"-->
+<!--            android:targetClass="org.mozilla.fenix.IntentReceiverActivity" />-->
+<!--    </shortcut>-->
     <shortcut
         android:shortcutId="open_new_private_tab"
         android:enabled="true"



View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/c5b1df66779781443472ce632735c0745a4dec79

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/c5b1df66779781443472ce632735c0745a4dec79
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20230928/beec9c64/attachment-0001.htm>


More information about the tor-commits mailing list