[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 158 commits: Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie

[richard (@richard)]

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser


Commits:
3824b254 by Eitan Isaacson at 2023-08-21T16:17:38+02:00
Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie

Differential Revision: https://phabricator.services.mozilla.com/D179737
- - - - -
9d39f4f4 by Pier Angelo Vendrame at 2023-08-21T16:17:39+02:00
Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized

Allow using NSS for checking MAR signatures also in platforms where
OS-native APIs are used by default, i.e., macOS and Windows.

Differential Revision: https://phabricator.services.mozilla.com/D177743
- - - - -
5becba54 by Henry Wilkes at 2023-08-21T16:17:39+02:00
Bug 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

- - - - -
a2ecb0c0 by Henry Wilkes at 2023-08-21T16:17:40+02:00
Bug 41483: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla bug 1790187

- - - - -
12b094e5 by Pier Angelo Vendrame at 2023-08-21T16:17:41+02:00
Bug 41116: Normalize system fonts.

System fonts are an enormous fingerprinting vector.
Even with font allow lists and with our custom configuration on Linux,
which counter metrics measurements, getComputedStyle leaks several
details.
This patch counters both these kinds of attacks.

- - - - -
04f4bc1a by Marco Simonelli at 2023-08-21T16:17:41+02:00
Bug 41459: WebRTC fails to build under mingw (Part 1)

- properly define NOMINMAX for just MSVC builds

- - - - -
12a8fa91 by Marco Simonelli at 2023-08-21T16:17:42+02:00
Bug 41459: WebRTC fails to build under mingw (Part 2)

- fixes required to build third_party/libwebrtc

- - - - -
f04576bf by Marco Simonelli at 2023-08-21T16:17:42+02:00
Bug 41459: WebRTC fails to build under mingw (Part 3)

- fixes required to build third_party/sipcc

- - - - -
5e2424f6 by Marco Simonelli at 2023-08-21T16:17:43+02:00
Bug 41459: WebRTC fails to build under mingw (Part 4)

- fixes requried to build netwerk/sctp

- - - - -
82bf2ff6 by Marco Simonelli at 2023-08-21T16:17:43+02:00
Bug 41459: WebRTC fails to build under mingw (Part 5)

- fixes required to build dom/media/webrtc

- - - - -
88549b16 by Marco Simonelli at 2023-08-21T16:17:44+02:00
Bug 41459: WebRTC fails to build under mingw (Part 6)

- fixes required to build dom/media/systemservices

- - - - -
cdecce6a by hackademix at 2023-08-21T16:17:44+02:00
Bug 41854: Allow overriding download spam protection.

- - - - -
9d7a9a79 by Pier Angelo Vendrame at 2023-08-21T16:17:45+02:00
Bug 42022: Prevent extension search engines from breaking the whole search system

We found that if an extension tries to add a search engine that is
already bundled the whole search system breaks because an exception is
thrown and it reaches the initialization function, whose catch undoes
the initialization.

With this commit, we handle this kind of exceptions when trying to
install the extension's engines, and contain it there.

- - - - -
fbb42625 by Gaba at 2023-08-21T16:17:45+02:00
Adding issue and merge request templates

- - - - -
bb1c95df by Pier Angelo Vendrame at 2023-08-21T16:17:46+02:00
Base Browser's .mozconfigs.

Bug 17858: Cannot create incremental MARs for hardened builds.
Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff
(which is part of mar-tools and is not distributed to end-users) with
ASan.

Bug 21849: Don't allow SSL key logging.

Bug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value.
Also see bug 27472 where we made a similar fix for Android.

Bug 29859: Disable HLS support for now

Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug 33734: Set MOZ_NORMANDY to False

Bug 33851: Omit Parental Controls.

Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

Bug 41584: Move some configuration options to base-browser level

- - - - -
59c5be4b by Pier Angelo Vendrame at 2023-08-21T16:17:46+02:00
Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment
disabled.
Mozilla does not use a similar configuration, but either runs a Firefox
build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a
better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with
./mach package-multi-locale to create multi-locale packages.
The required command isn't exposed through any other mach command.
So, we patch package-multi-locale both to prevent it from failing when
doing official builds and to detect any future changes on it.

- - - - -
e065393a by Pier Angelo Vendrame at 2023-08-21T16:17:47+02:00
Bug 41108: Remove privileged macOS installation from 102

- - - - -
56d5e92a by Dan Ballard at 2023-08-21T16:17:47+02:00
Bug 41149: Re-enable DLL injection protection in all builds not just nightlies

- - - - -
71bf453b by Matthew Finkel at 2023-08-21T16:17:48+02:00
Bug 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
manifest, so we can't use the ifdef preprocessor guards around the
permissions we do not want. Commenting the permissions is the
next-best-thing.

- - - - -
1870cb01 by Matthew Finkel at 2023-08-21T16:17:48+02:00
Bug 28125: Prevent non-Necko network connections

- - - - -
ac400423 by Mike Perry at 2023-08-21T16:17:49+02:00
Bug 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421,
https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

- - - - -
e84f6460 by Alex Catarineu at 2023-08-21T16:17:49+02:00
Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

- - - - -
ca6aef60 by Georg Koppen at 2023-08-21T16:17:50+02:00
Bug 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying
--disable-eme. But that changed and it is even bundled nowadays (see:
Mozilla's bug 1300654). We don't want to ship it right now as the use
case for it is not really visible while the code had security
vulnerabilities in the past.

- - - - -
f9159b20 by Kathy Brade at 2023-08-21T16:17:50+02:00
Bug 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

- - - - -
3c891fd9 by Kathy Brade at 2023-08-21T16:17:51+02:00
Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

- - - - -
5dec33d9 by Alex Catarineu at 2023-08-21T16:17:51+02:00
Bug 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

- - - - -
9b8a2aee by Kathy Brade at 2023-08-21T16:17:52+02:00
Bug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people
volunteer to participate in studies that collect detailed, sensitive data about
how they use their browser.

Bug 41662: Disable about:sync-logs

Even though we disable sync by default with
`identity.fxaccounts.enabled`, this about: page is still avilable.
We could throw an exception on the constructor of the related
component, but it would result only in an error in the console, without
a visible "this address does not look right" error page.
If we fix the issues with MOZ_SERVICES_SYNC, we can restore the
component.

- - - - -
93fba749 by Arthur Edelstein at 2023-08-21T16:17:52+02:00
Bug 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when
the user entered an https or http URL in the URL bar, or
typed a search term.

- - - - -
b6c2ab51 by Alex Catarineu at 2023-08-21T16:17:53+02:00
Bug 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and
url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for
'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For
the ones in the 'main' bucket, this prevents them from being synced
unnecessarily (the code in remote-settings does so for collections
in the main bucket for which a dump or local data exists). For the
collections in the other buckets, we just save some size by not
shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

- - - - -
322c5e59 by cypherpunks1 at 2023-08-21T16:17:53+02:00
Bug 41092: Add a RemoteSettings JSON dump for query-stripping

- - - - -
05be4e25 by Pier Angelo Vendrame at 2023-08-21T16:17:55+02:00
Bug 41635: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

- - - - -
51467cda by Georg Koppen at 2023-08-21T16:17:55+02:00
Bug 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

- - - - -
052190a7 by Alex Catarineu at 2023-08-21T16:17:56+02:00
Bug 28369: Stop shipping pingsender executable

- - - - -
dd7a2f78 by cypherpunks1 at 2023-08-21T16:17:56+02:00
Bug 41568: Disable LaterRun

- - - - -
4be371ef by cypherpunks1 at 2023-08-21T16:17:57+02:00
Bug 40717: Hide Windows SSO in settings

- - - - -
608f1447 by Pier Angelo Vendrame at 2023-08-21T16:17:57+02:00
Bug 41599: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes
and act consequently (e.g., to improve WebSocket UX).
However, there are a few ways to get this internal network ID, so we
patch them out, to be sure any new code will not be able to use them and
possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to
prevent any accidental leak in the future.
Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

- - - - -
2e012618 by Mike Perry at 2023-08-21T16:17:58+02:00
Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Bug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

Bug 18297: Use separate Noto JP,KR,SC,TC fonts

Bug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug 23745: Set dom.indexedDB.enabled = true

Bug 13575: Disable randomised Firefox HTTP cache decay user tests.
(Fernando Fernandez Mancera <ffmancera at riseup.net>)

Bug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated
by OriginAttributes, so we can re-enable them by
allowing the default value (true) of
"security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete
(removed in https://bugzilla.mozilla.org/917049)

Bug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for
isolation of connections, push streams, origin frames, etc.
That means we get first-party isolation provided
"privacy.firstparty.isolate" is true. So in this patch, we
stop overriding "network.http.spdy.enabled" and
"network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation.
So we stop overriding
"network.http.altsvc.enabled" and "network.http.altsvc.oe"
as well.

(All 4 of the abovementioned "network.http.*" prefs adopt
Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we
set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in Bug 1132357.
"network.http.sped.enabled.v2" was removed in Bug 912550.
"network.http.sped.enabled.v3" was removed in Bug 1097944.
"network.http.sped.enabled.v3-1" was removed in Bug 1248197.

Bug 26114: addons.mozilla.org is not special
* Don't expose navigator.mozAddonManager on any site
* Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

Bug 29916: Make sure enterprise policies are disabled

Bug 2874: Block Components.interfaces from content

Bug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent
header and to JavaScript code via navigator.userAgent. To avoid
leaking the OS inside each HTTP request (which many web servers
log), always use the Windows 7 OS value in the desktop User-Agent
header. We continue to allow access to the actual OS via JavaScript,
since doing so improves compatibility with web applications such
as GitHub and Google Docs.

Bug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in:
  %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\
and has a name in the form
  [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from
something called the 'App User Model ID' (AUMID) via some unknown
hashing method. The AUMID is provided as a key when programmatically
creating, updating, and deleting a jumplist. The default behaviour in
firefox is for the installer to define an AUMID for an app, and save it
in the registry so that the jumplist data can be removed by the
uninstaller.

However, the Tor Browser does not set this (or any other) regkey during
installation, so this codepath fails and the app's AUMID is left
undefined. As a result the app's AUMID ends up being defined by
windows, but unknowable by Tor Browser. This unknown AUMID is used to
create and modify the jumplist, but the delete API requires that we
provide the app's AUMID explicitly. Since we don't know what the AUMID
is (since the expected regkey where it is normally stored does not
exist) jumplist deletion will fail and we will leave behind a mostly
empty customDestinations-ms file. The name of the file is derived from
the binary path, so an enterprising person could reverse engineer how
that hex name is calculated, and generate the name for Tor Browser's
default Desktop installation path to determine whether a person had
used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch
works around this AUMID problem by having firefox.exe create it's own
AUMID based on the profile path (rather than looking for a regkey). This
way, if a user goes in and enables and disables jumplist entries, the
backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in
the above mentioned directory and this patch will not remove it since it
was created with an unknown AUMID. However, another patch could be
written which goes to that directory and deletes any item containing the
'Tor Browser' string.  See bug 28996.

Bug 30845: Make sure default themes and other internal extensions are enabled

Bug 28896: Enable extensions in private browsing by default

Bug 31065: Explicitly allow proxying localhost

Bug 31598: Enable letterboxing

Disable Presentation API everywhere

Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer
security levels.

Bug 32321: Disable Mozilla's MitM pings

Bug 19890: Disable installation of system addons

By setting the URL to "" we make sure that already installed system
addons get deleted as well.

Bug 22548: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor
Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0.
All clients will get better experience and lower traffic, beause TBB doesn't
use "Use hardware acceleration when available".

Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs

Bug 16441: Suppress "Reset Tor Browser" prompt.

Bug 29120: Use the in-memory media cache and increase its maximum size.

Bug 33697: use old search config based on list.json

Bug 33855: Ensure that site-specific browser mode is disabled.

Bug 30682: Disable Intermediate CA Preloading.

Bug 40061: Omit the Windows default browser agent from the build

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40408: Disallow SVG Context Paint in all web content

Bug 40308: Disable network partitioning until we evaluate dFPI

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40383: Disable dom.enable_event_timing

Bug 40423: Disable http/3

Bug 40177: Update prefs for Fx91esr

Bug 40700: Disable addons and features recommendations

Bug 40682: Disable network.proxy.allow_bypass

Bug 40736: Disable third-party cookies in PBM

Bug 19850: Enabled HTTPS-Only by default

Bug 40912: Hide the screenshot menu

Bug 41292: Disable moreFromMozilla in preferences page

Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector

Bug 24686: Set network.http.tailing.enabled to true

Bug 40183: Disable TLS ciphersuites using SHA-1

Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old
ones. See the description of that issue to see all the preferences we
believed were still valid for 102, and some brief description for the
reasons to keep them.

- - - - -
02faa608 by hackademix at 2023-08-21T16:17:58+02:00
fixup! Firefox preference overrides.

Bug 33282: Redefine the dimensions of new RFP windows

- - - - -
34335d0a by ruihildt at 2023-08-21T16:17:59+02:00
fixup! Firefox preference overrides.

Bug 41691: Hide "Firefox Suggest" label in URL suggest menu.

- - - - -
8d7b1da3 by hackademix at 2023-08-21T16:17:59+02:00
fixup! Firefox preference overrides.

- - - - -
f771aacc by Richard Pospesel at 2023-08-21T16:18:00+02:00
Bug 41659: Add canonical color definitions to base-browser

- - - - -
00e97231 by Pier Angelo Vendrame at 2023-08-21T16:18:00+02:00
Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our
fontconfig configuration. As a result, the final criterion to choose
the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use
it also for the UI. FontConfig will fall back to some other font for
scripts Arimo does not cover as expected (we tested with Japanese).

- - - - -
c58204e0 by Alex Catarineu at 2023-08-21T16:18:01+02:00
Bug 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is
called from Fenix side and sets `intl.accept_languages`
accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

- - - - -
6634ba56 by Alex Catarineu at 2023-08-21T16:18:01+02:00
Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView

- - - - -
f2b0f584 by Alex Catarineu at 2023-08-21T16:18:02+02:00
Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware

- - - - -
beef09e8 by Alex Catarineu at 2023-08-21T16:18:03+02:00
Bug 26345: Hide tracking protection UI

- - - - -
7926d4dd by Pier Angelo Vendrame at 2023-08-21T16:18:03+02:00
Bug 9173: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a
directory relative to the binary path.
The directory can be specified through the --with-relative-data-dir.
This is relative to the same directory as the firefox main binary for
Linux and Windows.

On macOS, we remove Contents/MacOS from it.
Or, in other words, the directory is relative to the application
bundle.

This behavior can be overriden at runtime, by placing a file called
system-install adjacent to the firefox main binary (also on macOS).

- - - - -
8d131fbe by Alex Catarineu at 2023-08-21T16:18:04+02:00
Bug 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

- - - - -
cd88d131 by Mike Perry at 2023-08-21T16:18:04+02:00
Bug 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line
tools, and not the browser, but I decided to patch them anyway because there
literally is a maze of network function pointers being passed around, and it's
very hard to tell if some random code might not pass in the proper proxied
versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

- - - - -
6a911922 by Igor Oliveira at 2023-08-21T16:18:05+02:00
Bug 23104: Add a default line height compensation

Many fonts have issues with their vertical metrics. they
are used to influence the height of ascenders and depth
of descenders. Gecko uses it to calculate the line height
(font height + ascender + descender), however because of
that idiosyncratic behavior across multiple operating
systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor
to be multiplied with the font size, simulating the concept
of ascender and descender. This way all operating
systems will have the same line height.

- - - - -
b60dbf45 by Pier Angelo Vendrame at 2023-08-21T16:18:05+02:00
Bug 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref
`intl.regional_prefs.use_os_locales` is false but RFP is enabled.

- - - - -
ee3f59e6 by Matthew Finkel at 2023-08-21T16:18:06+02:00
Bug 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

- - - - -
f1974012 by cypherpunks1 at 2023-08-21T16:18:06+02:00
Bug 33955: When copying an image only copy the image contents to the clipboard

- - - - -
aa185f45 by cypherpunks1 at 2023-08-21T16:18:07+02:00
Bug 41791: Omit the source URL when copying page contents to the clipboard

- - - - -
709316b1 by Pier Angelo Vendrame at 2023-08-21T16:18:07+02:00
Base Browser strings

This commit adds all the strings needed by following Base Browser
patches.

- - - - -
19b7e1a9 by Henry Wilkes at 2023-08-21T16:18:08+02:00
fixup! Base Browser strings

Bug 41984: Rename languageNotification.ftl to base-browser.ftl.

- - - - -
b870c786 by Henry Wilkes at 2023-08-21T16:18:08+02:00
fixup! Base Browser strings

Bug 41984: languageNotification.ftl renamed to base-browser.ftl.

- - - - -
ce5fbe32 by hackademix at 2023-08-21T16:18:09+02:00
Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.

- - - - -
8e5192f6 by hackademix at 2023-08-21T16:18:09+02:00
Bug 41434: Letterboxing, improve logging.

- - - - -
6059af63 by hackademix at 2023-08-21T16:18:11+02:00
Bug 31064: Letterboxing, exempt browser extensions.

- - - - -
093203f5 by hackademix at 2023-08-21T16:18:11+02:00
Bug 32411: Letterboxing, exempt view-source: URIs.

- - - - -
aba8bc9f by hackademix at 2023-08-21T16:18:12+02:00
Bug 32308: use direct browser sizing for letterboxing.

- - - - -
a9bdd514 by hackademix at 2023-08-21T16:18:12+02:00
amend! Bug 32308: use direct browser sizing for letterboxing.

Bug 32308: use direct browser sizing for letterboxing.
Bug 30556: align letterboxing with 200x100 new win width stepping

- - - - -
d9c16603 by hackademix at 2023-08-21T16:18:13+02:00
Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

- - - - -
1e28c476 by Pier Angelo Vendrame at 2023-08-21T16:18:13+02:00
Bug 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than
name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the
Japanese language tag could be confusing for users, and moreover the
language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system
language, but some users might want to change it.
So, we tell them that it is possible, but only once.

- - - - -
5fd19671 by p13dz at 2023-08-21T16:18:14+02:00
Bug 40283: Workaround for the file upload bug

- - - - -
eab808d9 by Arthur Edelstein at 2023-08-21T16:18:14+02:00
Bug 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

- - - - -
d1ee6668 by Pier Angelo Vendrame at 2023-08-21T16:18:15+02:00
Bug 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and
MOZ_SOURCE_CHANGESET.
But the code takes for granted that it refers to a Hg instance, so it
combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`.
With this commit, we change this logic to combine them to create a URL
that is valid for GitLab.
$MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag.
If that is needed, we could use /-/tree/, instead of /-/commit/.

- - - - -
4feb0533 by Henry Wilkes at 2023-08-21T16:18:15+02:00
Bug 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order
to avoid several network requests that we do not need.

Bug 41624: Disable about:pocket-* pages.

Bug 40144: Redirect about:privatebrowsing to the user's home

- - - - -
4e1505f2 by Kathy Brade at 2023-08-21T16:18:16+02:00
Bug 4234: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201).
Windows: avoid writing to the registry (16236).
Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
  16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser
version changed (even if the Firefox version and build ID did
not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions
that windows will be restored after an update is applied, and replace the
"Restart and Restore" button label with an existing
"Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the
hamburger (app) menu while the update service is downloading a MAR
file. Before this change, the browser did not indicate to the user
that an update was in progress, which is especially confusing in
Tor Browser because downloads often take some time. If the user
clicks on the new menu item, the about dialog is opened to allow
the user to see download progress.

As part of this fix, the update service was changed to always show
update-related messages in the hamburger menu, even if the update
was started in the foreground via the about dialog or via the
"Check for Tor Browser Update" toolbar menu item. This change is
consistent with the Tor Browser goal of making sure users are
informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

- - - - -
824adc7b by Nicolas Vigier at 2023-08-21T16:18:16+02:00
Bug 41682: Add base-browser nightly mar signing key

- - - - -
2b09fdae by hackademix at 2023-08-21T16:18:17+02:00
Bug 41695: Warn on window maximization without letterboxing in RFPHelper module

- - - - -
b4530bb9 by Pier Angelo Vendrame at 2023-08-21T16:18:17+02:00
Bug 41698: Reword the recommendation badges in about:addons

Firefox strings use { -brand-product-name }.
As a result, it seems that the fork is recommending extensions, whereas
AMO curators are doing that.
So, we replace the strings with custom ones that clarify that Mozilla is
recommending them.

We assign the strings with JS because our translation backend does not
support Fluent attributes, yet, but once it does, we should switch to
them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

- - - - -
46da595e by Henry Wilkes at 2023-08-21T16:18:18+02:00
fixup! Bug 41698: Reword the recommendation badges in about:addons

Bug 41984: languageNotification.ftl renamed to base-browser.ftl.

- - - - -
47dad0d2 by Alex Catarineu at 2023-08-21T16:18:18+02:00
Bug 40069: Add helpers for message passing with extensions

- - - - -
19765c70 by Matthew Finkel at 2023-08-21T16:18:19+02:00
Bug 41598: Prevent NoScript from being removed/disabled.

Bug 40253: Explicitly allow NoScript in Private Browsing mode.

- - - - -
3fe5a9aa by hackademix at 2023-08-21T16:18:19+02:00
Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons

- - - - -
1d6de5cb by Pier Angelo Vendrame at 2023-08-21T16:18:20+02:00
Bug 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually
indicates the current global security level via icon (as defined by the
extensions.torbutton.security_slider pref), a drop-down hanger with a
short description of the current security level, and a new section in
the about:preferences#privacy page where users can change their current
security level. In addition, the hanger and the preferences page will
show a visual warning when the user has modified prefs associated with
the security level and provide a one-click 'Restore Defaults' button to
get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

- - - - -
c060534c by Pier Angelo Vendrame at 2023-08-21T16:18:20+02:00
Bug 40926: Implemented the New Identity feature

- - - - -
071665f3 by hackademix at 2023-08-21T16:18:21+02:00
fixup! Bug 40926: Implemented the New Identity feature

Remove useless and confusing EXPORTED_SYMBOLS usage in ScriptLoader inclusion.

- - - - -
0ce27112 by hackademix at 2023-08-21T16:18:21+02:00
fixup! Bug 40926: Implemented the New Identity feature

Remove redundant "Closing tabs" logging.

- - - - -
6eb2878e by hackademix at 2023-08-21T16:18:22+02:00
fixup! Bug 40926: Implemented the New Identity feature

Bug 41833: Reload extensions on new identity

- - - - -
e19a81db by Henry Wilkes at 2023-08-21T16:18:22+02:00
Bug 41736: Customize toolbar for base-browser.

- - - - -
63ea4319 by Richard Pospesel at 2023-08-21T16:18:22+02:00
Bug 41649: Create rebase and security backport gitlab issue templates

- - - - -
96d74dd2 by Richard Pospesel at 2023-08-21T16:18:23+02:00
Bug 41089: Add tor-browser build scripts + Makefile to tor-browser

- - - - -
4a8da4f3 by Pier Angelo Vendrame at 2023-08-21T16:18:23+02:00
fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser

Bug 41967: Add a Makefile recipe to create multi-lingual dev builds

- - - - -
108bab6e by Henry Wilkes at 2023-08-21T16:18:24+02:00
Bug 41803: Add some developer tools for working on tor-browser.

- - - - -
43939067 by Kathy Brade at 2023-08-21T16:18:24+02:00
Bug 11641: Disable remoting by default.

Unless the -osint command line flag is used, the browser now defaults
to the equivalent of -no-remote.  There is a new -allow-remote flag that
may be used to restore the original (Firefox-like) default behavior.

- - - - -
a4b065d5 by Alex Catarineu at 2023-08-21T16:18:25+02:00
Bug 10760: Integrate TorButton to TorBrowser core

Because of the non-restartless nature of Torbutton, it required
a two-stage installation process. On mobile, it was a problem,
because it was not loading when the user opened the browser for
the first time.

Moving it to tor-browser and making it a system extension allows it
to load when the user opens the browser for first time.

Additionally, this patch also fixes Bug 27611.

Bug 26321: New Circuit and New Identity menu items

Bug 14392: Make about:tor behave like other initial pages.

Bug 25013: Add torbutton as a tor-browser submodule

Bug 31575: Replace Firefox Home (newtab) with about:tor

- - - - -
1f7ce276 by Pier Angelo Vendrame at 2023-08-21T16:18:28+02:00
fixup! Bug 10760: Integrate TorButton to TorBrowser core

Move the SOCKS preference updater to TorProtocolService.
We will need to refactor all this kind of stuff, but at least let's get
it in a single place.

Also, since this was the last bit of the startup service, remove the
file, the component and what else was needed to add them.

- - - - -
603bf803 by Pier Angelo Vendrame at 2023-08-21T16:18:29+02:00
fixup! Bug 10760: Integrate TorButton to TorBrowser core

The hashpassword parameter has been removed.

- - - - -
51275698 by Pier Angelo Vendrame at 2023-08-21T16:18:29+02:00
fixup! Bug 10760: Integrate TorButton to TorBrowser core

Removed torbutton.js, tor-control-port.js and utils.js.

- - - - -
ea4dc759 by Pier Angelo Vendrame at 2023-08-21T16:18:30+02:00
fixup! Bug 10760: Integrate TorButton to TorBrowser core

Make this commit disappear from the patch set.

We still need the jar.mn, but only for strings, so do these changes in
the strings commit, instead.

The Android change should not be needed at all, at this point.

- - - - -
82d452ef by Alex Catarineu at 2023-08-21T16:18:30+02:00
Add TorStrings module for localization

- - - - -
c67648ac by Pier Angelo Vendrame at 2023-08-21T16:18:31+02:00
fixup! Add TorStrings module for localization

Move the `getLocale` function here from TorButton util.js and stop
importing it.

- - - - -
8f599d66 by Mike Perry at 2023-08-21T16:18:31+02:00
Bug 2176: Rebrand Firefox to TorBrowser

See also Bugs #5194, #7187, #8115, #8219.

This patch does some basic renaming of Firefox to TorBrowser. The rest of the
branding is done by images and icons.

Also fix bug 27905.

Bug 25702: Update Tor Browser icon to follow design guidelines

- Updated all of the branding in /browser/branding/official with new 'stable'
icon series.
- Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
add the source svg in the same directory
- Copied /browser/branding/official over /browser/branding/nightly and the new
/browser/branding/alpha directories. Replaced content with 'nightly' and
'alpha' icon series.
Updated VisualElements_70.png and VisualElements_150.png with updated icons in
each branding directory (fixes #22654)
- Updated firefox.VisualElementsManfiest.xml with updated colors in each
branding directory
- Added firefox.svg to each branding directory from which all the other icons
are derived (apart from document.icns and document.ico)
- Added default256.png and default512.png icons
- Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
original icon
- Use the Tor Browser icon within devtools/client/themes/images/.

Bug 30631: Blurry Tor Browser icon on macOS app switcher

It would seem the png2icns tool does not generate correct icns files and
so on macOS the larger icons were missing resulting in blurry icons in
the OS chrome. Regenerated the padded icons in a macOS VM using
iconutil.

Bug 28196: preparations for using torbutton tor-browser-brand.ftl

A small change to Fluent FileSource class is required so that we
can register a new source without its supported locales being
counted as available locales for the browser.

Bug 31803: Replaced about:debugging logo with flat version

Bug 21724: Make Firefox and Tor Browser distinct macOS apps

When macOS opens a document or selects a default browser, it sometimes
uses the CFBundleSignature. Changing from the Firefox MOZB signature to
a different signature TORB allows macOS to distinguish between Firefox
and Tor Browser.

Bug 32092: Fix Tor Browser Support link in preferences

For bug 40562, we moved onionPattern* from bug 27476 to here, as
about:tor needs these files but it is included earlier.

Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one

- - - - -
507a058c by sanketh at 2023-08-21T16:18:32+02:00
Bug 40209: Implement Basic Crypto Safety

Adds a CryptoSafety actor which detects when you've copied a crypto
address from a HTTP webpage and shows a warning.

Closes #40209.

Bug 40428: Fix string attribute names

- - - - -
f761cc45 by Mike Perry at 2023-08-21T16:18:32+02:00
TB3: Tor Browser's official .mozconfigs.

Also:
Add an --enable-tor-browser-data-outside-app-dir configure option

Add --with-tor-browser-version configure option

Bug 31457: disable per-installation profiles

The dedicated profiles (per-installation) feature does not interact
well with our bundled profiles on Linux and Windows, and it also causes
multiple profiles to be created on macOS under TorBrowser-Data.

Bug 31935: Disable profile downgrade protection.

Since Tor Browser does not support more than one profile, disable
the prompt and associated code that offers to create one when a
version downgrade situation is detected.

Add --enable-tor-browser-update build option

Bug 40793: moved Tor configuration options from old-configure.in to moz.configure

Bug 41584: Move some configuration options to base-browser level

- - - - -
a8bdffa0 by Pier Angelo Vendrame at 2023-08-21T16:18:33+02:00
fixup! TB3: Tor Browser's official .mozconfigs.

Bug 41509: Set the remoting name for dev builds, and add a comment to
tell downstream builders that do not use tor-browser-build that they
might want to customize it as well.

- - - - -
f3b6a0bd by Henry Wilkes at 2023-08-21T16:18:33+02:00
Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds

tor-browser#41285: Enable fluent warnings.

- - - - -
ed724115 by Pier Angelo Vendrame at 2023-08-21T16:18:34+02:00
Bug 40562: Added Tor Browser preferences to 000-tor-browser.js

Before reordering patches, we used to keep the Tor-related patches
(torbutton and tor-launcher) at the beginning.
After that issue, we decided to move them towards the end.

In addition to that, we have decided to move Tor Browser-only
preferences there, too, to make Base Browser-only fixups easier to
apply.

- - - - -
182ed17e by Pier Angelo Vendrame at 2023-08-21T16:18:34+02:00
Bug 13252: Customize profile management on macOS

On macOS we allow both portable mode and system installation.
However, in the latter case, we customize Firefox's directories to
match the hierarchy we use for the portable mode.

Also, display an informative error message if the TorBrowser-Data
directory cannot be created due to an "access denied" or a
"read only volume" error.

- - - - -
0ed1e9d4 by Pier Angelo Vendrame at 2023-08-21T16:18:35+02:00
Bug 40933: Add tor-launcher functionality

- - - - -
ced99694 by Pier Angelo Vendrame at 2023-08-21T16:18:35+02:00
fixup! Bug 40933: Add tor-launcher functionality

Bug 41844: Added a couple of wrappers for Onion Auth on
TorProtocolService.

- - - - -
2d3871a1 by Pier Angelo Vendrame at 2023-08-21T16:18:35+02:00
fixup! Bug 40933: Add tor-launcher functionality

Small improvements on event registration.

- - - - -
c89a0385 by Pier Angelo Vendrame at 2023-08-21T16:18:36+02:00
fixup! Bug 40933: Add tor-launcher functionality

Bug 41844: Do not use a the control port directly.

Collect the bridge node for the about:preferences#connection page in
TorMonitorService.

Also, move parts of the circuit display to TorMonitorService and
TorProtocolService.

- - - - -
c19ca457 by Pier Angelo Vendrame at 2023-08-21T16:18:36+02:00
fixup! Bug 40933: Add tor-launcher functionality

Fix a couple of problems in TorLauncherUtil and TorParsers.

Also, moved the function to parse bridges in TorParsers.

- - - - -
fee7b513 by Pier Angelo Vendrame at 2023-08-21T16:18:37+02:00
fixup! Bug 40933: Add tor-launcher functionality

Use actual private members for TorProcess.

- - - - -
036ead95 by Pier Angelo Vendrame at 2023-08-21T16:18:37+02:00
fixup! Bug 40933: Add tor-launcher functionality

Group arg pushes in one line (keys and values together).

- - - - -
22c518f3 by Pier Angelo Vendrame at 2023-08-21T16:18:38+02:00
fixup! Bug 40933: Add tor-launcher functionality

TorProcess: use real private properties instead of _, and removed the
dependency on TorProtocolService (temporarily moved it to
TorMonitorService, but eventually we should unify TorProtocolService
and TorMonitorService, to then split them again in a smarter way).

- - - - -
1c30f9a7 by Pier Angelo Vendrame at 2023-08-21T16:18:38+02:00
fixup! Bug 40933: Add tor-launcher functionality

Hashing the control port password is needed only on the process, so move
this function to TorProcess.

- - - - -
3b6593fc by Pier Angelo Vendrame at 2023-08-21T16:18:39+02:00
squash! Bug 40933: Add tor-launcher functionality

Bug 41926: Reimplement the control port

- - - - -
2e9c10be by Pier Angelo Vendrame at 2023-08-21T16:18:39+02:00
fixup! Bug 40933: Add tor-launcher functionality

Make TorProtocolService an ES class, and change _ with actual private
stuff.

- - - - -
4f625829 by Pier Angelo Vendrame at 2023-08-21T16:18:40+02:00
fixup! Bug 40933: Add tor-launcher functionality

Merged TorMonitorService into TorProtocolService.

- - - - -
d33337bc by Pier Angelo Vendrame at 2023-08-21T16:18:40+02:00
fixup! Bug 40933: Add tor-launcher functionality

Use the new functions whenever possible, adjust some property names and
other minor fixes.

- - - - -
bf65f321 by Pier Angelo Vendrame at 2023-08-21T16:18:41+02:00
fixup! Bug 40933: Add tor-launcher functionality

Remove the final references to TorMonitorService and TorProtocolService.

- - - - -
f7ab2ff3 by Richard Pospesel at 2023-08-21T16:18:41+02:00
Bug 40597: Implement TorSettings module

- migrated in-page settings read/write implementation from about:preferences#tor
  to the TorSettings module
- TorSettings initially loads settings from the tor daemon, and saves them to
  firefox prefs
- TorSettings notifies observers when a setting has changed; currently only
  QuickStart notification is implemented for parity with previous preference
  notify logic in about:torconnect and about:preferences#tor
- about:preferences#tor, and about:torconnect now read and write settings
  thorugh the TorSettings module
- all tor settings live in the torbrowser.settings.* preference branch
- removed unused pref modify permission for about:torconnect content page from
  AsyncPrefs.jsm

Bug 40645: Migrate Moat APIs to Moat.jsm module

- - - - -
2d1b115d by Pier Angelo Vendrame at 2023-08-21T16:18:42+02:00
fixup! Bug 40597: Implement TorSettings module

Bug 41907: Change state after the process becomes ready only when we
are in the initial state.

- - - - -
5004c86f by Pier Angelo Vendrame at 2023-08-21T16:18:42+02:00
fixup! Bug 40597: Implement TorSettings module

Changes needed for the new control port implementation.

Also, moved to ES modules and done some refactors on Moat.

- - - - -
2617207f by Arthur Edelstein at 2023-08-21T16:18:45+02:00
Bug 3455: Add DomainIsolator, for isolating circuit by domain.

Add an XPCOM component that registers a ProtocolProxyChannelFilter
which sets the username/password for each web request according to
url bar domain.

Bug 9442: Add New Circuit button

Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ.

Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce.

Bug 19206: Clear out the domain isolator state on `New Identity`.

Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes

Bug 21745: Fix handling of catch-all circuit

Bug 41741: Refactor the domain isolator and new circuit

- - - - -
2393f056 by Pier Angelo Vendrame at 2023-08-21T16:18:46+02:00
fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.

Bug 41844: Do not use the control port directly.

Use TorDomainIsolator also as a backend for the circuit display.

- - - - -
8c367633 by Pier Angelo Vendrame at 2023-08-21T16:18:46+02:00
fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.

Remove TorMonitorService and TorProtocolService references.

- - - - -
75ffd93d by Pier Angelo Vendrame at 2023-08-21T16:18:47+02:00
fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.

Bug 42031: Fixed some requests failing because of a type error

Some requests (e.g., uBlock Origin filter updates) failed because they
the TorDomainIsolator tried to access the browser from their channels.

- - - - -
b917f1de by Henry Wilkes at 2023-08-21T16:18:47+02:00
Bug 41600: Add a tor circuit display panel.

- - - - -
39bf2dda by Pier Angelo Vendrame at 2023-08-21T16:18:48+02:00
fixup! Bug 41600: Add a tor circuit display panel.

Bug 41844: Have a separate backend for the tor circuits

Remove the backend stuff from the circuit display.

- - - - -
a41799b1 by hackademix at 2023-08-21T16:18:48+02:00
Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop

Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs

- - - - -
ae0abf83 by Amogh Pradeep at 2023-08-21T16:18:49+02:00
Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.

See Bug 1357997 for partial uplift.

Also:
Bug 28051 - Use our Orbot for proxying our connections

Bug 31144 - ESR68 Network Code Review

- - - - -
73c154e8 by Matthew Finkel at 2023-08-21T16:18:49+02:00
Bug 25741: TBA: Disable GeckoNetworkManager

The browser should not need information related to the network
interface or network state, tor should take care of that.

- - - - -
8720e367 by Kathy Brade at 2023-08-21T16:18:50+02:00
Bug 14631: Improve profile access error messages.

Instead of always reporting that the profile is locked, display specific
messages for "access denied" and "read-only file system".

To allow for localization, get profile-related error strings from Torbutton.
Use app display name ("Tor Browser") in profile-related error alerts.

- - - - -
b0e584b6 by Pier Angelo Vendrame at 2023-08-21T16:18:50+02:00
Bug 40807: Added QRCode.js to toolkit/modules

- - - - -
6a4d6e26 by Richard Pospesel at 2023-08-21T16:18:50+02:00
Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

This patch adds a new about:preferences#connection page which allows
modifying bridge, proxy, and firewall settings from within Tor Browser.
All of the functionality present in tor-launcher's Network
Configuration panel is present:

 - Setting built-in bridges
 - Requesting bridges from BridgeDB via moat
 - Using user-provided bridges
 - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
 - Setting firewall ports
 - Viewing and Copying Tor's logs
 - The Networking Settings in General preferences has been removed

Bug 40774: Update about:preferences page to match new UI designs

- - - - -
cfe65ecb by Pier Angelo Vendrame at 2023-08-21T16:18:51+02:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Bug 41844: Do not use the control port directly

Do not use the controller in the settings frontend.
Instead, let TorMonitorService collect the first node's fingerprint.

- - - - -
1918498e by Pier Angelo Vendrame at 2023-08-21T16:18:51+02:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Use the bridge line parser from TorParsers.

- - - - -
431586fd by Henry Wilkes at 2023-08-21T16:18:52+02:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Bug 41964: Wait for both emoji resources before setting bridge emoji
attributes.

Also change annotations in response to a change in locale.

- - - - -
47c681d8 by Pier Angelo Vendrame at 2023-08-21T16:18:52+02:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Changes for the new control port implementation and following
ESMification.

- - - - -
7ef74631 by Richard Pospesel at 2023-08-21T16:18:53+02:00
Bug 27476: Implement about:torconnect captive portal within Tor Browser

- implements new about:torconnect page as tor-launcher replacement
- adds new torconnect component to browser
- tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
- adds warning/error box to about:preferences#tor when not connected to tor

Bug 40773: Update the about:torconnect frontend page to match additional UI flows.

Bug 41608: Add a toolbar status button and a urlbar "Connect" button.

- - - - -
1f434d73 by Kathleen Brade at 2023-08-21T16:18:53+02:00
Bug 7494: Create local home page for TBB.

- - - - -
7fc24f0f by Pier Angelo Vendrame at 2023-08-21T16:18:54+02:00
fixup! Bug 7494: Create local home page for TBB.

Use the TorProvider in TorCheckService

- - - - -
5306da3f by Arthur Edelstein at 2023-08-21T16:18:54+02:00
Bug 12620: TorBrowser regression tests

Regression tests for Bug #2950: Make Permissions Manager memory-only

Regression tests for TB4: Tor Browser's Firefox preference overrides.

Note: many more functional tests could be made here

Regression tests for #2874: Block Components.interfaces from content

Bug 18923: Add a script to run all Tor Browser specific tests

Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.

- - - - -
87d90613 by Pier Angelo Vendrame at 2023-08-21T16:18:55+02:00
Bug 41668: Tweaks to the Base Browser updater for Tor Browser

This commit was once part of "Bug 4234: Use the Firefox Update Process
for Tor Browser.".
However, some parts of it were not needed for Base Browser and some
derivative browsers.
Therefore, we extracted from that commit the parts for Tor Browser
legacy, and we add them back to the patch set with this commit.

- - - - -
4d42a19b by Pier Angelo Vendrame at 2023-08-21T16:18:55+02:00
fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser

Removed TorMonitorService reference

- - - - -
9f8c1a9d by Kathy Brade at 2023-08-21T16:18:56+02:00
Bug 12647: Support symlinks in the updater.

- - - - -
ff6bff50 by Kathy Brade at 2023-08-21T16:18:56+02:00
Bug 19121: reinstate the update.xml hash check

This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.

Revert most changes from Mozilla Bug 862173 "don't verify mar file hash
when using mar signing to verify the mar file (lessens main thread I/O)."

We kept the addition to the AppConstants API in case other JS code
references it in the future.

- - - - -
344d9e80 by Kathy Brade at 2023-08-21T16:18:57+02:00
Bug 16940: After update, load local change notes.

Add an about:tbupdate page that displays the first section from
TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
post-update page (typically our blog entry for the release).

Always load about:tbupdate in a content process, but implement the
code that reads the file system (changelog) in the chrome process
for compatibility with future sandboxing efforts.

Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
changelog page that is designed to be displayed via a link that is on
about:tor.

- - - - -
57c9982a by Georg Koppen at 2023-08-21T18:02:37+02:00
Bug 32658: Create a new MAR signing key

It's time for our rotation again: Move the backup key in the front
position and add a new backup key.

Bug 33803: Move our primary nightly MAR signing key to tor-browser

Bug 33803: Add a secondary nightly MAR signing key

- - - - -
eaab8844 by Mike Perry at 2023-08-21T18:02:39+02:00
Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

eBay and Amazon don't treat Tor users very well. Accounts often get locked and
payments reversed.

Also:
Bug 16322: Update DuckDuckGo search engine

We are replacing the clearnet URL with an onion service one (thanks to a
patch by a cypherpunk) and are removing the duplicated DDG search
engine. Duplicating DDG happend due to bug 1061736 where Mozilla
included DDG itself into Firefox. Interestingly, this caused breaking
the DDG search if JavaScript is disabled as the Mozilla engine, which
gets loaded earlier, does not use the html version of the search page.
Moreover, the Mozilla engine tracked where the users were searching from
by adding a respective parameter to the search query. We got rid of that
feature as well.

Also:
This fixes bug 20809: the DuckDuckGo team has changed its server-side
code in a way that lets users with JavaScript enabled use the default
landing page while those without JavaScript available get redirected
directly to the non-JS page. We adapt the search engine URLs
accordingly.

Also fixes bug 29798 by making sure we only specify the Google search
engine we actually ship an .xml file for.

Also regression tests.

squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

Bug 40494: Update Startpage search provider

squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

Bug 40438: Add Blockchair as a search engine

Bug 33342: Avoid disconnect search addon error after removal.

We removed the addon in #32767, but it was still being loaded
from addonStartup.json.lz4 and throwing an error on startup
because its resource: location is not available anymore.

- - - - -
adfe66da by Alex Catarineu at 2023-08-21T18:02:39+02:00
Bug 40073: Disable remote Public Suffix List fetching

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
fetching the Public Suffix List via RemoteSettings and replacing the default
one at runtime, which we do not want.

- - - - -
ee15a8ab by Richard Pospesel at 2023-08-21T18:02:39+02:00
Bug 23247: Communicating security expectations for .onion

Encrypting pages hosted on Onion Services with SSL/TLS is redundant
(in terms of hiding content) as all traffic within the Tor network is
already fully encrypted.  Therefore, serving HTTP pages from an Onion
Service is more or less fine.

Prior to this patch, Tor Browser would mostly treat pages delivered
via Onion Services as well as pages delivered in the ordinary fashion
over the internet in the same way.  This created some inconsistencies
in behaviour and misinformation presented to the user relating to the
security of pages delivered via Onion Services:

 - HTTP Onion Service pages did not have any 'lock' icon indicating
   the site was secure
 - HTTP Onion Service pages would be marked as unencrypted in the Page
   Info screen
 - Mixed-mode content restrictions did not apply to HTTP Onion Service
   pages embedding Non-Onion HTTP content

This patch fixes the above issues, and also adds several new 'Onion'
icons to the mix to indicate all of the various permutations of Onion
Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.

Strings for Onion Service Page Info page are pulled from Torbutton's
localization strings.

- - - - -
d6a6529b by Kathy Brade at 2023-08-21T18:02:40+02:00
Bug 30237: Add v3 onion services client authentication prompt

When Tor informs the browser that client authentication is needed,
temporarily load about:blank instead of about:neterror and prompt
for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
control port command to add the key (via Torbutton's control port
module) and reload the page.

If the user cancels the prompt, display the standard about:neterror
"Unable to connect" page. This requires a small change to
browser/actors/NetErrorChild.jsm to account for the fact that the
docShell no longer has the failedChannel information. The failedChannel
is used to extract TLS-related error info, which is not applicable
in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display
error messages within the popup notification doorhanger without
closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the
socket transport and SOCKS layers. Improved display of all of these
errors will be implemented as part of bug 30025.

Also fixes bug 19757:
 Add a "Remember this key" checkbox to the client auth prompt.

 Add an "Onion Services Authentication" section within the
 about:preferences "Privacy & Security section" to allow
 viewing and removal of v3 onion client auth keys that have
 been stored on disk.

Also fixes bug 19251: use enhanced error pages for onion service errors.

- - - - -
b1860c5b by Pier Angelo Vendrame at 2023-08-21T18:02:40+02:00
fixup! Bug 30237: Add v3 onion services client authentication prompt

Bug 41844: Stop using the control port directly

- - - - -
69748f94 by Pier Angelo Vendrame at 2023-08-21T18:02:41+02:00
fixup! Bug 30237: Add v3 onion services client authentication prompt

Changes for the new control port implementation.

- - - - -
9ae12401 by Alex Catarineu at 2023-08-21T18:02:41+02:00
Bug 21952: Implement Onion-Location

Whenever a valid Onion-Location HTTP header (or corresponding HTML
<meta> http-equiv attribute) is found in a document load, we either
redirect to it (if the user opted-in via preference) or notify the
presence of an onionsite alternative with a badge in the urlbar.

- - - - -
670e53a4 by Pier Angelo Vendrame at 2023-08-21T18:02:42+02:00
Bug 40458: Implement .tor.onion aliases

We have enabled HTTPS-Only mode, therefore we do not need
HTTPS-Everywhere anymore.
However, we want to keep supporting .tor.onion aliases (especially for
securedrop).
Therefore, in this patch we implemented the parsing of HTTPS-Everywhere
rulesets, and the redirect of .tor.onion domains.
Actually, Tor Browser believes they are actual domains. We change them
on the fly on the SOCKS proxy requests to resolve the domain, and on
the code that verifies HTTPS certificates.

- - - - -
99c6b973 by Pier Angelo Vendrame at 2023-08-21T18:02:42+02:00
Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser

This patch associates the about:manual page to a translated page that
must be injected to browser/omni.ja after the build.
The content must be placed in chrome/browser/content/browser/manual/, so
that is then available at chrome://browser/content/manual/.
We preferred giving absolute freedom to the web team, rather than having
to change the patch in case of changes on the documentation.

- - - - -
fd9ef50a by Pier Angelo Vendrame at 2023-08-21T18:02:43+02:00
Bug 41435: Add a Tor Browser migration function

For now this function only deletes old language packs for which we are
already packaging the strings with the application.

- - - - -
bf0b40f3 by Dan Ballard at 2023-08-21T18:02:43+02:00
Bug 40701: Add security warning when downloading a file

Shown in the downloads panel, about:downloads and places.xhtml.

- - - - -
8074badc by Henry Wilkes at 2023-08-21T18:02:44+02:00
Bug 41736: Customize toolbar for tor-browser.

- - - - -
452783e6 by hackademix at 2023-08-21T18:02:44+02:00
Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key

- - - - -


30 changed files:

- .eslintignore
- .gitignore
- + .gitlab/issue_templates/Backport Android Security Fixes.md
- + .gitlab/issue_templates/Rebase Browser - Alpha.md
- + .gitlab/issue_templates/Rebase Browser - Stable.md
- + .gitlab/issue_templates/UXBug.md
- + .gitlab/issue_templates/bug.md
- + .gitlab/merge_request_templates/default.md
- accessible/android/SessionAccessibility.cpp
- accessible/android/SessionAccessibility.h
- accessible/ipc/DocAccessibleParent.cpp
- accessible/ipc/DocAccessibleParent.h
- accessible/ipc/moz.build
- + browser/actors/AboutTBUpdateChild.jsm
- + browser/actors/AboutTBUpdateParent.jsm
- + browser/actors/CryptoSafetyChild.jsm
- + browser/actors/CryptoSafetyParent.jsm
- − browser/actors/RFPHelperChild.sys.mjs
- − browser/actors/RFPHelperParent.sys.mjs
- browser/actors/moz.build
- browser/app/Makefile.in
- browser/app/macbuild/Contents/Info.plist.in
- browser/app/macbuild/Contents/MacOS-files.in
- browser/app/permissions
- + browser/app/profile/000-tor-browser.js
- + browser/app/profile/001-base-profile.js
- browser/app/profile/firefox.js
- browser/base/content/aboutDialog-appUpdater.js
- browser/base/content/aboutDialog.js
- browser/base/content/aboutDialog.xhtml


The diff was not included because it is too large.


View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2a0fbfb043a37bea8846e224b376002620bdde0d...452783e66985451b89922082a95ef454c71d5087

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2a0fbfb043a37bea8846e224b376002620bdde0d...452783e66985451b89922082a95ef454c71d5087
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20230821/38ffe7e9/attachment-0001.htm>