[tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are kept
-------------------------------------------------+-------------------------
 Reporter:  juga                                 |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:  sbws:
                                                 |  1.1.0
 Severity:  Normal                               |     Resolution:
 Keywords:  sbws-roadmap, intro,                 |  Actual Points:
  GeorgKoppen202004                              |
Parent ID:  #33121                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:8 juga]:
 > Replying to [comment:6 gk] and [comment:7 arma]:
 >
 > i'm replying to both of you, last comments.
 >
 > So, my first thought was, yeah, the relay is the same, it's probably
 changing IP cause of having dynamic IP address, so we should keep the
 recent measurements with a different IP.
 >
 > Then, i thought, what if the relay changes IP cause it changes physical
 location? (while keeping the keys/configuration), in that case the
 measurements could actually be quite different and the previous ones would
 not make sense.
 >
 > So we have at least 2 cases in which a relay might change IP and think
 the first one is the more common one.
 >
 > I don't know what's was the initial thought to implement this, i also
 didn't find i in the git log or tickets.
 >
 > I realize now that we don't need to change the code, we can just change
 the default configuration to set `reset_bw_ipv4_changes` to false.

 Yep, that's what I came up with as well.

 > I don't know what Torflow does and it's not so easy to check.
 >
 > What we can do, it's to wait a few days until longclaw uses nightly
 changes, see how many relays it's measuring with the current fixes and see
 whether we should change this.

 I am fine with that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33832#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online