[tor-bugs] #33745 [Circumvention/Snowflake]: Merge a turbotunnel branch

[Tor Bug Tracker & Wiki]

#33745: Merge a turbotunnel branch
-------------------------------------+------------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  task                     |         Status:  needs_review
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  turbotunnel              |  Actual Points:
Parent ID:  #19001                   |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------
Changes (by dcf):

 * status:  assigned => needs_review


Comment:

 https://people.torproject.org/~dcf/pt-bundle/tor-browser-snowflake-
 turbotunnel-9.5a11-20200410/

 Here are packages built from the branches in comment:6. I'm asking for
 review of the snowflake turbotunnel-merge changes. If they're accepted
 then I'll do another ticket for the Tor Browser merge.

 These packages have snowflake-client logging disabled by default. To re-
 enable logging, edit Browser/TorBrowser/Data/Tor/torrc-defaults and add
 `-log snowflake-client.log -logToStateDir` to the `ClientTransportPlugin
 snowflake` line.

 These packages also remove the `LearnCircuitBuildTimeout 0` setting that
 was present in earlier iterations. I'm going to test to see if creates a
 problem of tor learning too-short timeouts, given the high rate of proxy
 failures some clients will experience (comment:8:ticket:33666 ff.).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33745#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online