[tor-bugs] #30674 [Core Tor/Tor]: Find out why ubsan/asan CI didn't catch #30629

[Tor Bug Tracker & Wiki]

#30674: Find out why ubsan/asan CI didn't catch #30629
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  041-should,  memory-safety,          |  Actual Points:
  valgrind                                       |
Parent ID:  #30629                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 I can confirm that this does get caught if we build libevent with
 sanitizers, and link tor against that libevent -- which is not so easy.

 I bet it would be worthwhile to add some kind of CI support for a
 "hardened compiler, hardened dependencies" build mode, but it would likely
 be a bit fragile.  Or we could try to get our tests to support running
 everything under valgrind.  Any thoughts here?  I think our right move is
 to call ''this'' ticket solved, and open a new ticket for our chosen
 solution.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30674#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online