[tor-bugs] #27772 [Core Tor/Tor]: Compile without warnings on GCC 8.2.0 with LTO enabled

[Tor Bug Tracker & Wiki]

#27772: Compile without warnings on GCC 8.2.0 with LTO enabled
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  High          |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 I think all of these commits can go in as they are generally cleaning up
 code.

 I do however think that some of the comments that are added to suppress
 warnings from GCC will become confusing when you look at the code later
 on. For example:
 https://github.com/torproject/tor/pull/356/commits/620108ea7770608de72dcbea4ca73d6fb99c1109
 #diff-23701c678d2a4dce3ba19f90e4bf5b00R4440

 The patches seems reasonably "small" to maybe backport all of them, or
 should we just backport the ones that causes compilation errors? Will any
 of our users who are using an older version of Tor be compiling Tor with
 such a new version of GCC?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27772#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online