[tor-bugs] #25990 [Core Tor/Tor]: module: Better safeguard authdir_mode_v3() if dirauth module is disabled
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue May 1 16:21:25 UTC 2018
#25990: module: Better safeguard authdir_mode_v3() if dirauth module is disabled
-------------------------+-------------------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: assigned
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core | Version:
Tor/Tor | Keywords: 034-roadmap-subtask,
Severity: Normal | modularization, tor-dirauth, refactor
Actual Points: | Parent ID: #25494
Points: | Reviewer:
Sponsor: |
-------------------------+-------------------------------------------------
We need to safeguard somehow the `authdir_mode_v3()` so it can NEVER
return true if the dirauth module is disabled.
One option here is to move this function to the dirauth module and NOP it
by returning false if the module is not enabled.
An other option is to #ifdef `HAVE_MODULE_DIRAUTH` in the function
directly. I'm kind of less enthusiastic about it but maybe it is better,
dunno yet.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25990>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list