[tor-bugs] #22310 [Core Tor/Tor]: Tor 0.3.x clients won't use Guard-flagged relays as Guards if they don't have V2Dir, throwing off consensus position weights

[Tor Bug Tracker & Wiki]

#22310: Tor 0.3.x clients won't use Guard-flagged relays as Guards if they don't
have V2Dir, throwing off consensus position weights
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Here's the simple patch:
 {{{
 diff --git a/src/or/dirserv.c b/src/or/dirserv.c
 index 2b10a09..c79bdfd 100644
 --- a/src/or/dirserv.c
 +++ b/src/or/dirserv.c
 @@ -2190,6 +2190,7 @@ set_routerstatus_from_routerinfo(routerstatus_t *rs,
    rs->is_valid = node->is_valid;

    if (node->is_fast && node->is_stable &&
 +      ri->supports_tunnelled_dir_requests &&
        ((options->AuthDirGuardBWGuarantee &&
          routerbw_kb >= options->AuthDirGuardBWGuarantee/1000) ||
         routerbw_kb >= MIN(guard_bandwidth_including_exits_kb,
 }}}

 I expect that updating the specs and documentation and so on will be a bit
 more involved.

 Also, in a later Tor, we'll want to refactor so we calculate rs->is_v2_dir
 higher up, and then just use that value in the 'if'. Surely that
 refactoring won't break anything, but the above diff is still an easier
 sell.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22310#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online