[tor-bugs] #22101 [Core Tor/Tor]: Can't have relative DataDirectory with CookieAuthentication enabled

[Tor Bug Tracker & Wiki]

#22101: Can't have relative DataDirectory with CookieAuthentication enabled
----------------------------------------------+----------------------------
 Reporter:  pastly                            |          Owner:  Jigsaw52
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.2.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  review-group-18, review-group-19  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  isis                              |        Sponsor:
----------------------------------------------+----------------------------

Comment (by arma):

 Replying to [comment:20 arma]:
 > Is Tor applying its "make the relative path absolute" algorithm twice
 here? That would be a bug, and one worth fixing.

 In particular, check out how init_cookie_authentication() in config.c just
 takes an fname argument, and that comes straight out of
 get_controller_cookie_file_name() in control.c. And when
 {{{CookieAuthFile}}} isn't set, it uses
 {{{get_datadir_fname("control_auth_cookie")}}} instead. The
 get_datadir_fname mess in config.h is deeply confusing to me, but, is it
 prepending the datadir onto the control_auth_cookie name, after it has
 done a chdir() to the datadir?

 I'm having trouble getting strace -f to cooperate with me, but I think in
 pastly's case Tor is trying to write to ./datadir-3hop/datadir-
 3hop/control_auth_cookie.tmp which is why it fails. And that's a bug in
 how we handle the default control_auth_cookie filename. Which should be
 fixable separate from the bigger-picture stuff above.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22101#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online