[tor-bugs] #18809 [Core Tor/Tor]: Handle linked connections better during bootstrap

[Tor Bug Tracker & Wiki]

#18809: Handle linked connections better during bootstrap
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,              |        Version:  Tor:
  TorCoreTeam201605, review-group-1,   must-     |  0.2.8.1-alpha
  fix-before-0283                                |     Resolution:
Parent ID:                                       |  Actual Points:  4
 Reviewer:  andrea                               |         Points:  3
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Jenkins mingw fails with `unused-but-set-variable` warnings:
 {{{
 15:34:57 src/test/test_connection.c:660:17: error: variable 'ap_conn4' set
 but not used [-Werror=unused-but-set-variable]
 15:34:57 src/test/test_connection.c:658:17: error: variable 'ap_conn2' set
 but not used [-Werror=unused-but-set-variable]
 15:34:57 src/test/test_connection.c:655:21: error: variable 'conn3' set
 but not used [-Werror=unused-but-set-variable]
 }}}
 https://jenkins.torproject.org/job/tor-ci-
 mingwcross-0.2.8/ARCHITECTURE=amd64,SUITE=jessie/27/console

 Please try my branch `fix18809-warnings`, which includes the warning fix
 and the comment fix.
 (I don't have a compiler that does `-Wunused-but-set-variable`, so we'll
 have to throw this one at jenkins.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18809#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online