[tor-bugs] #17592 [Tor]: Clean up connection timeout logic

[Tor Bug Tracker & Wiki]

#17592: Clean up connection timeout logic
-----------------------+------------------------------------
 Reporter:  mikeperry  |          Owner:  mikeperry
     Type:  defect     |         Status:  needs_review
 Priority:  High       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor        |        Version:
 Severity:  Normal     |     Resolution:
 Keywords:             |  Actual Points:
Parent ID:  #16861     |         Points:
  Sponsor:             |
-----------------------+------------------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 These issues should all be fixed in
 e1c57775ed8a09a8767bf4d74db94d04c9fe1659 in mikeperry/netflow_padding-
 v4_squashed+rebased. I opted to explicitly check for time_t
 overflow/underflow and associated clock jumps rather than use monotonic
 time. I don't like the idea of waiting for the clock to catch up with
 itself here, either. I'd rather reset the timeout in that case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17592#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online