[tor-bugs] #20980 [Core Tor/Tor]: Use the standard OpenBSD preprocessor definition

[Tor Bug Tracker & Wiki]

#20980: Use the standard OpenBSD preprocessor definition
--------------------------+------------------------------------
 Reporter:  cypherpunks   |          Owner:
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:3 teor]:
 > Is `__OpenBSD__` defined for bitrig and other OpenBSD variants?

 For context, Bitrig support was added in #6982 (commit
 d92d3f33356af002892ba5754d9d36cc4504c95f).

 The [https://sourceforge.net/p/predef/wiki/OperatingSystems/ Pre-defined
 Compiler Macros wiki] contains a bunch of operating systems but not
 Bitrig. [https://github.com/bitrig/bitrig/issues/72 Issue 72] on the
 Bitrig bug tracker was about getting Bitrig added to this list.

 The `param.h` header typically contains these preprocessor definitions.
 That [https://github.com/bitrig/bitrig/blob/master/sys/sys/param.h#L42
 header file] in the Bitrig repository contains no `__OpenBSD__`. The
 current patch would therefore remove support for Bitrig. It does contain
 `OpenBSD` which seems to exists for other forks (like
 [https://notabug.org/alimiracle/LibertyBSD_kernel/src/master/sys/sys/param.h#L44
 LibertyBSD]) also.

 > If so, this patch is fine, flip it into merge-ready.
 IMO the patch is fine, because Bitrig isn't explicitly supported and other
 parts of the code already uses `__OpenBSD__` without caring about Bitrig
 (a quick grep shows 10 lines using `__OpenBSD__` and 4 lines using
 `OPENBSD`).

 > If not, we need to rethink how we make this change.
 If we really care about Bitrig and other OpenBSD forks, the patch could be
 fixed by replacing `OPENBSD` with `OpenBSD` but -1 from me on that.

 I'll leave it to teor for the final word on this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20980#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online