[tor-bugs] #12160 [Tor]: ORPort self-testing fails behind tcp proxy when using version 0.2.4.22

[Tor Bug Tracker & Wiki]

#12160: ORPort self-testing fails behind tcp proxy when using version 0.2.4.22
------------------------+--------------------------------
     Reporter:  kargig  |      Owner:  andrea
         Type:  defect  |     Status:  assigned
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.22
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by andrea):

 I think I understand a bit more: the connections all have 127.0.0.1 for
 their address when channel_tls_handle_incoming() gets called, so they get
 classified as local and the condition (!channel_is_local(circ->p_chan) &&
 !channel_is_outgoing(circ->p_chan)) always fails.  These incorrect channel
 remote addrs can also be observed in the output of channel_dumpstats()
 sending SIGUSR1 to the Tor process.

 On a comparison relay running 0.2.4 without any NoListen/NoAdvertise,
 though, the channel remote addresses are all correct.  I still have to
 trace down why this worked in the 0.2.3 case, too.  The old test was
 (!is_local_addr(&circ->p_conn->_base.addr) &&
 !connection_or_nonopen_was_started_here(circ->p_conn)).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12160#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online