[tor-bugs] #6733 [Firefox Patch Issues]: Patch Firefox to allow addons to set SOCKS username+password per request

[Tor Bug Tracker & Wiki]

#6733: Patch Firefox to allow addons to set SOCKS username+password per request
-------------------------------------+-------------------------------------
     Reporter:  mikeperry            |      Owner:  ben
         Type:  enhancement          |     Status:  accepted
     Priority:  major                |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  interview, tbb-
   Resolution:                       |  linkability
Actual Points:                       |  Parent ID:  #3455
       Points:                       |
-------------------------------------+-------------------------------------

Comment (by ben):

 Furthermore, SOCKS v4 is broken for me in the original Tor browser
 (downloaded from website, without my patch) with Tor. SOCKS v5 works.
 No wonder I'm having problems to test this.

 -------

 I found one bug in my patch, in the state machine for SOCKS v5, and fixed
 that.

 -------

 There's one more bug.

 Note to self: It's hanging at this point:
 {{{
         case SOCKS5_WRITE_USERNAME_REQUEST:
             if (WriteToSocket(fd) != PR_SUCCESS)
                 return PR_FAILURE;
             WantRead(2);
             mState = SOCKS5_READ_USERNAME_RESPONSE;
             return PR_SUCCESS;
         case SOCKS5_READ_USERNAME_RESPONSE:
             if (ReadFromSocket(fd) != PR_SUCCESS)    <==== hanging here
                 return PR_FAILURE;
             return ReadV5UsernameResponse();
 }}}

 I do see the response from the SOCKS server in Wireshark. Just the Mozilla
 code doesn't read the bytes. I have to figure out why. The |WantRead(2);|
 before is an obvious culprit, but we should be getting 2 bytes, and I do
 see 2 bytes in Wireshark coming back.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6733#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online