[tor-bugs] #7883 [Flashproxy]: Consider and potentially implement the integration of pyptlib in flashproxy
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jan 21 05:27:58 UTC 2013
#7883: Consider and potentially implement the integration of pyptlib in flashproxy
------------------------+---------------------------------------------------
Reporter: asn | Owner: asn
Type: task | Status: needs_review
Priority: normal | Milestone:
Component: Flashproxy | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by dcf):
The patch looks overall nice.
The changes in `flashproxy-reg-email` don't look right. That program is
not a transport plugin and it shouldn't be calling `pyptlib.client.init`.
`flashproxy-reg-email` is forked by `flashproxy-client` and inherits its
environment variables, including `TOR_PT_STATE_LOCATION`, which it uses.
`flashproxy-reg-email` shouldn't be doing the whole PT negotiation.
I thought about keeping a copy of pyptlib in the flashproxy tree. The
trivial thing doesn't work because there is an extra level of `pyptlib`
directory before reaching `__init__.py`.
{{{
$ ./flashproxy-client
Traceback (most recent call last):
File "./flashproxy-client", line 23, in <module>
import pyptlib.client
ImportError: No module named pyptlib.client
}}}
If we include pyptlib in this way, then there is the problem of what `make
install` should do. It can copy its own copy of pyptlib to
`/usr/local/lib/python`, but there might already be a copy of pyptlib
there.
I guess the best thing in the log run is to require pyptlib to be
installed already. To that end, in your branch would you add links and
instructions for installing pyptlib to `README` and to a message that gets
printed when a `pyptlib` import fails? I'm still not totally decided how
to handle all this.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7883#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list