[tor-bugs] #4533 [Tor Client]: compat.h: tor_socket_t defined as intptr_t instead native SOCKET (Windows)

[Tor Bug Tracker & Wiki]

#4533: compat.h: tor_socket_t defined as intptr_t instead native SOCKET (Windows)
---------------------------+------------------------------------------------
    Reporter:  troll_un    |       Owner:                    
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Client  |     Version:                    
  Resolution:              |    Keywords:  Windows easy      
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by asn):

 {{{
 < wanoskarnet> "(unsigned)(s) != INVALID_SOCKET" is never false for win64.
 SOCKET is unsigned and sizeof(SOCKET) is 8 bytes and INVALID_SOCKET
 defined as (SOCKET)(-1) so (unsigned)(intptr_t)(-1) never equal
 (SOCKET)(-1). 00000000FFFFFFFF != FFFFFFFFFFFFFFFF
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4533#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online